2faf721360
Edit library table through backing table instead of grid.
...
While editing the grid works on OSX, it doesn't appear to on MSW or
GTK. Whether or not editing the backing table is any better or not
remains to be seen....
Fixes https://gitlab.com/kicad/code/kicad/issues/7323
2021-02-03 15:50:37 +00:00
c220913aa1
Handle y-axis inversion in Symbol Editor when drag-selecting text.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7406
2021-02-03 15:28:11 +00:00
ff3441143e
Fix assert in setupUiConditions.
2021-02-03 14:40:19 +00:00
b07c8110c8
Follow grid snapping when moving
2021-02-02 20:23:12 -08:00
97194983cd
Select cells at a time
...
Selecting cells allows us to cut/paste from individual cells. This is
critical to be able to paste from spreadsheets and move columns around
2021-02-02 19:33:18 -08:00
238aa2b5b0
Snap to eeschema lines
...
Allows easier snapping to lines when drawing in eeschema.
Fixes https://gitlab.com/kicad/code/kicad/issues/7378
2021-02-02 19:33:18 -08:00
ea08f1b8cb
Update action short names for clarity
2021-02-02 19:33:18 -08:00
9aedeae5c3
Don't log error messages when using the clipboard
...
wxClipboard::GetData()and wxClipboard::SetData() both log a "wxLogSysError" error-level message (see for example: https://github.com/wxWidgets/wxWidgets/blob/v3.1.4/src/msw/clipbrd.cpp#L703 ). This logged message gets displayed as a messagebox to the user.
The logging can be disabled temporarily by creating a wxLogNull object. See https://docs.wxwidgets.org/3.0/classwx_log_null.html
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6956
2021-02-03 01:55:05 +00:00
1c6c0bf8cf
Null-ptr safety.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7266
2021-02-02 23:09:35 +00:00
8464add58c
Use GetSchSymbolLibraryName() when looking up symbol in schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7301
2021-02-02 22:55:18 +00:00
b8e97bb6b6
Only apply B&W printer fixes when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7388
2021-02-02 15:37:30 +00:00
afad1625d7
Fix save-as extension of imported schematics
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7333
2021-02-01 18:34:59 +00:00
c11ded24cd
Add instrumentation to track down local issues in symbol library file code.
2021-02-01 12:57:16 -05:00
147c839857
Allow drag-select of fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6662
2021-02-01 17:14:30 +00:00
31fd49d444
Use the new nudge path for the symbol lib table, save global and project mru differently
2021-01-31 19:01:33 -05:00
ae5d2efe07
Snap common single-click tools
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7362
Fixes https://gitlab.com/kicad/code/kicad/issues/7363
2021-01-31 15:17:24 -08:00
bbb8173b61
Remove and re-add saved-as libraries when Syncing tree.
...
Also removes the aForce parameter as it was always true anyway.
Fixes https://gitlab.com/kicad/code/kicad/issues/7357
2021-01-31 23:00:17 +00:00
8567739a7a
Remove conditions from common immediate-mode keys
...
The conditions prevent use in immediate mode for common actions. While
this makes enable/disable easier in menu items, this fix is a patch
until we refactor the action framework to distinguish between immediate
mode hotkeys that should start without selections and menu items that
need a selection before running.
Fixes https://gitlab.com/kicad/code/kicad/issues/5333
2021-01-31 14:45:24 -08:00
de9da20bda
Fix broken html
2021-01-31 17:37:47 -05:00
b05bf34b77
Cleanup redundant if statement
2021-01-31 15:31:57 -05:00
2edcf42115
Symbol Editor IO_ERROR catching
...
Tests for read-only in table save routines and catches other IO_ERRORS.
Still returns a non-specific error message but prevents crashing when
erroring during save.
Fixes https://gitlab.com/kicad/code/kicad/issues/7352
2021-01-31 11:31:07 -08:00
dfc6070178
Unify schematic file version checking with PCBNew.
...
This also makes sure that the user gets a warning before saving over
an older s-expr format. While that won't always be wanted, it's now
in the infobar (like in PCBNew), so it's not too onerous.§
Fixes https://gitlab.com/kicad/code/kicad/issues/7347
2021-01-31 17:28:14 +00:00
a156acc6b0
Fix broken LIB_ITEM::Compare case
2021-01-31 11:48:05 -05:00
bfa8723bb6
Add uninitialized call
2021-01-31 11:45:17 -05:00
3380617836
Axis color fixes in symbol editor
...
- explicitly set axis color at symbol editor start
- force redraw of grid after axis color change
Fixes: https://gitlab.com/kicad/code/kicad/issues/7160
2021-01-31 15:28:37 +00:00
08a932a969
Add smarts to switch selection on right-click
...
Now looks at how hard it is to select the item (grids) and switches only
if the mouse is more than a grid square away and there is a new item
under the mouse.
Fixes https://gitlab.com/kicad/code/kicad/issues/4455
2021-01-31 07:00:48 -08:00
abf0a46dce
Refactor PICKER_TOOL and push up snapping disable functionality
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7348
2021-01-31 09:50:41 -05:00
c155218582
Sim plot: fix a rounding issue that can create a missing point in a plot.
...
Due to a truncation when converting a value to integer, the first point was
sometimes missing because it looked like out of plot range.
Fix also a cosmetic issue in dialog.
Fixes #7345
https://gitlab.com/kicad/code/kicad/issues/7345
2021-01-31 10:36:26 +01:00
8eca23aabe
Mark null project initial screen as zoom-initialized
...
The variable `m_Initialized` in `BASE_SCREEN` is used by
`SCH_EDIT_FRAME` to mark whether a screen had its zoom level initialized
by the "zoom to fit screen" action. When this variable is `false`, the
function `SCH_EDIT_FRAME::DisplayCurrentSheet()` performs "zoom to fit
screen", modifying the zoom level. This function is indirectly called in
the undo routines, so if `m_Initialized` is not set to `true`, a zoom
change will occur when the user undoes an operation, a behavior that is
undesired.
`m_Initialized` was not initialized to `true` for the null schematic
(the schematic that is loaded if no project is loaded), causing the
aforementioned undesired behavior.
To prevent this, I've changed the `SCH_EDIT_FRAME` constructor to set
`m_Initialized` to `true`, since it zooms to fit screen already. I've
moved `m_Initialized` from `BASE_SCREEN` to `SCH_SCREEN`, as it is used
only in Eeschema, and renamed it to `m_zoomInitialized`, a name I
believe that better describes what this variable does.
I've also introduced the function `SCH_EDIT_FRAME::initScreenZoom()` to
group the "zoom to fit screen" action with setting `m_Initialized` to
`true`, as they often should occur together.
I'd also like to say that I'm not confident whether
`SCH_EDIT_FRAME::DisplayCurrentSheet()` should perform the zoom level
initialization at this point, but I have decided to not change this
behavior for now, as the commit history suggests it's several years old.
Fixes https://gitlab.com/kicad/code/kicad/issues/7343
2021-01-31 00:49:11 +00:00
7737489e57
Symbol editor: don't allow new or imported symbols in read only libraries.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7334
2021-01-30 13:03:05 -05:00
41234a8373
Implement more precise annotation-required messages.
...
Also moves the message to an infobar so it's more noticeable.
Fixes https://gitlab.com/kicad/code/kicad/issues/7332
2021-01-30 16:31:27 +00:00
a235103e48
Redo pad & via painting (again).
...
New strategy isolates all draw/don't draw decisions to the ViewGetLOD
routines, and all dimmed/not dimmed to PCB_RENDER_SETTINGS::GetColor.
The actual drawing in PCB_PAINTER is more-or-less conditon free.
Also adds new layers for pad and via hole walls so that they can be
controlled for high-contrast mode.
Also changes the drawing paradigm so that the pads are drawn even when
not on the high contrast layer, just in low contrast. The hole wall
is drawn in high contrast. This actually makes things clearer to the
user (although to be honest was done to keep from having to re-render
pads when the high contrast layer changes since we have two separate
layers now that we can adjut colours on).
Fixes https://gitlab.com/kicad/code/kicad/issues/7328
2021-01-30 16:31:27 +00:00
1d12f3fe4a
Fix logic in selecting power symbols for net highlighting
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7339
2021-01-30 10:28:26 -05:00
619e128536
altium: Fix #6194 by no longer mirroring schematic text. Furthermore improve value parsing.
2021-01-30 15:44:32 +01:00
babda304d9
Prevent addition of false plot when current plot panel is not in m_plots
...
Without this commit, when `currentPlotWindow()` returned a valid
pointer, but one that is not used as a key in `m_plots`, it would get
inserted to the `m_plots` map. Because this pointer was not properly
initialized, a crash would later occur. I think this problem was
triggered by the pointer to welcome page, but I haven't checked.
Fixes https://gitlab.com/kicad/code/kicad/issues/7324
2021-01-30 02:04:57 +01:00
b64611af7a
Make highlight net flexible with grid
2021-01-29 14:28:26 -08:00
ea6dc0d730
Make auto-wire use snapping behavior
...
Forcing grid snap for the kick-start behavior loses snaps to pins that
may be desired. This also adds force-snapping in select mode to match
the user's auto-start preferences
Fixes https://gitlab.com/kicad/code/kicad/issues/7293
2021-01-29 14:09:33 -08:00
02954dfaa1
Fix another instance of modifying iterators
...
We cannot modify the ee_rtree while iterating over it without
invalidating the iterators
Fixes https://gitlab.com/kicad/code/kicad/issues/7331
2021-01-29 08:33:44 -08:00
540dd11b58
Use the file version when reading lib symbols from schematic file.
2021-01-28 21:31:33 +00:00
50b05aea4a
Thou shalt not set minimum width
2021-01-28 10:55:27 -08:00
78dbcdcdb7
Slight fixup to previous library browse change
2021-01-28 07:31:32 -05:00
69d58d39e5
Add alt pin table to compare function for LIB_PIN.
...
Also fixes refresh issue when editing alt pins.
Fixes https://gitlab.com/kicad/code/kicad/issues/7204
2021-01-28 11:35:18 +00:00
ff7742c6b8
File naming and include cleanup.
2021-01-28 11:35:18 +00:00
a373abd68a
Invert the new symbol library flow to push users to default to a different folder for global symbols
2021-01-28 00:40:21 -05:00
77bb36a482
Ensure local names of vector bus members are preserved
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7196
2021-01-27 21:53:04 -05:00
beb50c529e
Reorganize the CMake folder to separate build and configure steps
...
The BuildSteps folder now contains the CMake scripts that are
called during the build process as individual stages, while
the root CMakeModules directory contains the CMake files used
during the configuration phase.
2021-01-28 00:24:22 +00:00
e6dd95e83a
Create a default user projects folder
2021-01-27 19:12:18 -05:00
6a39b81647
Fix the last of broken Doxygen comment specifiers.
2021-01-27 17:39:44 -05:00
7d6a749285
Implement a more aggressive re-entrancy check for SCH drawing tools.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7259
2021-01-27 19:51:11 +00:00
df80f6484e
Use canonical names when exporting fields to netlist.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7300
2021-01-27 13:52:24 +00:00
df62adf901
eeschema,sim: fix crash at simulation start
...
fixes: https://gitlab.com/kicad/code/kicad/-/issues/7277
2021-01-26 23:29:05 +00:00
0967f8fc78
Fix typo.
2021-01-26 23:17:30 +00:00
de1c3a83fd
Hittesting for background-body-filled shapes (and other fills).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7286
2021-01-26 23:17:30 +00:00
0dd65d9cd1
Naming conventions and file order.
2021-01-26 23:17:30 +00:00
06f85471a4
Fix copy/paste error.
2021-01-26 19:01:31 +00:00
f3047829e5
Mark document dirty after drag; don't wait for point editor deactivation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7285
2021-01-26 19:01:31 +00:00
1598e870b6
Insert the same unit on all sheet instances when adding a symbol
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5898 (C)
2021-01-26 18:12:49 +00:00
2e21489acf
Copy unit numbers to symbol instances when pasting sheets
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5898 (B)
2021-01-26 18:12:49 +00:00
4bcd56b1f6
Always include unit number when copying to clipboard
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5898 (A)
2021-01-26 18:12:49 +00:00
4619d5e112
Fix more broken Doxygen comment specifiers.
2021-01-26 12:17:52 -05:00
3702f2e0a9
Add uuid r/w for sch pins, text, wires, etc.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7269
2021-01-26 10:56:19 +00:00
b576ccef61
Don't double-up tools on tool stack.
...
Also make sure move tool gets cancelled by other tools being
activated.
Fixes https://gitlab.com/kicad/code/kicad/issues/7259
2021-01-26 10:56:19 +00:00
6a48e21eb2
simulator: update dialog to handle R, I & TEMP DC sweeps
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2370
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6195
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2386
2021-01-25 21:29:13 +00:00
f6b7817044
Init intersheet refs props when converting to global label.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7252
2021-01-25 13:20:16 +00:00
9f18fee124
Fix ERC for nets with power input and input pins
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7264
2021-01-24 22:17:56 -05:00
8dfd297ee2
Show all pages for intersheet refs, and use IDs in hypertext menu.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7253
2021-01-25 00:55:38 +00:00
0a1a5ea669
Fold annotation error reporting into ERC.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6938
2021-01-24 23:01:24 +00:00
8ad448cbbc
Don't leave point editor running when moving things in eeschema
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7227
2021-01-24 12:59:42 -05:00
09bd66477d
Make sure sheet field parents are up to date
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7251
2021-01-24 12:59:42 -05:00
b2cd1fddf9
Prevent invalidating iterators
...
When iterating over RTree, we cannot modify the RTree without
invalidating our iterators, so we use a temporary structure to hold the
schematic items
Fixes https://gitlab.com/kicad/code/kicad/issues/7228
2021-01-23 13:41:00 -08:00
df2d0962c6
Drop hover selection in Symbol Editor after edit action.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7234
2021-01-23 17:12:34 +00:00
d770284fa2
Add a bus instead of a wire for bus junctions.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7231
2021-01-23 17:04:44 +00:00
7a8a099259
Bump SCH file format version for "unconnected" -> "no_connect".
2021-01-23 17:04:44 +00:00
0ba0160da9
Add a PT_NIC pin electrical type and a netlist token for SCH_NO_CONNECT.
...
ADDED a new pin electrical type "free" for internally unconnected pins.
CHANGED the "unconnected" pin electrical type is now represented by
"no_connect" in files and netlists. (The legacy syntax is also accepted
in files.)
2021-01-23 00:10:01 +00:00
10c6e0bc46
Cache entries are dependant on setting of aForceNoConnect
...
Don't use a result cached when aForceNoConnect was false when
aForceNoConnect is true.
2021-01-23 00:10:01 +00:00
f5e35af1a5
Transmit pin electrical types through to pads.
2021-01-23 00:10:01 +00:00
274fc60fe9
Formatting.
2021-01-23 00:10:01 +00:00
42cbcf7ef4
Don't allow empty page numbers
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6698
2021-01-22 14:02:34 +00:00
4f0accb714
Allow only updating reference links during back-annotation
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7190
2021-01-20 00:37:38 +00:00
ab8bd8f8c7
Dont duplicate items in sheet pin properties combo
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7132
2021-01-19 23:54:03 +00:00
360953ba98
"comp" -> "symbol".
2021-01-19 23:50:40 +00:00
d32c12b4b9
Banish new project from template to the menubar
...
+ remove inappropriate icon from Eeschema ctx menu
2021-01-19 22:57:25 +00:00
80dbc24326
Icons: remove superfluous icon
...
Remove icons where menu text gives context
2021-01-19 22:57:25 +00:00
351074cc48
Better-encapsulate collector sources in the selection tool.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7191
2021-01-19 21:10:43 +00:00
4da28cf8f4
Fix bad dereference
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7188
2021-01-19 08:39:22 -08:00
1491330596
Fix various memory leaks exposed by qa_eeschema
2021-01-18 22:40:58 -05:00
4052b2153a
Fix an ASAN issue in SCH_SHEET
2021-01-18 21:50:26 -05:00
6cd4fcf30c
Don't pick a name with a longer path to override with
...
Only triggered on some platforms because of compiler-dependent
unordered_set iteration
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7169
2021-01-18 21:50:26 -05:00
1eb6902b82
Fix race condition between eeschema and cvpcb.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6969
2021-01-18 19:24:57 +00:00
d052524707
Eeschema: fix zoom change on undo/redo command.
...
It was a side effect of commit e10025 fixing another zoom issue.
Fixes #7170
https://gitlab.com/kicad/code/kicad/issues/7170
2021-01-18 16:26:30 +01:00
c016ed7940
Engage brain before coding.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7123
2021-01-18 15:20:15 +00:00
2c9da4daa4
Make sure Check Pins works on a flattened copy of the part.
...
Also improved the reporting slightly (in particular for pins with
no names or pins with the empty flag ("~").
Fixes https://gitlab.com/kicad/code/kicad/issues/7165
2021-01-18 15:20:15 +00:00
479487ceb1
Tidy up context menus a bit
...
Try and put the common actions in the same places
2021-01-17 22:42:03 +00:00
95ca5a0233
Don't record null drivers.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7155
2021-01-17 16:24:22 +00:00
f3a6d2655e
Improvements to ERC and bus parsing.
...
1) Add some nullptr safety to ERC.
2) Allow unconnected flagging on bus/wire entries.
3) Allow commas in bus group definitions.
Fixes https://gitlab.com/kicad/code/kicad/issues/7155
2021-01-17 16:24:22 +00:00
f1221a9ca3
Resolve text variables in title blocks for outputing to netlist.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7153
2021-01-17 16:24:22 +00:00
65f90f141f
Symbol editor: remove duplicate legacy code path
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7139
2021-01-17 11:14:44 +00:00
e10025db64
Hierarchy navigation: keep the last used zoom level in a sheet when go back to this sheet.
...
Fixes #7107
https://gitlab.com/kicad/code/kicad/issues/7107
2021-01-17 09:41:49 +01:00
68efdb2fff
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:18:10 +00:00
ece0a5ec8e
Make default color UNSPECIFIED for new sheets and allows "clearing" the color
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6697
2021-01-16 08:39:20 +00:00
e27bd5cf15
Add control over updating of symbol attributes.
...
ADDED Update Symbol from Library and Change Symbol can now specify
whether or not to update attributes (include in BOM and include on
board).
Fixes https://gitlab.com/kicad/code/kicad/issues/7123
2021-01-15 22:19:49 +00:00
bd786b578a
Labels on pins should be considered "wire labels".
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7120
2021-01-15 21:07:45 +00:00
82cf747ca8
Symbol editor: fix broken pin table dialog OK button disable logic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7122
2021-01-15 09:28:36 -05:00
bae5825d1b
Fix copy/paste error.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7119
2021-01-15 13:14:47 +00:00
02681fcf0e
Move no-connect processing to connection graph
...
This way the net names can be inspected in eeschema and cross-probing works.
Testcases updated for the name changes
CHANGED: all unconnected pins are now included in the netlist with no_connect_ prefixes
2021-01-14 20:55:49 -05:00
9b69c1e198
Fix a bone-headed cause of non-determinism
2021-01-14 19:20:37 -05:00
1c42f95ab3
Added visible column to pins table
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6761
2021-01-14 21:03:51 +00:00
654e9a77db
Connectivity: defer and parallelize item updates
...
Good for ~15% performance improvement in large designs
2021-01-14 12:21:19 -05:00
6fb1ed2824
Make sure hierarchical overrides are deterministic
...
Without alphabetic sorting here, we are at the mercy of
the r-tree and multithreading.
2021-01-14 12:21:19 -05:00
b90e72ed07
Don't simplify hierarchical nets based on weak drivers
...
This behavior provided shorter net names, but was confusing if
the user gives an explicit strong driver in the subsheet but not
one in the parent sheet.
Testcases updated for net name changes; connectivity is the same
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4201
2021-01-13 22:10:56 -05:00
24ff66f5a2
ERC: flag unconnected sheet pins
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1780
2021-01-13 19:47:28 -05:00
693e40b5b0
Exclude buses from dangling label checks
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7017
2021-01-13 19:37:05 -05:00
2d64613bbb
Coverity fixes.
...
Reports 314745, 316271, and 316269.
2021-01-13 11:23:09 -05:00
e34756d596
Symbol editor: fix read only dialogs when symbol is from schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6968
2021-01-13 09:40:30 -05:00
bedd785546
Implement pin cross-probing now that EEschema can select them.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7084
2021-01-13 14:19:44 +00:00
0bce280424
Make sure design rules get recompiled after netclass changes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7082
2021-01-13 12:37:20 +00:00
ede500f117
Don't create multiple markers for the same issue
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7016
2021-01-12 23:24:13 -05:00
5ceadbda3b
Don't show redundant ERC markers from subsheets
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7016
2021-01-12 23:24:13 -05:00
ac3e677fae
Cleanup some compile warnings
2021-01-13 02:12:59 +00:00
d23b5f89b3
Don't save sheet multiple times on undo stack.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7063
2021-01-12 23:56:35 +00:00
c22921ee4f
Fix spelling
2021-01-12 13:33:40 -08:00
dc02ec9758
Remove a few const_cast
2021-01-12 20:51:31 +00:00
07635d2fc7
Minor adjustments
2021-01-12 20:51:31 +00:00
ac94d72d2d
Add more const specifiers
2021-01-12 20:51:31 +00:00
ec0af24f13
Make wxFindReplaceData argument const
2021-01-12 20:51:31 +00:00
bb2881a5ab
Make RENDER_SETTINGS argument const
2021-01-12 20:51:31 +00:00
cd2c46e5c9
Make "... file is read only." warnings translatable.
2021-01-12 14:33:35 +00:00
8fba0c257b
Icons: remove more inconsistencies around Select
...
Missed from 5d9b2d3fea
2021-01-11 23:31:24 +00:00
50889a9ed6
Promote mouse drag settings to full enums.
2021-01-11 22:09:36 +00:00
e4c77f3a47
Remove non-existant BOM plugins
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7053
2021-01-11 13:50:15 -08:00
1eee72ec65
Fix library tree behavior when duplicate project table entry is disabled.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5438
2021-01-11 07:46:07 -05:00
6c648df4c6
Support 3 drag vs. select options, and unifiy with other drag prefs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5493
2021-01-11 11:50:14 +00:00
60152bc00e
Spice sim: fix incorrect (very large) dialog size displaying the netlist.
...
It was previously fixed to 1500x900 pixels, that can be too large.
The window size and position is also now retained during a session.
Fixes #7043
https://gitlab.com/kicad/code/kicad/issues/7043
2021-01-11 10:06:33 +01:00
a718416245
Fix cross-probe clearing Eeschema net
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6915
2021-01-10 01:39:45 +00:00
e3f205a3c4
Minor eeschema annotate dialog flow optimisation
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4700
2021-01-10 01:03:58 +00:00
753442c60a
Don't select all of textfield on each focus.
...
GTK (at least) generates focus events when the app is reactivated so
the text keeps getting re-selected.
Fixes https://gitlab.com/kicad/code/kicad/issues/6757
2021-01-09 20:53:24 +00:00
0655f2c436
Symbol editor: do not disable tools and grey symbols from schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6968
2021-01-08 18:25:18 -05:00
51e6846ca5
Don't edit fields when more than one is selected.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7005
2021-01-08 20:43:02 +00:00
3467e643e5
Move pad locking from footprint to pads.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6997
2021-01-08 20:43:02 +00:00
c3d46c1cb5
Add ncPins to the list of no_connect_ nets.
...
This allows the info to be acted upon in PCBNew (for instance, clearance
rules).
Fixes https://gitlab.com/kicad/code/kicad/issues/6991
2021-01-07 21:56:04 +00:00
8c8516b7b1
Remove formbuild URL from hypertext links.
...
Also adds a tooltip.
Fixes https://gitlab.com/kicad/code/kicad/issues/6982
2021-01-07 15:12:19 +00:00
87b2081807
Set sheet file name when Save as... succeeds
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6561
2021-01-06 19:29:18 +00:00
b08555b924
Give blank schematics an output name
...
Plotting a blank schematic should have a placeholder name until the user
saves the file
Fixes https://gitlab.com/kicad/code/kicad/issues/6561
2021-01-06 11:11:26 -08:00
db394286c7
Add missing rect hittest
2021-01-06 10:02:06 -08:00
20888681f8
Fix wording of interchangeable units
2021-01-05 17:37:08 -08:00
2a24886d47
Icons: remove more duplicates
2021-01-06 00:35:20 +00:00
54724096ea
Icons: consistency between Eeschema and Pcbnew
2021-01-06 00:35:20 +00:00
6f228f9dea
hpgl_plotter: correct formatting
2021-01-05 22:42:21 +00:00
f5b7595675
Add user coordinate support to HPGL plotter
2021-01-05 22:42:21 +00:00
f6578da824
UUID compare should always be last
...
It is, by definition, unique, so all comparisons should be made before
it or they won't be made at all.
Fixes https://gitlab.com/kicad/code/kicad/issues/5940
2021-01-05 10:01:21 -08:00
7c29ff76f2
Fix a minor wxWidgets alert.
2021-01-05 15:07:23 +01:00
b40e3a39f5
Minor cleanup.
2021-01-04 23:59:36 +00:00
87d5318187
Disable alternate pin assignments for DeMorgan
...
Instead of hiding the dialog, we diable the pane and dropdown with a
consistent tooltip explaining why the pin assignments are not available.
2021-01-04 15:57:59 -08:00
51f40a3f2b
DIALOG_EDIT_ONE_FIELD: use a SCH_FIELD_VALIDATOR for mandatory fields.
...
These fields do not accept some chars, and must be filtered.
2021-01-04 16:03:04 +01:00
39abf8964f
Icons: fix simulator menubar
2021-01-04 01:44:01 +00:00
6542960ba5
Fix failure to clear list before reusing it.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6927
2021-01-04 00:33:42 +00:00
dc65166ee7
Implement algin-to-grid for fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6530
2021-01-03 22:39:58 +00:00
154e19b6e7
Icons: use common prefix for small 16x16
2021-01-02 23:16:33 +00:00
6d3c1c7716
Icons: remove unused sources/duplicates + rename
2021-01-02 23:16:33 +00:00
a69a4be853
Fix build error with icon names
2021-01-01 13:13:33 -08:00
5a0c3bf4bc
Icons updates
...
- Remove 22px bitmaps
- Move 24px icons to icon_XXX_24 filenames
- Update convert icon thanks to MisterHW
Fixes https://gitlab.com/kicad/code/kicad/issues/6088
2021-01-01 11:00:15 -08:00
8de9cff4e0
Change environmental variables to human-readable
...
Versions specific variables that may point to objects that change
through versions, allowing multiple KiCad versions to operate correctly
(even on MSW) on the same machine.
2021-01-01 16:20:35 +00:00
6a81113c2d
Better comments in files related to my previous commit.
2021-01-01 17:09:32 +01:00
93e186f53e
SelectFootprintFromLibTree(): fix a issue similar to commit 27d47743.
...
Force immediate deletion of the APP_PROGRESS_DIALOG (do not use Destroy() )
because on Windows, APP_PROGRESS_DIALOG has some side effects on the event loop
manager. A side effect is the call of ShowModal() or ShowQuasiModal of a dialog
following the use of a APP_PROGRESS_DIALOG (if not deleted) has a broken behavior
(incorrect modal/quasi modal behavior).
2021-01-01 15:59:15 +01:00
27d47743cd
SYMBOL_TREE_MODEL_ADAPTER: fix an annoying issue on Windows.
...
Force immediate deletion of the SYMBOL_TREE_MODEL_ADAPTER (do not use Destroy() )
because on Windows, APP_PROGRESS_DIALOG has some side effects on the event loop
manager. A side effect is the call of ShowModal() of a dialog following
the use of SYMBOL_TREE_MODEL_ADAPTER creating a SYMBOL_TREE_MODEL_ADAPTER
has a broken behavior (incorrect modal behavior).
2021-01-01 13:09:50 +01:00
b168b74919
CADSTAR Archive Importer: Fix position of multiline text with NO_ALIGNMENT in CADSTAR
2020-12-30 18:53:43 +00:00
a33ccf48b9
CADSTAR Schematic Archive Importer: Load signal name even if no net label (global labels and power symbols)
...
Fixes error that prevented global net names from being loaded properly
2020-12-30 18:53:43 +00:00
f6ec173ba7
CADSTAR Schematic Archive Importer: Do not load blocks without a linked sheet
...
Fixes std::out_of_range error
2020-12-30 18:53:43 +00:00
728792aa3c
CADSTAR Schematic Archive Importer: Fix SIGLOC in JPT (Load labels in junctions)
...
Fixes but that refused to open file with a SIGLOC node in JPT
2020-12-30 18:53:43 +00:00
a5118df44c
CADSTAR Schematic Archive Importer: Load Schematic Text Variables to KiCad project
2020-12-30 18:53:43 +00:00
9ed4780fec
CADSTAR Archive Importer: Change architecture to Parse CADSTAR fields and store them in a static map
...
Architecture of the parser changed to have a shared PARSER_CONTEXT between all the individual parsers.
Parses CADSTAR fields such as <@DESIGN_TITLE@> or <@SHEET_NUMBER@> and replaces with an equivalent KiCad Text Variable.
2020-12-30 18:53:42 +00:00
8a278a0579
update tuner_slider_base.fbp to our current wxFormBuilder version.
2020-12-30 19:03:31 +01:00
db0f3b42b4
Stop the cursor from reverting away from the window select in eeschema
...
Fix #6590
2020-12-29 19:51:34 -05:00
487aa37d2e
Connectivity: don't rename things multiple times in subsheets
...
Depending on what order the subgraphs are processed in, it's
possible to hit a case where the parent sheet renames a bus
member before the bus neighbor renaming logic runs. In this
case, we don't want to apply the bus neighbor logic as it will
break connectivity to the parent sheet if that bus was not
also renamed (for example, if the hier ports only make net
connections and not bus connections)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6887
2020-12-29 16:42:30 -05:00
50b171fa33
Symbol editor: improve symbol library save as behavior.
...
ADDED: Radio button controls to symbol library editor save as file dialog
to allow the user to choose the appropriate symbol library table changes
to be made after the library is saved.
Fixes https://gitlab.com/kicad/code/kicad/issues/4911
2020-12-29 14:00:46 -05:00
157ceedc12
Fix offset of repeated pin in Symbol Editor
2020-12-29 18:32:46 +00:00
07673d3c11
Don't access tools after they've shut down.
2020-12-29 17:29:24 +00:00
2a5cd08abb
Fix another crash when using the simulator probe
2020-12-29 07:39:49 -05:00
77f651639d
Eeschema: fix crash using tune/probe function in spice simulator.
...
Fixes #6875
https://gitlab.com/kicad/code/kicad/issues/6875
2020-12-29 13:13:58 +01:00
f2c5856124
Correct comment about the cast
2020-12-28 22:38:02 -05:00
230f3c2792
Fix crash when welcome panel was present in simulator and white background is toggled
...
Fix #6872
2020-12-28 22:33:20 -05:00
e66451c56e
I18n: remove useless trailing spaces in strings.
2020-12-28 08:43:47 +01:00
e33a331095
Don't ERC check absorbed subgraphs
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6861
2020-12-27 15:31:48 -05:00
ac1f7f93a2
Save context menu position for bus unfold
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6378
2020-12-27 13:07:16 -05:00
0de924ab4c
Fix deletion of bus aliases on subsheets
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4364
2020-12-27 12:33:35 -05:00
97a9f43a9f
Fix import of schematic grid settings
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6705
2020-12-27 12:33:35 -05:00
59c2bf19dc
Symbol editor header clean up.
2020-12-27 11:55:32 -05:00
5069d20768
Symbol editor: make library and symbol save as operations explicit.
...
Prior to this change the "Save As.." command would take a different action
based on the state of the editor which could be confusing. There are now
separate commands for saving the currently selected library or symbol.
CHANGED: The implicit save as menu entry which would save the currently
selected library if no symbol was selected or the current symbol to a
different library. There are now separate save as commands for libraries
and symbols to make it obvious what is being saved.
2020-12-27 11:55:32 -05:00
c16dda4027
Make sure added wires (from junctions) don't get left selected.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6852
2020-12-27 13:17:03 +00:00
c0e5e8eeee
Formatting.
2020-12-27 13:17:03 +00:00
8a720ef305
Update naming.
2020-12-25 23:37:01 +00:00
1648dd6f0e
Fix various issues with save & editing symbols from schematic.
...
1) Zero out selection in tree when canvas captures focus so that
save/save as actions will go to canvas, not tree item.
2) Make save do a save to schematic when the canvas symbol is from
the schematic.
3) Copy fields when doing a save to schematic (setting the lib part
doesn't update them on its own).
4) Remove no-longer-necessary calls to update schematic after
saving symbols (the schematic symbols are no longer hot-linked).
Fixes https://gitlab.com/kicad/code/kicad/issues/6763
2020-12-25 11:58:58 +00:00
9b43177e74
Remove highlight from colour preview.
...
It's more confusing than helpful.
2020-12-24 10:42:52 +00:00
ce700d4e16
Fix color preview issues: RTree and dangling flags.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6830
2020-12-24 10:36:29 +00:00
eb1f07bade
Icons: standardise `export_png` to match set
2020-12-24 01:02:03 +00:00
d2018b122b
Icons: unify export_svg with the rest of the set
2020-12-24 01:02:02 +00:00
6b420b191a
Use color theme backgrounds in page previews.
...
Also includes a *lot* of const fixing to make it happen.
Fixes https://gitlab.com/kicad/code/kicad/issues/6811
2020-12-23 23:18:38 +00:00
f722ba690f
Don't crash when lib table has no rows.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6812
2020-12-23 22:10:34 +00:00
3a3ef19ccb
When rotating during a drag/move, only rotate user-selected items.
...
In particular, don't rotate wires that had to be picked up; just
keep them connected.
Fixes https://gitlab.com/kicad/code/kicad/issues/6789
2020-12-23 14:24:35 +00:00
61ac9c8d90
Add multiple size icons for programs
...
In theory, the WM should now choose the closest size icon for its
purpose, making it easier to distinguish in space-constrained settings
Fixes https://gitlab.com/kicad/code/kicad/issues/6798
2020-12-22 15:37:26 -08:00
54ca087999
Update icon resource sets
...
Updates the .icns, .ico and .png files used by various distros to show
KiCad and KiCad files.
2020-12-22 15:16:33 -08:00
47ea51ec34
Allow both aui-manager-based infobars and window overlay infobars.
2020-12-22 21:36:39 +00:00
fb7ac450d9
Read-only dialogs for symbols in legacy libraries.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5211
2020-12-22 12:16:27 +00:00
f9bbdb31b0
Beginnings of legacy symbol locking.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5211
2020-12-22 00:14:54 +00:00
93dc7feea3
Remove multi-threading for footprint loading.
...
Also don't load the footprints up front. The whole purpose of the
footprint-info stuff is to have enough info about the footprints to
filter them *without* loading. After that just load individual
footprints as we need them.
Fixes https://gitlab.com/kicad/code/kicad/issues/6177
2020-12-21 22:03:24 +00:00
50e1e07f4b
Put pasted part on canvas.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6793
2020-12-21 17:37:53 +00:00
9bf952a695
Fix missing punctuation.
2020-12-21 17:37:53 +00:00
eb7dc6ddd9
Minor fixes. In stand alone show the frame as soon as possible.
...
Especially when running Pcbnew to open a complex board the frame is shown faster.
Add also a busy cursor when loading files and building the data.
2020-12-21 17:44:10 +01:00
81ce1a07ee
Fix a few issues with builtin color themes
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6754
2020-12-20 14:43:41 -05:00
f311831c27
Coverity fixes.
...
280252, 314742, 314745, 314747, 314755, 314756, 314757, 314758,
314935, 314936
2020-12-20 13:24:47 -05:00
7376c25ebe
Fix a crash bug trying to update the view before it was ready.
2020-12-20 18:02:16 +00:00
3d852372ca
Handle nested unescaping (for buses in particular).
...
Also adds a few missing unescape() calls when showing netnames to the
user.
Fixes https://gitlab.com/kicad/code/kicad/issues/6400
2020-12-20 15:59:09 +00:00
0830f87ef4
Break wire segments on bus-wire entry endpoints
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6173
2020-12-20 10:22:59 -05:00
7bc42f387a
Make sure splitter sashes are visible.
...
Also might fix 6791, although that's probably a long-shot.
Fixes https://gitlab.com/kicad/code/kicad/issues/6791
2020-12-20 12:35:41 +00:00
9b0a137d6c
Stop bludgeoncompiling dialog_page_settings
...
Through the power of OOP!
Needs some more cleanup though
2020-12-19 10:40:37 -05:00
489db6adde
Handle case where multiple pins are moved
...
When synchronized, if multiple pins are selected to be moved, we need to
match each to a matching pin in the new unit
Fixes https://gitlab.com/kicad/code/kicad/issues/2589
2020-12-18 15:48:34 -08:00
0fd920a94c
Modify Synchronize Pins behavior
...
Consider a pin synchronized iff the names and electrical types match in
addition to the position, orientation and demorgan variant.
Also, only modify one matching pin per unit. This prevents
moving/editing a full stack of pins on the same unit when synchonized.
Fixes https://gitlab.com/kicad/code/kicad/issues/2590
2020-12-18 15:48:29 -08:00
2226e0b7aa
Do grid snapping earlier to avoid inconsistencies.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5908
2020-12-18 19:57:44 +00:00
189b1742f7
Naming conventions and formatting.
2020-12-18 19:57:44 +00:00
c0d2ad42ce
Remember state of RefDes and Value checkboxes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6755
2020-12-18 15:09:54 +00:00
5d400a9e11
Improve symbol library messages.
...
Includes both error messages and ERC messages.
Fixes https://gitlab.com/kicad/code/kicad/issues/6302
2020-12-18 12:49:20 +00:00
bf632ad771
Pick up root sheet KIID from sheet instances.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6725
2020-12-18 12:49:20 +00:00
b68b1692ec
Clean up some more user messages.
...
Mostly component -> symbol but also some I18N cleanup.
2020-12-18 12:49:20 +00:00
4ce91d3e92
HPGL improvements and optimizations for physical plotters
...
- Sort HPGL plots for speed
- Reduce HPGL circle precision for tiny circles
- Teach HPGL plotter about filled rectangles
2020-12-18 07:21:59 +00:00
1c0d4ac02d
Simplify some error messages.
2020-12-18 00:30:26 +00:00
91ab540d18
Naming conventions.
2020-12-18 00:30:26 +00:00
c875efb635
Prevent modal deadlock by using QuasiModal mode.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6779
2020-12-18 00:30:26 +00:00
bb232e6ac6
Unify LIB_IDs now that both are stored in sexpr files.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6764
2020-12-18 00:30:26 +00:00
7b9c21e290
Not connected pins should not get connected
...
This prevents splitting wires/busses on the NC pin end. It also keeps
NC pins out of the netlist.
Fixes https://gitlab.com/kicad/code/kicad/issues/6777
2020-12-17 11:56:42 -08:00
aab3c936f0
Move headers from common folders to appropriate include folders round 2.
2020-12-17 11:44:03 -05:00
11117a2d9a
Fix invalid access into empty string.
2020-12-17 14:18:27 +00:00
a6085fa88d
Consistency for gerbview toolbar icons and some other icon tweaks.
2020-12-17 14:02:23 +00:00
08cf9a1e20
Move headers from common folders to appropriate include folders round 1.
2020-12-17 08:12:18 -05:00
a484d10470
Ensure schematic autosave works if sheet path is invalid
2020-12-16 21:17:48 -05:00
fc20eaa083
Fix some compiler and Coverity warnings
2020-12-17 00:30:22 +00:00
5761666ad6
Don't let the flattened symbol go out of scope before we're done with it.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6760
2020-12-16 17:59:20 +00:00
5f9ed2583c
Don't put up double lock confirmation dialogs.
...
Also removes EditToolSelectionFilter which was misused in more places
than it was used correctly. The original point of the client filter
was to move the logic to the point of use, which the
EditToolSelectionFilter sort of obviated anyway.
Fixes https://gitlab.com/kicad/code/kicad/issues/6751
2020-12-15 22:34:24 +00:00
d05df4a9d4
Buffer bitmap buttons in pinmap for Mac
...
Mac bitmap buttons are not properly handled in wxWidgets, so the size of
the bitmap needs more buffer space to the button edge or the image will
clip
2020-12-15 12:47:03 -08:00
92db1d35e1
Formatting.
2020-12-15 17:11:14 +00:00
4cc43b3bd3
Don't print sheet backgrounds when printing in black & white.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6746
2020-12-15 17:11:09 +00:00
10e68daa37
Fix some bugs in Change Symbol and Update Symbols.
...
In particular, there was a typo that kept library values from being
updated, and there was missing logic to fetch the various field names
from the library parts (and the change-to part).
Also implements some performance gains by desisting from copying
LIB_FIELDs around every time we want to look at them.
Fixes https://gitlab.com/kicad/code/kicad/issues/6733
Fixes https://gitlab.com/kicad/code/kicad/issues/6749
2020-12-15 16:12:17 +00:00
70cbf59846
eeschema/intersheet: don't list own page
2020-12-15 01:06:00 +00:00
dad2e317e9
Modify edit text & graphics to use pencil
2020-12-14 17:03:35 -08:00
22a6b36257
Don't allow dbl-click to leak through to other tools.
...
This only applies if the tool doesn't handle properties (which also
handles double-click events).
Fixes https://gitlab.com/kicad/code/kicad/issues/6735
2020-12-14 22:15:43 +00:00
07bb2729f8
Clean up over-use of auto.
2020-12-14 22:15:43 +00:00
c1a74b427a
Translucent magnifying glass on footprint & library browser icons.
...
Also renamed.
2020-12-14 22:15:43 +00:00
797a588015
Aliases should inherit their descs, keywords, and fp filters.
...
Assuming they're not set locally, of course.
Also updates to new class structure order.
Fixes https://gitlab.com/kicad/code/kicad/issues/6051
2020-12-14 13:48:26 +00:00
3b35bfc0a5
Don't write out synthetic severities (they're headings).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6726
2020-12-14 13:34:53 +00:00
9dae57ae9d
Fix several bugs in SCH color printing and plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6723
2020-12-13 22:43:09 +00:00
9720fc80fe
Print sheet background colour if specified.
2020-12-13 22:43:09 +00:00
126d40f9d3
"Sheet label" too confusing w/ sheet names and fields. Use "sheet pin".
2020-12-13 22:43:09 +00:00
40200ceab5
Clean up the symbol browser toobar a bit.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6712
2020-12-13 13:41:25 +00:00
5b22cef984
Associate -> assign in the context of footprint assignments.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6708
2020-12-13 13:41:25 +00:00
bc99545eb2
ADDED Migrate Libraries button to Manage Symbol Libraries...
...
Allows easier conversion of legacy libraries.
Note that performance will be suboptimal as it must read/write each
library once for each symbol in the library. Doing otherwise would
require modifying the PlugIn API, which probably isn't worth it for
a one-time migration.
2020-12-13 11:42:03 +00:00
1db7ffad5e
Formatting.
2020-12-13 11:42:03 +00:00
d67cf2f9af
Replace wxFile usage with wxFFile
...
Buffered libc wxFFile is better thinking about syscall wxFile going wrong.
2020-12-12 13:16:23 -05:00
93d55e3d23
Tweak no-connect and label icons
2020-12-12 11:26:30 -05:00
6544dca056
Ensure driver connections are always properly initialized
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6694
2020-12-12 10:43:30 -05:00
7186a0c621
Remove canonical name column from view and make sash more obvious.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6693
2020-12-12 15:27:46 +00:00
b6e267b78d
Naming conventions.
2020-12-12 03:43:41 +00:00
cf6f0b9b92
Use trash icon where appropriate
2020-12-11 17:05:11 -08:00
412c9c8c4e
Save should be disabled only if the file is up-to-date.
...
Any other issues (such as locked files) need to produce a dialog
with info for the user.
2020-12-11 23:58:30 +00:00
e667d26854
Eeschema: use "board editor" instead of "PcbNew" in UI strings.
2020-12-11 15:24:42 -05:00
4516aff43e
Symbol Editor: don't show edit page number in context menu.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6711
2020-12-11 15:02:34 -05:00
5d028b82ed
Eeschema: tool tip improvements.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6708
2020-12-11 13:42:50 -05:00
dd4298bb94
Coverity fixes: 280374, 313611, 313648, 313649, and 314720.
2020-12-11 13:29:52 -05:00
224697d0b3
Sheet navigator tooltip.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6680
2020-12-11 16:43:55 +00:00
73b7b104cd
Fix some issues with Infobar sizing.
...
This also commits to the new strategy as it wasn't really compatible
with if-def-ing anymore.
2020-12-11 12:39:40 +00:00
ee6f37bdc7
Headings and groupings for ERC severities.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6673
2020-12-09 22:19:06 +00:00
e61f768fbc
Eeschema: add defensive code to symbol library cache I/O.
2020-12-09 11:46:10 -05:00
ad1aae40ec
Unify the saved file strings
2020-12-08 19:49:47 -05:00
f29f052aa7
Update an outlier from the component -> symbol rename.
2020-12-08 18:30:14 +00:00
b26a5972c5
LIB_TREE's SetFocus() override no longer getting called.
...
The KIPLATFORM stuff forces focus, but not through the SetFocus()
call.
Fixes https://gitlab.com/kicad/code/kicad/issues/6657
2020-12-08 17:46:10 +00:00
c611f62ade
Get rid of annoying double-draw when choosing a new symbol.
2020-12-08 15:27:50 +00:00
34be4b4666
Cleanup.
2020-12-08 15:27:43 +00:00
d1a9efa5fc
Try out an animating, obscuring infobar.
2020-12-08 15:05:35 +00:00
cbda1d7bf1
Remove more vestiges of old colored msg panel messages
2020-12-08 00:50:25 -05:00
b45eb56ddf
Cleanup some msg panel usage using the no longer support colors
...
The color was being passed to the aPadding param now.....
2020-12-08 00:34:36 -05:00
abb5cb8310
Fix up msg panel status on save slightly
...
- pcbnew should use status bar on success like eeschema
- Add a helper to clear msgpanel and set it in one go to avoid redraw delays due to doing processing in between
2020-12-08 00:28:07 -05:00
ac32d6a4b6
Symbol editor: add tool tip to clarify interchangeable symbol units.
2020-12-07 17:52:01 -05:00
893f1bb4c1
Clear view before deleting part.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6658
2020-12-07 15:49:57 +00:00
78129aabeb
Fix another case of 413ff4525b.
2020-12-07 14:25:55 +00:00
59527dff2a
Add infobar for derived symbol editing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6439
2020-12-06 22:44:30 +00:00
ad281f7538
Remove duplicated TestDanglingEnds routines.
...
Also adds a changedItemHandler so that the single remaining version
can update the view.
Fixes https://gitlab.com/kicad/code/kicad/issues/6581
2020-12-06 21:24:16 +00:00
4f90c03c7d
Allow snapItem to be re-activated.
...
Don't clear until another snapPoint is chosen. This allows line
snapping to re-appear when they move back in range.
Fixes https://gitlab.com/kicad/code/kicad/issues/5973
2020-12-05 23:57:33 +00:00
a3406e7514
Make snapping more predictable.
...
In particular, allow grid positions to override line snapping if
they're a better match (and do this independently on x and y axes).
We already allow a nearer anchor to override, but that should be
based on a cartesian distance rather than independent axes.
Fixes https://gitlab.com/kicad/code/kicad/issues/6626
2020-12-04 22:50:30 +00:00
9ece90a541
Fix off-by-one error in exporting netlist, and update testcases.
...
The golden file update entails the change to no-connects as well as
the introduction of natural number ordering.
2020-12-04 19:37:55 +00:00
7b347d793b
Change gears on no-connect net generation. See bug rpt.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6534
Fixes https://gitlab.com/kicad/code/kicad/issues/6615
2020-12-04 18:25:48 +00:00
2050e05944
Formatting.
2020-12-04 14:48:48 +00:00
8d72a768e0
eeschema/intersheet: add print and plot functions
2020-12-04 14:46:42 +00:00
c47871e775
EDA_BASE_FRAME::ShowInfoBarMsg: add option to show a close button.
...
Same for EDA_BASE_FRAME::ShowInfoBarError and EDA_BASE_FRAME::ShowInfoBarWarning
2020-12-04 14:45:14 +01:00
821128cb8e
Eeschema: Make auto-decrementing net labels stop at zero
...
CHANGED: If you set the auto-increment value to a negative number,
created a net label and hit the insert key, when the name got below zero,
the net labels tried to go negative but created bad labels instead.
Now the code caps decrementing at zero, warns users when it has
happened, and explains why.
Fixes https://gitlab.com/kicad/code/kicad/issues/6537
2020-12-04 12:48:32 +00:00
e882753ebf
Grid snapping fixes.
...
1) Uniformly honour the GAL grid snap settings
2) Make more uniform use of GRID_HELPERs
3) Smarten EDIT_LINE for mid-point snapping
Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:55:58 +00:00
a19028a396
Hook up EE_GRID_HELPER to some more tools.
...
Also implements EE_GRID_HELPER layers so that connectable things
snap to connectable things and graphics snap to graphics.
Fixes https://gitlab.com/kicad/code/kicad/issues/5641
2020-12-03 15:16:34 +00:00
e79df4a3ed
Formatting.
2020-12-03 15:16:34 +00:00
fd3348690d
Symbol editor: enable save command when only libraries are modified.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6445
2020-12-03 08:17:09 -05:00
cf6620f8fa
eeschema: DIALOG_SYMBOL_PROPERTIES: fix crash when working on a old .sch file
...
Old .sch files do not store the symbol part description (stored in a cache lib)
So when using a .sch file, the part description can be not existing.
The fix tests for non existing part description.
Fixes #6580
https://gitlab.com/kicad/code/kicad/issues/6580
2020-12-03 10:45:47 +01:00
e5f340d176
Use monospace (teletype) font in show simulator netlist
...
May need fixing again for gtk (see #6587 )
2020-12-02 19:27:10 -05:00
43fe228367
Hook up a bit more of the EE_GRID_HELPER.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5985
2020-12-02 23:18:33 +00:00
64f555079a
Code cleanup related to zoom:
...
- remove outdated code or comment coming from old drawing code using wxDC
- move zoom values lists to zoom_defines.h
- fix incorrect zoom max and min values (gal scaling factor limits).
2020-12-02 18:35:28 +01:00
fcce62f0a4
cleanup related to zoom definitions
2020-12-02 18:35:27 +01:00
b7564f6f05
Don't modify RTree while iterating over it
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6582
2020-12-02 12:33:08 -05:00
8d3d648975
Update Change Symbols dialog to Update/reset terminology...
...
... as used in the Change Footprints dialog.
2020-12-02 14:27:43 +00:00
3d7c26b6bd
Get fields out of SYMBOL, not LIB_PART.
...
Also make sure the match-mode is initialised before we try and fetch
all the field names.
Fixes https://gitlab.com/kicad/code/kicad/issues/6589
2020-12-02 14:27:43 +00:00
d8fa37d5c2
Remove old root-schematic hacks. They don't work anymore anyway.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6583
2020-12-02 14:27:43 +00:00
71ab42e60a
Minor fixes and cleanup related to zoom definitions.
...
Mainly move 2 define relative to Zoom from convert_to_biu.h to zoom_defines.h.
Will make some changes/fixes in zoom code more easy.
2020-12-02 10:14:35 +01:00
05609dbc1d
Update screen r-tree after mirror operation
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6549
2020-12-01 19:19:12 -05:00
df262eaa06
Make prev/next marker work reliably on all platforms.
...
Requires us to move from arrow-keys to our own commands (the only
way that the OSX wxWidgets impl doesn't eat the keys when the dataVIew
has focus).
While there we might as well add a command to exlucde markers.
ADDED Prev Marker, Next Marker, Exclude Marker
Fixes https://gitlab.com/kicad/code/kicad/issues/6575
Fixes https://gitlab.com/kicad/code/kicad/issues/5501
2020-12-01 22:37:07 +00:00
3c521942ed
Smarten isEmpty checks to include nothing-but-whitespace.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6567
2020-12-01 16:39:06 +00:00
aa09418a14
Fixup memory lifespan of GAL options for the settings preview canvas
...
The canvas keeps a reference to the settings object, so we
can't pass one from the stack because it runs into lifetime
issues.
Also cleanup some loop-iterator problems.
Fixes https://gitlab.com/kicad/code/kicad/issues/6338
2020-12-01 01:12:07 +00:00
56fa5a23c3
SPICE export full precision data
...
Saving csv files loses precision when time/data steps are smaller than
10^-6. This switches to engineering notation when dealing with higher
precision.
Ref KiCad Services ticket 281
(cherry picked from commit 938859f10a
2020-11-30 13:27:38 -08:00
3ad5bce67f
Rewrite connected-lines dragger to not use EDA_ITEM flags.
...
We had some spurious bugs where both ends would get dragged to a
single point (making them disappear). While I never caught it
in the debugger, I'm guessing that the flags weren't getting
cleared properly or were getting overwritten or something. Anyway,
it now uses std::pair instead.
Fixes https://gitlab.com/kicad/code/kicad/issues/6550
Fixes https://gitlab.com/kicad/code/kicad/issues/6431
2020-11-30 19:30:03 +00:00
b1270bc9ab
eeschema page numbers: match print and plotting ordering to page number ordering
...
- new function SCH_SHEET_LIST::SortByPageNumbers() which uses SCH_SHEET::ComparePageNum for the sorting algorithm
- SortByPageNumbers() is called after every call to BuildSheetList()
2020-11-30 16:49:33 +00:00
9380d6f533
eeschema page numbers: match ordering in hierarchy navigator to sheet page number ordering
...
- update hierarchy navigator after any modifications to the SCH_EDIT_FRAME
- do not generate ghost selection events after updating hierarchy tree
- use Human Readable path in SCH_EDIT_TOOL::EditPageNumber
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5760
2020-11-30 16:49:33 +00:00
afcaa60faa
Remove "Order" field hack (partly reverts da1a89fc)
2020-11-30 16:49:33 +00:00
3a9a6e22bc
Fix issues in reporting netclasses.
...
1) make sure we get the default netclass when we want it
2) escape for HTML (particularly important for "<invalid>", but also
for reporting user rule names, netclass names, etc.)
2020-11-30 14:38:06 +00:00
3da0ab1a9a
Fix a couple of bugs in intersheet references.
...
1) init reference pages before trying to draw the SCH_FIELDs when
turning intersheet references on
2) don't double redraw because we accidentally cleared the last
hover item on a non-mouse-moved event.
3) make sure the root sheet gets a name for the hypertext menu.
2020-11-29 16:53:18 +00:00
56bb91b042
French translation update
2020-11-29 13:40:48 +01:00
09a1137f11
Fix a minor compil warning
2020-11-29 13:06:44 +01:00
9922b7b738
Redraw canvas after preferences. (Needed for grid changes, etc.)
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6433
2020-11-29 10:57:45 +00:00
becc811775
Make path substitutions grid read only in lib table dialog
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5624
2020-11-29 09:51:53 +00:00
ebf0cb3612
symbol viewer: fix closing issue when opened in modal mode
...
Fixes #6509
https://gitlab.com/kicad/code/kicad/issues/6509
2020-11-29 09:38:42 +01:00
095102614f
Eeschema: Fix non-visible source types in SPICE model dialog
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6540
2020-11-29 07:39:37 +00:00
6a28d6af27
CADSTAR Schematic Archive Importer: Fix loading of Schematic Sheet Pins and Orientation of Labels
...
- Find the intersection between the wire and the sheet and place the sheet pin there
- Fix orientation of hierarchical labels and global labels by applying opposite orientation to the connecting wire
2020-11-28 17:18:17 +00:00
ba77bf662c
CADSTAR Schematic Importer: Fix loading of buses
...
Place bus labels and correctly group nets for the bus in a BUS_ALIAS
2020-11-28 17:18:17 +00:00
0691e942f4
CADSTAR Archive Importer: Fix duplicate KIID for loaded elements
...
Don't use clone to copy an EDA_ITEM. Use Duplicate().
Even if you give the clone a new KIID, all its children will still be clones.
Create Duplicate() in LIB_PART
2020-11-28 17:18:17 +00:00
d2fbe12cfd
CADSTAR Schematic Archive Importer: Parse SCALE token in Symbol and warn user this is not supported
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6463
2020-11-28 17:18:17 +00:00
a058e26ddc
CADSTAR Schematic Archive Importer: Fix Loading of page numbers
...
Need to keep track of the hierarchy path in order to assign the page number
2020-11-28 17:18:17 +00:00
cba45ea257
CADSTAR Schematic Archive Importer: Fix orientation of components
...
- Fix the logic for the orientation of mirrored components
- Fix loading of angles/orientations from earlier versions of CADSTAR
2020-11-28 17:18:17 +00:00
49a2926a34
CADSTAR Schematic Archive Importer: Fix loading of graphical arc segments
...
Load the arc segments as piece-wise straight segments
2020-11-28 17:18:17 +00:00
71f9847601
CADSTAR Archive Importer: Only load the Master variant
2020-11-28 17:18:17 +00:00
f2ba9f7ac3
CADSTAR PCB Archive Importer: Correctly load the pad numbers as per the original design
...
To load the pad numbers correctly we need to also check the PART DEFINITION for each component
2020-11-28 17:18:17 +00:00
73ad503db3
CADSTAR Schematic Archive Importer: Parse missing TERMATTR node
2020-11-28 17:18:17 +00:00
13c63e3a50
Clearer warning about not back-annotating footprint deletes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6521
2020-11-26 19:30:16 +00:00
fc2bdc49de
Once more into the depths of hell... er, I mean fix a focus issue.
...
So the new steals-focus protection stuff works well when there's a
focused control, but not as well when there's a modal dialog up which
happens not to have a focused control (or worse, a focusable control).
This adds a second mechanism for also checking to see if a modal dialog
is up (something that wxWidgets, true to form, makes very difficult).
Fixes https://gitlab.com/kicad/code/kicad/issues/6520
2020-11-26 16:47:40 +00:00
c85ef8eb69
Make updating netnames in backannotate more discrete.
...
Trying to be too smart was producing unexpected results.
Fixes https://gitlab.com/kicad/code/kicad/issues/6480
2020-11-25 22:16:56 +00:00
d50d728d19
Cleanup compiler warnings
2020-11-25 00:08:09 +00:00
71ce00c5ce
Allow rotation of a single graphic line.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6487
2020-11-24 23:40:53 +00:00
9c7c05c161
Mostly formatting cleanup but a few type-casting cleanups too.
2020-11-24 22:16:41 +00:00
050d9e37ec
Fix rotation bugs in Eeschema.
...
Rotate text using the Rotate90() function which gets the orientation
right.
Also, when calculating the center point for rotation, don't include
labels if the selection contains other stuff. It just makes the
rotation odd, and tends to cause walking when continuing to rotate
(due to keep-upright being non-symmetrical).
Fixes https://gitlab.com/kicad/code/kicad/issues/git
2020-11-24 18:19:35 +00:00
44850e9409
Fix nullptr crash.
2020-11-24 14:13:03 +00:00
253f41c4f2
Fix minor dialog layout issue.
2020-11-23 23:57:26 +00:00
78b505f36a
Count head and tail lists as well.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6461
2020-11-23 23:54:54 +00:00
bf04fc3b72
Process all symbol instances as the ref, value, etc. may be different.
...
Also makes sure that the instance fields get set for reference, value
and footprint, and not just the base SCH_FIELD.
Also makes the translations easier.
Fixes https://gitlab.com/kicad/code/kicad/issues/6459
2020-11-23 22:09:15 +00:00
e91a5b3f81
Symbol editor: prevent derived symbol elements from being moved.
2020-11-23 15:46:03 -05:00
5f8a8c6850
Read/write "no net" (0) for pins with a no-connection marker.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2273
Fixes https://gitlab.com/kicad/code/kicad/issues/5587
2020-11-23 19:47:55 +00:00
c94001839b
Minor performance improvements to connection graph.
2020-11-23 19:47:55 +00:00
976c6262f4
French translation update (fix also trailing spaces in a few sentences)
2020-11-23 11:42:25 +01:00
dd60fd47b2
Cleanup and formatting.
2020-11-23 01:10:08 +00:00
baac9bfbf8
Don't try and rename lib entry when symbol is from board.
2020-11-22 15:40:44 +00:00
1f5831185e
Fix rotation of multiple global labels with intersheet references.
2020-11-21 23:44:26 +00:00
a9271e43cc
Read global fieldNameTemplates for project but don't write them.
...
Writing responsibility goes to the preferences dialog handler.
Fixes https://gitlab.com/kicad/code/kicad/issues/6450
2020-11-21 23:10:54 +00:00
3a4bd6fb8b
Fix uninitialized variable.
2020-11-21 20:57:36 +00:00
1391774f64
Re-factor boundary/courtyard checker error handling.
...
ADDED Footprint Checker dialog to display the results in.
Fixes https://gitlab.com/kicad/code/kicad/issues/6446
2020-11-21 20:57:35 +00:00
01b6cd08b5
lib_edit_tool.cpp: fix a wxWidgets 3.0.4 compatibility.
2020-11-21 11:56:32 +01:00
64636601b8
Eeschema: fix a Unicode/UTF8 management when pasting items from Clipboard.
...
Copy to clipboard save items (using S expr description) using wide strings
(not UTF8 encoding).
But Paste from clipboard was not converting the wide string to UTF8 string
when getting the stored data to send it as std::string to the S expr reader.
Fixes #6449
https://gitlab.com/kicad/code/kicad/issues/6449
2020-11-21 10:59:25 +01:00
3ff22fc882
Order symbols by unit/convert
...
This keeps the output symbol names in human-readable order
Fixes https://gitlab.com/kicad/code/kicad/issues/6376
2020-11-19 15:19:55 -08:00
c9fb595f64
Avoid assertion with invalid width
...
After adjusting col 0, the new width might be too large to handle. In
which case, allow the system to choose our best width
2020-11-19 15:19:55 -08:00
9e9946628a
Go back to arrow cursor on a cancel (or finish).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6421
2020-11-19 20:09:28 +00:00
c2ba68cdfa
Make sure intersheet references are updated on file-open.
2020-11-19 19:21:15 +00:00
826e47dde3
Hook up excluded ERC marker persistence.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6425
2020-11-19 18:22:52 +00:00
99796d359f
Honour include-in-board flag when back-annotating.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6438
2020-11-19 15:29:53 +00:00
801f385521
Eeschema: fix a UTF8 issue created by my commit 993a684
2020-11-19 14:37:51 +01:00
754e8e912c
Eeschema: some fixes in grid list and zoom list from config.
...
- slightly modify the zoom list.
- Do not use the values read from config: the user cannot change them,
so any issue in config cannot be easily solved.
Moreover, the grid list cannot be changed.
However the lists are still written in config, just in case.
2020-11-19 11:42:21 +01:00
99da663e82
Remove unused variables plus some more fixes from CppCheck
...
Remove unused variables plus a few more fixes from CppCheck
Remove unused variables plus a few more fixes from CppCheck
2020-11-19 02:28:47 +00:00
7c344e9be6
Mirroring for intersheet references.
2020-11-18 23:34:27 +00:00
c61c7b62aa
Start of impl for persisting ERC exclusions.
2020-11-18 23:34:27 +00:00
293795fd46
Support rotation on intersheet references.
2020-11-18 23:34:27 +00:00
0e44f5128c
Add const specifiers
2020-11-18 19:50:36 +00:00
f005335743
Resolve variables in Sheet Properties dialog's sheet path.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6409
2020-11-18 17:55:12 +00:00
55d0b79746
Make sure current sheet gets set when creating BOM.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6418
2020-11-18 17:32:40 +00:00
c1d1c12b41
Simplify message panel code.
...
We've had the colours turned off for two releases now without any
screaming or gnashing of teeth, so it's time to clean up the code.
2020-11-18 17:32:40 +00:00
cb5ec8bce1
Make Eeschema cursors update without waiting for mouse movement.
2020-11-18 17:32:40 +00:00
bd1f262a6b
Fix issues with Intersheet Ref highlighting and hover actions.
2020-11-18 17:32:40 +00:00
16e3e59495
Split out arrayDim and MIRROR templates from macros.h
...
These were not macros
2020-11-17 20:21:04 -05:00
a4201ea833
Fix crash in libedit
...
LIB_ITEM is not derived from SCH_ITEM but they share a selection model
2020-11-17 14:28:56 -08:00
c89676e39d
Require client to specify whether they want resolved values or not.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6408
2020-11-17 21:36:48 +00:00
94a358c592
fix 2 compil issues
2020-11-17 19:32:20 +01:00
8c5c902fa3
Re-write IntersheetRefs on top of SCH_FIELDs and textVars.
...
1) Generalize SCH_ITEM owners (SCH_COMPONENT, SCH_SHEET, and now
SCH_GLOBALLABEL)
2) Generalize hypertext items
3) Use SCH_FIELD autoplace infrastructure for placing intersheet
references
4) Use textVar infrastructure for buildin intersheet references.
As an important side-effect this also fixes the undo issues with
intersheet refs.
2020-11-17 16:05:49 +00:00
d616d5ad1f
Naming conventions.
2020-11-17 16:05:49 +00:00
a207bd97bb
Naming conventions.
2020-11-17 16:05:49 +00:00
dff5173baf
Exorcise some instances of "modedit".
2020-11-17 16:05:48 +00:00
b9cc9b0f74
sch_sexpr_plugin.cpp: fix incorrect calculation of a relative path on Windows.
...
On Windows paths have a disk identifier. but MakeRelativeTo() was called with
wxPATH_UNIX option, thus creating sometimes incorrect (non existent) relative paths.
2020-11-17 16:24:03 +01:00
9b2dac8df6
fix error in commit 993a684.
2020-11-17 14:56:34 +01:00
993a684959
.kicad_sym files: Fix an issue when a symbol name contains a double quote.
...
This char (accepted in dialog) was escaped in some places, but not all.
So if a symbol name contained a double quote, the lib file was broken.
2020-11-17 12:33:46 +01:00
1db15052b0
Remove unused schematic settings filed
...
It was never written to the file and never used.
2020-11-15 21:30:50 +00:00
b21e07d759
Allow spaces in SheetPins (for bus definitions).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6379
2020-11-15 20:23:15 +00:00
b227d2b910
More component -> symbol.
2020-11-15 20:23:15 +00:00
6e6e0aa644
Naming conventions (including some component -> symbol).
2020-11-15 20:23:15 +00:00
4e8072b8c2
Prefer relative paths.
...
This also prevents us from leaking private information into netlists
and PCBNew files.
Fixes https://gitlab.com/kicad/code/kicad/issues/6361
2020-11-15 20:23:15 +00:00
6654c03041
Embarking on the next adventure: component -> symbol.
2020-11-15 20:23:15 +00:00
9aa6e40b79
Eeschema, fields_grid_table.cpp: fix a crash when the eeschema settings are not available.
...
It happens if the svhematic is not open when opening the symbol editor.
Fix also a compil warning.
Fixes #6384
https://gitlab.com/kicad/code/kicad/issues/6384
2020-11-15 13:50:10 +01:00
d094f86b1a
Finish module cleanup (except for xpms).
2020-11-14 22:00:12 +00:00
d2a88234b6
Fix issue deleting footprint libraries from table.
...
wxWidgets pageChanged handler is evidently buggy. Who would have
guessed?
2020-11-14 20:12:49 +00:00
7bd31d5237
Naming conventions.
2020-11-14 18:26:03 +00:00
8bae52d1c3
Correct naming conventions.
2020-11-14 14:29:11 +00:00
f35736cdd7
Eeschema: minor dialog and panel layout fixes.
2020-11-14 07:40:17 -05:00
592cd99fd5
Pin dialog min size so that we don't wrap our (hacked) overbars.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6371
2020-11-13 17:55:54 +00:00
bdbb68f813
MODULE -> FOOTPRINT.
2020-11-13 16:04:03 +00:00
63a54d003e
More module -> footprint.
2020-11-13 15:16:24 +00:00
522d64968e
Yet more module -> footprint.
2020-11-13 15:16:24 +00:00
f0d0e17aab
Prepare for MODULE -> FOOTPRINT.
2020-11-13 15:16:24 +00:00
43a4cf7957
Coverity fixes.
...
CIDs 309391, 310711, 310712, and 313055.
2020-11-12 08:15:49 -05:00
787bd5109e
Copy properties but not values of datasheet and footprint fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6037
2020-11-11 17:52:15 +00:00
d88eaaf477
Fix various compiler and Coverity warnings
2020-11-11 00:41:02 +00:00
36a139acb3
Tighten up hittest logic for junctions and lines.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6348
2020-11-10 18:08:25 +00:00
4ea3914d4e
Coverity fixes.
...
CIDs: 312996, 305508, 305509, 305510, 312992, 312997, 312994, 312995,
312968, and 306650.
2020-11-10 08:50:16 -05:00
79dd6e6476
Eeschema, ERC: fix missing call to subgraph->ResolveDrivers() when test driver
...
conflicts (more than one name for a net) is disabled.
This missing call was creating issues in tests that need a full connection
calculation, especially ercCheckFloatingWires()
2020-11-10 11:30:30 +01:00
4889f9bb7c
Fix typo in net label orientation calculation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6333
2020-11-09 12:07:40 +00:00
8665098757
Don't write translated strings from the plugin cache
...
Followup for b7f115bf5f
2020-11-09 07:33:46 +00:00
1f5213946e
Restore accidentally-removed allowsSpaces architecture.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6252
2020-11-08 00:34:04 +00:00
c6ba4cdd19
Naming conventions.
2020-11-07 21:55:18 +00:00
bfd8a62852
Formatting and naming conventions.
2020-11-07 18:50:30 +00:00
91ba002da7
Make sure move machinery gets initialized if we're going to use it.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6293
2020-11-06 12:21:31 +00:00
08ca80a2d8
Smooth out redrawing of toolbars by not letting wx pointlessly calculate both orientations
...
Monkey patch
Fix #5705
2020-11-05 20:56:14 -05:00
670fc645de
More fixes for initializing imported filenames.
2020-11-06 01:33:14 +00:00
3630f32c26
Initialize newly imported files with current schematic extension.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6083
2020-11-05 23:24:59 +00:00
44400ca413
Formatting, some i18n, and shorter log messages.
2020-11-05 23:19:47 +00:00
ae4614bfbd
Symbol editor: do not allow paste into derived symbols.
...
Don't allow select all, copy, cut, paste, or duplicate if the current
symbol is an alias.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6050
2020-11-04 15:00:09 -05:00
43176a5b29
Eeschema: Add Schematic Setup GUI to set junction dot size from list
...
CHANGED: In Schematic Setup->General->Formatting->Connections, added
pulldown for "Junction dot size" with values none, smallest, small
default, large, largest" Added support in "sch_painter.cpp" to not
paint junction when they have a diameter of "1" which is what "none"
sets as the diameter.
2020-11-04 01:49:41 +00:00
3d47eb0d49
Fix localization of the menu strings with accelerator strings
...
The accelerator strings really shouldn't be part of the translation,
and some translations have cause the accelerator keys to be incorrectly
handled. It is simpler to make it separate and just join them to the
translated string.
Make all accelerator modifiers use lowercased Ctrl instead of CTRL
to be the same as the other modifiers.
Fixes https://gitlab.com/kicad/code/kicad/issues/5992
2020-11-04 01:31:52 +00:00
123fe5a887
Sort root symbols by name in new symbol dialog
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5910
2020-11-04 01:31:52 +00:00
88abcc1287
Fix broken handling of closing ERC dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6277
2020-11-04 01:08:21 +00:00
5507575d64
Move ERC dialog to EE_INSPECTION_TOOL and kill when resetting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6111
2020-11-03 20:27:44 +00:00
4be6a27a39
Report error when pin for backannotate can't be found.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6263
2020-11-03 18:53:14 +00:00
2a8ea25209
Null pointer safety.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6263
2020-11-03 15:47:38 +00:00
52e9ec5954
Symbol editor: fix library symbol tree modified state bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5573
2020-11-03 09:33:06 -05:00
bd103c133d
Don't save junction colours when they're inherited.
...
Also fixes Edit Text & Graphics Properties to be able to clear
colours from junctions.
Fixes https://gitlab.com/kicad/code/kicad/issues/6018
2020-11-03 14:07:50 +00:00
6a3c868db5
Don't copy lastDriver when cloning connection.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6018
2020-11-03 14:07:50 +00:00
c1ecb4257d
Fix error with empty sheet paths.
2020-11-02 18:05:56 +00:00
20bb3b194f
Eeschema: Display the root sheet name to the user
...
Instead of just `/` denoting the root sheet, use the filename
in preparation for non-hierarchical multi-sheet schematics
2020-11-02 17:50:13 +00:00
644546cd83
Cleanup PathHumanReadable and remove dead code
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6152
2020-11-02 17:50:13 +00:00
2e92cc7958
ERC: use separate tests for input pins and power input pins.
...
Input pins can be driven by many pin types: output, passive, 3state, I/O
But Power pins can be driven by only power output pins, and cannot
use the same criteria in ERC tests.
2020-11-02 12:41:58 +01:00
7c505da368
Make sure ERC tests honour the severity settings.
...
(And in particular, IGNORE.)
Fixes https://gitlab.com/kicad/code/kicad/issues/6178
2020-11-01 17:38:24 +00:00
042e5956c2
Fix library table dialog tab labels.
2020-11-01 09:13:55 -05:00
cf59468de2
Fix library table dialog tab appearance in dark mode.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6236
2020-11-01 08:30:27 -05:00
fbcbed5543
Add acceleratedGraphics prompt for eeschema
2020-10-31 17:49:50 -04:00
7203a51fec
Fix bad include path
2020-10-31 16:42:24 -04:00
3dde4e5616
Eeschema: fix yet another symbol properties dialog layout issue.
...
Stop trying to make a read only wxTextCtrl with a custom font work
for displaying the symbol library identifier and use an ellipsized
wxStaticText control with the standard font instead.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6240
2020-10-31 08:36:59 -04:00
6cefec64ea
Commit pending changes before quitting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6239
2020-10-31 11:50:11 +00:00
92d6988f10
Keep pin positions stable when resizing sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6196
2020-10-31 11:49:07 +00:00
bddc97df30
LibEdit -> SymbolEditor
2020-10-31 10:28:21 +00:00
0d8789935d
Refactoring. Push editing code to toolset.
2020-10-31 10:28:21 +00:00
de013ee60a
Selection center is center of visible items.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6188
2020-10-30 23:37:35 +00:00
4314e4dc93
Update French translation and fixes minor I18n issues.
2020-10-30 21:01:15 +01:00
9065908859
Update SCH_SCREEN's RTree when moving items.
...
Or when modifying geometric shape/properties.
Fixes https://gitlab.com/kicad/code/kicad/issues/5922
2020-10-30 15:26:07 +00:00
45618327cf
Fix crash bug closing schematic with sheet selected.
2020-10-30 15:26:07 +00:00
a1508d2531
Symbol editor: minor symbol properties dialog layout fixes.
2020-10-30 10:49:24 -04:00
a5e628a552
Symbol editor: fix missing footprint filter support for derived symbols.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6038
2020-10-30 09:28:54 -04:00
1d110d5414
Move a couple more dialogs to QuasiModal for syntax help.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5897
2020-10-29 22:55:33 +00:00
5abb61e195
DIALOG_FIELDS_EDITOR_GLOBAL: fix a few minor issues.
2020-10-29 17:27:38 +01:00
9101e61c06
Symbol editor, fix saving legacy symbol library bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6157
2020-10-29 08:22:38 -04:00
d26d93b32c
Remove shadow version of autoplace fields variable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6199
2020-10-28 22:48:23 +00:00
c9d7bdc340
Hook up AutoplaceFields for sheets.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6197
2020-10-28 22:32:36 +00:00
d90d734166
Eeschema: fix symbol rescue bug.
...
Loading the schematic symbol preserves the invalid LIB_ID characters in
the symbol name. Unfortunately, loading the library symbol automatically
fixes the invalid characters so this caused the symbol rescue to not find
library symbols with invalid characters. Replacing the invalid characters
in the schematic symbol name during rescue fixed the issue. This fix
isn't perfect because there is the off chance that replacing the invalid
characters could lead to a name clash in the library resulting in the
incorrect symbol to be rescued.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2319
2020-10-28 09:31:10 -04:00
a6d4ce2a5c
Finish impl of alternate pins.
...
It appears this got shelved while waiting for the sexpr format to be
firmed up, and then I forgot about it.
Fixes https://gitlab.com/kicad/code/kicad/issues/6189
2020-10-28 13:01:42 +00:00
ceb4b56134
DIALOG_FIELDS_EDITOR_GLOBAL: fix crash due to a missing column used in code.
...
Fix column sizes.
Fixes #6191
https://gitlab.com/kicad/code/kicad/issues/6191
2020-10-28 11:22:52 +01:00
49fd95f58d
Bus-wire entries can't propagate through bus junctions
...
This fixes strange connectivity issues observed if you manage
to get a bus junction touching a bus-wire entry.
2020-10-27 22:05:35 -04:00
70c90266a8
Fix crash when loading new schematic with something selected
2020-10-27 22:05:35 -04:00
31d502735c
Better messages for bus entry conflict ERC
2020-10-27 22:05:35 -04:00
2d59bb8156
altium: initial code to insert sheets (but not parse them)
2020-10-27 15:51:57 +01:00
3f0edb6f83
altium: introduce workaround until symbols are parsed with their real orientation
2020-10-27 15:51:57 +01:00
00af4e123e
altium: improve support for ports, using the knowledge about terminal points
...
Still not perfect, but better than the previous version.
2020-10-27 15:51:57 +01:00
a7d5d1f091
Add more consts all over the place
2020-10-27 11:03:35 +00:00
6bd3b0afa4
Various Coverity fixes
2020-10-27 00:25:08 +00:00
31e626f279
Cleanup creation of all our smart pointers
2020-10-26 23:52:44 +00:00
976b7e1c47
Eeschema: Move last netlist code to netlist_exporters folder
2020-10-26 18:40:58 +01:00
52d8501563
altium: initial parsing of designator and some parameters
2020-10-26 18:27:29 +01:00
52b5e4d0b3
altium: initial code to parse ports. Includes a hack until we know which side to connect to.
...
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6056
2020-10-26 18:27:29 +01:00
f7084afb72
Eeschema: fix annotation bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6154
2020-10-26 13:01:36 -04:00
d7ee5fe97f
Apply wxWidgets hack to get saved component tree widths restored.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6036
2020-10-26 15:36:07 +00:00
1984581c46
Remove common.h from more headers
2020-10-25 22:29:53 -04:00
9de0ff22c1
Rename Mirror template to MIRRORVAL to avoid shadowing
...
I am bad at naming creativity here, but hey, it's unique
2020-10-25 20:44:22 -04:00
14c18b7e64
Move ui functions out of common and into ui_common
2020-10-25 20:01:12 -04:00
91e5611341
Move dialog_configure_paths.h and dialog_edit_library_tables.h to dialogs folder
2020-10-25 20:01:12 -04:00
e49ac45b84
HTML_MESSAGE_BOX is a dialog
2020-10-25 20:01:12 -04:00
a785f70ea1
msgpanel is a widget, shove it to the right folder.
2020-10-25 20:01:12 -04:00
ec11697660
Language update for autostart wires checkbox
2020-10-25 18:37:54 -04:00
2edd246f36
Use explicit message for multiple drivers ERC
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/3980
2020-10-25 18:30:22 -04:00
ee08a3488f
Fix missing driver conflict ERC
2020-10-25 18:13:03 -04:00
0e9efef7aa
Never show footprints in power symbol chooser mode
2020-10-25 17:27:06 -04:00
48a67e1ff8
Set a few more ERCs to be warnings by default
2020-10-25 16:32:15 -04:00
2f1e755f66
Update preference panel names.
2020-10-25 19:51:03 +00:00
4789794e0e
Minor dialog spacing normalization.
2020-10-25 13:38:15 +00:00
51dff1c822
Live update sheetpath.
...
Also makes it a static text to get rid of the spacing/clipping
problems it has been having.
Fixes https://gitlab.com/kicad/code/kicad/issues/6152
2020-10-25 13:37:40 +00:00
189792cd4c
Eeschema: fix sheet properties dialog sheet path bug.
2020-10-25 08:08:10 -04:00
15c2181a89
Eeschema: fix sheet properties dialog page number bug.
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6151
2020-10-25 07:32:20 -04:00
d6f91c810f
Fix a few compil and Coverity warnings.
2020-10-25 10:02:07 +01:00
e928b2d8fd
Split EDA_UNITS out from common.
2020-10-25 00:02:52 -04:00
346b7178b7
Repair the way other units are collected when syncing symbol fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6106
2020-10-24 22:39:53 +01:00
1f21a93b39
Don't require power symbols to be annotated.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6112
2020-10-24 19:46:08 +01:00
f34ee00a8b
altium: import power port in all their different shapes
2020-10-24 18:40:54 +02:00
1c848622d7
Remove junctions as auto wire targets
...
Fix #6100
2020-10-24 10:09:42 -04:00
4ac4cc14ee
Eeschema: fix new sheet page number bug.
...
Msys2 builds on windows still don't support the %z printf specifier so
convert to integer and use %d.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6142
2020-10-24 09:08:56 -04:00
81a7afc76e
Use kicad_algo directly rather than common.h
2020-10-24 08:53:11 -04:00
77ece552f7
Remove macros.h from files that don't need it
2020-10-24 08:28:02 -04:00
c173ea14b7
Quiet MSVC warning about bool OR int
2020-10-24 00:50:37 -04:00
1c0700fbc4
Quiet gcc warning about assignment
2020-10-24 00:50:02 -04:00
eeac3cb4d5
Nix some more common.h includes
2020-10-24 00:38:25 -04:00
304e5faf36
Move wxStringSplit to kicad_string
2020-10-24 00:17:07 -04:00
b7f115bf5f
Don't write translated strings
...
Even though the translation isn't used, the choice of locale can create
unwanted diffs
2020-10-23 19:53:25 -07:00
1d559108c8
Move LOCALE_IO out of common.h
2020-10-23 21:49:42 -04:00
50cff57b9a
Explicit bools for MS
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6146
2020-10-23 21:35:23 -04:00
c5a86126d2
Be more clever about making sheet names unique.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6123
2020-10-23 23:55:45 +01:00
db66e16f71
SymbolEditor: Ask to save local edits in schematic on symbol editor window closure
...
Previously, Asking for save, cancel... was made for a symbol coming from lib
but not when the symbol come from the schematic editor.
Fixes #6132
https://gitlab.com/kicad/code/kicad/issues/6132
2020-10-23 17:56:15 +02:00
b7c2d64333
altium: Correctly parse multiunit symbols
...
Followup to https://gitlab.com/kicad/code/kicad/-/issues/6055
2020-10-23 17:20:07 +02:00
adfc74f93a
altium: Add initial support for multiunit symbols
...
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6055
2020-10-23 17:04:59 +02:00
0d3d3e0d7c
altium: parse symbol description, remove dependency on legacy plugin
2020-10-23 17:04:59 +02:00
47786fa976
altium: Correctly handle symbol names containing invalid chars
...
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6082
2020-10-23 14:30:29 +02:00
d8ffea881e
Improve dialog static sizer box consistency.
...
Remove colons from the end of static sizer box labels from a few dialogs so
they are consistent with all dialogs.
2020-10-22 22:00:04 -04:00
922304f980
Guard against missing theme in DIALOG_PLOT_SCHEMATIC
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6124
2020-10-22 21:21:27 -04:00
ed03ca7ad0
Symbol editor: improve save all behavior for read only libraries.
...
Instead of forcing the user to save modified read only libraries to a
different file name, an info bar is displayed warning the user that read
only libraries need to be saved as a different library. All modified
non-read only libraries are saved as normal.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4668
2020-10-22 07:49:00 -04:00
d785dae88b
DIALOG_EDIT_COMPONENT_IN_LIB -> DIALOG_LIB_SYMBOL_PROPERTIES.
2020-10-22 10:41:21 +01:00
7d09681f9e
Improve reporting on NC and global label ERCs
2020-10-21 22:14:04 -04:00
601a63b63a
Better prioritization for non-driven pin ERC
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1881
2020-10-21 21:47:00 -04:00
af28634df1
Bring Pin Not Driven ERC to the new system
...
Also reword the error title to be a bit more clear
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5681
2020-10-21 21:35:09 -04:00
2153a7655b
Try harder not to give a read-only path to save dialog
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5937
2020-10-21 20:55:43 -04:00
b39fb3374d
Fix fat fingered error
2020-10-21 14:41:14 -07:00
69d47c90ea
Unify sentences in translation
2020-10-21 12:31:21 -07:00
d90faa26a5
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6095
2020-10-21 18:35:39 +00:00
176f461b2c
Fix a corner case of wire merging.
...
We want to look for a junction before merging two touching colinear
segments, but the old code would also check for a junction when
merging two overlapping segments, which is not what you want.
Fixes https://gitlab.com/kicad/code/kicad/issues/5960
2020-10-21 18:51:47 +01:00
339fa5e0e3
Hack around the mess that we've made of line styles. :(
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5960
2020-10-21 18:51:47 +01:00
f8a4edb1c9
First pass renaming module to footprint
...
This is mostly in comments and the few remainin text strings that
reference module
2020-10-20 20:49:11 -07:00
06bf7943b7
Minor warning fixes
2020-10-21 00:30:50 +01:00
7a41ff74df
Fix undo of DeMorgan conversion.
2020-10-21 00:04:04 +01:00
e5089d783d
Remove multi-label entry feature.
...
It was causing problems with surprising behaviour and issues with
allowing spaces in existing labels. We'll work on something better
for 7.0....
Fixes https://gitlab.com/kicad/code/kicad/issues/6073
2020-10-20 22:53:44 +01:00
e497639320
Don't allow both DeMorgan alternates and general pin alternates.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6087
2020-10-20 22:26:47 +01:00
83890f8d3a
Move label editors to QuasiModal so the Syntax Help window can be shown.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5437
2020-10-20 22:26:47 +01:00
661e85d705
Standardize "Key words" to "Keywords"
2020-10-20 13:18:48 -07:00
2a43b88115
Standardize PostScript capitalizaiton
2020-10-20 13:09:13 -07:00
316ca120e8
Don't translate spice prefixes or numbers
2020-10-20 12:51:23 -07:00
4085757aeb
Remove beginning/ending spaces in translations
...
Adding space padding makes translations more difficult by increasing
string counts
2020-10-20 12:08:04 -07:00
7c9acc605d
Introduce a new number badge UI element for DRC and ERC reporting
...
This new badge allows for proper UI scaling and will not cut off
the number being displayed.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5734
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6011
2020-10-20 02:35:48 +01:00
8f67557a65
Separate display and canonical names in Edit Symbol Fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6066
2020-10-19 23:58:07 +01:00
c79d6391dd
Eeschema: minor plot dialog layout fixes.
2020-10-19 14:34:43 -04:00
8ff51d8899
Eeschema: add schematic sheet page number.
...
The groundwork has now been laid for per sheet instance data. Initially
this only supports sheet page numbers but could be expanded to include
other per sheet instance information.
ADDED: Support for user defined schematic page numbers.
2020-10-19 14:05:45 -04:00
d0ddc909dc
Handle hierarchical symbols when performing "lib symbol changed" check.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6002
2020-10-19 15:37:47 +01:00
3100273db1
Don't invalidate itterator by adding markers inside loop.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6002
2020-10-19 15:32:59 +01:00
725082786e
Move ERC dialog to DRC architecture.
...
This is mainly to remove the annotation nag dialogs in favour of the
HTML links. But it also allows you to see more than a few messages,
and implements a progress reporter architecture if the ERC checks ever
get slow enough to benefit from it.
2020-10-19 15:17:49 +01:00
539ac4c214
Remove a few include<wx/wx.h> in many files that do not actually use this include.
2020-10-19 09:00:50 +02:00
16d5f95981
Meet irreflexive requirements of std::sort
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6053
2020-10-18 21:03:01 +01:00
dd53b9c399
Bail on 45º text in pin conflicts map.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5515
2020-10-18 20:28:23 +01:00
e735d21824
Maximize main editors by default if config is missing
...
Also set default size for other windows to something slightly
larger than it was before
2020-10-18 14:38:55 -04:00
c388bf0f92
Update default color theme
...
Blue is the new green :)
ADDED: built-in read-only color themes support
Classic theme is still available for those who love it
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1991
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4259
2020-10-18 14:12:54 -04:00
0044c6b48a
Add missing includes
2020-10-18 19:22:15 +02:00
f6b4b66a86
Avoid include wx/wx.h in many files that do not actually use this include.
...
Including wx.h includes the full set of wxWidgets include files, that is not good,
and can create some conflicts with some Windows headers on msys2.
2020-10-18 18:21:34 +02:00
ebc0d47239
More pinmap spacing adjustments for MSW.
2020-10-18 14:20:36 +01:00
b28f397614
altium: fix unsigned overflow inside loop
...
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6044
2020-10-18 15:11:12 +02:00
9f16b68bde
Better centreing of pin conflict map col labels.
2020-10-18 12:08:16 +01:00
6ce803b77c
Push/pop move tool even when there's nothing to move.
...
This keeps other tools from having the special-case an empty move.
Fixes https://gitlab.com/kicad/code/kicad/issues/6048
2020-10-18 12:08:15 +01:00
688a031793
Fix broken logic when updating fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6024
2020-10-18 00:51:58 +01:00
6dfcfb0177
Rename DIALOG_EDIT_COMPONENT_IN_SCHEMATIC -> DIALOG_SYMBOL_PROPERTIES
2020-10-18 00:26:37 +01:00
a6166c8ccc
Select just reference number when editing reference field.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6004
2020-10-18 00:26:37 +01:00
81e1bc9df0
Keep track of driver changes so the view can be updated.
...
Also make renaming of nets a bit more stable.
Fixes https://gitlab.com/kicad/code/kicad/issues/6018
2020-10-17 20:40:05 +01:00
229194c76b
Fix flags and remove unicode from string in eeschema dialog
...
* Remove unicode quotes and ellipses from a tooltip string. Our
translation framework can't handle these, and they caused errors
generating the cpp file.
* Remove an assert generated when opening the dialog on 3.1 due to the
wxALIGN_CENTER_VERTICAL and wxEXPAND flags being used together.
* Add a left border to the general static box items so they aren't
squashed against the line.
2020-10-17 15:46:52 +01:00
39e55d8559
altium: parse bus-entry
2020-10-17 16:05:47 +02:00
5793c899dd
altium: use correct default entry in record
2020-10-17 16:05:47 +02:00
034a6bfe0d
altium: parse sheet size and align everyhting inside the sheet
2020-10-17 16:05:47 +02:00
1ce215a1f2
altium: parse fonts from sheet record and use them for label styling
2020-10-17 16:05:47 +02:00
a6072a40f5
altium: add initial support for labels
2020-10-17 16:05:47 +02:00
a981ffe8c7
altium: fix compilation issue due to rebase
2020-10-17 13:45:33 +00:00
1400e5cdb9
altium: improve orientation of net label
...
It is interesting, because altium allows text which is upside-down. Of course, KiCad does
not allow this sensless thing.
2020-10-17 13:45:33 +00:00
ad93396d35
altium: parse no_erc record
2020-10-17 13:45:33 +00:00
79a02d7997
altium: initial version for rounded rectangle (without rounded corners for now)
2020-10-17 13:45:33 +00:00
9199d1ff63
altium: fix line style and filling
2020-10-17 13:45:33 +00:00
06df80a88d
altium: add arc and line segment, fixup bezier parsing
2020-10-17 13:45:33 +00:00
fa8208182a
altium: add support for bezier (symbol only) and polyline
2020-10-17 13:45:33 +00:00
19cfd7bd3a
altium: add non working fix for rounding error
2020-10-17 13:45:33 +00:00
0b190f02dc
altium: reduce code duplication for unit parsing
2020-10-17 13:45:33 +00:00
56a60ffbed
altium: add (emulated) support for polygons
2020-10-17 13:45:33 +00:00
b4b8e31177
altium: add support for junction
2020-10-17 13:45:33 +00:00
30ea1a274e
altium: add some more pin types, and reverse engineer symbol outer and symbol inner
2020-10-17 13:45:33 +00:00
53d90431ea
altium: correctly parse pins
...
TODO: for now, we assume the component is not rotated, simply because this would require me to
write quite a bit of helper methods to handle all those different rotation cases ;)
2020-10-17 13:45:33 +00:00
114f9062f1
EEschema, save correct line style in file when style == DEFAULT.
...
previously, when a graphic line style was set to Default,
the line style saved in file was always SOLID.
This is incorrect for graphic lines
Fixes #6017
https://gitlab.com/kicad/code/kicad/issues/6017
2020-10-17 15:18:14 +02:00
98710e2742
Eeschema, parser: allows using "default" as line style.
...
It is allowed in Eeschema code, so allow it if found in a .kicad_sch file,
just in case.
However it is not yet in use in .kicad_sch files to avoid breaking previous Kicad versions
2020-10-17 12:39:51 +02:00
a9619c051b
Better name for a plot style variable and accessors.
...
Accessors were previously GetType() and SetType(), but this is a bad name:
These names are already widely used in code as accessors for a data type.
We do not set a data type, but a style, so use a better name (GetPlotStyle/SetPlotStyle).
2020-10-17 12:00:43 +02:00
971eb529f4
Separate strings into full strings
2020-10-16 23:10:47 -07:00
0d6684bdf0
Freeze GUI as well to prevent wx updates
...
The tree model may get updated by a redraw, so we need to freeze both
the model and the view while updating
Fixes https://gitlab.com/kicad/code/kicad/issues/5872
2020-10-16 08:28:14 -07:00
a1c75748a0
Remove GetChars(), a wxWidgets 2.9 compatibility hack
2020-10-15 20:53:25 -04:00
a2c3bdec0d
Remove kicad_string.h from netlist_exporter.h
2020-10-15 18:48:53 -04:00
128910c602
Pass unhandled command events from Symbol Editor move tool.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6015
2020-10-15 18:43:23 +01:00
445b9df827
Don't output pins to net if parent symbol isn't included on board.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5984
2020-10-15 18:32:52 +01:00
1c5aad1f9e
Hierarchical schematic with subsheets in subdirectory: fix plot filenames.
...
When creating an unique filename to plot a subsheet, the subdirectory name is
used to create the unique filename, but should not be used as a directory,
otherwise the plot file is not created at the right place (and sometimes
cannot be created)
2020-10-15 18:07:00 +02:00
bfd5da0159
Add missing include (under some configurations)
2020-10-15 07:34:38 -04:00
5f4b0eb0fb
Fix formatting and overzealous renaming for FILL_TYPE
2020-10-15 11:24:49 +01:00
1538d737e7
Split out FILL_T to its own header to avoid spreading eda_item everywhere
2020-10-14 21:51:23 -04:00
5302f7ce73
Remove kicad_string.h from eda_text.h
2020-10-14 19:18:38 -04:00
90da5fccbd
Disambiguate backannotation (Update Schematic from PCB) from Cvpcb.
2020-10-14 21:07:10 +01:00
12d21e34e2
Remove trigo.h from eda_text.h
2020-10-13 23:37:48 -04:00
ad191fda52
Unwrap eda_base_frame from base_screen
2020-10-13 21:52:57 -04:00
b2e9f6987d
Split base_struct into eda_item and eda_rect
2020-10-13 21:24:50 -04:00
2c86363aa0
Relocate the page_layout includes to a page_layout folder
2020-10-13 20:33:33 -04:00
d1bdfb7253
Clear selection before adding new lines in immediate mode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4266
2020-10-13 19:16:48 -04:00
cb1d416e5a
Use settings keys, not error codes, for ERC/DRC reports
...
Error codes can shift around if the enum ordering is
not maintained, which is more fragile than the settings
key which should never be changed after a new code is
created.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6001
2020-10-13 18:03:07 -04:00
fd874d8345
Check to see if isolating junction is part of the drag or not.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5960
2020-10-13 13:52:49 +01:00
7b5d628e4b
Eeschema: fix save-as dispatching from new file
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5937
2020-10-12 20:06:55 -04:00
5f6d309d36
Eeschema: REMOVED "Update from Symbol Library"
...
This is effectively duplicated by "Update Symbol(s) from Library".
Fixes https://gitlab.com/kicad/code/kicad/issues/5217
2020-10-12 22:44:53 +00:00
8930e48cf3
Cleanup dead code
...
Remove leftovers from e4bc1eb3bf
2020-10-12 22:44:53 +00:00
c40483d18a
Cleanup: Move KiCad files into plugins folder
2020-10-12 16:36:08 +00:00
0efe073dec
Add wires between selected wires and unselected junctions when dragging.
...
Also fixes a bug where the auto-start-wire stuff was messing up the seleciton
when the selection tool wasn't at the top of the tool stack.
Fixes https://gitlab.com/kicad/code/kicad/issues/5960
2020-10-12 11:46:08 +01:00
fbb20d08cd
Don't allow netclass assignment to auto-generated net-names.
...
They can change the next time they're generated so it's just asking
for heartache.
Fixes https://gitlab.com/kicad/code/kicad/issues/5972
2020-10-12 00:30:18 +01:00
03074ae6ed
Kick the selection tool to activate (and thus update cursors) on exiting some picker tools
2020-10-11 13:12:29 -04:00
91db6a770c
Eeschema: Add missing tooltips to left toolbar buttons
...
CHANGED: The button in the left toolbar for hiding/showing hidden
pins, and the button for forcing/relaxing H&V only wire mode had
no tooltips. This MR adds them.
2020-10-11 13:55:36 +00:00
558f4b4b51
Add new place cursor, fix cursor hotpoints again
2020-10-10 23:45:21 -04:00
310786333d
Add missing cursors for bus, graphic lines, and hier labels
...
Fix #5949
2020-10-10 18:25:44 -04:00
a8bd0a9b84
Handle Windows manifests ourselves and add dpi awareness option
2020-10-10 19:08:23 +00:00
b2124a34dc
Add grid properties context menu to grid toolbar
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5663
2020-10-10 14:44:03 +00:00
5aa796b5fe
Cleanup compiler warnings
2020-10-10 15:24:35 +01:00
1df35145b5
Not all items are drivers
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5946
2020-10-10 09:16:31 -04:00
fc93a04751
eeschema: iref: use GetParentLabel instead of GetParent
2020-10-09 02:37:51 +00:00
61f731aa1d
Fix disambiguation for vector buses with different ranges
...
Previously disambiguation was looking for exact matches,
but vector buses are permitted to have different ranges and
still participate in merging, so they need to be disambiguated.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5925
2020-10-08 22:26:24 -04:00
bd30a4a406
Add selection lasso and window cursors
2020-10-08 21:25:21 -04:00
8f4fba4c67
Don't deallocate absorbed SGs anymore
...
Now there is some code depending on access to them
outside the context of connectivity calculation...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5928
2020-10-08 21:24:35 -04:00
f238d05ead
Add COMPONENT cursor
2020-10-08 20:52:58 -04:00
6cf4016a64
Add net and global label cursors
2020-10-08 20:52:58 -04:00
fd22fe8e37
Show preview item in drawing tool before mouse is moved.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5922
2020-10-08 19:56:09 +01:00
4095edda07
Add Properties support to Junction and Bus Entry tools.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5907
2020-10-08 18:11:06 +01:00
2b839c6c9c
Ensure command events are passed when placing junctions
...
We only handle specific command events in the handler, so we
must pass the rest to allow other tools to work.
Fixes https://gitlab.com/kicad/code/kicad/issues/5922
2020-10-08 17:58:06 +01:00
7e974e5ccc
Use the snapped cursor position used for detection for the wire tool autostart
...
Fixes #5902
2020-10-07 23:57:26 -04:00
f5e0754f65
Use the setCursor lambda pattern and fix up the initial cursor states
2020-10-07 23:26:14 -04:00
d9485129c8
Implement more context specific cursors using both stock and custom cursors.
2020-10-08 00:50:28 +00:00
809f4c2ffb
Finish single-click-place drawing tool on double-click.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5907
2020-10-07 18:30:55 +01:00
4565631728
Finish moving eeschema assigned netclasses to sheet-path-relative.
...
Also adds code for the case where a new label is created on a net
with an existing netclass assignment.
Fixes https://gitlab.com/kicad/code/kicad/issues/5886
2020-10-07 16:31:55 +01:00
5127d6c772
Eeschema: add ERC check for library symbol issues.
...
ADDED: ERC check for library symbols that have changed since they were
added to the schematic or have broken symbol library links.
2020-10-07 09:15:31 -04:00
504f57811a
Remove a hard-coded parameter
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5373
2020-10-06 14:26:22 -07:00
8c367cce8d
Separate ki_fp_filters by spaces
...
Multiple footprint filters will no be separated by spaces for easier
parsing as an array
2020-10-06 14:26:22 -07:00
006e383f2a
Move sch_text help into markdown file
2020-10-06 17:18:35 +00:00
30c2ca67d9
Fix typo.
2020-10-06 14:23:10 +01:00
e9d372f4b7
Allow spaces in sheet filenames.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5736
2020-10-06 14:21:18 +01:00
76bfa47a77
Allow creating new projects when doing a Save As in eeschema
2020-10-05 22:36:26 -04:00
43c14face0
Switch to showing metric/imperial units in comboboxes and menus
...
This will always show 1 unit from each system, with the primary unit
being the current frame unit and the secondary unit being the
most recent unit used from the other system. These are saved in
the settings, so they are saved between runs.
2020-10-05 20:26:33 +01:00
1416280662
Cleanup: Move Eagle files into plugins folder
2020-10-05 14:19:07 +00:00
63a0f537d8
Performance enhancement: check hierarchy validity only when necessary.
2020-10-05 13:49:29 +01:00
7a7de027a7
Fix order of operations for setting underline.
2020-10-05 12:32:47 +01:00
c9096c7168
Re-enable selection of intersheet references.
...
Un-modified roll-overs and clicks still produce hypertext action, but
modified clicks and drag-selects will select.
2020-10-05 11:55:33 +01:00
a28a0e14ba
Fix conversion warnings
2020-10-05 10:41:14 +00:00
e27786de2d
Fix double call of OnPgmExit
...
Also fix bad filename being passed to pcbnew when starting
from a blank schematic in standalone mode
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5786
2020-10-04 18:39:33 -04:00
6c2433fed6
eeschema: Fix nullptr reference in intersheet references
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5881
2020-10-04 22:28:35 +01:00
bdb18022c0
Flag all dangling labels, not just isolated ones
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1788
2020-10-04 17:13:42 -04:00
8c09f28b28
libedit: Fix dialog spacing
2020-10-04 17:53:55 +01:00
8b0fb9f4cf
Remove units and polar settings from the preferences panels
...
These options are already available in menus, toolbars and hotkeys,
so having them in the preferences pane is more trouble than it is
worth.
2020-10-04 17:53:55 +01:00
122bd7ca7c
Make the statubar aware of mils units
...
Switch Eeschema to use the built-in printing routines
because its precisions are close to those and it is
cleaner.
Give mils a precision of 2 decimal places to match
the precision shown in inches.
2020-10-04 17:53:55 +01:00
b1bd1f2a97
Introduce new action to switch to mils as a unit
2020-10-04 17:53:55 +01:00
44580acee2
Clean up some compiler warnings.
2020-10-03 22:55:34 +01:00
d14761bee6
Fix inches being sometimes used instead of mils
2020-10-03 20:06:56 +00:00
400c15b8eb
Add mils to units, remove useMils variables
2020-10-03 20:06:56 +00:00
676f3221cc
Fix symbol editor glitches due to autostart trying to start
2020-10-03 15:47:08 -04:00
0b2b8b150d
Use the event position always instead of the view cursor position
...
Fix #5850
2020-10-03 15:20:32 -04:00
454c4f1783
Minor fixup to intersheet reference files
2020-10-03 19:09:18 +01:00
0b23cb7dbb
more cleanup about removing useless include
2020-10-03 15:26:03 +02:00
e76736b7bf
Fix a few Coverity warnings
2020-10-03 12:47:41 +02:00
bda275de46
more cleanup about removing useless include
2020-10-03 11:48:16 +02:00
b38cef409b
Rename CopyFile() to KiCopyFile() to avoid name colliding with a windows header.
...
Using CopyFile() that can collide with a windows header create hard to
understand errors, including link errors.
Renaming this function avoids these strange errors.
2020-10-03 10:08:21 +02:00
ab18c8e219
eeschema: Add "All supported formats" drop-down to the "Import Non Kicad Schematic" file dialog
2020-10-03 02:19:13 +00:00
b0ffbcaba1
Fix #5850
2020-10-03 02:10:56 +00:00
4c5db9681c
Naming conventions.
2020-10-02 21:25:14 +01:00
cc617b715f
Implement hypertext links for intersheet references.
2020-10-02 21:18:34 +01:00
1258abef07
EEschema: move plot_xx.cpp files to "plotters" folder.
2020-10-02 15:56:05 +02:00
7865d8de43
more cleanup about removing useless include
2020-10-02 15:50:46 +02:00
c1b34b02b5
Disallow selection of intersheet references.
2020-10-02 13:50:16 +01:00
4b315b0fda
Clean up dialog spacing.
2020-10-02 13:50:16 +01:00
8285110c2a
more cleanup about removing useless include
2020-10-02 08:58:19 +02:00
60046a1bcc
Dynamically scale cross-probe zooming
...
CHANGED: When doing cross-probe zooming, KiCad zooms the selected
component to fill the screen. This makes it hard to understand the
part in context so users would have to always zoom out manually. This
commit uses the default text height in Eeschema and Pcbnew as a
constant to compare the height of selected parts or components against.
This lets the code determine how big the part is and scale the zoom
wider accordingly. Big parts get less scaling and small part get more.
NOTE: There is a little bit of debug code present. There are #ifdefs
to let developers easily swap in the original KiCad zoom for comparison.
There is also a bool added that can force each program to always perform
the new calculated zoom since KiCad ignores zooms that are close to the
current value. This debug code can be removed later as desired.
2020-10-02 00:56:52 +00:00
c940a45937
ADDED: Autostart wires in eeschema
...
Allows wires to be automatically started by clicking over a connection point
2020-10-01 23:53:47 +00:00
71ed7ee707
Revert "Drag preselected items even when "prefer selection to dragging" enabled"
...
This reverts commit d530e2c2cd
2020-10-01 18:23:30 -04:00
2fc49045d1
ADDED: eeschema: Add intersheets references function
...
Add a new function to place intersheets references next to
global labels.
2020-10-01 20:39:32 +00:00
f702da95c7
Minor code cleanup, step2: remove more useless include.
...
fix also a minor compil warning
2020-10-01 15:39:47 +02:00
42350a4928
Minor code cleanup: remove useless include or useless code.
...
fix also a minor compil warning
2020-10-01 11:36:15 +02:00
d530e2c2cd
Drag preselected items even when "prefer selection to dragging" enabled
...
Not being able to drag an already-selected item feels broken
2020-09-30 20:10:13 -07:00
1eb423830e
Eeschema: Remove wire and bus formatting GUI elements
...
CHANGED: Remove wire and bus formatting GUI elements from "Schematic
Setup" dialog panel. Wire thickness is handled by netclasses now
and this was a leftover from before that change.
Fixes https://gitlab.com/kicad/code/kicad/issues/5815
2020-10-01 00:20:31 +00:00
b0e05ad9bf
Eeschema: Check for NULL pointer when using interactive delete tool
...
CHANGED: If you start the interactive delete tool and the mouse pointer
isn't near anything, Eeschema tries to use a null EDA_ITEM pointer
which throws an exception. This commit checks if the pointer is null
and exits if it is.
2020-09-30 23:05:29 +00:00
2c49c406a0
Remove ignore other projects option from back annotation
...
The new schematic format makes this option unneeded, and it isn't
used at all in the backannotation code - so it doesn't need to be
in the UI.
2020-09-30 23:34:04 +01:00
3f8c9d49f8
Revert "Code cleanup: remove useless wx/wx.h include inside a few files."
...
due to compil issue on Linux
This reverts commit cffccc3970
2020-09-30 20:47:20 +02:00
cffccc3970
Code cleanup: remove useless wx/wx.h include inside a few files.
...
in most of files, including wx.h is not necessary, when only 2 or 3 wx files must be included.
Moreover, on windows, including wx.h sometimes create compil warnings about
shadowed vars defined in some specific windows headers.
2020-09-30 20:03:27 +02:00
7dc1966a0d
Eeschema: Fix text formatting in "Project Load Warning" dialog
...
CHANGED: When the "Show Details" button on the "Project Load Warning"
dialog is clicked, it reveals text that has odd formatting of when
lines split. This commit fixes the text for the dialogs that warn
that schematics will be saved in the new file format, and that Symbol
Libraries defined in the project file symbol library list are no longer
supported.
2020-09-29 00:31:13 -07:00
39995341d9
Compile fixes
...
Fix compile error
Fix string format to use %ld instead to work on clang in CADSTAR Archive importers
Add virtual destructor to CONNECTION in CADSTAR_ARCHIVE_PARSER
2020-09-27 22:05:07 +00:00
6f5f6a0fba
CADSTAR Schematic / PCB Archive Importers: Fix string formatting asserts
2020-09-27 18:14:02 +01:00
93242eb3ad
CADSTAR Schematic / PCB Archive Importers: Add missing import warnings and fix code formatting
2020-09-27 18:14:01 +01:00
5e2e692ad8
CADSTAR Schematic Archive Importer: Load Documentation Symbols
2020-09-27 18:14:00 +01:00
c6bc72d579
CADSTAR Schematic Archive Importer: Load Texts
2020-09-27 18:14:00 +01:00
da791c5298
CADSTAR Schematic Archive Importer: Load Figures
2020-09-27 18:13:59 +01:00
40c5795c03
CADSTAR Schematic Archive Importer: Load Busses and fix minor import bugs
...
Fixed missing tokens that weren't parsed before:
- Danglers (in NET_SCH)
- Pin numbers (in SYMBOL)
- HidePinNames in both PART and PART::DEFINITION, defaulting it to false
2020-09-27 18:13:59 +01:00
2d85fc8c91
CADSTAR Schematic Archive Importer: Load Nets, Wires, Junctions and Hierarchical Pins
2020-09-27 18:13:59 +01:00
1c57b5c079
CADSTAR Schematic Archive Importer: Load symbol library and schematic symbol instances
2020-09-27 18:13:58 +01:00
2d99703e28
CADSTAR Schematic Archive Importer: Load all Sheets and Hierarchical Blocks
2020-09-27 18:13:58 +01:00
646a733556
CADSTAR Schematic Archive Importer: Parse all elements
2020-09-27 18:13:57 +01:00
721cba32d5
ADDED: CADSTAR Schematic Archive Importer
...
Initial commit to trigger the importer
2020-09-27 18:13:57 +01:00
a01e4f19b4
eeschema: allow exporting netlists through UI-less KIFACE API function
2020-09-27 16:45:46 +02:00
e4bc1eb3bf
Fold Update Fields from Library into Update Symbol.
...
Also gives Change Symbol control over which fields to update.
Fixes https://gitlab.com/kicad/code/kicad/issues/5217
2020-09-27 14:09:11 +01:00
6b958ff4e0
Move specialized plotter classes from plotter.h to specific plotter_xx.h
...
plotter.h contains now only a header common to all plotters.
The code does not actually change, but it allows modifying a specific plotter
without recompiling most of kicad files.
2020-09-27 09:54:39 +02:00
fc565edb33
Add a palette to the toolbars to display groups of actions
...
This adds a palette to toolbar items that displays groups
of actions when long-pressed on a button.
2020-09-27 01:00:44 +01:00
5e96849abd
Fix missing newline.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5679
2020-09-27 00:12:14 +01:00
f8875bc5a6
Move std::contains to alg::contains.
2020-09-26 14:42:40 +01:00
d7e80f8008
Add std::contains() to simplify a lot of code.
2020-09-26 12:40:32 +01:00
d1322e7d1d
Refactor GetDocumentExtents()
...
CHANGED: GetDocumentExtents() in 'eda_draw_frame.h' now has a bool
parameter "aIncludeAllVisible" with a default value "true" which makes
it behave as it did before adding parameter. If "aIncludeAllVisible"
is false, the returned bbox ignores some items depending on which
program it is running in.
CHANGED: Made "Zoom to Objects" use only PCB edge in Pcbnew. This
allows text, notes, etc outside the PCB edge to be excluded in the
zoom calculation.
CHANGED: Added "Zoom to Objects" to Pcbnew main menu, and to RMB context
menus for Eeschema and Pcbnew.
Fixes https://gitlab.com/kicad/code/kicad/issues/5787
2020-09-25 00:31:56 -07:00
eaf151075c
Correctly de-highlight found items when closing Find dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5775
2020-09-24 18:46:25 +01:00
ca2252686a
Eeschema: Make SCH_VIEW::GetItemsExtents() ignore invisible text
...
CHANGED: SCH_VIEW::GetItemsExtents() returns a bbox of all visible items
but ignores the page and border. It was taking invisible strings into
account when calculating the bbox, and now it doesn't. Makes "Fit to
Objects" work correctly with all components that have hidden text.
Fixes https://gitlab.com/kicad/code/kicad/issues/5726
2020-09-23 02:46:14 +00:00
1c2ab0f523
eeschema: fixed auto increment of pin position in Pin Table
...
CHANGED: Pin position is now incremented properly in the Pin Table
dialog. The Pin position is ussing Internal Units insted of mils, so
the hardcoded 50/100 mils spacing has to be converted to IU before
adding.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5730
2020-09-22 23:46:50 +00:00
e77b7e3360
Make MMB double click perform 'Zoom to Fit'
...
ADDED: Make middle mouse button double click do a 'Zoom to Fit'
in Eeschema, Pcbnew, and Gerbview. Ctrl-MMB does a 'Zoom to Objects'
in Eeschema.
Fixes https://gitlab.com/kicad/code/kicad/issues/1988
2020-09-22 23:21:44 +00:00
f47d81af85
Create and use a LIB_PIN constructor to remove hot path during symbol table loading
2020-09-22 22:33:06 +00:00
975e5562a0
EEschema: Sort Hierarchy tree
...
This sorts the hierarchy tree children alphabetically
2020-09-21 11:17:33 -07:00
6020b70596
Display green badge for zero errors or zero warnings.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5735
2020-09-21 11:59:27 +01:00
c6fb799fcd
Restore severity in saved DRC/ERC reports.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5733
2020-09-21 11:59:27 +01:00
fdbb28aea2
Treat Reference and Unit as separate words when searching.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4630
2020-09-20 18:57:33 +01:00
89dcc46898
Coverity cleanup and remove unused variables
2020-09-20 02:20:41 +01:00
13f1de8e73
Forgot a bunch of files from last commit.
2020-09-19 19:53:58 +01:00
64fa400b19
Ease translation a bit.
...
Also improves the SNR and consistency of the menu item text. For
instance, a position is rarely useful, while relative sizes can be.
Also removes some unnecessary repitition, such as "Graphic Rectangle"
when "Rectangle" communicates the necessary information.
2020-09-19 18:49:06 +01:00
39bdc547af
Smarten up the guess selection routine to pick closest item.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5697
2020-09-19 15:55:27 +01:00
4fa3de2211
Ensure we clear forced position
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5699
2020-09-18 16:10:09 -07:00
ef48dba7ff
Correctly set value and footprint fields from Symbol Fields editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5689
2020-09-18 23:30:16 +01:00
7062a3b29b
Fix bug in net <-> netclass matching.
...
Also adds a "Default" setting for Edit Text and Graphics Properties
so the linestyle can be batch-edited back to default.
Fixes https://gitlab.com/kicad/code/kicad/issues/5674
2020-09-18 23:29:34 +01:00
d468618411
Don't eat commands that aren't ours in SCH_MOVE_TOOL.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5692
2020-09-18 16:45:41 +01:00
c8879d9034
Eeschema: Check if user wants to warp mouse to origin of moved object
...
CHANGED: When moving a footprint, Eeschema was always warping the mouse
when moving an item regardless of the state of the "Warp mouse to
origin of moved object" checkbox. This MR now honors the state of the
checkbox when moving schematic items.
NOTE: Issue 5279 originally only mentioned Pcbnew, but after the fix
for Pcbnew was submitted, a user pointed out it also happened in
Eeschema. Becuase of this, there are two MRs that "fix" the same issue.
Fixes https://gitlab.com/kicad/code/kicad/issues/5279
2020-09-18 02:49:59 +00:00
471f81742f
ADDED: Align to Grid function in Eeschema
...
Adds tool option to align selected elements to the current grid.
Fixes https://gitlab.com/kicad/code/kicad/issues/5481
2020-09-17 12:27:43 -07:00
8bd77c4fe7
Rename the ITEM_SET types to be descriptive of their contents
...
Now that we have one set type for BOARD_ITEMs and another for SCH_ITEMs
it is better to explictly say if they are board or schematic sets.
2020-09-16 02:04:17 +01:00
abdd1906c2
Change 'Zoom to Fit' margins and add 'Zoom to Objects'
...
CHANGED: The margin used in 'Zoom to Fit' is now 2% instead of 10%.
ADDED: Added 'Zoom to Objects' to Eeschema which does not include
the page and border in the bbox calculations.
CHANGED: Removed pre-existing code that tweaked the center to account
for the scrollbars. It actually made the view off center. Removing it
results in perfectly centered zooms.
Fixes https://gitlab.com/kicad/code/kicad/issues/5145
2020-09-16 00:53:39 +00:00
7e35658c28
Use schematic colours in symbol preview status panel.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4998
2020-09-16 00:58:36 +01:00
cdbe2fd2d2
User terminology specific to Change Footprint/Symbol.
...
Also implements separate session settings for the reset checkboxes
for Change Footprint and Update Footprint.
Fixes https://gitlab.com/kicad/code/kicad/issues/5614
2020-09-16 00:15:26 +01:00
67a7aa8ba4
Make snapping size grid-dependent
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5638
Fixes https://gitlab.com/kicad/code/kicad/issues/5588
2020-09-15 12:07:34 -07:00
aa24fe2880
Fix return type from ternary operator ( fixes #5554 )
2020-09-12 22:43:49 +00:00
1703657fb5
Decrease default snap range
...
The snap range needs tuning to preference and monitor resolution. This
shifts the default range down for users until the customization bits are
implemented.
2020-09-12 08:34:21 -07:00
d14c6ba71f
Keep snap line alignment before new snaps
...
Also fixes the alignment line that was supposed to be dashed and not
solid.
2020-09-11 14:22:41 -07:00
23a9df8a59
ADDED: Allow Eeschema dragging graphical corners
...
This separates the two options (drag/move) into different actions. Drag
will drag all graphical lines connected. Move will disconnect the
graphical lines when moving.
2020-09-11 09:31:38 -07:00
f493e270ea
ADDED: Menu option to enable/disable snap to grid
...
You can now enable and disable snap to grid when drawing/editing across
all apps. You can also tie snap to grid to the visibility of the grid
to allow rapid enable/disable via grid display.
2020-09-10 20:09:30 -07:00
62433736bc
Snap Eeschema moves to nearest anchor
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3803
2020-09-09 10:48:15 -07:00
4026904cc4
Make grid snapping depend on grid visibility
...
Turning the grid view on enables snapping to the grid. Turning it off
removes the snap and allows free draw
2020-09-09 10:18:15 -07:00
173b4ff588
Add snapping to eeschema
...
This generalizes both the SetPosition() function and ORIGIN_VIEWITEM
class away from the pcbnew-centric.
2020-09-09 10:18:15 -07:00
d45c11b4b5
Exclude from bill of materials and board netlist to library symbols.
...
ADDED: Support for exclude from bill of materials and board netlist to
library symbols.
Fixes https://gitlab.com/kicad/code/kicad/issues/4915
2020-09-09 09:03:37 -04:00
f347118ce3
Add a min pin width advanced config for plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5546
2020-09-08 20:19:54 +01:00
cfcc3bbc0a
Fix UTF8 conversion issue
...
The ternary needs a wxString object for both sides to reference the UTF8
functions
Fixes https://gitlab.com/kicad/code/kicad/issues/5554
2020-09-08 10:08:21 -07:00
02a5d47de9
Avoid passing references in EESchema
...
This returns the connection list by value. This allows easier Python
use
Also renames m_End() to GetEnd()
2020-09-08 06:29:27 -07:00
054b5aa475
Fix copy-pasta.
2020-09-08 11:02:09 +01:00
7b05e456cc
Bug fixes for multiple symbol instances in complex hierarchies
...
1) use SCH_COMPONENT::GetRef(), GetValue() and GetFootprint() when
instance-specific info is needed
2) update UpdateAllScreenReferences() to handle value and footprint.
3) BACKANNO is CvPcb's handler, not back annotation's handler. Which
means it needs GUI behaviour, not back annotation behaviour.
Fixes https://gitlab.com/kicad/code/kicad/issues/5520
2020-09-06 13:57:14 +01:00
b28332c5f1
Minor code cleanup.
2020-09-06 13:04:52 +01:00
d5fd09249b
Save instance info on clipboard and reapply it when keeping annotations.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5522
2020-09-06 11:32:28 +01:00
133fb5cded
Minor code cleanup.
2020-09-06 11:28:58 +01:00
a25dfb2ac9
Stop setting modify from ClearAnnotation().
...
It's a side-effect, and as it turns out every current caller has
special-case code to reset it afterwards.
2020-09-06 11:26:39 +01:00
e782794f96
Flesh out object properties and DRC Rule syntax help.
2020-09-05 17:44:59 +01:00
f28b60896c
Allow toolbar items to cancel tools when pressed
...
There was a regression in v6 where the zoom to selection toolbar
item wasn't canceling the tool when pressed and the tool was active
(it was in v5). This implements a more generic framework for canceling
tools on button presses.
Fixes https://gitlab.com/kicad/code/kicad/issues/5103
2020-09-05 01:49:38 +01:00
16b85ed567
Fix for reading back-annotation data from sexpr sch format.
2020-09-04 21:41:47 +01:00
5e9ec82642
Correctly resolve textVar refs in worksheet items in ERC.
...
Also fixes a null-ptr bug in DRC.
Fixes https://gitlab.com/kicad/code/kicad/issues/5506
2020-09-04 21:38:07 +01:00
be15053745
Allow back-annotation of differing values and footprints.
...
Also fixes a couple of bugs where resolving a textVar reference
to the refDes or unit wouldn't get the correct value in a
hierarchical schematic. (Unlogged.)
Fixes https://gitlab.com/kicad/code/kicad/issues/5397
2020-09-04 15:21:56 +00:00
0bd6e5d96e
FIELDS_GRID_TABLE and TEXT_MOD_GRID_TABLE: fix incorrect position of checkboxes
...
This is an issue specific to wxWidgets 3.1.4
2020-09-04 15:41:51 +02:00
15c4a7b066
DIALOG_LIB_EDIT_PIN_TABLE: fix incorrect handling of Cancel button
2020-09-04 09:49:54 +02:00
a4d23fff12
Fix multi-unit pin check logic
...
Typo name vs. number
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5483
2020-09-03 17:30:13 -04:00
03423f13a1
Eeschema: fix broken new sheet path comparison on windows.
...
Using wxFileName::GetPath( wxPATH_WITH_SEPARATOR ) does not include the
drive specifier (A:, B:, C:, etc.) on windows which fails the comparison
with the project path 100% of the time. wxFileName::GetPathWithSep()
solves the issue nicely.
Fixes https://gitlab.com/kicad/code/kicad/issues/5077
2020-09-03 11:11:14 -04:00
3ce1b2b44e
Clean up Coverity warning.
2020-09-03 15:03:09 +01:00
8751a55651
Tightening up the title bar display
...
Eeschema was the only application showing the file path. This is of
limited use and prevented other information from showing in the
shortened menubar display. Also combined strings for better translation
2020-09-03 06:59:37 -07:00
d6a4ab0eec
Shortening filenames in titlebar
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2096
2020-09-03 06:38:34 -07:00
de03d3d427
Application title bar: app name after filename
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2096
2020-09-03 06:35:48 -07:00
04ba129881
Add specific icon for save symbol to schematic.
...
Also update CMakeLists.txt to prepare compatibility with Inkscape 1.0
However the command line to invoke Inkscape is still for 0.92 version
2020-09-03 10:00:44 +02:00
bd23d003d2
Bring Eeschema UI closer in line with Pcbnew for change terminology.
...
Also clears up the text & tooltip of the Remap Symbols function to
better explain why it's greyed out most of the time.
2020-09-02 15:21:51 +01:00
b596d3c3d5
Implement update options for Update Symbol from Library.
2020-09-02 15:21:51 +01:00
c0bc47810a
Fold pin table in to Symbol Properties.
2020-09-02 15:21:51 +01:00
fa8138ee5a
Rework Symbol Props to Footprint Props design.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2286
Fixes https://gitlab.com/kicad/code/kicad/issues/5414
2020-09-02 15:21:51 +01:00
c0afeed13d
Symbol editor: fix broken long dash in title.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5455
2020-09-02 09:22:55 -04:00
1b4ec6ccb5
Display symbol libraries that couldn't be loaded as disabled text
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5092
2020-09-02 00:10:25 +01:00
c17f832de1
Eeschema: move auto save check before clearing current screen.
...
GitLab issue #5068 only affected the 5.1 branch. The same issue could
also affect master if for some reason a context switch occurs due to
changes. Moving the auto save feature before setting the current screen
to null should mitigate any potential future issues.
2020-09-01 16:52:05 -04:00
f38631b9ab
fix a compil warning (shadowed var).
2020-09-01 17:46:17 +02:00
e6f4e156b6
Fix the SCH_PINs test to be more reflective of the codebase.
2020-09-01 15:25:49 +01:00
c9fa46ace8
Eeschema: allow symbols to be edited in place.
...
ADDED: Support to allow schematic symbols to be edited in place.
2020-09-01 07:28:20 -04:00
9f128f942c
Move shutdown blocker to kiplatform
2020-09-01 10:14:51 +00:00
30b402bc02
Don't set modify flag when deleting markers
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5418
2020-08-31 22:07:19 -04:00
a9532c2fa1
Add browse button to footprint 3d settings
...
Add normalization to 3d settings and footprint library table editor
2020-09-01 02:00:38 +00:00
6e72f609f0
Make sure router and via tools update when sizes change.
...
Also adds a size menu to the context menu for the Via tool.
Fixes https://gitlab.com/kicad/code/kicad/issues/5321
2020-08-31 23:33:02 +01:00
1ea08f27f8
Keep local number up-to-date so we don't have to look at libPin's.
...
The libPin, in particuar, may have been freed.
Fixes https://gitlab.com/kicad/code/kicad/issues/5399
2020-08-31 20:09:47 +01:00
cd55185904
Don't accept any values not in the dropdown for alternate pins.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5399
2020-08-31 20:04:05 +01:00
2697fc3864
Remove canvas-switching from OSX.
...
The Cairo renderer doesn't work on Retina displays.
Fixes https://gitlab.com/kicad/code/kicad/issues/4788
2020-08-31 18:48:25 +01:00
88635ee5b6
Clean up error messages.
...
Convert a lot of nags to InfoBar errors/warnings/messages, and some
that never should have been exposed to wxFAIL_MSGs.
2020-08-31 14:19:57 +01:00
38a4e4ad5a
Remove the last bits of the old netlist system
2020-08-30 16:30:04 -04:00
cf17a675b4
Port simulator probing to new connectivity info
2020-08-30 16:05:16 -04:00
9f7bca38b3
A better way of handling standalone project files
2020-08-30 16:04:39 -04:00
be0aad5984
Move similar labels check to new connectivity engine
2020-08-30 15:43:16 -04:00
48d7c46a53
Move pin table checks to new connectivity system
2020-08-30 15:43:16 -04:00
68dd508fbd
Use correct wildcard for creating new schematics
2020-08-30 15:43:16 -04:00
20211eed49
Unroll a level of prefs for fieldname templates.
...
It was playing havoc with the saving of project and global templates
without one overwriting the other.
Fixes https://gitlab.com/kicad/code/kicad/issues/5415
2020-08-30 18:58:18 +01:00
45ed91a405
Regularize formatting.
2020-08-30 18:58:18 +01:00
cc64709407
Reimplement skip-parent-page to work with MacHack.
...
This prevents the "leaking" pages where the layers panel is shown
in the background of all other panels.
Fixes https://gitlab.com/kicad/code/kicad/issues/5182
2020-08-29 20:53:53 +01:00
e2f32ce7b6
Allow setting a stroke type back to the default.
2020-08-29 18:47:11 +01:00
1bd7290309
Repair broken logic in ForceKeepAnnotations.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5382
2020-08-29 18:18:23 +01:00
b653df2b21
Make numbers in pin table read only
2020-08-29 12:06:33 +02:00
f005977aab
Minor simplification to custom colour theme GUI for print/plot dialogs.
2020-08-28 14:15:58 +01:00
e7db43285f
ADDED new footprint fabrication attributes.
...
This commit also adds mapping of the new symbol properties
"exclude from BOM" and "exclude from board" to be correctly
handled in Update Board from Schematic.
Fixes https://gitlab.com/kicad/code/kicad/issues/2399
Fixes https://gitlab.com/kicad/code/kicad/issues/4643
Fixes https://gitlab.com/kicad/code/kicad/issues/2233
2020-08-28 11:05:58 +01:00
46cb760641
Standardize eeschema header with pcbnew
...
Removes the host tag with build data and replaces with the "generator"
tag
2020-08-27 12:23:26 -07:00
1082402b33
Convert UNDO_REDO_T to an enum class
2020-08-26 18:04:32 +00:00
731f247eb3
Libedit: conform default pin offset to KLC
...
Move default defines to standard location
Fixes https://gitlab.com/kicad/code/kicad/issues/5373
2020-08-26 10:30:19 -07:00
a97f2fb22a
Eeschema: cosmetic enhancement: add 2 missing icons
2020-08-26 13:00:46 +02:00
b0af66afc7
Allow empty value field if simulation is disabled
2020-08-26 02:42:50 +00:00
1d2838bd92
Fix overzealous driver check that was causing false positives
2020-08-25 21:54:14 -04:00
d40ae3de46
ADDED: ERC check for missing hier labels for sheet ports
...
A subsheet may have more than one instance of a hier label,
but it's generally a mistake if there is no matching hier label
for a port on the parent sheet.
This is harder to do today now that we don't have manual tool
for placing hier ports, but it's still possible if you place
ports but then rename the label on the subsheet.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/3468
2020-08-25 21:52:52 -04:00
f50dba6b62
Offer to open annotation dialog when running ERC on unannotated schematic
...
Also improve the error messaging and use an infobar to display it
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2292
2020-08-25 21:17:54 -04:00
45cae6405d
Improve no-connect ERC and check for floating wires
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2393
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2038
2020-08-25 18:00:16 -04:00
da17437490
Don't crash when trying to draw a no connect with no parent schematic
2020-08-25 13:26:33 -04:00
d02ce77bee
Make no-connects (and dangling symbols) more visible.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5329
2020-08-25 13:46:40 +01:00
1138c32bf3
Don't pass Cancel event where there was a specific action cancelled.
...
For instance, if during a move the user hits ESC they only want the
move cancelled, not (for instance) the selection dropped.
Fixes https://gitlab.com/kicad/code/kicad/issues/5356
2020-08-25 12:54:40 +01:00
24435fcc62
Don't create new project files when opening boards/schematics
...
Display warning infobar in the board/schematic setup when no project
is loaded, since most of the settings in those dialogs are saved in
the project and not in the board/schematic file.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4868
2020-08-24 22:17:21 -04:00
5e2946ef90
Use full net names in netclasses
...
Short net names are not unique; full names with paths must be used.
Added a grid cell renderer that does the escaping, to make it easier
to display net names in grid cells.
Once you unescape a net name, you can't go back to the escaped form
because you can't assume which `/` should be {slash} and which `/`
Because of this, we cannot use Unescape/Escape on the data model in
the netclass setup panel, and instead do the Unescape in the view.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5331
2020-08-24 21:19:07 -04:00
15c136ead2
Make a bunch of help dialogs modeless.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5334
2020-08-24 23:17:33 +01:00
d5878e552d
Fixes for line, wire and bus styles.
...
1) Return the default netclass if an assignment is not found
2) Local overrides have precedence over netclass values
Fixes https://gitlab.com/kicad/code/kicad/issues/5308
2020-08-24 18:23:55 +01:00
fd4fb61acc
DIALOG_SPICE_MODEL: fix incorrect readonly setting of m_libraryContents.
...
This wxStyledTextCtrl was set to readonly before writing its contents,
so nothing was shown, at least on wxWidgets 3.1.4.
2020-08-24 17:30:36 +02:00
3673c23696
Code style
2020-08-23 22:10:05 -04:00
89e74140eb
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
2f7094b352
Cleanup some unused variables
...
* Make the app progress indicator only have the indeterminate state
when the taskbar indicator is used (causes an uused variable warning
on wx<3.1)
* Remove unused dry run variable in pcb_netlist.h
* Remove unused forceDropAnnotations from the paste special dialog
since the dialog only controls keeping them.
2020-08-24 01:51:23 +01:00
750b186582
Return the type and shape for alternate pins
...
These return statements were missing from the original implementation,
so the alternate style was never being returned.
2020-08-24 01:18:46 +01:00
605ddce651
Make sure ERC has a current sheet to resolve text vars with.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5318
2020-08-24 00:49:08 +01:00
75d813f1bf
Fix gcc-only include
2020-08-23 15:50:16 -04:00
a03fb7a9a8
Altium: Refactor and add initial structure for schematic importer
...
altium: move pcbnew/altium2kicadpcb_plugin -> pcbnew/plugins/altium
See: https://gitlab.com/kicad/code/kicad/-/issues/4412
2020-08-23 19:01:08 +00:00
6eab1ce17d
Fix a minor wxWidgets alert.
2020-08-23 15:20:46 +02:00
80ee805782
Eeschema: fix broken symbol exclude from BOM support.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5284
2020-08-22 13:44:55 -04:00
6a5644d981
Make spice model library contents read-only.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5062
2020-08-22 16:20:18 +01:00
d71d127c1a
Put up infobar when editing board footprint.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5294
2020-08-21 23:53:40 +01:00
a3a36ed4d6
Disallow text var references in reference designators.Disallow text var references in reference designators.Disallow text var references in reference designators.Disallow text var references in reference designators.Disallow text var references in reference designators.Disallow text var references in reference designators.Disallow text var references in reference designators.Disallow text var references in reference designators.Disallow text var references in reference designators.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5293
2020-08-21 23:07:56 +01:00
23c8123ac9
Update a bunch of netlist exporters to resolve textVars.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5285
2020-08-21 22:19:43 +01:00
65bdaff133
Add include for GCC.
2020-08-21 20:54:36 +01:00
80846dcbc7
Improve shutdown performance.
2020-08-21 19:12:51 +01:00
97c34e2516
ADDED alternate pin definitions and assignments.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2002
2020-08-21 18:29:36 +01:00
7565a08396
eeschema: Add select all to schematic and library editor
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2497
2020-08-20 16:07:10 -07:00
9cda3dbff5
Eeschema: Verify path can be made relative before asking in plotter dialog
...
CHANGED: When the output path is set in the plotter dialog, the user is
asked if they want to make the path relative to the project. The old
code would ask the user if they wanted to do this, and then if it
failed would present an error dialog. The new code tries it first on
a copy, and only if it works does the user get asked if they want
to do it.
Related to issue https://gitlab.com/kicad/code/kicad/issues/5263 except
that is for Pcbnew, and this fixes the same problem in Eeschema. Issue
5263 is fixed with Merge Request:
https://gitlab.com/kicad/code/kicad/-/merge_requests/370
2020-08-20 17:08:36 +00:00
c14065ee98
Fix initial zoom to fit size in schematic and board editors.
...
This may affect other EDA_DRAW_FRAME objects as well but it doesn't seem
to be as noticeable in the symbol, footprint, and worksheet editors.
Fixes https://gitlab.com/kicad/code/kicad/issues/5248
2020-08-20 10:33:30 -04:00
ee5c991d2f
eeschema: Ensure all wires are joined
...
When running the cleanup routine, we should check that we haven't
changed our lines during the process. If we have, we run again to pick
up the new merges
Fixes https://gitlab.com/kicad/code/kicad/issues/5265
2020-08-20 06:49:05 -07:00
c5b91c9bb2
Output resolved text to generic BOM XML.
2020-08-20 13:41:49 +01:00
cb74050d13
Add sheet fields as properties of modules on that sheet.
...
This allows text variables in the module text items to resolve
properly in PCBNew.
Fixes https://gitlab.com/kicad/code/kicad/issues/5005
2020-08-19 13:25:52 +01:00
c8917a0951
Cleamup some compiler warnings
2020-08-19 11:35:00 +01:00
b60a7e2aca
Eeschema: fix crash in DIALOG_CHANGE_SYMBOLS when run Update Library Symbols.
...
Probably due to a typo.
Fix also a minor wxWidgets alert in this dialog
2020-08-18 20:53:10 +02:00
fb38344e2f
Symbol editor: use C locale for copy and paste.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5223
2020-08-18 14:30:14 -04:00
a029feb029
eeschema: Add component needs to be Modal
...
Adding a component in eeschema accesses the footprint table as well as
the symbol table. There are no safe edits that can be taken while this
window is open, so we force it to be Modal instead of QuasiModal
The issue is addressed but reveals additional possible problems that
this commit fixes
Fixes https://gitlab.com/kicad/code/kicad/issues/5206
2020-08-18 11:23:18 -07:00
6ef20e34fc
Better support for mixed styles in Junction Properties dialog.
...
Also move to COLOR_SWATCH to reduce code duplication.
2020-08-18 19:05:30 +01:00
b0a09b782d
Better support of mixed states in Line Style dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5249
2020-08-18 19:05:30 +01:00
1558e63c0e
Make local overrides higher priority than netclass widths.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5249
2020-08-18 19:05:30 +01:00
8a4b7bd9c8
Repair wire-width calculation routine.
...
Netclass handling has been move to GetPenWidth() so it's no longer
just a "1" that we can do a std::max against.
Fixes https://gitlab.com/kicad/code/kicad/issues/5249
2020-08-18 19:05:30 +01:00
ede39780e2
Remove all debugging output that cannot be disabled.
...
The use of printf, wxLogDebug, and std::err/std::out causes excessive
debugging output which makes finding specific debugging messages more
difficult than it needs to be.
There is still some debugging output in test code that really needs to
be moved into a unit test.
Add debugging output section to the coding policy regarding debugging
output.
2020-08-18 10:17:36 -04:00
c2847e00d8
eeschema: Fix crash when rescuing during update
2020-08-18 06:34:34 -07:00
1905a23ba1
libedit: fix double msg_panel refresh and use new move event
2020-08-18 13:11:48 +00:00
3674064b9e
Fix double msgpanel refresh and use the new moved event
2020-08-18 13:11:48 +00:00
88d76eaf62
Enforce Apple's destructive button distance guideline.
...
Also fixes a few errant icon buttons that were still setting a fixed
size.
2020-08-17 23:55:31 +01:00
4491f24d5e
Ripout the old SyncToolbars infrastructure reminants
...
The tool framework no longer needs to request updates of the UI
state for the controls, wxWidgets will do it for us.
2020-08-16 19:10:26 +00:00
fd4388710d
Migrate eeschema, libview and libedit to the UI condition framework
...
Also, fix some issues in other frames identified along the way.
2020-08-16 19:10:25 +00:00
3b05d7cddd
Move more frames to the new UI condition framework
...
* Frames moved: cvpcb, cvpcb footprints frame, gerbview, pagelayout editor
This also introduces new EDITOR_CONDITIONS that are used to set the
conditions of very common editor settings.
Also, some IDs were converted to tools in the pagelayout editor.
2020-08-16 19:10:25 +00:00
72a1c71e07
Implement a framework to handle wxUpdateUIEvents for tool actions
...
This allows for the tool framework to keep track of a universal
set of conditions for the UI state (enabled/checked/shown) for
controls of actions. It removes the need for the main menubar
menus to be CONDITIONAL_MENUs and be rebuilt on each open,
and instead makes the updates of the check and enabling of
items handled in the native wxWidgets way.
This commit switchs the 3d viewer and kicad project manager window
over to this system.
2020-08-16 19:10:25 +00:00
61cdf3436b
Ensure PAINTER::Draw routines properly handle EDA_ITEM casting
...
EDA_ITEM is a child of VIEW_ITEM, so a static_cast is not appropriate,
since in some cases it could be called with a non-EDA_ITEM argument.
This was triggering an ASAN heap-buffer-overflow in GerbView.
2020-08-16 12:37:51 +01:00
ade7f529b8
Switch shared_ptr creation to using make_shared
2020-08-16 12:37:50 +01:00
f58221ca98
Add 'GetBoundingBox' that optionally only calcs w visible fields
...
Cross-probing from Pcbnew to Eeschema revealed that EEschema was
including all fields, visible or not, when calculating the bounding
box of the probed componentt. This caused problems with long strings
such as URLs that were not set as visible. The cross-probing code
tries to minimize 'Zoom to Fit' operations when it's not necessary,
and the overly large bbox values often resulted in zooms not being
performed and components displayed very small.
This code adds a version of 'GetBoundingBox' that takes a boolean
to tell it to include invisble fields or not.
Addresses issue: https://gitlab.com/kicad/code/kicad/-/issues/5149
2020-08-15 22:15:30 +00:00
57c3d8e8d8
Make sure preview group gets added to view after a clear.
2020-08-15 21:13:44 +01:00
bd14f8a82a
ADDED: New appearance control widget for PcbNew
...
Featuring:
- Layer view presets
- Per-type opacity for tracks, vias, pads, zones
- Net and netclass color and visibility controls
CHANGED: Simplified object visibilty controls
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-08-15 15:24:28 -04:00
275e810573
eeschema: Use recursive mutex for SCH_PIN
...
We need to be able to lock individual actions while keeping the code
modular. The recursive mutex keeps this thread-local.
Fixes https://gitlab.com/kicad/code/kicad/issues/5186
2020-08-14 18:42:11 -07:00
e54363524c
lib_manager: Do not make a copy of the parent symbol to save
...
The parent symbol needs to be the same pointer as the symbol that is
saved to the cache otherwise the derived symbol will have it's parent
set to a parent that is not in the cache so it will not be saved.
Signed-off-by: Kevin Lannen <kevin.lannen@gmail.com>
2020-08-14 18:37:44 +00:00
13f9478a76
Symbol Editor: Allow changing parent for derived symbol
...
The symbol editor did not actually update the parent symbol when the
dropdown in the properties editor was changed. This fixes that defect.
Signed-off-by: Kevin Lannen <kevin.lannen@gmail.com>
2020-08-14 18:37:43 +00:00
2b0b7a5153
Clear pin net-name-driving cache when changing annotation.
...
Also update connectivity after clear annotation, annotate or back
annotate.
Also update status bar for highlighted nets.
Fixes https://gitlab.com/kicad/code/kicad/issues/5170
2020-08-14 12:41:20 +01:00
cda155ca30
Remove last exposure of GUIDs in UI.
...
Also makes the hierarchical path box bigger so it won't clip on some
themes.
Fixes https://gitlab.com/kicad/code/kicad/issues/5171
2020-08-13 20:59:18 +01:00
0bb175a028
Eeschema: Add change and update symbol from library support.
...
ADDED: Add support to to Eeschema to change and update symbols from a
symbol library.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/4565
2020-08-13 13:53:49 -04:00
d937fadd6f
Migrate RC_ITEM to use shared_ptr
2020-08-13 14:50:59 +02:00
e05cd0e914
Raise limit to prevent zooming on cross-probing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5149
2020-08-12 22:28:18 +01:00
826f81f57d
eeschema: Don't error when replacing references
...
Avoids an unneeded error message when checking the validity of the
replace action
2020-08-12 07:04:51 -07:00
433616cbf0
Prevent segfault on schematic frame close
...
We are seeing multiple events firing when closing via the manager frame.
Cleaning up the schematic should only happen once.
2020-08-11 18:56:47 -04:00
259cacf648
Entries typed into the text size field should be read as mils
...
Previously, they were being interpreted as inches, and then being
displayed as mils - leading to a multiplication by 1000 if there
was no unit string included.
Fixes https://gitlab.com/kicad/code/kicad/issues/5117
2020-08-11 00:14:58 +01:00
e1c449902d
Ask user before throwing away changes to DRC Rules.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5135
2020-08-10 23:43:24 +01:00
827138f6b4
Remove left-over debug code.
2020-08-10 14:17:17 +01:00
f4ab14f32d
Performance improvements for SchematicCleanup().
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4563
2020-08-10 12:41:52 +01:00
265c6fa3b7
Improve color theme support in the footprint preview widget
...
This ensures the colors used by the status text pane in the preview
widget are the same as the canvas, so there is a seemless transition
between the two.
Additionally, remove the scrollbars from the symbol preview widget
in the place symbol dialog - they are pointless.
2020-08-10 02:29:15 +01:00
63f777b620
Fixup the UI for the symbol preview widget
...
This is the proper fix for the symbole preview widget. It will ensure
there are no size changes between the two panels (preview and status),
and also ensure that the status panel has the same background color as
the preview panel.
Fixes https://gitlab.com/kicad/code/kicad/issues/4997
2020-08-10 00:55:36 +01:00
2fc9c7233d
Add color layer for schematic aux items
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4825
2020-08-09 17:39:52 -04:00
e910dc0092
Make sure lines/wires/busses get default widths if not spec'ed.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4854
2020-08-09 21:52:36 +01:00
5abc85aa80
Cleanup re-annotation code style
2020-08-09 12:43:05 -04:00
d08bf90576
ADDED: Geographic Reannotation
2020-08-09 12:43:05 -04:00
c6e388db14
Implement an app progress indicator in the taskbar
...
ADDED: Progress indicator in the taskbar
This adds a progress indicator to the Windows and macOS taskbar
icons to display the progress of some operations.
Note, this requires wxWidgets 3.1+
2020-08-09 10:55:00 +00:00
6b7503be8e
ADDED properties passed between eescema and pcbnew.
...
And referencable from textVars.
Fixes https://gitlab.com/kicad/code/kicad/issues/5079
2020-08-08 22:49:04 +01:00
32a7d00256
Make sure projects are cleaned up nicely when frames close
...
PROJECT objects will be deleted by SETTINGS_MANAGER::UnloadProject
so we need to make sure that this is called at an early enough point
in the closing process that anything needed by the PROJECT dtor
is still around.
Also fix an issue where the schematic worksheet was depending on
the project existing after the schematic had been reset.
2020-08-08 16:52:57 -04:00
111ed6c4ac
Fix simulator: op results are not printed correctly when numbers are very small
...
Was due to an overflow in units calculation.
Fixes #5074
https://gitlab.com/kicad/code/kicad/issues/5074
2020-08-08 15:18:50 +02:00
dcc484e114
CHANGED: Library editors are now usable with no project loaded
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/3688
2020-08-07 18:02:34 -04:00
413c2cc2c6
Don't use the schematic grid for page border in pcbnew
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5105
2020-08-07 17:12:21 -04:00
76bd344730
Preview for PCBNew colour settings editor.
2020-08-06 19:38:06 +01:00
3522fd0535
Refresh for colour changes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4983
2020-08-05 22:56:07 +01:00
b3b567e591
A better approach to clearing color overrides
2020-08-04 19:50:26 -04:00
9cc6a77cc0
Fix bug where preview wasn't getting re-added after view cleared.
2020-08-04 20:40:40 +01:00
c01bf9c911
Refinement in NETLIST_DIALOG, spice panel.
...
The run simulator button is enabled only if the command line is not empty.
2020-08-04 13:57:41 +02:00
7f91a1f5da
Eeschema, export netlist dialog: re-add a commane to run spice from this dialog.
...
Fixes #5025
https://gitlab.com/kicad/code/kicad/issues/5025
2020-08-04 12:52:14 +02:00
be6e2e6308
Add hierarchical sheet (and pin) to color preview.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5029
2020-08-04 11:45:07 +01:00
9c9fdb2569
More performant (and more correct) deletion of DRC markers.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5057
2020-08-04 11:45:07 +01:00
5982626a80
Eeschema: fix a minor wxWidgets alert.
...
Fixes #5066
https://gitlab.com/kicad/code/kicad/issues/5066
2020-08-04 08:27:31 +02:00
dcd02539e3
Remove linked-pin processing from LIB_PIN's setters.
...
It belongs in the tool layer (specifically LIB_PIN_TOOL).
2020-08-03 22:21:35 +01:00
c56599ab07
Allow ERC/DRC markers to be deleted without deleting exclusions.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4953
2020-08-02 22:45:48 +01:00
f3b92903e2
Evidently the sheet client list isn't kept up-to-date.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5021
2020-08-02 19:58:15 +01:00
ee6acb983a
Build out the rest of the schematic preview for colors editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5029
2020-08-01 21:07:14 +01:00
d586495c0a
Preview fp edges & text while dragging in router.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5037
2020-08-01 15:40:34 +01:00
e86fc64e7d
Check envvars as well before flagging as un-resolved.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4644
2020-08-01 00:24:26 +01:00
173493b1a8
Try to store the actual sheet #, but don't store 1 for non-root sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5021
2020-07-31 22:29:05 +01:00
5f3fd43b29
Fix uninitialized variable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4948
2020-07-31 17:19:21 +01:00
1be39195ab
Remove UUIDs from the GUI.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5018
2020-07-31 16:06:54 +01:00
047e95ccc4
Fix crash on Preferences > Colors.
2020-07-31 12:04:01 +01:00
4c5fe7e651
Only update relative paths in nested subsheets.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4366
2020-07-31 12:04:01 +01:00
310613a941
Pin junction dot size to no less than 170% of wire width.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4917
2020-07-30 20:04:12 +01:00
0804f487ec
Add text var cross-reference processing to SCH_FIELDs.
2020-07-30 14:27:42 +01:00
cdaa866428
Put UUID on own line.
2020-07-30 14:27:42 +01:00
0a4ce183a4
ADDED: polygon newlines every point
...
By default KiCad will now print each polygon point on its own line.
This adds to the vertical distance for large polygons but makes revision
control much cleaner as single point addition to a polygon does not
propagate to a diff over the full polygon.
Users/developers who want to save the files using the 4-points per line
have the ADVANCED_CONFIG setting 'CompactSave' which will provide the
original save method
2020-07-30 01:18:44 +00:00
b0c6a0f9ef
Allow sheet colors to remain unspecified if not manually set
...
This way, when the user changes their color theme, any sheets
that did not have a specific color set will change with the theme.
Also add a button to clear color overrides from a sheet, because
any schematics that have been saved before this change will have
the colors set to something other than UNSPECIFIED.
2020-07-29 21:16:07 -04:00
98b1f55e29
Eeschema: minor fixes: fix incorrect label in DIALOG_LIB_EDIT_PIN, electrical pin list.
...
Gives also to functions GetText() and GetBitmap() a more significant name.
Fixes #5007
https://gitlab.com/kicad/code/kicad/issues/5007
2020-07-29 17:04:52 +02:00
f00c59c446
Fix a few Coverity warnings.
2020-07-29 09:26:57 +02:00
9278660b10
Add support for the windows application restart api
2020-07-28 14:32:39 -04:00
55784afbfe
Allow text variables to reference parent sheet's fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2466
2020-07-28 13:35:37 +01:00
039b6fd5cf
Eeschema plot: do not plot the hierarchy sheet symbol background in B&W mode.
...
if the the hierarchy sheet symbol background is not white, in B&W mode it is black,
and texts are not readable.
Fixes #4987
https://gitlab.com/kicad/code/kicad/issues/4987
2020-07-28 10:13:56 +02:00
b74e125264
Read/write schematic netclass properties.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4990
2020-07-27 23:10:46 +01:00
4479fcc6dc
Give HardReset() a better chance of success.
2020-07-27 21:55:08 +01:00
97964b2a4c
Use netclass colour for junction dots and when printing/plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4986
Fixes https://gitlab.com/kicad/code/kicad/issues/4982
2020-07-27 21:47:05 +01:00
8a9fa53cd7
Clear annotations by default on copy/paste.
...
Folks didn't seem to like the "only clear when there are collisions"
behaviour. Paste Special remains available to "force keep".
Fixes https://gitlab.com/kicad/code/kicad/issues/4933
Fixes https://gitlab.com/kicad/code/kicad/issues/4744
2020-07-27 19:53:42 +01:00
8324cb30b7
Save the wxDisplay index to set the position of windows correctly
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4338
2020-07-27 02:53:56 +00:00
7bdb98f961
libedit: Make context menu follow context
2020-07-26 20:16:38 +00:00
864087890b
Fix typo assuming new field value was always the name.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4936
2020-07-22 15:10:54 +01:00
9a801d8b72
Don't disrupt diff pairs when auto-renaming buses
...
With bus groups we can use the prefix to disambiguate
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4916
2020-07-20 20:41:56 -04:00
a1437f4a95
Eeschema : Add A5 sheet size
2020-07-21 00:00:36 +00:00
095937563b
Hook libeval compiler up to rule parser
...
- convert expression string tokens to single-quote-delimited
- fix bug where netclass assignments weren't getting updated after
board setup dialog
- move property manager rebuild to lazy evaluation
- improve performance with wider use of const&
- retire DRC_SELECTOR stuff
- use wxString for GUI stuff (particularly translated stuff)
- fix EqualTo() to return false instead of asserting when op types
don't match
- fix buffer overruns with fixed-size string buffers
- make expression function calls case-insensitive
- integrate expression errors into rule parser
- produce more and better error messages
- keep BOARD_ITEM ptrs const as long as possible
- fix a couple of uninitialized variables
2020-07-20 22:11:53 +01:00
3b727b5d16
Make preference groups not selectable
2020-07-20 13:45:46 +00:00
1d450adfdf
Eeschema: fix crash when trying to save as a library in a non writable folder.
...
The crash was due to a non caught thrown error.
Fixes #4914
https://gitlab.com/kicad/code/kicad/issues/4914
2020-07-19 18:27:19 +02:00
ae45c08ce4
Fix label creation for new netname driven from a pin
...
LIB_PIN is never used in the connectivity calculation,
so it should use SCH_PIN instead. Additionally, the label
orientation should take into account the orientation of
the component to ensure they don't overlap.
2020-07-19 01:52:34 +01:00
50b2271f84
Fix missing variable initialization
2020-07-18 23:56:39 +01:00
1e9d947598
Save MRU path when doing a library Save As....
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4910
2020-07-18 15:26:11 +01:00
cc688a3e1d
Initialize variables properly
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4919
2020-07-18 00:36:47 +01:00
3fd0a3f842
Update text variables even when they're changed from other binary.
...
For instance, you might have PCBNew open but change the variable
value through EEschema > Schematic Setup.
Fixes https://gitlab.com/kicad/code/kicad/issues/4918
2020-07-17 21:05:11 +01:00
33480ecad1
Show all symbol libraries by default.
...
Also fixes an issue where the plugin wasn't getting reset if the
library type was changed.
2020-07-17 18:33:14 +01:00
944c9eac7c
Allow Update Schematic from PCB to re-link based on refdes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4306
2020-07-16 18:32:49 +01:00
6296b4e20b
Kicad manager: create a minimal .kicad_pro file when creating a project from scratch.
...
Fixes #4889
https://gitlab.com/kicad/code/kicad/issues/4889
2020-07-16 11:31:39 +02:00
0ab8b9a2d9
Symbol editor: fix assertion attempting to copy an inherited symbol.
...
Copying or cutting an symbol to the clipboard using the context menu
in the library tree requires a root symbol. Inherited symbols must
be flattened in order to properly be added to a symbol library.
Fixes https://gitlab.com/kicad/code/kicad/issues/4901
2020-07-15 20:57:34 -04:00
11ca21039a
Clear new flag when creating image pins.
...
Otherwise if you then move it we'll think it needs to be inserted
and end up with a circular drawings list.
Fixes https://gitlab.com/kicad/code/kicad/issues/4622
2020-07-16 01:39:29 +01:00
e8079bf655
Make sure UI gets adjusted for Symbol property changes.
...
For instance, if the number of units is changed from 1 to not-1
or vice versa then we need to rebuild the units selector.
Fixes https://gitlab.com/kicad/code/kicad/issues/4622
2020-07-16 01:39:29 +01:00
729dc75396
Symbol editor: fix copy/cut and paste bug.
...
Use the s-expression symbol library file format for copy/cut to clipboard
instead of legacy symbol file format when using the library tree context
menu copy and cut entries. Also use s-expression file format for parsing
clipboard contents using the context menu.
Fixes https://gitlab.com/kicad/code/kicad/issues/4900
2020-07-15 20:23:10 -04:00
af729d578f
Unify settings reset buttons into one location
2020-07-16 00:08:16 +01:00
19d0899a80
Fix previous botched attempt to deal with duplicate field ids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4821
Fixes https://gitlab.com/kicad/code/kicad/issues/4891
2020-07-15 13:51:12 +01:00
1dc804232c
Fix issue with duplicate field IDs getting saved out.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4821
2020-07-14 16:00:38 +01:00
7f991ce855
Revert "Set DoubleBuffering to reduce flicker"
...
This reverts commit 106259f6e6
2020-07-13 20:23:12 -07:00
e19a7910f8
Revert "Revert "Set DoubleBuffering to reduce flicker""
...
This reverts commit c18cab6154
2020-07-13 20:19:10 -07:00
dd61f6f019
Use pin graphic only for rubber-band selection hit-testing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4138
2020-07-13 22:41:56 +01:00
1cd2a51db2
Make undo/redo lists protected.
2020-07-13 15:53:36 +01:00
fa9937701f
Undo for Edit Component's LibId.
2020-07-13 14:16:21 +01:00
7340c97ef9
Undo for schematic-wide operations.
...
Editing value/footprint fields of multi-unit components.
Find/Change.
Annotation.
Back annotation.
Fixes https://gitlab.com/kicad/code/kicad/issues/2122
Fixes https://gitlab.com/kicad/code/kicad/issues/4869
Fixes https://gitlab.com/kicad/code/kicad/issues/3933
Fixes https://gitlab.com/kicad/code/kicad/issues/4871
Fixes https://gitlab.com/kicad/code/kicad/issues/3899
2020-07-13 12:32:17 +01:00
9f09c3872f
Ensure file reads always use the C-locale variant
...
Str2Double assumes current locale. We usually switch the locale when
reading files but we should be using the function that explicitly gets
the C-locale conversion.
2020-07-12 20:03:50 -07:00
a2041073ee
Skip project backup in standalone mode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4867
2020-07-12 11:42:05 -04:00
9b92b275de
Remove vestiages of old open-PCB-for-settings hack.
...
We used to have to open a PCB_EDIT_FRAME to get the settings for
the footprint editor and footprint viewer. This necessitated some
special processing when opening a PCB_EDIT_FRAME to actually edit
a board as it might already be open but unloaded.
Since the new settings architecture allows the footprint editor and
footprint viewer to init themselves we no longer need the special-
case code.
2020-07-11 21:19:49 +01:00
e325d2e18f
Allow Net Inspector to create, rename and delete nets.
...
ADDED: create/edit/delete nets in PCBnew Net Inspector
ADDED: update from PCB now allows updating of changed nets
Fixes https://gitlab.com/kicad/code/kicad/issues/1996
2020-07-11 21:19:49 +01:00
c18cab6154
Revert "Set DoubleBuffering to reduce flicker"
...
This reverts commit 106259f6e6#4785
Fixes https://gitlab.com/kicad/code/kicad/issues/4863
2020-07-11 09:43:30 -07:00
106259f6e6
Set DoubleBuffering to reduce flicker
...
This sets double buffering for GTK and MSW to minimize flicker when
redrawing window elements.
Fixes https://gitlab.com/kicad/code/kicad/issues/4785
2020-07-10 09:29:42 -07:00
4a5792cb87
Fix bus unfolding in the wake of bus entry changes
...
Since bus entry shape is not a thing anymore,
unfolding routine can be simplified to just use size
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4853
2020-07-09 18:51:42 -04:00
66bdd37637
Connectivity optimizations
...
Cache names of potential driving items
Change a few data structures based on profiling
2020-07-09 18:14:37 -04:00
fc92fb076e
Cache sheet path to string conversion in UpdateSymbolInstances
...
Profiling of large designs (with many hierarchical sheets)
showed that this can be a huge (4x) speed up to schematic
loading times.
2020-07-09 18:14:37 -04:00
b1b9cef5fb
Full-project automatic backup system
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4763
2020-07-09 13:55:19 +00:00
282fcd5f3c
Connectivity optimizations
...
Don't copy the recursion test cache when copy-constructing
SCH_SHEET_PATHs as it's not needed in connectivity
Fix a few places that were copying unnecessarily
2020-07-08 17:42:12 -04:00
741481591e
NetClass settings for Eeschema.
...
ADDED Eeschema-specific netclass settings including wire and bus
thickness, color, and line style.
Netclasses override individual wire & bus colors and line styles.
If that proves an issue we might look at something more sophisticated
with inheritance.
Fixes https://gitlab.com/kicad/code/kicad/issues/4581
2020-07-08 21:23:25 +01:00
d292db866a
Fix mismatch between dialog and code.
...
(The code was updated to use INDETERMINATE_ACTION, but the dialog
wxChoice still specified an entry of "...". This moves both to the
code so it's harder for them to get out of sync.)
2020-07-08 19:31:44 +01:00
41dd31babf
Symbol editor: fix unnecessary "Save As..." prompt.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4818
2020-07-08 14:06:10 -04:00
37ce9fb847
Tell wx that we really want a transparent background
...
Try more options for telling wxWidgets that we want the area
to have a transparent background. Also, fix some spacing issues.
Fixes https://gitlab.com/kicad/code/kicad/issues/4842
2020-07-08 16:29:04 +01:00
4c383c51fa
Eeschema: add update symbol from library command to context menu.
...
Rather than displaying dialog that has every update option possible like
updating footprints in the board editor, this change updates the library
symbol immediately using the symbol library identifier and requires no
additional input from the user.
ADDED: Context menu entry for schematic symbols to update the symbol from
the symbol library using the existing library identifier.
2020-07-08 10:15:24 -04:00
7f1e1a4abb
Fix missing pin table visible columns setting
...
This got missed in the settings merge
2020-07-07 20:59:55 -04:00
788f31d743
Fix import of Eagle schematics
...
Old project needs to be unloaded before schematic is reset,
then new project has to be loaded before doing the import
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4836
2020-07-07 20:48:32 -04:00
908377f9c4
Remove incorrect factor of 2 scaling
...
This was a copy-paste error that caused the junction dots
to be twice as small as they should be.
Fixes https://gitlab.com/kicad/code/kicad/issues/4834
2020-07-08 01:45:11 +01:00
c6eb072726
eeschema: Fix cutoff text in pinmap
...
Ensure the proper bounding box is used when computing the amount
of space taken by angled text in the control.
Fixes https://gitlab.com/kicad/code/kicad/issues/4761
2020-07-07 23:12:17 +01:00
f481be3358
Set a proper default for the schematic junction size
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4834
2020-07-07 23:12:17 +01:00
ccc0ceb32f
Remove deleted item global variables
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4819
2020-07-07 23:12:17 +01:00
7cea4b23f1
ADDED: Expand selection in context menu
...
Break out the context menu with heuristically limited choices being
appended to the main list rather than re-selecting
Fixes https://gitlab.com/kicad/code/kicad/issues/4799
2020-07-07 14:18:35 -07:00
84b02e51f1
Fix overly aggressive ERC check
...
It helps to only check for the pintypes I care about
2020-07-07 17:08:07 -04:00
358cccfd73
A bit of safety if realtime connection updating isn't on.
2020-07-07 14:45:14 +01:00
e66523586b
Add Assign Netclass... to context menu.
...
ADDED Assign Netclass feature to EEschema.
Netclass assignments also now shown in status bar.
Fixes https://gitlab.com/kicad/code/kicad/issues/4581
2020-07-07 14:23:39 +01:00
d8be5f9ecf
Don't allow pins with NC electrical type to join other nets
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1826
2020-07-06 20:27:38 -04:00
23ce2d2e36
Re-add missing include
2020-07-06 19:47:07 -04:00
66f38dfc10
Remove assert that fires in normal operation
...
The missing symbol happens normally when the user does not have their
cache file available. This should not be an assert
2020-07-06 14:37:03 -07:00
0410fdd9fb
Push a few missed project settings out of the frame
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4823
2020-07-06 17:30:27 -04:00
3939b31027
Integration of netclasses into Eeschema.
...
This is mostly architecture, with the hookup of the Schematic Setup
dialog's Net Classes page. Things like assigning to a net on the
canvas to follow.
Fixes https://gitlab.com/kicad/code/kicad/issues/2132
Fixes https://gitlab.com/kicad/code/kicad/issues/4581
2020-07-06 20:00:50 +01:00
b917e9aa72
Implement import from... for pin conflicts map.
2020-07-06 20:00:50 +01:00
b0ca7d5140
Netclass setup for Eeschema.
...
ADDED netclass panel in Schematic Setup dialog.
Fixes https://gitlab.com/kicad/code/kicad/issues/2132
2020-07-06 20:00:50 +01:00
c1d5394e46
properties: post-rebase fixes
2020-07-05 22:44:38 +02:00
509cd8f495
Remove duplicate fix not found by merge.
2020-07-05 21:01:19 +01:00
ec6c1b80b7
Fix a couple of bugs in the CurrentSheet architecture.
2020-07-05 19:53:04 +01:00
e9b99cc8b7
Fix grabbing connections from power components
2020-07-04 20:59:35 -04:00
04a51a5ba4
Push current sheet handling to SCHEMATIC
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4803
2020-07-04 20:59:35 -04:00
9e669db5b4
Eeschema: fix a name collision with a Windows header.
...
the member ERROR of the class PIN_ERROR was colliding: changed to PP_ERROR
2020-07-04 17:51:00 +02:00
d143e14694
Fix memory leaks in color theme editor
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4794
2020-07-03 22:34:41 -04:00
f725248fd8
Fix ERC pin checking logic
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4577
2020-07-03 17:51:20 -04:00
b94e29e3b1
Persist ERC pin table in project settings
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2066
Also a partial fix for https://gitlab.com/kicad/code/kicad/-/issues/4577
2020-07-03 17:11:42 -04:00
cf38d382c7
Eeschema: ensure the netlist data is up to date before generating the netlist
...
Fixes #4779
https://gitlab.com/kicad/code/kicad/issues/4779
2020-07-03 21:08:38 +02:00
0201cb4e7e
Fix schematic reload in standalone mode
2020-07-03 10:43:23 -04:00
05771f74f7
Fix netlist QA test
2020-07-03 08:21:19 -04:00
1c72042fc4
Clean up stale nested settings when changing project pointer
2020-07-02 23:55:46 -04:00
498fa8d8ba
Fix some things about template fieldname synchronization
2020-07-02 23:42:36 -04:00
4dbbe1cf68
Project settings fixes from review
...
- Fix file extension for new project
- Fixes for exceptions on MSW
- Fix some ASAN issues
- Allow SETTINGS_MANAGER to run headless
- Don't flag schematic as modified after schematic setup is closed
- Don't automatically unload projects when LoadProject is called
- Don't unload project if it's the same as the current one
- Make sure to properly init/de-init template field names
2020-07-02 22:08:54 -04:00
fe5959b625
Remove the schematic and board backup file system
...
Per discussion on the developers list, this old system
no longer provides much value and is seen as annoying
by many users. The new save logic should prevent any
cases of file corruption on save, which was a major
reason for the backup file system existing.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2012
2020-07-02 22:08:54 -04:00
12b4a55ae8
Port Eeschema to new project settings
...
DRC/ERC error serialization changed to use explicit tokens
Old stored severities and ignored errors are discarded
2020-07-02 22:08:54 -04:00
c0aa6965de
Migrate PcbNew project settings to new framework
...
Various architecture upgrades to support this.
Creating a BOARD now requires a valid PROJECT, which caused
some (mostly transparent) changes to the Python API internals.
ADDED: Project local settings file
CHANGED: Board design settings are no longer stored in PCB file
CHANGED: Net classes are no longer stored in PCB file
CHANGED: Importing board settings now reads boards, not just projects
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2578
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4070
2020-07-02 22:08:54 -04:00
0e2f9cb1bd
Migrate CvPcb project parameters
2020-07-02 22:08:54 -04:00
a4fadfcdf2
Begin moving project file load to new system
2020-07-02 22:08:54 -04:00
a7708fa6dc
Add PROJECT_FILE and basic load/unload methods
2020-07-02 22:08:54 -04:00
f7156a9d49
eeschema: Only warn user about off-grid pins if the position has changed
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4673
2020-07-03 02:11:47 +01:00
e91acfb67b
Correct SHEETNAME validation exclusions which were for SHEETFILENAME.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4748
2020-07-02 21:38:37 +01:00
7b042f4a75
Add rectangle tool to PCBNew toolbar in favour of Aux Origin.
...
ADDED new rectangle graphics tool for PCBNew and Footprint Editor.
Also adds rectangle tool to both Footprint Editor and PCBNew Place
menus.
The Aux Origin tool can come back once we have multi-select toobar
buttons.
Also collapses an unnecessary level out of the auxOrigin and gridOrigin
settings.
Fixes https://gitlab.com/kicad/code/kicad/issues/2246
2020-07-01 13:31:30 +01:00
6d56ba2072
Minor cleanup to edit label dialog.
2020-06-30 19:55:04 +01:00
61b5a12362
Don't allow component & sheet field IDs to collide.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4748
2020-06-30 19:17:28 +01:00
bb1afb747a
Remove bus entry shape
...
The shape isn't needed anymore, since bus entries can be rotated
and mirrored like other items.
Fixes https://gitlab.com/kicad/code/kicad/issues/4588
2020-06-30 02:09:33 +01:00
8a0277eb2e
Fix null graph in some connections
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4747
2020-06-29 20:27:08 -04:00
67bd49b4a8
Fix order-of-ops issue in sim plot
2020-06-27 19:59:49 -07:00
bd19c580f4
Add configuration for cross-probing behavior
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2317
2020-06-27 22:48:48 -04:00
6acd35c981
Cleanup.
2020-06-27 20:07:26 +01:00
0f0627a53e
Eeschema: add 4 new zoom levels (0.1, 0.15, 0.2, 0.3) in context menu.
...
However, to see them in context menu, the old eeschema.json
config file must be deleted, because it contains the list of allowed zooms.
2020-06-27 20:35:54 +02:00
32c3ea4edd
Flags cleanup.
...
Remove extraneous use of FLAG0 from tracks cleaner (it was checked but
never set).
Fix issue in expand connections where two parts of it couldn't agree
on the same flag (BUSY vs SKIP_STRUCT), and where the second part was
clearing the flag instead of setting it.
Remove obsolete HIGHLIGHT infrastructure (we now use selection).
Remove extraneous use of BUSY flag in several places (it was never
set).
2020-06-27 17:53:04 +01:00
fb10406e67
Add right-click context menus for toolbar items
2020-06-26 21:29:03 +00:00
52856a8ce4
Move scaled toolbar separator into ACTION_TOOLBAR
...
* Ensure all separators are scaled separators
* Clean up toolbar creation functions
2020-06-26 21:29:03 +00:00
2078e629c5
Eeschema: allow editing of junction properties diameter and color.
...
Add missing plot and print changes for the new bus entry properties.
ADDED: Junction properties diameter and color can now be edited.
Fixes: https://gitlab.com/kicad/code/kicad/issues/4593
2020-06-24 13:36:17 -04:00
853cf2c9b9
Eeschema: make bus wire entry properties editable.
...
CHANGED: Bus to wire entry object properties line color, width, and style
can now be edited.
Fixes: https://gitlab.com/kicad/code/kicad/issues/4591
2020-06-24 13:36:17 -04:00
b15ee1086f
Eeschema: factor out line stroke property object.
...
The line stroke property object STROKE_PARAMS was factored out an used in
the schematic line object. This will allow it to be used in other objects
that require line stroke properties so every object does not need to have
it's own definition for line stroke properties.
2020-06-24 13:36:17 -04:00
e82e30d215
bom2grouped_csv.xsl: Fix sorting of grouped references
...
Commit a96ebe8fhttps://gitlab.com/kicad/code/kicad/-/issues/940
hopefully for good this time.
Signed-off-by: Tormod Volden <debian.tormod@gmail.com>
2020-06-23 15:48:59 +02:00
158f6ad526
Fix net highlighting
2020-06-22 12:02:58 -04:00
40e0a4295d
Re-add netlisting logic inadvertently removed during refactor
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4692
2020-06-21 21:43:24 -04:00
202b55f4d2
Plot sheet background colors if present
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4697
2020-06-21 20:43:47 -04:00
09cb75b8a1
Use a temporary file when saving boards/schematics to make the operation more atomic
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4517
2020-06-19 23:31:26 +00:00
dd42a19319
Prevent grid axes from inadvertently turning on in eeschema
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4680
2020-06-19 17:22:25 -04:00
6d2f30005e
Don't blow up the sheet path when selecting an ERC item
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4685
2020-06-19 17:00:41 -04:00
ee9d8fcd15
Collapse Pcbnew & ModEdit display and edit settings.
...
(Prep work for reusing them with a custom shape editor.)
2020-06-18 15:38:01 +01:00
15b95f2980
Fix project references in eagle importer after SCHEMATIC object
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4672
2020-06-17 17:30:24 -04:00
a7703d1207
Cleanup Graphics to parallel Cleanup Tracks & Vias.
...
This also allows for easier migration to DRAWSEGMENT::S_RECTs by
auto-converting 4 rectilinear lines to a rectangle.
2020-06-17 18:44:39 +01:00
4480759599
Remove unused variable
2020-06-15 12:40:02 -07:00
ad12c42e8b
Push grid settings dialogs down into common.
...
This also gives support for fast grid switching and a user grid
to eeschema.
Fixes https://gitlab.com/kicad/code/kicad/issues/2200
2020-06-14 19:26:37 +01:00
a8d5d9b690
panel lib tables: avoid crash when deleting the last entry in list.
2020-06-14 17:39:32 +02:00
e16426987a
Fix wxWidgets alert on integer overflow.
2020-06-13 22:44:16 +01:00
c48f4272f3
Collapse a level out of the zoom settings.
...
The APP_SETTINGS_BASE now holds the list of zoom factors, and
the old legacy (screen-based) code has been removed.
2020-06-13 22:44:16 +01:00
a02d8a5993
Fix a number of signed/unsigned comparisons
2020-06-13 11:55:59 -07:00
f84406009b
Push a couple of layers of indirection out of grid settings.
2020-06-13 11:35:56 +01:00
a97f14e217
Propagate exclude from board to all units of a component
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4650
2020-06-12 14:26:11 +01:00
037898f6fb
Eeschema: add support for excluding symbols from board.
...
ADDED: Support for excluding symbols from board during. This allows for
creating bill of materials only symbols.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2522
2020-06-10 10:57:28 -04:00
79cdd608af
Make sure Footprint ID gets initialized when calling chooser.
...
Also make some of the labels in the dialog more explicit.
2020-06-09 20:10:39 +01:00
2401ed587e
eeschema, pcbnew: fix too narrow window showing the item color list
...
Fixes #4610
https://gitlab.com/kicad/code/kicad/issues/4610
2020-06-09 20:05:38 +02:00
64231a8491
fix a minor wxWidgets alert and a outdated comment.
2020-06-09 14:12:38 +02:00
9d0ea66a96
Don't use the accelerator table in the menubars
...
It seems that the accelerator table causes issues with
keyboard events on MSW.
Fixes https://gitlab.com/kicad/code/kicad/issues/1941
2020-06-06 22:50:35 +00:00
eef81e84b2
Avoid marking a default name translatable: after translation the result
...
can be unexpected and broken.
2020-06-06 20:51:50 +02:00
4357c1d3b3
Coverity and compiler warning fixes
...
* Initialize variables
* Test dynamic casts
Fixes https://gitlab.com/kicad/code/kicad/issues/4620
2020-06-05 12:50:56 +01:00
c27ca90c13
Symbol library editor: fix broken "Save As..." feature.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4590
2020-06-04 13:25:53 -04:00
a29b3eb017
Eeschema, DIALOG_EDIT_ONE_FIELD: fix incorrect behavior for footprint field,
...
when initialized from the footprint viewer.
Fixes #4609
https://gitlab.com/kicad/code/kicad/issues/4609
2020-06-04 18:47:12 +02:00
ae852e17f9
Re-add null component checking in UpdateNetHighlighting
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4606
2020-06-03 20:36:30 -04:00
3fa2bad3c5
Symbol editor: disable tools and menu entries for derived symbols.
2020-06-03 16:57:08 -04:00
616ac50cfb
KiCad: add support for missing file format extensions.
...
Don't rename symbol libraries when performing a project "Save As.."
except for the legacy cache library. Changing library file names
breaks the symbol library table. This was the less painful option
than updating the symbol library table.
Fixes https://gitlab.com/kicad/code/kicad/issues/4605
2020-06-03 16:13:42 -04:00
0032845f9e
Fix clipped bitmap buttons with GTK on Linux.
...
A note to developers, please do not set the minimum and/or size of bitmap
buttons. It causes bitmaps to get clipped using GTK on Linux. If the
bitmap button size is not acceptable, then supply an appropriately sized
bitmap rather than attempt to force the wxWidgets sizing mechanism to do
what you want. This almost always causes platform differences that do
not work well.
2020-06-03 14:01:44 -04:00
77a59fb5d3
Eeschema: add support for excluding symbols from bill of materials.
...
This provides a method to add symbols that represent footprints on the
board that do not have an associate component such as mounting holes,
fiducials, logos, etc that should be excluded from the bill of materials.
It also prevents those footprints from being removed from the board
accidentally when updating the board from the schematic.
ADDED: Support to exclude schematic symbols from bill of materials
export.
2020-06-03 08:55:13 -04:00
5d493abea7
Check for duplicate field names.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4219
2020-06-02 21:44:03 +01:00
c01046c12f
Give new sheets an initial name and filepath.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4516
2020-06-02 20:28:20 +01:00
10add93d16
Fix clang compile warnings.
2020-06-02 20:27:22 +01:00
aadc926740
Coverity fixes and "auto" removal.
2020-06-02 17:22:23 +01:00
354d53a6c5
Handle derived library symbol optional field inheritance.
...
CHANGED: Derived library symbols will inherit optional fields defined by
their parent symbol and override existing optional fields.
CHANGED: The symbol editor will now only display the fields defined in
derived symbols rather than show mandatory fields inherited from the
parent symbol. Showing fields that cannot be edited would be confusing.
2020-06-02 14:21:11 +00:00
52078a4b1b
Allow setting mandatory derived symbol field properties.
...
CHANGED: All mandatory fields in derived symbols can be edited. This
not only includes the field value but also all text properties.
Kill the dual datasheet variable storage which caused many datasheet
bugs over the years. The datasheet is now always stored in the data
sheet field.
2020-06-02 14:21:11 +00:00
dd1a7627f8
Move setting derived symbol field properties from parent symbol.
...
In order allow the new file format to support derived symbols with
field properties that are different than the parent symbol, the code
that copied the parent field properties to the derive symbol field
properties had to moved out of LIB_PART::SetParent() into the legacy
symbol library plugin and the symbol library editor add new symbol
code to preserve the current behavior and not overwrite derived
symbol field properties.
This lays the ground work for allowing field properties of derived
symbols to be different than their parent symbol.
2020-06-02 14:21:11 +00:00
21c752fa0b
eeschema: Rename shadowing var
2020-06-01 09:58:07 -07:00
eae0c142fe
Eeschema, DIALOG_PLOT_SCHEMATIC: fix incorrect unit of default pen width.
...
The default line width used to set the default pen width is given in mils,
and the conversion to iu was missing.
Fix also a minor Coverity warning.
Fixes #4594
https://gitlab.com/kicad/code/kicad/issues/4594
2020-06-01 16:08:46 +02:00
adb1074597
Add undo for Edit Text & Graphics Properties.
2020-05-31 00:01:55 +01:00
3425deff47
Hook up Edit Text and Graphics Properties to wires.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1974
2020-05-31 00:01:55 +01:00
9414f65a3f
Eeschema: allow Properties... in wire context menu
...
Seems to have been forgotten from 91fd0635
2020-05-30 14:29:53 +00:00
598ed8b394
toolbars_lib_view.cpp and toolbars_libedit.cpp: do not recreate comboboxes
...
when clearing toolbars.
Clearing toolbars delete only tools, not other widgets.
recreating comboboxes creates strange cosmetic issues.
Fixes #4542
https://gitlab.com/kicad/code/kicad/issues/4542
2020-05-30 14:14:24 +02:00
e7603ddcb9
Add tilde escape syntax to syntax help.
2020-05-29 22:06:48 +01:00
b0ebc476d2
Don't assert when getting line width for sheets
2020-05-29 16:38:25 -04:00
e8c1738361
dialog_edit_label.cpp: fix a minor compil warning (shadowed var)
2020-05-29 20:16:03 +02:00
91fd063585
Eeschema: allow editing of wire and bus properties.
...
CHANGED: Wire and bus lines properties (color, line width, and line type)
can be edited the same as graphical lines.
2020-05-29 14:33:27 +00:00
c2d94358fc
Symbol editor: minor fixes to disable saving the legacy file format.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4093
2020-05-29 12:43:00 +00:00
6c8b937e1b
Symbol editor: disable saving legacy symbol libraries.
...
CHANGED: The symbol library save menu entry is now only enable when the
currently selected library is modified.
CHANGED: The symbol library save all menu entry and tool bar button are
enabled when one or more of the symbol libraries have been modified.
REMOVED: The ability to save symbol libraries in the legacy file format.
2020-05-29 12:43:00 +00:00
b624c7090a
Deprecate saving legacy schematic and symbol library file formats.
...
REMOVED: The ability to save schematics in the legacy file format.
2020-05-29 12:43:00 +00:00
b83d64fc0d
Eeschema: remove superfluous updating of SCH_COMPONENT pins.
...
Every time SCH_COMPONENT::GetDrawItem() was called, the schematic symbol
pin table was updated. Under certain conditions, this happens inside
loops so the amount of time spent rebuilding the pin table can add up.
2020-05-28 18:32:28 -04:00
790b061b8b
Make sure all plotters have a RENDER_SETTINGS.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4556
2020-05-28 20:16:36 +01:00
8d92a95cb8
Fix a couple of issues with text var autocomplete.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4190
2020-05-28 20:00:21 +01:00
9f2be3714f
Add unresolved variable testing for worksheet items.
2020-05-28 17:36:22 +01:00
5bfa06bb1c
Coverity fix.
2020-05-28 10:38:40 +01:00
fe4fd19c66
Fix crash bug in unicode chars with Scintilla.
2020-05-28 00:23:18 +01:00
8b084c373e
Autocomplete for text variables.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4190
2020-05-27 23:29:51 +01:00
f3e4e61fa7
Push some more editing code out to the tool framework.
2020-05-27 23:29:51 +01:00
fb8dcb52d1
Don't gray out mandatory field names.
...
(Even though they are read-only. It makes it look like the whole
field is disabled.)
2020-05-27 23:29:51 +01:00
1792479ca5
Fix sheet pin import after SelectPoint API change
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4552
2020-05-27 11:21:59 -04:00
6ef6284924
Make sure markers get removed from view when deleted.
2020-05-26 22:09:31 +01:00
f971e1267b
Fix typo and remove a I18N marker in a sentence containing keywords
...
(keywords cannot be translated)
Fix also use of a deprecated constant.
2020-05-26 17:47:58 +02:00
06fde791f0
New schematic and symbol library file format layout changes.
...
Force default settings to be written instead of undefined which mimics
the behavior of the previous file format with the exception of text
objects which requires some more thought. Please note that no new
features are added to the library file format so the file version did
not need to be updated.
Fixes https://gitlab.com/kicad/code/kicad/issues/4411
2020-05-26 12:58:57 +00:00
160981ee71
Better error reporting for DRC rule parsing.
2020-05-25 22:51:47 +01:00
2164501b06
Don't reparent symbol fields
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4540
2020-05-25 17:47:50 -04:00
13baf548ca
Ensure merged buses have all members
2020-05-25 17:35:26 -04:00
df16ea25a8
Properly send cross-probe for nested buses
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4541
2020-05-25 17:03:49 -04:00
ecec7192fc
Add "Select All" in schematic & layout disambiguation popup menu
...
ADDED: "Select All" in schematic editor disambiguation menu
ADDED: "Select All" in layout edtor disambiguation menu
Fixes https://gitlab.com/kicad/code/kicad/-/issues/3877
2020-05-24 23:35:04 +00:00
77a6550ba9
Fix bus unfolding with prefixes
2020-05-24 19:17:01 -04:00
82a2530863
Fix missing inits of graph in a few places
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4532
2020-05-24 19:17:01 -04:00
699985cd97
Check for nested buses when highlighting
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4531
2020-05-24 16:15:22 -04:00
a52435bbb0
ADDED: New mouse settings panel, expanded mouse settings
...
You can now choose the behavior of dragging with the
middle and right mouse buttons.
You can also choose which modifier keys to use for
panning and zooming with the scroll wheel or trackpad.
You can also customize the zoom speed, which makes
it possible to have a good zoom experience on a wider
range of input devices.
You can also now zoom by dragging with the right or
middle button if desired.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/3885
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4348
2020-05-24 14:38:28 -04:00
c7daf8a8f3
ADDED: Cross-probe highlighting of bus members
...
Note: this is a basic implementation but it could be
improved once we include bus information in the netlist
and pcbnew can natively keep track of buses and nets
instead of just nets.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4158
2020-05-24 13:30:23 -04:00
4a8d5a2e6c
Fix missing include
2020-05-24 10:55:37 -04:00
1e69f592f6
Rework net highlighting to use connections instead of strings
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1933
Fixes https://gitlab.com/kicad/code/kicad/-/issues/3921
2020-05-24 10:46:05 -04:00
48ab1d1a93
Set sheet pins to bus color if they are a bus in the child sheet
...
As a visual aid, we can peek into the child to see if a pin
represents a bus in the child (in the case of aliases etc
we might not be able to tell by the name of the pin).
Only do this if there isn't anything else driving a connection
onto the sheet pin in the parent sheet.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2619
2020-05-23 23:57:10 -04:00
e934f8b459
Remove python netlist QA facilities
2020-05-23 22:48:09 -04:00
f7578eb038
Implement new native netlist QA test
2020-05-23 21:04:11 -04:00
1c2ef8678c
Use proper refdes sorting for component ordering in netlists
2020-05-23 20:31:41 -04:00
cc47082566
Reset connection graph when loading new root sheet
2020-05-23 20:31:41 -04:00
1a946a7094
Eeschema:Remove import fp assignments from toolbar
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4368
2020-05-23 23:09:37 +00:00
a63df2fbf0
Remove BuildNetListBase from netlisting paths
2020-05-23 13:14:05 -04:00
ca41dc2e66
Clean up extra TODO
2020-05-23 12:53:05 -04:00
de9520d65e
Finish porting netlisters to use CONNECTION_GRAPH
2020-05-23 12:45:24 -04:00
d61b6f965e
Flatten some settings and remove some more globals.
2020-05-23 16:50:33 +01:00
70fb5cac96
Flatten one level of showElectricalTypes settings.
2020-05-23 16:50:33 +01:00
17fad3a9a4
Minor cosmetic fix and enhancement is 2 dialogs.
2020-05-23 09:48:05 +02:00
a6ec225f43
Eeschema sheet pin properties: use combobox
...
Prepopulate with hierarchical labels within the sheet.
Update connection type to match hierarchical label.
2020-05-22 19:56:16 +00:00
14f5ef4078
Eeschema: ensure component edit flags are cleared after loading a schematic file.
...
Fixes #4515
https://gitlab.com/kicad/code/kicad/issues/4515
2020-05-22 20:25:43 +02:00
4cfff6b35d
Libedit: fix crash when right clicking.
...
Fixes #4511
https://gitlab.com/kicad/code/kicad/issues/4511
2020-05-22 09:01:29 +02:00
fca7ade81f
Move to the AUI version of the infobar
...
The sizer-based version had issues with the event processing
inside the GAL panel on Windows systems.
Fixes https://gitlab.com/kicad/code/kicad/issues/4501
2020-05-21 18:22:56 +01:00
a02f4cc7e4
Eeschema: fix project rescue bug.
...
Apparently at some point in our development history, we allowed aliases
to be saved in the cache library. The rescue code was only looking for
root symbols in the cache library which caused missing symbol rescues.
Flattening the symbols ensures the rescue library will have a unique
symbol for every symbol in the schematic. This bug also was in play
when rescuing from the symbol library table.
Fixes https://gitlab.com/kicad/code/kicad/issues/4494
2020-05-21 08:02:45 -04:00
2499a1d640
Remove KIWAY dependence from SCH_PLUGINs
2020-05-20 23:00:23 -04:00
7c7b7f41da
Move SCH_SCREEN project access to SCHEMATIC
...
SCH_SCREEN no longer needs to be a KIWAY_HOLDER
2020-05-20 22:27:48 -04:00
b6d7bc36d0
Ensure component bounding boxes are correct
...
This was causing junctions to not always be added on wire
segments that overlapped component pins, because the pin
might not be part of the component bounding box before
UpdateLocalLibSymbolLinks() is called. When the bbox
was never updated, these symbols weren't collected by
the rtree query for objects overlapping a point.
2020-05-20 18:50:09 -04:00
480588866c
Eeschema: toggle locale when pasting to prevent parsing errors.
2020-05-20 08:08:38 -04:00
c4142a5842
Remaining part of code forgotten by 73a1ce3e
2020-05-20 11:43:50 +01:00
5248f2952e
Use schematic default line width for GetPenWidth on zero-size lines
2020-05-20 00:03:27 -04:00
fbc42a8cb5
Move schematic defaults to SCHEMATIC and add some missing settings entries
2020-05-20 00:03:23 -04:00
b074cdf185
Ensure that eeschema loads project params in standalone mode
2020-05-19 23:57:53 -04:00
e1476dea58
Fix build
2020-05-19 23:57:53 -04:00
73a1ce3e84
Move eeschema find notification to the infobar and improve the infobar widget
...
* Move it to a panel along with the canvas to have a better UI
* Allow the infobar to automatically close after a set time
CHANGED: The eeschema find notifications now use the infobar instead of
a popup window
2020-05-20 02:31:47 +01:00
2bc57ade28
Cleanup parentage inside the draw panels
2020-05-20 02:23:46 +01:00
7bb280ea39
General cleanup.
2020-05-19 20:48:47 +01:00
4e2e280bf4
Fix part adding
2020-05-19 13:24:57 -04:00
28b8e75211
Fix duplicate time stamp bug when loading legacy schematics.
2020-05-19 11:01:00 -04:00
14773d073d
Fix initialization of schematic in legacy plugin
2020-05-19 09:08:49 -04:00
f4d7c323f5
Coverity fixes
2020-05-18 22:58:28 -04:00
a2f027e063
Add an infobar widget to display information above the canvas
...
This widget allows for non-intrusive display of text
above the editing canvas. Currently, this is used
for displaying the read only status of the files.
2020-05-19 00:46:33 +01:00
5a9e69b146
Use the eeschema color theme for the symbol preview canvas
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4484
2020-05-18 17:53:46 -04:00
ad6857f131
Eeschema: fix copy and paste issue when non-C locales are involved.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4449
2020-05-18 15:47:36 -04:00
d7bd4c9b04
Move Eeschema globals to new SCHEMATIC object
...
Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC
they live on: Items will all be parented to the SCH_SCREEN that
they are added to, and each SCH_SCREEN will point back to the
SCHEMATIC that it is part of. Note that this hierarchy is not
the same as the actual schematic hierarchy, which continues to
be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-18 13:04:56 -04:00
e662e33104
Store the current filename in the history on close
2020-05-17 00:12:49 +01:00
613c020920
Move the file history into the frames
2020-05-17 00:12:49 +01:00
d599648ec7
ADDED: Enable color themes for schematic printing
2020-05-16 13:19:43 -04:00
42319e57c6
Clean up libedit color settings
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4433
2020-05-16 09:24:12 -04:00
980aefea4b
Eeschema: fix copy and paste bug.
...
Add required library symbols to new file formatter and parser when copying
schematic symbols to prevent missing library symbol when pasting into a
different schematic which may not have the same library symbol available.
Fix a minor bug where the default schematic symbol reference was not set
by the parser when loading.
Fixes https://gitlab.com/kicad/code/kicad/issues/4442
2020-05-15 15:53:59 -04:00
84160c1da4
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4448
2020-05-15 00:27:19 +01:00
ad88874adf
Use new file formats for copy and paste in schematic and symbol editors.
2020-05-13 18:56:19 -04:00
4a1ee40058
Pretty print bus definitions to the menus.
2020-05-13 16:26:53 +01:00
050191460f
Check for empty bus vectors and allow backwards vector specs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4421
2020-05-13 13:42:23 +01:00
ba301c292a
Check for single item seletion for most property dialogs.
2020-05-13 13:42:23 +01:00
2cf82d9129
fix a wxWidgets minor alert and compil warnings
2020-05-13 08:53:32 +02:00
ed57c3464d
Fix sch parser issue with older file versions.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4417
2020-05-12 20:05:23 +01:00
ec5f7b35a9
Attempt to fix crash with RMB on un-selected graphic line.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4414
2020-05-12 19:48:59 +01:00
724c669434
Move a few more commands to tool framework.
2020-05-12 18:12:38 +01:00
301ac3461c
Fix some more pen width issues from global removal.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4408
2020-05-12 15:20:17 +01:00
06dea92bcb
Fix issues with Kicad Manager frame and new kicad_sch files.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4410
2020-05-12 15:20:17 +01:00
c66bf3df67
Move tool shutdown to after all cancel opportunities.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4401
2020-05-12 00:07:19 +01:00
105f85e551
Fix new bus parsers to correctly handle non-buses.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4403
2020-05-11 22:56:09 +01:00
9ca61b50b6
Check reference designator type when comparing comp
...
example: prevents a 10K NTC resistor from getting grouped with a 10K SMD resistor
2020-05-10 23:54:28 +00:00
0d654b3574
Use dynamic_cast for safety in eeconfig()
...
Calling config() gets you whatever APP_SETTINGS_BASE is returned
by the underlying kiface, which is currently going to be an
EESCHEMA_SETTINGS everywhere this is used, but that isn't a
guarantee.
2020-05-10 18:43:01 -04:00
108cf23892
Restore separate libedit settings for common settings params
...
Be careful when calling config() in eeschema/libedit/pcbnew/modedit
It's usually not the thing you want.
A better fix for #4389
2020-05-10 18:02:58 -04:00
1cfcfc3ca7
Fix some formatting issues in syntax help.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4233
2020-05-10 22:34:40 +01:00
1a1ecd8ce1
Rearrange some code to keep from hitting a wxGrid d'tor bug.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4384
2020-05-10 19:42:45 +01:00
df5b093fda
Fix missing GetWindowSettings for LIB_EDIT_FRAME
...
Fixes #4389
2020-05-10 14:28:41 -04:00
cbe4b79107
Add syntax help for bus definitions (and upgrade parser to handle them).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4233
2020-05-10 18:40:06 +01:00
cc1ebca242
Add syntax help to pin dialogs.
2020-05-10 18:40:06 +01:00
f3a5f5b6ca
Don't resync the screen before we've changed it back.
...
Fixes: lp:4382
* https://bugs.launchpad.net/kicad/+bug/4382
2020-05-10 18:40:06 +01:00
bc24d8e957
Fix typo and I18N string
2020-05-10 16:55:15 +02:00
8c2aee1261
Eeschema: fix new schematic file format image parser buffer size.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4387
2020-05-10 08:47:42 -04:00
632494cba7
Add missing includes
...
A few more instances of missing <algorithm> for std::max
2020-05-10 00:24:11 +02:00
a81286d9ea
Fix infinite loop bug in new schematic file format image parser.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4362
2020-05-09 14:20:27 -04:00
ee08baca03
Eeschema: fix issue when saving a S expr symbol library in countries using comma as fp separator
...
Fixes #4381
https://gitlab.com/kicad/code/kicad/issues/4381
2020-05-09 19:39:08 +02:00
b29f55c1ca
Cosmetic minor changes for 2 icons.
...
Avoid using the same icon for 2 different actions in the same screen or menu.
2020-05-09 16:22:29 +02:00
04057423a9
A bit of cleanup.
2020-05-09 14:14:38 +01:00
d645c22411
Allow path separators in the sheet filename validator.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4374
2020-05-09 00:04:29 +01:00
8ef66732e4
Add syntax help for text markup.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4233
2020-05-08 23:30:33 +01:00
ae102c7411
Remove bogus assert. Also fix const leak.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4367
2020-05-08 23:30:33 +01:00
3c3984a6fc
Generalize default footprint fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2289
2020-05-08 23:30:33 +01:00
35f3eb6220
Eeschema: fix large diffs when saving schematics.
...
Apparently the < operator was never implemented for SCH_JUNCTION objects
so they were not get sorted which was causing the large diffs between
schematic saves.
Fixes https://gitlab.com/kicad/code/kicad/issues/4369
2020-05-08 16:01:14 -04:00
1840fe351e
Eeschema: fix assertion when duplicating a sheet.
...
The duplicate sheet code path assigned a SCH_SCREEN object instead of a
SCH_SHEET object as a parent. A recently added assertion to check for
this did it's job.
Fixes https://gitlab.com/kicad/code/kicad/issues/4369
2020-05-08 14:57:44 -04:00
62d72ae081
Eeschema: fix new symbol library file format parser bug.
...
LIB_FIELD objects require a LIB_PART as a parent. Add missing parent on
symbol library load.
Fixes https://gitlab.com/kicad/code/kicad/issues/4360
2020-05-08 13:34:21 -04:00
302646cb3c
Check for null parent in GetFullText
...
Fixes #4360
2020-05-07 20:31:06 -04:00
bc0fc0bb3a
Eeschema: fix broken net list items in schematic symbol object.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4358
2020-05-07 16:28:59 -04:00
61e981be17
Symbol editor: fix broken alternate body style toolbar state.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4329
2020-05-07 15:55:04 -04:00
73e1496b25
Change attached-label algorithm.
...
Rather than try and keep moving with other items, calculate nearest
point on current line to original label at each step.
Fixes https://gitlab.com/kicad/code/kicad/issues/4347
2020-05-07 18:59:47 +01:00
f0cda374a0
A few more visual adjustments to the new note text.
2020-05-07 17:51:27 +01:00
8efa8af8cc
Add persistence of DRC error severities.
2020-05-07 17:51:27 +01:00
3fbc2f9035
Symbol editor: adding a new library should not create legacy format.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4346
2020-05-07 11:25:48 -04:00
26803f54f0
Eeschema: fix sheet file extension warning.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4351
2020-05-07 10:28:47 -04:00
e253862f77
Eeschema: remove automatic conversion of time stamp UUIDs.
...
In order to avoid confusion when loading legacy schematics, updating time
stamp UUIDs is no longer performed. If users where not experiencing issues
with time stamp clashes with shared schematics then this was probably a
case of me being overly cautious.
The original conversion code has be moved to
SCH_EDIT_FRAME::ConvertTimeStampUuids() so the working functionality is
not lost. This function should not be used until a way is found to update
the board from the schematics with the appropriate settings.
2020-05-07 09:26:43 -04:00
c92181621e
Use strong check for bus label when netlisting
...
Fixes #4318
2020-05-06 18:27:03 -04:00
241fc3166b
Implement a symbol type filter for Edit Text and Graphics.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4334
2020-05-06 22:57:14 +01:00
1443d69f00
Move the import non-kicad schematic item to the import submenu
...
This matches its location in Pcbnew.
2020-05-06 22:37:40 +01:00
d56dced0ab
Fix dialog grow behaviour.
2020-05-06 20:38:12 +01:00
51e72ed9ba
Finish the collect-attached-labels rewrite.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4341
2020-05-06 20:38:12 +01:00
54caebb04a
Fix translation issues and a typo
2020-05-06 20:41:29 +02:00
f6d1aa1f42
Fix some failures to drop hover selections after executing a command.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4330
2020-05-06 19:02:21 +01:00
001a50bf14
Moved PANEL_COLOR_SETTINGS from buttons to swatches.
...
This allows us to correctly display non-100%-opacity colors (ie:
over the correct background color).
2020-05-06 19:02:21 +01:00
d0217e38cd
Some clean-up from last merge.
2020-05-06 19:02:21 +01:00
1f9723cf62
Reconcile new Sheet Fields and new S-expr file format.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4327
2020-05-06 15:48:58 +01:00
0f34fc2e5f
Simplify the "pick up attached labels" logic.
...
This should vastly reduce the number of side-effects we were seeing.
Fixes https://gitlab.com/kicad/code/kicad/issues/4311
Fixes https://gitlab.com/kicad/code/kicad/issues/git
Fixes https://gitlab.com/kicad/code/kicad/issues/4320
2020-05-06 15:48:58 +01:00
7d7e0143e4
Fix note text to correct location of text offset ratio property.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4323
2020-05-06 15:48:58 +01:00
d0c3c11e59
Eeschema: fix crash when resetting schematic symbol fields from library.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4336
2020-05-06 10:43:08 -04:00
91494fc561
Eeschema: add missing bus alias support to new schematic file format.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4335
2020-05-06 09:27:01 -04:00
7911bc431a
Fix segfault when starting LIB_VIEW_FRAME
2020-05-05 21:46:00 -04:00
e4b6487fca
Overhaul compiler warnings infrastructure
...
* Track our warnings separate from normal flags
* Remove all warnings from the SWIG code
* Add more GCC warnings
2020-05-06 01:47:20 +01:00
2148c593d6
Fix some compile warnings
2020-05-06 01:46:09 +01:00
aa9e74493f
Eeschema: fix netlist creation crash when opening spice simulator.
2020-05-05 18:35:27 -04:00
590a101a88
Eeschema: fix update schematic symbol library link bugs.
2020-05-05 18:06:43 -04:00
00716e362a
Eeschema: simplify updating symbol alternate body style.
...
Move updating the pin maps from external code to the SCH_COMPONENT object
when changing the symbol body style (DeMorgan). This is a vein attempt
to make the SCH_COMPONENT object self contained so we don't have to depend
on the caller needing to figure out how to keep internal objects synced.
2020-05-05 16:42:59 -04:00
9c99286385
Fix a few Coverity warnings.
2020-05-05 16:42:59 -04:00
9e4125c451
Add note on spacing to Global Label Properties dialog.
...
Also cleans up some of the other notes to have a uniform presentation.
Fixes https://gitlab.com/kicad/code/kicad/issues/4323
2020-05-05 20:33:20 +01:00
df37887b1f
Factor line width into global label shape.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4323
2020-05-05 20:26:51 +01:00
67bccaf465
Make indeterminate control states clearer for the user.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4313
2020-05-05 20:26:51 +01:00
a06fa22b8a
Eeschema: remove rogue calls to SCH_SCREEN::UpdateSymbolLinks().
...
SCH_SCREEN::UpdateSymbolLinks() should only be called when working with
the legacy schematic file format. Add schematic symbol library symbol
links should be set using SCH_COMPONENT::SetLibSymbol() which updates
the symbol link and pin map accordingly.
Change the schematic symbol LIB_ID edit dialog to properly use the new
SCH_COMPONENT::SetLibSymbol() function.
2020-05-05 12:52:17 -04:00
5cf474e1c8
Eeschema: fix bugs in symbol edit properties dialog.
...
Use flattened (root) library symbols to prevent broken library symbols
in schematic files.
Remove the edited symbol from screen before making changes to the symbol
to prevent potential orphaned symbol libraries being saved in schematic
file.
Add some defensive programming to let developers know that an invalid
library symbol link was used when calling SCH_COMPONENT::SetLibSymbol().
2020-05-05 10:56:23 -04:00
0ef97ac486
Eeschema: add missing alternate body style to new schematic file format.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4321
2020-05-05 09:15:13 -04:00
c18a7b42ee
Eeschema: fix crash when updating board from schematic.
...
Removed some rogue calls to SCH_SCREEN::UpdateSymbolLinks() which should
only be called the last time the schematic is loaded from the legacy file
format. After that, all symbol library links should be changed using
SCH_COMPONENT::SetLibSymbol() which will prevent the pin maps from ending
up with broken symbol library pin links.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4318
2020-05-04 19:34:24 -04:00
a8407fba4c
Fix schematic field index bug in s-expression file format plugin.
2020-05-04 12:40:03 +00:00
169f63a6c0
Eeschema: make schematic sharing truly safe across all designs.
...
There has been a long standing (since the beginning of the project?)
issue with sharing schematics between projects. It has been somewhat
supported for complex hierarchies (a sheet shared multiple times in a
single design) but it has not been well supported for simple hierarchies
(the symbol references cannot be changed in the shared schematic). This
issue has been resolved by moving all of the symbol instance sheet paths
from the symbol definitions in the all of the project files and save all
symbol path instances in the root sheet. This ensures that orphaned
symbol instance paths do not accumulate in shared schematic files and
that designs that reuse schematic in simple hierarchies can how have
different references. It also allows the root schematic from one project
to be uses as a sub-sheet in another project.
When legacy schematics are loaded, all sheet and symbol UUIDs are
converted from time stamps to true UUIDs. This is done to ensure there
are no sheet path instance clashes between projects. That being said,
there are no checks for this. It is assumed that the probability of
UUID clashes is so low that it doesn't make sense to test for them.
2020-05-04 12:40:03 +00:00
7183e9f97e
Make the new schematic and symbol library file formats the default.
...
This is a very large and potentially disruptive change so this will be an
unusually long and detailed commit message.
The new file formats are now the default in both the schematic and symbol
library editors. Existing symbol libraries will be saved in their current
format until new features are added to library symbols. Once this happens,
both the legacy schematic and symbol file formats will be no longer be
savable and existing libraries will have to be converted. Saving to the
legacy file formats is still available for round robin testing and should
not be used for normal editing.
When loading the legacy schematic file, it is imperative that the schematic
library symbols are rescued and/or remapped to valid library identifiers.
Otherwise, there will be no way to link to the original library symbol and
the user will be required manually set the library identifier. The cached
symbol will be saved in the schematic file so the last library symbol in
the cache will still be used but there will be no way to update it from the
original library.
The next save after loading a legacy schematic file will be converted to
the s-expression file format. Schematics with hierarchical sheets will
automatically have all sheet file name extensions changed to .kicad_sym
and saved to the new format as well.
Appending schematics requires that the schematic to append has already been
converted to the new file format. This is required to ensure that library
symbols are guaranteed to be valid for the appended schematic.
The schematic symbol library symbol link resolution has been moved out of
the SCH_COMPONENT object and move into the SCH_SCREEN object that owns the
symbol. This was done to ensure that there is a single place where the
library symbol links get resolved rather than the dozen or so different
code paths that previously existed. It also removes the necessity of the
SCH_COMPONENT object of requiring any knowledge of the symbol library table
and/or the cache library.
When opening an s-expression schematic, the legacy cache library is not
loaded so any library symbols not rescued cannot be loaded. Broken library
symbol links will have to be manually resolved by adding the cache library
to the symbol library table and changing the links in the schematic symbol.
Now that the library symbols are embedded in the schematic file, the
SCH_SCREEN object maintains the list of library symbols for the schematic
automatically. No external manipulation of this library cache should ever
occur.
ADDED: S-expression schematic and symbol library file formats.
2020-05-04 12:40:03 +00:00
12d1d3a844
Pcbnew: fix not wanted changes in .kicad_pcb files when the board has no changes.
...
Some items (tracks and footprint graphic items) when reading were added in reverse order
of the initial file, creating useless differences and breaking source comparisons.
2020-05-04 14:01:35 +02:00
c155d80213
User configurability of pin electrical symbol size.
...
Also fixes a bug where a bunch of eeschema settings weren't getting
loaded because it looked like they were larger than the max value
(which wasn't being scaled from mils to internal units).
Fixes https://gitlab.com/kicad/code/kicad/issues/2089
2020-05-04 00:56:32 +01:00
da1a89fc7e
Allow users to control the order of sheets through sheet fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2394
2020-05-03 23:27:30 +01:00
5bed201a23
Don't collect connected labels on a paste.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4311
2020-05-03 21:47:53 +01:00
0370eff7ba
Add sheet number processing to sheet fields.
...
Also fixes a bug where we were depending on the old deque stuff's
deterministic traversal, which isn't provided by the new RTree stuff.
Fixes https://gitlab.com/kicad/code/kicad/issues/2433
2020-05-03 20:56:32 +01:00
05afbcc22e
library viewers: fix a focus issue that prevent using arrow keys in lib or fp lists.
...
Once the gal canvas hsad the focus, it was not possible to use arrow keys in library
or symbols or fp lists even after clicking on an item.
This focus issue is now fixed.
Fixes #4292
https://gitlab.com/kicad/code/kicad/issues/4292
2020-05-03 20:11:33 +02:00
7554a2df30
Eeschema, library viewer: fix some render options, especially default line thickness
2020-05-03 15:38:28 +02:00
c9d549ffba
Eeschema: minor update symbol fields dialog layout improvements.
2020-05-03 08:40:31 -04:00
1c82fc9465
Eeschema: minor sheet properties dialog layout improvements.
2020-05-03 08:24:08 -04:00
199bb2ffb0
Add hittesting for worksheets in Pcbnew and Eeschema.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4282
2020-05-03 00:07:38 +01:00
055ab92797
Fix symbol library table dialog padding.
2020-05-02 18:42:45 -04:00
9d6b987ecc
Fixes to map pin-to-pin erorrs to new Warning/Error strucutre.
2020-05-01 18:49:42 +01:00
874f13e29e
Fix some issues with rotated oval pads.
2020-05-01 18:49:42 +01:00
a56191b658
Add distances to a bunch of DRC violation reports.
2020-05-01 18:49:42 +01:00
4b4952b09a
Add short-circuits for regex testing
2020-04-30 19:53:25 +00:00
cf15a1c493
Cache SCH_SHEET_PATH recursion test results
2020-04-30 19:53:25 +00:00
f4f43f51c8
Cache connection names
2020-04-30 19:53:25 +00:00
1204b9cbef
Use cached pins in SCH_COMPONENT::GetEndPoints()
2020-04-30 19:53:25 +00:00
2eaefb4874
Improve performance of schematic load and connectivity
...
Store component paths and references efficiently
Remove redundant calls to RecalculateConnections
2020-04-30 19:53:25 +00:00
b26e9520b3
DIALOG_EDIT_SHEET_PIN: allows only the text size to be edited (and sizeX = sizeY).
...
In Eeschema, texts are expected to have the same size X and size Y.
So we cannot set 2 different values for X and Y pin size:
- only size X is saved in file
- 2 different values for X and Y create bad look for pin + associated graphic symbol
Allowing separte values need a file format change *and* a code change.
2020-04-30 10:33:53 +02:00
687c2f3e82
eeschema: fix a readability issue for small texts.
...
Texts were drawn with a minimal line thickness = GetDefaultPenWidth().
The default pen width can be to large for small texts.
So the actual text thickness is now always clamped.
2020-04-30 09:38:23 +02:00
d10c8cd75b
Sheet pins: fix incorrect size and plot thickness of the graphic symbol.
...
Unlike the global labels, the hierarchical label is not inside the graphic symbol.
So the graphic symbol size depends only of the text size, not of the text offset.
2020-04-29 17:46:36 +02:00
62d78cdf49
erc_item.cpp: fix issue that created broken error list in panel setup severities
...
Fix a minor Coverity warning.
2020-04-29 15:30:31 +02:00
1daa2224d0
Tidy up the layout of the Colors Editor.
2020-04-27 11:59:57 +01:00
d006acecf4
More window sizing fixes
...
* Push all sizing operations into EDA_BASE_FRAME
* Save the unmaximized window size when maximizing
so that we can then save it in the config if the
window is maximized. Otherwise the config ends up
with the maximized size saved, and weird behavior
occurs when unmaximizing on the next opening.
2020-04-27 00:14:12 +01:00
1a8082c6d6
Eeschema: fix partial schematic load bug in the legacy plugin.
...
Move the hierarchical sheet loading outside of the try exception block
so that any sheets that were loaded when a schematic file load fails
are loaded rather than skipped. This allows more of the schematic to
be loaded when any parser errors occur.
2020-04-26 15:47:25 -04:00
fa57c8a570
Eeschema: fix sheet bug in schematic editor drawing tool.
...
SCH_SHEET objects can only have another SCH_SHEET object as a parent
or nullptr for the root sheet so overload EDA_ITEM::SetParent() to
prevent the parent from being set to another type of object and add
some checks to the root sheet code just in case someone gets clever
and attempts to bypass the overloaded SetParent() call.
2020-04-26 14:27:51 -04:00
349ec2031b
Eeschema plot worksheet: use the color defined in Eeschema settings.
...
Fixes #4265
https://gitlab.com/kicad/code/kicad/issues/4265
2020-04-26 09:06:02 +02:00
4f369801f2
Fix a few compil and Coverity warnings.
2020-04-25 08:49:16 +02:00
99dcadf7e6
Introduce new KI_FALLTHROUGH macro
...
Annotate purposeful fallthroughs in switch statements with the
KI_FALLTHROUGH macro.
2020-04-25 00:44:09 +01:00
49c46dc796
Fix typo.
2020-04-24 23:22:11 +01:00
2fb2eac4d5
Performance enhancements.
2020-04-24 22:17:45 +01:00
32db9eb0f1
Add some distances to a few DRC errors.
2020-04-24 22:17:45 +01:00
e14e3faed6
Use resolved text for connections.
2020-04-24 22:17:45 +01:00
1535c83b88
Lay some groundwork for adding distances to DRC errors.
...
modified: eeschema/lib_rectangle.cpp
2020-04-24 14:46:22 +01:00
cb89e18281
Get rid of the visible axes in Eeschema.
2020-04-24 14:46:22 +01:00
7308099852
Add an icon and put Schematic Setup in the toolbar.
2020-04-24 14:46:22 +01:00
69db66e1ea
Fix saving of pcbnew colors when edited from layers widget
2020-04-23 22:33:02 -04:00
2d95270a31
Add color theme settings to pcbnew
2020-04-23 21:55:29 -04:00
facf40d3ce
libedit: Add drag to move behavior
...
ADDED: Drag to move behavior in the symbol editor
Fixes https://gitlab.com/kicad/code/kicad/issues/1904
2020-04-23 23:58:33 +01:00
f7ebf2af5e
Add separate color setting for bus junctions
...
Fix plotting and printing to use bus color when
connectivity detects that the junction is on a bus.
Fixes #4098
2020-04-22 21:55:48 -04:00
615ad9abfc
Check sheet file extension when editing, and add if missing when reading.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4107
2020-04-22 21:27:33 +01:00
fe383efb93
That gcc is a squirrelley beast...
2020-04-22 12:35:32 +01:00
1fdaac3440
Safer way to do std::string conversions.
2020-04-22 12:31:06 +01:00
857aca78cd
More std::string vs. wxString compile issues.
2020-04-22 12:28:25 +01:00
61f28f0958
Fix build error on gcc
2020-04-21 19:29:34 -04:00
93d0f19e3f
Fix compile error on linux (perhaps all gcc platforms?).
2020-04-21 22:53:33 +01:00
f3a2495757
Fix compile issue on GTK (or possibly just with some versions of wxWidgets).
2020-04-21 22:19:36 +01:00
da7205ff32
Re-implement negative-width-means-don't-stroke hack.
2020-04-21 21:17:59 +01:00
1916ea868b
Highlight current row in Edit Symbol Fields, and save col widths.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4235
2020-04-21 21:17:59 +01:00
f113370e1e
Edit worksheet properties when no other selection is available.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4044
2020-04-21 21:17:59 +01:00
83cb9c0d14
Fix a few Coverity and compil minor warnings. Remove dead code
2020-04-21 12:47:48 +02:00
d7d1ea33ac
Check for conflicts before promoting sheet pins to be strong drivers
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4201
2020-04-19 19:13:24 -04:00
b802a3e776
Add command-line option to generate netlist and exit
2020-04-19 19:13:24 -04:00
7e4d255cdd
Apply Scintilla hack to get auto-sizing canvas.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4207
2020-04-19 20:09:43 +01:00
a286cb5a8f
Keep labels on dragged wires.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2107
2020-04-19 18:24:39 +01:00
71fd560735
Add "Export to other sheets" to paper settings.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2177
2020-04-19 18:24:39 +01:00
895f46da8f
Another attempt to fix the textbox scrollbars on GTK.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4207
2020-04-18 21:41:20 +01:00
2b6089240a
Change super/subscript syntax to ^{foo} and _{foo}.
2020-04-18 21:04:41 +01:00
42cd604c3c
Expose Show Hidden Fields to GUI.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2010
2020-04-18 16:36:51 +01:00
d7d1cb6f78
A bunch of fixes to Eeschema Find/Replace.
2020-04-18 14:43:08 +01:00
98b9c80eb4
Schematic editor: fix not working tool to show/hide invisible pins.
...
Fixes #4222
https://gitlab.com/kicad/code/kicad/issues/4222
2020-04-18 09:57:04 +02:00
3b67e3d0a4
Rewrite window positioning logic
...
Now only reposition a window if it is completely on a
disconnected display or if only one corner is on screen
and it is within a region close to the screen border.
CHANGED: Window position on startup should be preserved more
2020-04-18 00:47:38 +01:00
7526d2affb
Fix possible null-dereference.
2020-04-17 21:13:56 +01:00
0dfdc37ae7
Clean up label spacing to be more predictable.
...
Don't try to use complex algorithms taking into account default
margins, line-widths and pen-widths (especially when they differed
between label types). We now use the (user-controlled) text
offset ratio to determine the margins (from the center-point of
the attached line).
2020-04-17 14:47:57 +01:00
66059d6d55
Remove scrollbars from multi-line text ctrl.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4207
2020-04-16 20:36:12 +01:00
96db1c7b1e
Add pin reference to PINLABEL for use when generating ERC marker.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4208
2020-04-16 19:53:03 +01:00
37023da56f
Tidy some compiler warnings.
2020-04-16 17:34:46 +01:00
9c8941e040
Remove a bunch of globals.
2020-04-16 17:34:46 +01:00
25d7c0cae2
Opencascade: fix min version: OCE=0.18, OCC=6.9.0
...
Fix also a few minor Coverity warnings.
2020-04-16 10:22:20 +02:00
fdccdd5cb9
Eeschema: adding .op SPICE simulation support
...
ADDED new tab on simulation settings dialog, which allows to run .op analysis.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2368
2020-04-15 01:51:58 +00:00
952e7a5fb4
Eeschema: move some default values to default_values.h.
...
These default values are used in many files, and some files were using
magic numbers.
2020-04-14 20:15:18 +02:00
4a2a5a9403
qa_eeschema: fix a crash due to LIB_PIN ctor that was using default config values,
...
but in QA tests, we do not have config values available.
2020-04-14 18:12:15 +02:00
a49deec278
Eeschema: fix crash when plotting in HPGL format.
2020-04-14 13:50:09 +02:00
6148461484
Eeschema plot: fix (temporary) line 0 thickness.
...
Plotting lines having 0 thickness is not acceptable and create issues.
2020-04-14 12:43:51 +02:00
04ea20dd44
Eeschema, SCH_PAINTER: fix max text thickness issue, to have small texts readable.
2020-04-14 11:08:42 +02:00
6e800bddae
Rationalize penWidth processing as first step in removing some globals.
2020-04-13 20:58:13 +01:00
d014dc47ab
Finish moving text markup flags to project-level settings.
2020-04-13 20:58:13 +01:00
122b1ddaae
Unwrap an unnecessary layer now that we have new config stuff.
2020-04-13 20:58:12 +01:00
5405c09b81
Eeschema: avoid initializing default line thickness to 0: it can create issues.
...
Some graphic line thickness were initialized to 0.
The actual line thickness is set after reading config.
But in some cases the config does not exist, and 0 line thickness creates draw issues.
2020-04-12 19:50:33 +02:00
bcf31ef3d1
DIALOG_SCHEMATIC_SETUP: fix incorrect parent of some sub-page panels.
...
These panels must have the wxTreeBook as parent to receive mouse and key events.
They previously have the dialog itself, but it does not work on any OS.
2020-04-12 18:17:57 +02:00
c82679a6f2
Fix crash bug when highlighting no net (found by Coverity).
2020-04-12 11:19:44 +01:00
bdada70ee7
Cosmetic enhancements: add bitmaps to a few context menus.
...
Fix also a minor compil warning.
2020-04-12 10:29:28 +02:00
292a9fadd9
Allow a click in the value field when searching for power nodes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4180
2020-04-11 23:51:00 +01:00
350696ecdd
Only convert references to KIIDs if the variable resolves.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2458
2020-04-11 20:47:44 +01:00
dbded3e5dc
Make sure to check for unit designator when converting to KIIDs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2458
2020-04-11 20:47:44 +01:00
505d8bf56e
Allow ':'s in field name references in text variables.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2458
2020-04-11 20:47:44 +01:00
c66fe5e91e
Don't try to add unit designator for a component without multiple units.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2458
2020-04-11 20:47:44 +01:00
48a0f25ce6
EE_COLLECTOR::Collect(): fix an issue when called with filter = SCH_LOCATE_ANY_T.
...
When the filter = SCH_LOCATE_ANY_T, components and sheets were selected twice, one
from the main loop, and one from specialized loops for SCH_COMPONENT_T and SCH_SHEET_T.
2020-04-11 16:08:10 +02:00
8854b799e8
Fix a minor spelling error.
...
Also changes the capitalisation of a string which isn't used, but looks
so wrong in FormBuilder that I couldn't help fixing it.
2020-04-11 13:06:45 +01:00
c4994eee7b
Fix a pair of bugs in the new highlight net logic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4180
2020-04-11 13:02:18 +01:00
096564ec0c
Fix some typos and I18n issues
2020-04-11 08:57:46 +02:00
84944524cc
Fix crash on OSX when page was changed before hack array was alloc'ed.
2020-04-10 22:49:56 +01:00
dac78d2562
fix a few minor Coverity warnings.
2020-04-10 18:28:12 +02:00
962aa73e12
Improve EE_COLLECTOR to not miss children of sheets or symbols.
...
Also implements pin highlighting and special cases for power symbols.
Fixes https://gitlab.com/kicad/code/kicad/issues/4180
2020-04-10 14:09:26 +01:00
b067e441c7
Show/hide sheet colors when flipping override flag.
2020-04-10 00:35:17 +01:00
f4e22a9264
Add ability to override individual item colors.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4167
2020-04-09 17:17:27 +01:00
317e98b344
Simplify user model for editing color themes.
2020-04-08 22:34:56 +01:00
6e593aa1e0
SCH_BASE_FRAME::FocusOnItem() fix incorrect calculation of a pin physical position.
...
Only ERC dialog was affected: when clicking on a error item, if the item is a pin
the cursor was put far from the right location.
2020-04-08 11:06:41 +02:00
cb7263d017
Eeschema: fix ERC dialog not shown after a double click, when recalled by tool ERC.
...
(the dialog was reactivated by calling Raise(), but this is not enough: Show()
must be called also, at least on Windows).
Fix also a minor wxWidgets alert in ERC dialog.
Fixes #4171
https://gitlab.com/kicad/code/kicad/issues/4171
2020-04-08 10:03:51 +02:00
6aaee01f1c
Generalize fill parsing and add support for sheet background R/W.
...
Also fixes a bug in colour parsing (the alpha channel is a float).
2020-04-07 17:29:58 +01:00
Jeff Young
Seth Hillbrand
Roberto Fernandez Bautista
RigoLigoRLC
Wayne Stambaugh
Marek Roszko
Zoltan Gyarmati
Jon Evans
jean-pierre charras
Mikolaj Wielgus
Thomas Pointhuber
Ian McInerney
Sylwester Kocjan
david-beinder
Sylwester Kocjan
Michael Kavanagh
Electro707
Dominik Wernberger
Konstantin Baranovskiy
Ola Rinta-Koski
Alexis Lockwood
Slawomir Siudym
Franck Jullien
Peter Montgomery
PJM
aris-kimi
Franck Jullien
Tomasz Wlostowski
Mateusz Majchrzycki
Simon Richter
ferdymercury
Kevin Lannen
bjpiccioni
Fabien Corona
Tormod Volden
Frank Severinsen