df84a90f6c
Turn down timeouts for socket connection
2021-03-23 17:43:24 -04:00
a94a481574
Fix compile warnings
...
Some simple warnings and also a deprecation warning from wx
because they felt that a function should be renamed...
2021-03-23 19:46:49 +00:00
41f88dbabc
Refactor platform-specific init into two phases
...
The first phase is for the environment before the OS
apps are created, and the second phase is for after
the OS app is created but before all of our processing.
Fixes https://gitlab.com/kicad/code/kicad/issues/7992
2021-03-23 19:11:08 +00:00
41d97e0007
Fix thread cleanup issue on Windows/msys2
2021-03-23 13:39:20 -04:00
9020611657
Cleanup
2021-03-22 23:42:48 -04:00
4dbeb15024
Use a worker thread to send socket commands
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6503
2021-03-23 03:20:40 +00:00
d96cccbf20
OpenGL GAL tracing improvements.
2021-03-22 17:45:49 -04:00
f24f0d93a5
Make OK default in inspectors (and hook up to close window).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7831
2021-03-22 21:20:54 +00:00
e0fdfbe1d5
createThemeList takes a filename, not a name
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7075
2021-03-21 21:03:01 -04:00
cc8413c841
Tweak default zoom settings for Windows
...
Acceleration seems to be worse than constant on many
systems, so let's turn it off by default.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5434
2021-03-21 19:46:23 -04:00
35438d3533
Add more bounds checking in KIwxExpandEnvVars
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7461
2021-03-21 20:13:20 +00:00
cdb352bb24
Allow finding kicad_3dsg when running from build dir
...
This might also come in handy later when we use more dynamic libs
2021-03-21 09:16:47 -04:00
9a13835f5d
Allow running release builds from build dir also
2021-03-20 21:03:19 -04:00
c291162567
Use KICAD_DATA to find stock libraries on Linux
...
Use the KICAD_DATA build-time variable to determine the default stock
library search path on Linux instead of relying on DEFAULT_INSTALL_PATH
in combination with hardcoded folder names. The search logic for Windows
and macOS is refactored but remains unchanged.
2021-03-21 00:28:33 +00:00
e9eb5a5e21
Refactor definition of stock data path
...
It is not always useful to distinguish between the cases when KiCad is
run from the build or the installation directory. E.g., the libraries
are generally not available in the same path as the code. Make the
evaluation of KICAD_RUN_FROM_BUILD_DIR conditional to accomodate these
scenarios.
2021-03-21 00:28:33 +00:00
eb5a85ba91
Fix coding error in DoubleValueFromString.
2021-03-20 21:53:30 +00:00
d9229697d8
altium: special string override map should be case-insensitive
...
This only fixes overrides where we explicitly map an override. Wrongly written variables pointing to fields are not corrected by this.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6256
2021-03-20 20:42:25 +01:00
cd26db24f9
altium: allow text in special strings
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6256#note_529783269
2021-03-20 19:25:57 +01:00
6924b98bc3
Remove deprecated BRIGHT_BOX preview item
2021-03-20 12:09:20 -04:00
c04e19f9ac
Include optimization: move some things from common.h to point-of-use
2021-03-20 12:09:18 -04:00
b1fa02bcc8
Push a non-existent ref's value as 0. (Don't just crash.)
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7971
2021-03-20 11:05:38 +00:00
f0e6f812ff
Edit One Field improvements.
...
1) Accept <enter> as OK if the multiline textbox isn't shown.
2) Focus and select all in first control if multiline textbox isn't shown.
3) Make title be title caps ("Edit Sheet name Field" looked dorky).
Fixes https://gitlab.com/kicad/code/kicad/issues/7940
2021-03-20 00:41:09 +00:00
b4e2db5913
Improve dialog layout.
2021-03-20 00:41:09 +00:00
cc9787e47a
Make sure space for message is reserved in APP_PROGRESS_DIALOG
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7953
2021-03-19 19:11:32 -04:00
812d38736e
Naming conventions.
2021-03-19 23:06:19 +00:00
3036683a2c
Move platform-specific init tasks into KIPLATFORM
2021-03-19 21:26:07 +00:00
7b4890e578
Cleanup memory in the asset archive reader
2021-03-19 21:23:35 +00:00
6c3b02aabe
Cleanup (no functional changes).
2021-03-19 16:14:34 +00:00
7231f1dc68
Fix caching strategy
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7960
2021-03-19 12:13:00 -04:00
2fc34bf59c
Protect from use of a null pointer.
2021-03-19 15:01:16 +01:00
472d0e03fc
Remove unused color layer
2021-03-18 22:30:24 -04:00
fee3c41c40
Force string to utf8 before trying to pass it to url encoding
...
Fix #7878
2021-03-16 23:04:52 -04:00
045160d486
Work around wxProgressDialog layout bug
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4288
2021-03-16 20:44:24 -04:00
6d502cb2a5
Don't generate real random UUIDs while loading libraries
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7921
2021-03-17 00:43:13 +00:00
46d71f0d23
Go back to validate-on-OK, but stop doing design checks.
...
If we keep doing design validations at two different places, they can
only start to drift apart. Board Setup should validate for malformed
data ONLY; everything else is the business of DRC.
This also fixes a bug where implementation validations would not allow
OK in the dialog, but wouldn't put up a message to say why. We now use
the InfoBar impl from Jon's commit for that.
2021-03-16 14:49:03 +00:00
c3c3649211
Stop text from causing a shift during flip when >1 items are selected
...
1e1be730https://gitlab.com/kicad/code/kicad/issues/7304
2021-03-15 21:24:16 +00:00
b2ac9cc29f
Formatting & naming conventions.
2021-03-15 19:04:59 +00:00
4e438763a3
Use the same StringFromValue() formatting in Eeschema as in other tools
2021-03-15 15:43:36 +00:00
a9f86c6f3d
Enable icon themes for Windows
...
Windows 10 "dark mode" is not supported and likely won't be,
but high-contrast mode and manual color theme editing is still
possible.
2021-03-14 15:39:47 -04:00
4482b3baba
altium: Handle special strings and convert them into KiCad variables. Use Comment for VALUE.
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6256
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/7736
2021-03-14 16:40:36 +01:00
953279ce70
Gerber plot: fix missing AperFunction attribute for texts.
...
Fix also a incorrect AperFunction attribute for graphic items on Edge.Cuts
in footprints
2021-03-14 12:37:13 +01:00
03b280589e
Enable dark icon theme for GTK
2021-03-13 10:54:50 -05:00
e38fe842e2
Don't crash when loading bitmaps before settings exist
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7900
2021-03-13 09:54:07 -05:00
b71ab01de4
More wxWidgets 3.1 layout adjustments.
2021-03-13 00:00:38 +00:00
faf9cca938
Fix many cases of old mils flag getting interpreted as allowEval flag.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7883
2021-03-12 15:15:50 +00:00
ba46a8d12d
Fix some layout issues resulting from wxWidgets version bump.
2021-03-12 14:54:54 +00:00
77d7eae7c3
Fix availability of "other"-sized bitmaps; update some comments
2021-03-11 17:16:49 -05:00
44f88f840c
Bitmaps: a few improvements from review
2021-03-11 08:37:35 -05:00
405fa183b2
Add icon theme selection behind advanced config flag
2021-03-11 08:37:35 -05:00
18037e2f65
Rework bitmap system to load from archived PNGs
...
Bitmaps are now identified by an enum class instead of by pointers.
Bitmap loading and caching is now handled by a class in common, and
we no longer compile most bitmaps into the binary, so there is no
longer a bitmaps static library.
Instead, bitmaps are archived to a .tar.gz file which is installed
in ${KICAD_DATA}/resources/images.tar.gz
The source PNGs are checked in to Git as the original CPP files were,
so that people can build without the required dependencies to convert
SVGs to PNGs.
Initial support is also added for dark theme icons, although this
is not yet exposed in the GUI.
Stubs are present for multi-resolution image resources, but this is
not fully-baked yet and could use some refinement.
2021-03-11 08:37:35 -05:00
3809f19ce3
Consistent layout.
2021-03-10 16:00:28 +00:00
b47453a93b
Fix app names in Quit menu items on Mac.
2021-03-09 16:45:33 +00:00
7ef9082c86
altium: add unit-tests for ReadProperties() and fix some issues found while doing so
2021-03-08 23:03:00 +01:00
e2aa7be4b3
Added a lot of consts and refactored a few lines
2021-03-08 12:49:48 -08:00
3d563af758
Make drawing sheet editor item names translatable.
2021-03-08 16:58:52 +00:00
a088032411
Correct what was meant to be a LINUX compile flag.
...
(__UNIX__ picks up OSX as well.)
Fixes https://gitlab.com/kicad/code/kicad/issues/7750
2021-03-08 13:49:57 +00:00
720147d272
Remove transitive inclusion of bitmaps.h
2021-03-07 16:08:57 -05:00
a4b1f9187d
Drawing Sheet Editor: Assign a line width before drawing page border
2021-03-07 13:40:38 +00:00
0d3a0e0dff
Move Serbian po
...
Updates the Serbian language code from sr_RS to sr. This appears to
work as intended under Debian whereas the full code, despite existing in
the i18n directory was not recognized by wxWidgets or Weblate.
2021-03-05 09:19:58 -08:00
62f1111c0b
Konstantin Baranovskiy in About dialog.
2021-03-03 10:30:10 +02:00
908de37e7c
Don't hardcode the file extensions where possible
2021-03-03 01:13:59 +00:00
f90164f7cf
Fix some typos and improve wording
2021-03-02 19:13:49 +01:00
cea779ec0f
Implement ctrl-A/ctrl-C on our side rather than relying on wxWidgets.
...
Hopefully this will make it work on MSWindows as well. (It worked on
Mac before, but evidently not MSW. Don't know about GTK.)
Fixes https://gitlab.com/kicad/code/kicad/issues/7771
2021-03-02 11:55:41 +00:00
366189b864
Fix incorrect comments in GESTURE_PSEUDO_ACTION list.
2021-03-02 10:29:39 +01:00
924accfdc8
Consolidate wxAui art providers
2021-03-01 23:10:03 -05:00
17bcbdbf56
Disable AuiBar fix until dark icon support is ready
2021-03-01 21:59:19 -05:00
93578517e4
Support dark mode in AuiBar buttons for wx 3.0
2021-03-01 21:24:29 -05:00
35e6e55bc9
3d stock plugins (dll plugins): fix incorrect path on Linux.
...
Fixes #7750
https://gitlab.com/kicad/code/kicad/issues/7750
2021-03-01 21:02:47 +01:00
6e7d7af3c9
Add Reset buttons for mouse and trackpad defaults.
...
ADDED: Preferences > Mouse and Trackpad > Reset to Mouse Defaults and
Reset to Trackpad Defaults.
Fixes https://gitlab.com/kicad/code/kicad/issues/7681
2021-03-01 14:14:00 +00:00
5c17ff0595
Libeval: don't try to dereference invalid STRUCT_REF parent
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7764
2021-02-28 14:46:13 -05:00
dbb6d0fb4a
Move paste and mask clearance settings back to board file
...
These are needed for correct Gerber plotting so need to be stored
along with the board file
2021-02-28 14:04:28 -05:00
a70106a3bd
Fix search paths for default project template
2021-02-27 20:30:18 -05:00
77ed62f506
Scroll HTML report box when pushing new lines in immediate mode
2021-02-27 19:55:19 -05:00
a251141d1d
Remove extra kicad from Linux plugins path
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7719
2021-02-27 11:02:13 -05:00
283d176cdc
Use std::locale::classic() globally
...
This is a better alternative when imbuing streams
2021-02-26 17:21:55 -08:00
c3c777d07f
Remove another abandoned function
2021-02-26 19:36:55 -05:00
e4ef531f7d
Fix Mac and Linux stock plugins paths
2021-02-26 19:00:52 -05:00
451d7c117a
Remove unused variable since this option was removed in 86aaa2e9
2021-02-26 18:46:18 +00:00
10990f8e81
Fix a minor compil and a minor Coverity warnings.
2021-02-26 15:33:50 +01:00
86aaa2e9cb
Rationalize footprint bounding boxes and cache all of them.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7720
2021-02-26 13:50:27 +00:00
0dca0e752b
Reduce the number of built-up calls to DisplayFootprint
...
When updating the libtree, we modify the tree multiple times to avoid
crashes on Linux. These generated events that buffered while the widget
was frozen and resulted in redrawing the same footprint 4-10x.
This reduces the buffering by discarding events that are generated
during the freeze and only redrawing when there is a new footprint to
draw
2021-02-25 12:13:42 -08:00
a9c54c10a2
VIEW_OVERLAY: support for bitmap text
2021-02-25 17:18:23 +01:00
fcf6511f0c
Implement Delete in grid tricks.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7703
2021-02-25 15:37:52 +00:00
b8c95345d0
Make sure reporters have a better default path than /bin.
2021-02-25 15:05:26 +00:00
4d2a1055d3
Save reportHead and reportTail lines as well as report lines.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7700
2021-02-25 14:38:41 +00:00
2c009906e5
Set unprinted layer colors to background.
...
This allows our Black&White special cases to still work when the
hole annular rings aren't being printed.
Fixes https://gitlab.com/kicad/code/kicad/issues/7692
2021-02-25 14:23:02 +00:00
7ec46bc346
Pcbnew: Footprint warps to mouse if drag invoked from RMB menu
...
CHANGED: If the user selected a footprint and then invoked drag from the
RMB menu, the footprint would warp to the mouse center (if set in
preferences) instead of the mouse warping to the footprint center.
There was a call to 'WarpCursor' that was coming after the menu had been
closed and the mouse had already warped to the footprint center. This made
the footprint jump instead to the old mouse position.
This MR removes the call to 'WarpMouse' and prevents the footprint
from warping to the mouse.
Fixes https://gitlab.com/kicad/code/kicad/issues/7680
2021-02-24 22:19:44 +00:00
92cc88f87c
Tighten up schematic label bounding boxes
...
Margins were being added in more places than necessary
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7689
2021-02-24 17:15:35 -05:00
50712f7280
Attempt to fix Coverity issue 305290.
2021-02-24 14:32:34 -05:00
0bab025832
Fixup toolchaining for immediate mode
...
The move tool can stack on others, so when we re-enter the previous tool
this caused another immediate action. We flag re-entry in the tool
stack to check for this and avoid unexpected tool starts
2021-02-24 10:44:54 -08:00
8dcf5404fc
Better UX for handling vertical scroll mapping
...
Show an error instead of preventing an invalid state
2021-02-24 00:07:17 -05:00
946073845c
Fix typo causing Coverity warning
2021-02-23 22:16:34 -05:00
aedc65f20f
Fix footprint editor default grid
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7659
2021-02-23 20:07:46 -05:00
509b1b7141
Fix for Coverity issue 157131.
...
Don't allow exception to be thrown from OPENGL_COMPOSITOR dtor.
2021-02-23 19:09:41 -05:00
efae25e24e
Splitter bar for netclass setup.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7668
2021-02-23 15:06:41 +00:00
a3b9e8ddb4
Round 2 of Worksheet -> Drawing Sheet.
2021-02-23 11:57:44 +00:00
507ca9bc73
Add DPI scaling to KIPLATFORM
...
GTK needs to check current scaling but wx doesn't provide this
functionality in 3.0, so we can bypass by going straight to the source.
2021-02-22 17:38:27 -08:00
90cb82b32d
Install translations into macOS bundle.
2021-02-22 23:36:08 +00:00
cad5198ab7
Worksheet -> (industry standard) Drawing Sheet.
2021-02-22 17:35:46 +00:00
5acdf1ddb1
CADSTAR Schematic Archive Importer: Align to original grid
...
Previous assumption of 100mil grid in CADSTAR schematic designs has
been proven to be incorrect. Let's use the "working grid" in the
original design instead.
2021-02-22 13:24:00 +00:00
09ebfcd650
CADSTAR Importer: Fix Code Style
...
- Rename member variable names to use the 'm_' prefix
- Rename a few object types that clashed with KiCad object names, such
as BOARD and SCHEMATIC, to avoid the use of '::' to access the KiCad
objects.
- Remove some unused code.
2021-02-22 13:24:00 +00:00
be8327bd54
GAL memory allocation fixes.
...
Vertex memory allocation uses malloc and realloc without checking the
result. Throw exceptions that can be caught in the DoRepaint() method
in EDA_DRAW_PANEL_GAL when malloc and realloc return a null pointer.
2021-02-22 08:15:09 -05:00
41b8ef85e3
Fix preferences on OSX.
2021-02-22 11:05:47 +00:00
4fd49cd261
Fix odd header change by CLion.
2021-02-22 11:05:47 +00:00
f1039dfb94
Disable project saving outside explicit save actions
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7589
2021-02-21 21:31:45 -05:00
6fa0ac45af
Re-enable custom grid settings for Pcbnew
...
Add a reset button that will only show up if the user
edits the JSON configuration for grids. This is a temporary
measure until we have a real grid editor GUI in V7.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7595
2021-02-21 15:33:13 -05:00
2d28ed8eda
Move canvas backend selection to Preferences.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7630
2021-02-21 20:12:43 +00:00
f9c42585fb
Force immediate action for auto start wire feature
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7503
2021-02-21 18:43:34 +00:00
3bc9d7b95e
Rework GAL layer enum to fix visibility import from legacy boards
2021-02-21 13:41:43 -05:00
f43c639a4d
Fix issue with predefined variable texts ${COMMENT0} to ${COMMENT9}
...
- remove ${COMMENT0}, that was broken (returned the same as ${COMPANY}.
- So ${COMMENT1} to ${COMMENT9} are only recognized for Comment1 to Comment9
in page settings dlg, and are equivalent to our old %C0 to %C8 format string
- fix a minor coding style issue.
Fixes #7642
https://gitlab.com/kicad/code/kicad/issues/7642
2021-02-21 18:29:14 +01:00
f76e54bd8b
Fix generation of translated hotkey tables
2021-02-20 13:55:10 -05:00
7b64389062
Add a helper to generate action documentation
2021-02-20 13:41:49 -05:00
907e282347
Silence some msvc warnings
...
- exception variables that were unused
- RAYSEG2D improperly foward declared with class instead of struct
- unused vars
2021-02-20 11:58:55 -05:00
d9d906e652
Take file size into account in cache hash
...
Revision control systems can play games with file timestamps. If the
file has changed size, we should reload it as well.
Fixes https://gitlab.com/kicad/code/kicad/issues/7627
2021-02-20 06:27:12 -08:00
9da55d961a
Make the descriptions of pin/unpin library translatable
2021-02-19 20:24:49 +00:00
05b559c9dc
Quiet gcc warnings
2021-02-18 11:20:27 -08:00
66b33834b5
Always enable save; move dirty bit to asterisk in title bar.
...
Also unifies PCB Editor and Schematic Editor names with other
locations in the GUI (which were still Pcbnew and Eeschema).
Fixes https://gitlab.com/kicad/code/kicad/issues/7587
Fixes https://gitlab.com/kicad/code/kicad/issues/7594
2021-02-18 16:05:42 +00:00
6a5bba2a80
We don't really want users hand-editing library table files.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7591
2021-02-18 11:53:36 +00:00
fd91529d88
Quiet Coverity.
2021-02-18 11:53:36 +00:00
5d2dc0b50e
Fix a few (minor) issues:
...
- Make DIALOG_SHIM::SetPosition working)
- rename PCB_BASE_FRAME::SelectLayer() to PCB_BASE_FRAME::SelectOneLayer()
- PCB_BASE_FRAME::SelectOneLayer(): make dismiss dialog by escape key working.
Fixes #7578
https://gitlab.com/kicad/code/kicad/issues/7578
2021-02-17 20:56:43 +01:00
b6a7981e62
Write changes back to grid after using file explorer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7361
2021-02-17 14:08:53 +00:00
0d98db2eb3
Lowercase check the kicad data dir name in the macos app check
...
macOS is case insensitive anyway
2021-02-16 23:30:19 -05:00
b609c7dcd6
Kick the osx specific path helpers into PATHS
2021-02-16 23:29:26 -05:00
13a91dd49d
Allow overriding documents home with an env var
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7543
2021-02-16 20:44:53 -05:00
dbbe9cdee4
Hide infobar for save when saving
2021-02-16 15:54:43 -08:00
b959378d58
Attempt to fix Coverity issue 168705.
2021-02-16 17:29:12 -05:00
e7227a4f21
GAL code cleaning.
2021-02-16 17:25:27 -05:00
df573255e0
Fix crash when switching schematics
...
When switching schematics that causes an error message (for example if
the schematic needs repair), wx can refresh in between view updates,
leading to a null preview.
2021-02-16 10:12:30 -08:00
f3449452db
Special case kicad manager default frame sizes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7559
2021-02-16 16:24:36 +00:00
2566547377
Make mac-default delete happy
...
On mac, the backspace key is commonly used from removing items. The
forward delete key doesn't really exist (it is hidden behind
fn-backspace), so this modifies our common use of delete. The
context-dependent usage in router and polygon creation are unaffected as
CONTEXT overrides GLOBAL when processing
2021-02-15 15:04:44 -08:00
f997deec75
eeschema: fixing title block variable expanding in text objects
...
Also fixing an off-by-one error, which also affects pcbnew.
Fixes https://gitlab.com/kicad/code/kicad/issues/7489
2021-02-15 22:24:05 +00:00
089b7afacf
Eeschema: Eagle schematic plugin parser improvements.
...
* Fix multi line text alignment.
* Parse schematic frame objects and convert them to lines.
* Make implicit global labels normal size so they can easily be seen.
* Move sheet fields to a more sensible position.
* Parse schematic symbol instances before wires so that the implicit power
connections can properly be tested. This will be used at a later time.
* Scale label text size down to allow for differences in label offset and
graphical items.
2021-02-15 16:44:58 -05:00
d93ba0a06a
Choose half-grid for mirror
...
Using the half-grid allows for odd-grid counts to remain on-grid,
closer to the actual center.
Fixes https://gitlab.com/kicad/code/kicad/issues/7493
2021-02-15 11:59:04 -08:00
5433adda2e
Add extra search paths for importing settings in FlatPak builds
2021-02-14 15:04:42 -05:00
60d4d5b846
Scale down netnames on tracks so overbars fit.
...
Also fixes a bug where the overbar ignored the color opacity.
Fixes https://gitlab.com/kicad/code/kicad/issues/7524
2021-02-14 12:15:26 +00:00
e06aa32780
Launcher tweaks
2021-02-13 08:59:33 -05:00
c69cdaff7c
Fix a minor wxWidgets alert.
...
Fixes #7513
https://gitlab.com/kicad/code/kicad/issues/7513
2021-02-13 12:56:12 +01:00
884de1f932
Allow translations to load from build dir
2021-02-12 22:39:37 -05:00
8c2fe42ef0
More Undo/Redo Cleanup.
...
Don't need the reference point or container action type. Clearing this
command signatures to prevent future confusion/use
2021-02-12 11:26:48 -08:00
d244c09680
Cleanup undo/redo
...
Mirror/Rotate/etc were all just "Change" items in the undo/redo stack.
This removes the old calls
2021-02-12 10:25:14 -08:00
ab34d94f36
Add a less-intrusive validation system to board setup
...
For some kinds of issues, we want a way to point them out but
we don't need to keep the user from being able to close the
dialog. A separate Validate button lets the user check for
issues if desired, but these issues are not "fatal" and can
be ignored if the user wishes.
2021-02-11 22:19:46 -05:00
b708fd36ae
Add tooltips to netclass setup panel column headers
...
Change router tooltips to be more straightforward
2021-02-11 20:50:26 -05:00
af7e4c6ca0
Don't try to pull invalid data from JSON
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7494
2021-02-11 17:25:14 -05:00
1dc0ef01b3
Fix automatic wire tool in gridless mode
...
The automatic wire tool was not working in the gridless mode because the
grid snapping on/off logic present in `EE_GRID_HELPER`, based on the
value of `m_enableGrid`, was not taking into account that another check,
but for the global KiCad setting, would be performed in the `Align()`
method, which is inherited from `GRID_HELPER`.
I've modified all tests of `m_enableGrid` value to also take the global
setting into account, and moved checks for it to `Align()` method, as
it's more consistent this way.
I've also removed an override of the `Align()` method in the
`PCB_GRID_HELPER` class, as it was made redundant by my changes.
Fixes https://gitlab.com/kicad/code/kicad/issues/7402
2021-02-10 22:07:49 +00:00
f530b12c31
CADSTAR Schematic Archive Importer: Handle undefined pin number in part
...
Use terminal pin number (i.e. from the symbol definition) when the pin
number is undefined in the part.
This fixes a bug that resulted in symbols with "0" as the pin numbers.
2021-02-10 18:49:20 +00:00
cc27c31ab0
CADSTAR Schematic Archive Importer: Import common fields visibilities
...
Import field visibilities for Ref, Value and Part Name
Also fix incorrect loading of designator from previous commit
2021-02-10 18:49:20 +00:00
297ff282f1
CADSTAR Importer: Update copyright years and remove white spaces
2021-02-10 18:49:20 +00:00
b0051c07cb
CADSTAR Schematic Archive Importer: Load all fields in symbols
...
- Load Fields in the library items as well as schematic instances
- Remove invalid characters (e.g. '\n', '\t', '\r') in fields
- Load footprint field (assume that the footprint library name
is the same as the filename of the schematic)
2021-02-10 18:49:20 +00:00
a30ae6a237
Pass un-pretty-printed bus names through menu help text.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7412
2021-02-10 15:03:06 +00:00
430310bb75
Add identifying info per request
...
We don't use e-mail addresses for contributors in the about box these
days. The field is re-purposed as an optional additional field to allow
for disambiguation of contributors, should they request it.
2021-02-09 17:26:13 -08:00
9ce255dc77
Use a different color for front and back courtyards
2021-02-09 20:15:30 -05:00
872184fe8b
Revert "Bump minimum required CMake version to 3.10"
...
This reverts commit a475f45753
2021-02-09 18:46:13 -05:00
505844f68c
Generalize the Ctrl-Q to all frames
...
Rather than adding our handler to each frame separately, we initialize
the Ctrl-Q quit action at the base frame to be consistent
2021-02-09 11:43:42 -08:00
3d920c4088
Fix tab spacing to use widest character as ref
...
We had been using each 4th column of spaces. But we needed an absolute
spacing rather than relative to the existing text to match spacing
between the input text box and our stroke font
2021-02-09 09:44:00 -08:00
5ecef204cd
Coding policy fixes.
...
Using "this->" violates coding policy section 2.7.
2021-02-09 11:35:43 -05:00
02aca4a7d7
Don't run off the end of a string.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7461
2021-02-08 12:28:15 +00:00
a475f45753
Bump minimum required CMake version to 3.10
...
This allows us to remove even more workarounds
2021-02-08 12:23:08 +00:00
c255dede17
altium: loosen up ReadProperties check a bit, to allow reading of likely malformed altium files.
2021-02-07 16:52:31 +01:00
f6aa25df52
Make bitmap text measuring cognizant of overbars.
...
Also adds fallback for when text contains super- or subscript.
Fixes https://gitlab.com/kicad/code/kicad/issues/6846
2021-02-07 13:59:53 +00:00
404d18763d
Icons: try a new version of the 'new' badge
...
and use it more consistently.
2021-02-06 22:51:56 +00:00
ac479a1c75
Fix regression in immediate actions.
...
Add some more comments to attempt to document our egregious series
of hacks over this.
Fixes https://gitlab.com/kicad/code/kicad/issues/7432
2021-02-05 16:18:28 +00:00
2ad5108e7d
Don't depend on wxWidgets dotted and dashed line styles.
...
Turns out they're buggy on OSX.
Fixes https://gitlab.com/kicad/code/kicad/issues/7144
2021-02-05 16:18:28 +00:00
1572d90ee7
Revert "Always return a path if we can't normalize it"
...
This reverts commit 7bdea16b1f
2021-02-05 00:49:34 -05:00
7bdea16b1f
Always return a path if we can't normalize it
...
Fix #7323
2021-02-04 23:55:18 -05:00
7a55dff566
Archiver: reduce set of archived files for auto-backup
...
Keep around only source files that are modified by KiCad;
other files can be re-generated.
2021-02-04 17:24:13 -05:00
4657ca5d4f
Fix GTK crash when multiple libraries are expanded
...
Once more into the gtk_tree_view breach.
This may also be related to https://gitlab.com/kicad/code/kicad/-/issues/7344
Fixes https://gitlab.com/kicad/code/kicad/issues/7422
2021-02-04 13:20:33 -08:00
d25341901c
Skip backup if project folder isn't writeable
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7405
2021-02-03 19:17:32 -05:00
3ac5fd6342
Get rid of wx popups when opening a read-only project
2021-02-03 19:17:32 -05:00
238aa2b5b0
Snap to eeschema lines
...
Allows easier snapping to lines when drawing in eeschema.
Fixes https://gitlab.com/kicad/code/kicad/issues/7378
2021-02-02 19:33:18 -08:00
4db7a5af56
Make sure print mode is off by default
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7388
2021-02-02 21:21:16 -05:00
098241e403
About->Version info. Allow clipboard data to be available after closing KiCad.
...
Fixes a bug in GTK that erased the data on the clipboard after exiting KiCad.
2021-02-03 01:55:05 +00:00
9aedeae5c3
Don't log error messages when using the clipboard
...
wxClipboard::GetData()and wxClipboard::SetData() both log a "wxLogSysError" error-level message (see for example: https://github.com/wxWidgets/wxWidgets/blob/v3.1.4/src/msw/clipbrd.cpp#L703 ). This logged message gets displayed as a messagebox to the user.
The logging can be disabled temporarily by creating a wxLogNull object. See https://docs.wxwidgets.org/3.0/classwx_log_null.html
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6956
2021-02-03 01:55:05 +00:00
b8e97bb6b6
Only apply B&W printer fixes when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7388
2021-02-02 15:37:30 +00:00
7688fdc94f
Hack to prevent multiple simulation commands from stacking up.
...
Can happen if someone hammers away on the probe and/or tune tools
without ever mousing over the schematic in between.
*May* fix the below bug.
Fixes https://gitlab.com/kicad/code/kicad/issues/6876
2021-02-02 01:23:22 +00:00
1394c1f4d4
Retire disabled buttons in favour of info boxes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7229
2021-02-01 22:56:55 +00:00
eba98aa9f6
Change default Ctrl+H hotkey to 3-state layer view mode
2021-02-01 17:37:17 -05:00
c11ded24cd
Add instrumentation to track down local issues in symbol library file code.
2021-02-01 12:57:16 -05:00
1f27b7e7df
Don't render hole walls when no physical layers are visible.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7369
2021-02-01 17:14:30 +00:00
47ada0ffba
Remove duplicate LAYER_VIA_THROUGH entry in theme
2021-02-01 11:51:42 -05:00
32bf88fa8e
Point to the user template path by default in pl editor
2021-01-31 23:57:41 -05:00
0125986588
Remove unused grid button
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7360
2021-01-31 13:55:10 -08:00
9770ba9739
Fix odd/even check in cairo. Modulo 1 is always 0 on ints.
2021-01-31 11:59:49 -05:00
db3b79a046
altium: Fix #6462 improve parsing of metric units
...
Because Altium uses imperial units for storage, this leads to rounding errors.
This code tries to correct those rounding errors for the user.
2021-01-31 16:18:57 +01:00
abf0a46dce
Refactor PICKER_TOOL and push up snapping disable functionality
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7348
2021-01-31 09:50:41 -05:00
9ddfd82b91
altium: Fix #6242 by increasing clamp limit for unit conversation. Furthermore fix error which happens when parsing negative units.
2021-01-31 13:59:51 +01:00
c155218582
Sim plot: fix a rounding issue that can create a missing point in a plot.
...
Due to a truncation when converting a value to integer, the first point was
sometimes missing because it looked like out of plot range.
Fix also a cosmetic issue in dialog.
Fixes #7345
https://gitlab.com/kicad/code/kicad/issues/7345
2021-01-31 10:36:26 +01:00
8eca23aabe
Mark null project initial screen as zoom-initialized
...
The variable `m_Initialized` in `BASE_SCREEN` is used by
`SCH_EDIT_FRAME` to mark whether a screen had its zoom level initialized
by the "zoom to fit screen" action. When this variable is `false`, the
function `SCH_EDIT_FRAME::DisplayCurrentSheet()` performs "zoom to fit
screen", modifying the zoom level. This function is indirectly called in
the undo routines, so if `m_Initialized` is not set to `true`, a zoom
change will occur when the user undoes an operation, a behavior that is
undesired.
`m_Initialized` was not initialized to `true` for the null schematic
(the schematic that is loaded if no project is loaded), causing the
aforementioned undesired behavior.
To prevent this, I've changed the `SCH_EDIT_FRAME` constructor to set
`m_Initialized` to `true`, since it zooms to fit screen already. I've
moved `m_Initialized` from `BASE_SCREEN` to `SCH_SCREEN`, as it is used
only in Eeschema, and renamed it to `m_zoomInitialized`, a name I
believe that better describes what this variable does.
I've also introduced the function `SCH_EDIT_FRAME::initScreenZoom()` to
group the "zoom to fit screen" action with setting `m_Initialized` to
`true`, as they often should occur together.
I'd also like to say that I'm not confident whether
`SCH_EDIT_FRAME::DisplayCurrentSheet()` should perform the zoom level
initialization at this point, but I have decided to not change this
behavior for now, as the commit history suggests it's several years old.
Fixes https://gitlab.com/kicad/code/kicad/issues/7343
2021-01-31 00:49:11 +00:00
a6b2fb3819
Page layout editor: Fix bitmap bounding box
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7315
2021-01-30 20:39:16 +00:00
fabafe719d
Use aperture macro for custom pads. Optimize aperture macros for free polygons.
...
These aperture macros were previously used but only for chamfered round rect.
They are now also used for custom pads (previously drawn as regions).
They are also optimized, i.e. only one aperture macro is created for a given shape.
(previously, one aperture macro was created for each chamfered round rect pad.)
So now all pads are flashed.
2021-01-30 18:14:58 +01:00
a235103e48
Redo pad & via painting (again).
...
New strategy isolates all draw/don't draw decisions to the ViewGetLOD
routines, and all dimmed/not dimmed to PCB_RENDER_SETTINGS::GetColor.
The actual drawing in PCB_PAINTER is more-or-less conditon free.
Also adds new layers for pad and via hole walls so that they can be
controlled for high-contrast mode.
Also changes the drawing paradigm so that the pads are drawn even when
not on the high contrast layer, just in low contrast. The hole wall
is drawn in high contrast. This actually makes things clearer to the
user (although to be honest was done to keep from having to re-render
pads when the high contrast layer changes since we have two separate
layers now that we can adjut colours on).
Fixes https://gitlab.com/kicad/code/kicad/issues/7328
2021-01-30 16:31:27 +00:00
af3789571e
Refresh screen after canvas switch
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7335
2021-01-29 15:33:32 -08:00
7a56608cd5
Fix incorrect path of 3d stock plugins.
...
Fixes #7330
https://gitlab.com/kicad/code/kicad/issues/7330
2021-01-29 19:29:52 +01:00
6983bcd55b
Push addition of shape width down into computeArcBBox.
...
Also improves performance by calling GetBoundingBox only once (this
is not always an inexpensive routine for some items, such as
polygons).
2021-01-28 22:29:28 +00:00
1a7b7e84c6
Use consistent terminology for component placement files.
...
CHANGED footprint positions files -> component placement files.
Not all footprints get placed, so component is a more neutral word.
Use of "placement" instead of "positions" removes the double-plural
that makes footprint positions files such a mouth-full.
Fixes https://gitlab.com/kicad/code/kicad/issues/7097
2021-01-28 19:24:55 +00:00
945faba586
Wrap CTOR in try/catch for context errors
2021-01-28 10:55:27 -08:00
78dbcdcdb7
Slight fixup to previous library browse change
2021-01-28 07:31:32 -05:00
f0aa6aa442
Fix drop-down-too-narrow-on-first-drop bug.
2021-01-28 11:35:18 +00:00
a373abd68a
Invert the new symbol library flow to push users to default to a different folder for global symbols
2021-01-28 00:40:21 -05:00
4c14406788
Further path refinements
2021-01-27 21:48:02 -05:00
fdf6318218
Ensure cmake commands depend on the cmake file they use
...
Without this dependency, the build stage won't rerun
if the CMake file changes on disk.
2021-01-28 00:24:22 +00:00
beb50c529e
Reorganize the CMake folder to separate build and configure steps
...
The BuildSteps folder now contains the CMake scripts that are
called during the build process as individual stages, while
the root CMakeModules directory contains the CMake files used
during the configuration phase.
2021-01-28 00:24:22 +00:00
a47e8af0d0
Fix up naming of the kiplatform helpers
2021-01-27 19:12:20 -05:00
6d4bae1136
Make calculateUserSettingsPath a little more compact and use kiplatform
2021-01-27 19:12:20 -05:00
bf0ff2a43b
Use pretty case for path strings on windows and mac
2021-01-27 19:12:20 -05:00
8baa5b46b0
Template not templates
2021-01-27 19:12:19 -05:00
daf9c4f319
Centralize the 3d cache path
2021-01-27 19:12:19 -05:00
7b5397f81f
Move PLUGINDIR to the make config.h
2021-01-27 19:12:19 -05:00
d0aede5caf
Fix the m_mruPath default
2021-01-27 19:12:19 -05:00
3bea9fc3d9
Add comment blocks
2021-01-27 19:12:18 -05:00
14327f3708
Cleanup the 3d plugins paths a little bit
2021-01-27 19:12:18 -05:00
8622565480
Add GetUserConfigDir
2021-01-27 19:12:18 -05:00
2807a37fc0
Create a stock scripting path helper
2021-01-27 19:12:18 -05:00
e6dd95e83a
Create a default user projects folder
2021-01-27 19:12:18 -05:00
28c6967dbc
Start trying to shuffle around path management
2021-01-27 19:12:18 -05:00
7d6a749285
Implement a more aggressive re-entrancy check for SCH drawing tools.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7259
2021-01-27 19:51:11 +00:00
886cad43bd
Cancel drag action when focus is lost
2021-01-27 03:33:22 +00:00
bea310569b
Fix parsing of track/via user sizes from legacy boards
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6134
2021-01-26 21:51:36 -05:00
679a755690
Adjust how wire tool cursors are arranged
...
Moves the cross-hair active point to the bottom left to align with the
wire graphic
Fixes https://gitlab.com/kicad/code/kicad/issues/7278
2021-01-26 08:44:39 -08:00
1e9639e89c
Save pintype alongside pinfunction (in pads).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7283
2021-01-26 15:28:48 +00:00
b576ccef61
Don't double-up tools on tool stack.
...
Also make sure move tool gets cancelled by other tools being
activated.
Fixes https://gitlab.com/kicad/code/kicad/issues/7259
2021-01-26 10:56:19 +00:00
98b0558bf6
Icons: make sure all op-amps are the same
...
+ fix wrong icon in About dialog
Fixes https://gitlab.com/kicad/code/kicad/issues/7214
2021-01-25 14:21:22 +00:00
6ab1144ea3
Fix broken Doxygen comment specifiers.
...
Please note, ///> is not a valid Doxygen comment specifier. ///< is the
correct specifier to use for single line or short Doxygen comments.
2021-01-25 07:42:36 -05:00
02f91c52a0
Avoid nag confirmation in scintilla
...
If we need to confirm abandoning changes, we need to do it in the dialog
where we check for dialog changes.
2021-01-24 12:31:04 -08:00
d5d9372839
Don't cancel dialog when esc-ing out of autocomplete.
2021-01-23 22:55:03 +00:00
d1c604e699
Run filters on <ENTER> in filter text; don't OK dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7247
2021-01-23 22:55:03 +00:00
15cc368918
Gerber plotter: prepare optimization of aperture macros type free polygons.
...
They are used for chamfered round rect pads, and can be used for custom shaped pads.
No actual change currently, but the shape rotation of custom pads and chamfered rr pads
can be now used in gerber plots.
2021-01-23 21:15:27 +01:00
16c7180ff5
Remove SetGrabMouse and revert some behaviours
2021-01-23 13:35:39 +00:00
905fd63c9f
Fix autopanning behaviour for left-click-drag
2021-01-23 13:35:39 +00:00
f7cd21c70d
Move windows-specific mouse capture stuff into ifdefs
2021-01-23 13:35:39 +00:00
bfd7a9e956
Suppress assertions caused by closing the window while mouse is captured
...
Closing the window while dragging with unsaved changes causes a dialog box, triggering a capture-lost event. Closing the window while dragging without unsaved changes causes an assertion about destroying a window with mouse capture.
2021-01-23 13:35:39 +00:00
39be962a69
Restructure mouse capture to avoid recapture asserts
2021-01-23 13:35:39 +00:00
b1d394258f
Fix grammar
2021-01-22 21:25:23 -05:00
f5e35af1a5
Transmit pin electrical types through to pads.
2021-01-23 00:10:01 +00:00
320ca5a0d0
Prevent KiCad launch on Windows 7 if python 3.8 or newer is bundled
...
Soon to be a permanent check regardless of python on Windows
2021-01-21 21:58:53 -05:00
1750faac4b
Icons: make copy/paste a bit more standard
...
+ Paste special shouldn't share an icon with paste
2021-01-19 22:57:25 +00:00
fa93cd8faa
Remove colour setting for internal layer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7149
2021-01-19 11:28:15 +00:00
fed56572f8
Refinements and fixes in auto-pan.
...
Add comments.
Fix incorrect comparison.
Fix a too fast auto-pan speed when auto-pan acceleration was not set to the minimal value.
2021-01-19 10:45:41 +01:00
eb80ac464a
Remove ability to select "Other" footprint from Symbol Chooser.
...
We no longer run as a QuasiModal (due to 5206), so we can't put up
the Footprint Browser.
Fixes https://gitlab.com/kicad/code/kicad/issues/7174
2021-01-19 01:18:41 +00:00
744d745ee5
Allow endless panning
...
Warp the cursor if it leaves the window while panning, to allow endless motion.
2021-01-18 22:07:59 +00:00
44655b98de
Initialize variables properly
2021-01-18 18:35:10 +00:00
f3a6d2655e
Improvements to ERC and bus parsing.
...
1) Add some nullptr safety to ERC.
2) Allow unconnected flagging on bus/wire entries.
3) Allow commas in bus group definitions.
Fixes https://gitlab.com/kicad/code/kicad/issues/7155
2021-01-17 16:24:22 +00:00
f1221a9ca3
Resolve text variables in title blocks for outputing to netlist.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7153
2021-01-17 16:24:22 +00:00
68efdb2fff
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:18:10 +00:00
288ecb9a02
Fix logic error in recent commit.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7118
2021-01-15 20:55:56 +00:00
08d595c9bf
Move title block fields to global availability in PCBNew.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7118
2021-01-15 15:41:18 +00:00
664c301cc7
Coverity fixes.
...
The Boost UUID random generator can throw an entropy error in the KIID
object constructor which leaves the UUID generator in an undefined state.
This is treated as a fatal error and KiCad is closed. The likelihood of
this occurring is low but at least now it is properly handled and cannot
result in UUID clashes.
Reports 305311, 305372, 305492, 314743, 314754, 314757, 316277.
2021-01-15 08:03:36 -05:00
58fa411260
CADSTAR importer: Parse missing SIGNALREF ATTROWNER
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7068
2021-01-14 00:13:34 +00:00
2d64613bbb
Coverity fixes.
...
Reports 314745, 316271, and 316269.
2021-01-13 11:23:09 -05:00
d2d4ffe6d0
Dismiss infobar if it's dismissable on board save
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7071
2021-01-12 23:24:13 -05:00
ac3e677fae
Cleanup some compile warnings
2021-01-13 02:12:59 +00:00
f303b07086
Initialize translation dictionary to default
...
Initializes the dictionary before potential messages are shown on the
screen.
Fixes https://gitlab.com/kicad/code/kicad/issues/7076
2021-01-12 13:33:40 -08:00
07635d2fc7
Minor adjustments
2021-01-12 20:51:31 +00:00
ac94d72d2d
Add more const specifiers
2021-01-12 20:51:31 +00:00
ec0af24f13
Make wxFindReplaceData argument const
2021-01-12 20:51:31 +00:00
bb2881a5ab
Make RENDER_SETTINGS argument const
2021-01-12 20:51:31 +00:00
a00b9cc821
Icons: general tweaks and pixel alignment
...
+ minor rename
+ fix missing bitmap in DRC panel
2021-01-11 23:31:25 +00:00
32f7f30958
Icons: remove where they don't make sense
...
Also avoid icon reuse
2021-01-11 23:31:25 +00:00
a36f655dcd
Consistent formatting.
2021-01-11 22:09:36 +00:00
50889a9ed6
Promote mouse drag settings to full enums.
2021-01-11 22:09:36 +00:00
be542c05f2
Gerber output, aperture macros: better compatibility with old Gerber readers.
...
In some macros we are using a circle as primitive (primitive 1).
It needs 4 mandatory prms and one optional (not used by Kicad, always 0) prm.
This not used optional prm can create issues with old Gerber readers, so it is removed now.
Fixes #7047
https://gitlab.com/kicad/code/kicad/issues/7047
2021-01-11 16:03:01 +01:00
a4d417f5c0
Get rid of "drill" terminology when talking about finish hole size.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7044
2021-01-11 13:49:43 +00:00
1eee72ec65
Fix library tree behavior when duplicate project table entry is disabled.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5438
2021-01-11 07:46:07 -05:00
6c648df4c6
Support 3 drag vs. select options, and unifiy with other drag prefs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5493
2021-01-11 11:50:14 +00:00
1ff2622b3c
wxGTK: fix an issue in WIDGET_HOTKEY_LIST ctor.
...
fixed for wxWidgets 3.0, but still existing in 3.1
2021-01-10 12:53:34 +01:00
ffb3748cfc
Don't crash when getting multiple wx calls
...
Multiple size calls will assert trying to re-lock the GAL context. Just
skip the second one.
2021-01-09 13:05:58 -08:00
a42d8cecd7
Allow either decimal separator when parsing numbers.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7022
2021-01-09 17:16:29 +00:00
df69ce5e67
Layout and textual simplification and cleanup.
2021-01-09 13:47:24 +00:00
e4f29d358c
Formatting.
2021-01-09 13:47:24 +00:00
d0af4e9f9d
Save a cancel value when asked if it's not being used to cancel.
...
Many, many KIDIALOGs use OK/Cancel and then rename both buttons to
confirm or deny some action. In those cases we *do* want to store
the deny actions if they check "Do Not Show Again".
Fixes https://gitlab.com/kicad/code/kicad/issues/6979
2021-01-08 21:32:19 +00:00
e73b852c2a
Forgot a '0' in tool tip commit
2021-01-08 10:27:27 -08:00
c5b6cf722d
Adjust Windows tooltip display time
...
While most platforms keep the tooltips if the mouse doesn't move, MSW
will hide the tooltip after 5 seconds (by default). This bumps that up
to 10s for all tooltips in the program.
Fixes https://gitlab.com/kicad/code/kicad/issues/6836
2021-01-08 10:09:35 -08:00
1e4d81e3c4
Protect against invalid HOME variable
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6990
2021-01-07 15:13:45 -08:00
bf332b3189
Fix minor compil warnings
2021-01-07 20:55:24 +01:00
2bf13c6e49
Quote string context only needs to escape double-quotes.
...
Escaping other things (such as braces) breaks other features (such
as text variables).
Fixes https://gitlab.com/kicad/code/kicad/issues/6973
2021-01-07 14:33:27 +00:00
52f822dedb
Remember autotrack width setting
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6971
2021-01-06 20:11:32 -08:00
f372c8025b
Better sizing for some conditional dialogs.
...
These dialogs don't have growable features but do have conditional
features, so the size is better adjusted automatically by the code
then by the user.
2021-01-07 01:27:12 +00:00
099ddb1517
Update Lanugage list with new contributions
2021-01-06 14:23:59 -08:00
5d9b2d3fea
Icons: new filter icon
...
+ remove icons where they don't make sense.
2021-01-06 00:35:20 +00:00
6f228f9dea
hpgl_plotter: correct formatting
2021-01-05 22:42:21 +00:00
f5b7595675
Add user coordinate support to HPGL plotter
2021-01-05 22:42:21 +00:00
5676117d0b
Make small drill marks size configurable via advanced config for both printing and plotting
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1972
2021-01-05 22:37:34 +00:00
a4b3b3c115
Fix some glyph of CJK characters
2021-01-05 19:11:41 +00:00
68240821d4
Make Linux/Mac cursors black again
...
This makes cursor color conditional on the system default. Some themes
in Linux and all Macs are black cursor on white background.
2021-01-05 09:47:17 -08:00
648c42f643
Show collisions preventing routing from starting.
...
Also introduces a callback to the infobar so that the view can be
cleaned up when the timer expires.
Fixes https://gitlab.com/kicad/code/kicad/issues/6930
2021-01-04 19:19:55 +00:00
1ddd0e53bb
Remove dead code.
2021-01-04 19:19:55 +00:00
8af4cf88a0
Fix crash when deleting symbol in GTK
...
So many things can go wrong with this control in GTK. We have to
collapse the tree when updating the search string to avoid a crash when
referencing a child object but collapsing the tree will iterate over
elements and crash when we have deleted a symbol.
The temporary fix for this nonsense is to carefully order the calls.
We only need to collapse the search tree if we are not keeping our state
(in other words if we are fully re-building the tree)
Fixes https://gitlab.com/kicad/code/kicad/issues/6910
2021-01-04 09:15:40 -08:00
92787cfa23
Make Configure KiCad Settings Path dialog translatable.
2021-01-04 14:28:05 +02:00
980a8cfb39
Use "Cmd" instead of "Ctrl" on OSX.
2021-01-03 14:42:57 +00:00
491fc2c8f2
Save DXF plot params to file and remove some dead code.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6720
2021-01-03 14:22:25 +00:00
8cdeb4d7bd
Update KiCad Developers copyright year
2021-01-03 06:47:02 +00:00
154e19b6e7
Icons: use common prefix for small 16x16
2021-01-02 23:16:33 +00:00
791d1f513c
Icons: fix some 3D viewer icons
...
- remove old palette icon in favour of new one
- use dark grey in new icon (instead of light grey)
- use generic gear for 3D display options
2021-01-02 23:16:33 +00:00
decca8baba
Do not migrate the versioned env variables
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6914
2021-01-02 10:47:06 -05:00
d880606e72
Happy New Year
...
May 2021 be an improvement
2021-01-01 12:01:18 -08:00
8de9cff4e0
Change environmental variables to human-readable
...
Versions specific variables that may point to objects that change
through versions, allowing multiple KiCad versions to operate correctly
(even on MSW) on the same machine.
2021-01-01 16:20:35 +00:00
a572be54e1
Fix sysdirsappend for msvc
2021-01-01 02:21:23 +00:00
4f21b943d4
Make search stack path_seps correct for msvc
2021-01-01 02:18:32 +00:00
f8f34982c0
Escape PCB text
...
Also keep a fail-safe for unescaping strings that are not previously
escaped
Fixes https://gitlab.com/kicad/code/kicad/issues/6901
2020-12-31 17:17:27 -08:00
f6a1d703ec
Fix some build warnings in the importer code.
2020-12-30 18:19:43 -05:00
b168b74919
CADSTAR Archive Importer: Fix position of multiline text with NO_ALIGNMENT in CADSTAR
2020-12-30 18:53:43 +00:00
a2cbbb963e
CADSTAR PCB Archive Loader: Correctly handle Dimension text
...
Do not parse fields in dimension text to allow splitting it into prefix and suffix
2020-12-30 18:53:43 +00:00
9ed4780fec
CADSTAR Archive Importer: Change architecture to Parse CADSTAR fields and store them in a static map
...
Architecture of the parser changed to have a shared PARSER_CONTEXT between all the individual parsers.
Parses CADSTAR fields such as <@DESIGN_TITLE@> or <@SHEET_NUMBER@> and replaces with an equivalent KiCad Text Variable.
2020-12-30 18:53:42 +00:00
a637f310d0
Store zone display mode in project local settings
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6886
2020-12-29 17:19:01 -05:00
950ccad220
Fix missing pcbcommon file
2020-12-29 15:26:14 -05:00
76e8c62269
PCB_VIEW: Fix a few ASAN issues
2020-12-29 14:58:45 -05:00
dec68a782c
Cleanup.
2020-12-29 12:41:24 +00:00
dc28de16d4
Refinement in infobar
...
- Fix a minor coding style issue.
- Remove double buffering, not needed with the new code, and that creates a
minor cosmetic issue when showing or hiding the infobar.
2020-12-29 11:13:07 +01:00
bfea2ab9f4
Fix incorrect calculation of infobar width on Linux and Windows.
...
The calculation was using the frame width, instead of the the GAL
canvas width.
Fixes #6865
https://gitlab.com/kicad/code/kicad/issues/6865
2020-12-29 10:32:22 +01:00
aee23e991c
Fix not working LaunchExternal() on Linux on wxWidgets 3.1.4
...
Adding quotes breaks the path actually used to run the browser.
However they are needed on wxWidgets 3.0
2020-12-29 10:29:54 +01:00
a761d42c12
Common: Typo in file extension description
...
CHANGED: The description for .erc files reads:
Electronic rule check file
This MR changes it to read...
Electrical rule check file
...which is the commonly accepted definition for ERC
Fixes https://gitlab.com/kicad/code/kicad/issues/6868
2020-12-28 15:33:26 +00:00
253b2da717
Dead code cleanup.
2020-12-25 23:07:49 +00:00
0d57f90982
Make sure SCH-related frames use the schematic worksheet color.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6843
2020-12-25 16:59:41 +00:00
7a081b7c04
Naming consistency.
2020-12-25 16:59:41 +00:00
1b8658137d
Change name reference per list request
2020-12-25 06:05:06 -08:00
359c29639f
Fix access into empty container.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6840
2020-12-24 19:43:33 +00:00
1d874e690e
Fix initial focus issue on OSX.
2020-12-24 10:36:29 +00:00
5fffde09d4
Improve SNR and formatting.
2020-12-24 10:36:29 +00:00
599c35edce
Fix memory leak in COLOR_SETTINGS
2020-12-24 00:24:44 +00:00
6b420b191a
Use color theme backgrounds in page previews.
...
Also includes a *lot* of const fixing to make it happen.
Fixes https://gitlab.com/kicad/code/kicad/issues/6811
2020-12-23 23:18:38 +00:00
caefc9dc91
Fix minor spacing issue in Symbol Chooser.
2020-12-23 18:33:17 +00:00
55bb407256
Add halfwidth and fullwidth forms to stroke font
2020-12-23 16:43:39 +00:00
6641168cbc
Update KiCad website links
2020-12-22 17:38:56 -08:00
9bc7aff3d0
Fix compile error on Linux and MSW.
2020-12-22 21:53:46 +00:00
47ea51ec34
Allow both aui-manager-based infobars and window overlay infobars.
2020-12-22 21:36:39 +00:00
93dc7feea3
Remove multi-threading for footprint loading.
...
Also don't load the footprints up front. The whole purpose of the
footprint-info stuff is to have enough info about the footprints to
filter them *without* loading. After that just load individual
footprints as we need them.
Fixes https://gitlab.com/kicad/code/kicad/issues/6177
2020-12-21 22:03:24 +00:00
1adb86aa52
Add vietnamese language
2020-12-21 18:54:24 +00:00
b2a0070d66
Add hiragana and katakana glyphs
2020-12-21 18:37:35 +00:00
0ba43ca231
Use library icon for footprint browsing for more visual distinction.
2020-12-21 17:37:53 +00:00
eb7dc6ddd9
Minor fixes. In stand alone show the frame as soon as possible.
...
Especially when running Pcbnew to open a complex board the frame is shown faster.
Add also a busy cursor when loading files and building the data.
2020-12-21 17:44:10 +01:00
c36f3ab521
Coverity fix for 280374.
2020-12-21 07:53:41 -05:00
70c397a9b4
Implement free vias fully
...
CHANGED: manually-placed (stitching) vias won't have their nets automatically updated
(unless the via is placed directly on a track segment)
CHANGED: stitching vias can be placed on footprint pads and pick up their nets
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5484
2020-12-20 16:29:50 -05:00
81ce1a07ee
Fix a few issues with builtin color themes
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6754
2020-12-20 14:43:41 -05:00
79c7cf12c9
Make sure bus members get escaped after parsing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6400
2020-12-20 18:02:16 +00:00
3d852372ca
Handle nested unescaping (for buses in particular).
...
Also adds a few missing unescape() calls when showing netnames to the
user.
Fixes https://gitlab.com/kicad/code/kicad/issues/6400
2020-12-20 15:59:09 +00:00
7bc42f387a
Make sure splitter sashes are visible.
...
Also might fix 6791, although that's probably a long-shot.
Fixes https://gitlab.com/kicad/code/kicad/issues/6791
2020-12-20 12:35:41 +00:00
f06a5894b3
Header clean up round 3.
2020-12-19 18:29:10 -05:00
21bd1c0f00
Preferences: Detect conflict assigning hotkeys already assigned in common
...
CHANGED: Currently KiCad only checks for hotkey assignment conflicts
within the same program. However, if a hotkey is already assigned in
"common", it will also assign it to the specific program requested. When
the hotkey is pressed, the original asignment in "common" will take
precedence and it's action performed instead of the new action.
This MR looks for and detects hotkey assignment conflicts in both the
current program section and the "common" section.
Fixes https://gitlab.com/kicad/code/kicad/issues/1920
2020-12-19 22:29:38 +00:00
be5102a6e0
Prevent refresh loops on GTK/MSW
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6787
(cherry picked from commit 281180512f
2020-12-19 15:00:18 -05:00
93173fca93
Fix refresh logic on MacOS to prevent excessive redraws
...
This new logic does not need to be MacOS-specific; it should
account for timer inconsistencies on any platform.
Thanks to Mark for the suggestions.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6222
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6332
(cherry picked from commit d79aee3f78
2020-12-19 15:00:18 -05:00
a1fae02427
Header clean up round 2.
2020-12-19 13:55:28 -05:00
f1aa82aad6
HPGL_PLOTTER: add missing include
2020-12-19 10:16:42 -07:00
9b0a137d6c
Stop bludgeoncompiling dialog_page_settings
...
Through the power of OOP!
Needs some more cleanup though
2020-12-19 10:40:37 -05:00
06aa1506ee
Add optional project parameter to PCB plugin load method.
...
The optional PROJECT parameter is primarily used for third party plugins
that need to store project information loaded by the plugin.
2020-12-18 10:40:51 -05:00
bd7c3447e0
Fix a few compil issues.
...
Round 2: Fixes #6782
https://gitlab.com/kicad/code/kicad/issues/6782
2020-12-18 16:16:16 +01:00
34fb55dc9c
Fix a compil issue.
...
Fixes #6782
https://gitlab.com/kicad/code/kicad/issues/6782
2020-12-18 14:17:20 +01:00
4ce91d3e92
HPGL improvements and optimizations for physical plotters
...
- Sort HPGL plots for speed
- Reduce HPGL circle precision for tiny circles
- Teach HPGL plotter about filled rectangles
2020-12-18 07:21:59 +00:00
54d2748032
HPGL driver: collect graphics to plot later
...
This will later enable sorting the items for efficiency, which will then
facilitate things that would otherwise be impossibly slow (e.g.
switching pens)
2020-12-18 07:21:59 +00:00
5937b38312
HPGL: Fix bug when plotting negative line widths
2020-12-18 07:21:59 +00:00
a59cab24b8
HPGL: Fix missing point in custom pad outline
2020-12-18 07:21:59 +00:00
1c0d4ac02d
Simplify some error messages.
2020-12-18 00:30:26 +00:00
bb232e6ac6
Unify LIB_IDs now that both are stored in sexpr files.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6764
2020-12-18 00:30:26 +00:00
c4117c1ecf
Adjust text and shadow offsets for flipped view.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6776
2020-12-18 00:30:26 +00:00
aab3c936f0
Move headers from common folders to appropriate include folders round 2.
2020-12-17 11:44:03 -05:00
08cf9a1e20
Move headers from common folders to appropriate include folders round 1.
2020-12-17 08:12:18 -05:00
a7ea63e610
Hack around broken column sizing in wxGTK 3.0 for hotkey editor
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6767
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6396
2020-12-16 20:51:18 -05:00
fc20eaa083
Fix some compiler and Coverity warnings
2020-12-17 00:30:22 +00:00
b9b4618c8e
Take a stab at fixing the GTK severity heading clipping issue.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6766
2020-12-17 00:24:02 +00:00
651e7f664d
Fix type-cast in page_layout_reader.cpp
...
The wksFile.Read() call returns a size_t which is then compared
with a int. Make the filelen variable a size_t to make sure it is
of the correct width.
Fixes the following warning:
kicad/common/page_layout/page_layout_reader.cpp: In member function ‘void WS_DATA_MODEL::SetPageLayout(const wxString&, bool)’:
kicad/common/page_layout/page_layout_reader.cpp:853:41: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Wsign-compare]
853 | if( wksFile.Read( buffer, filelen ) != filelen )
2020-12-16 10:59:26 +00:00
b7875e4d41
Setup file_* icons
...
Don't use the same "post_*" icon in the treeview. The badge gives an
action that doesn't apply in the treeview.
Also renames different file blobs to the "file_*" prefix.
2020-12-15 14:48:09 -08:00
00255f2a9c
Fix a compil warning.
2020-12-15 16:20:58 +01:00
c1a74b427a
Translucent magnifying glass on footprint & library browser icons.
...
Also renamed.
2020-12-14 22:15:43 +00:00
500db27802
Icons: The return of the ladybug
...
Completely new ladybug icon for the Report Bug menu item.
2020-12-14 10:32:45 -08:00
e07848d887
Make the footprint preview control bg the same as the preview itself
...
Fix #5571
2020-12-14 09:48:26 -05:00
3b35bfc0a5
Don't write out synthetic severities (they're headings).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6726
2020-12-14 13:34:53 +00:00
d0e008053a
Fix compile issue on OSX.
2020-12-13 23:46:20 +00:00
126d40f9d3
"Sheet label" too confusing w/ sheet names and fields. Use "sheet pin".
2020-12-13 22:43:09 +00:00
8b843d023c
Double buffer the info panel
...
Fix #6721
2020-12-13 13:14:19 -05:00
cc43b66daf
Icons: use correct size for open action in toolbar
...
Previously 16x16 was used
2020-12-13 16:10:26 +00:00
e32686a80b
Formatting.
2020-12-13 11:42:03 +00:00
7565f60a03
Swap wxFileInputStream/wxFileOutputStream for the buffered kind
2020-12-12 18:52:02 -05:00
dce4d04113
Add 24x24 size refresh icon
...
Previously 16x16 was being used alongside 24x24
2020-12-12 18:51:55 +00:00
d67cf2f9af
Replace wxFile usage with wxFFile
...
Buffered libc wxFFile is better thinking about syscall wxFile going wrong.
2020-12-12 13:16:23 -05:00
5d7a6ea990
DIALOG_ABOUT: fix incorrect size of bitmaps: it is now 24x24 pixels
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6716
2020-12-12 18:29:47 +01:00
3ae87ba613
Use wxFFileOutputStream in place of previous wxFFile switch
...
wxFFile with fwrite still has a chance of partial writes.
wxFFileOutputStream provides WriteAll which will iterate until all bytes written or error.
2020-12-12 10:46:30 -05:00
b4e4e1cf5e
Use wxFFile instead of wxFile for saving json settings/json_settings.cpp
...
wxFile is dangerous, it's ::Write method is a direct map to the write syscall. It does not handle partial writes!
This must be handled in our code which we don't.
2020-12-12 10:00:49 -05:00
67d8af4a4f
Use buffered file write for hotkeys
...
Not a important change in the slightest but who knows, it might help someone saving to a network drive
2020-12-12 09:50:52 -05:00
65f9212f46
Naming conventions.
2020-12-12 03:43:41 +00:00
42d96fcadc
Naming conventions.
2020-12-12 03:43:41 +00:00
cf6f0b9b92
Use trash icon where appropriate
2020-12-11 17:05:11 -08:00
412c9c8c4e
Save should be disabled only if the file is up-to-date.
...
Any other issues (such as locked files) need to produce a dialog
with info for the user.
2020-12-11 23:58:30 +00:00
f26a1a32e0
UNIT_BINDER: better support of DEGREES units (and some fixes).
...
Especially, add a way to define the number of digits in mantissa.
base_units.cpp: set number of digits in mantissa to 3 instead of 1 for DEGREES
2020-12-11 16:26:58 +01:00
73b7b104cd
Fix some issues with Infobar sizing.
...
This also commits to the new strategy as it wasn't really compatible
with if-def-ing anymore.
2020-12-11 12:39:40 +00:00
0967995a80
Replace wxTextFile for writing fp info cache
...
wxTextFile uses wxFile which uses write syscalls which means its unbuffered.
This makes file IO more expensive against network shares where it will flush far too aggressively.
wxTextFile is fine for reads however.
2020-12-10 21:34:40 -05:00
645c49427c
Fix hotkey editing on OSX.
...
Focus was on the dialog instead of the panel. The dialog doesn't
have the IsUserPanel flag set and so wxEVT_CHAR processing doesn't
happen. (Why? I haven't a clue.)
Also fixed some more performance issues with the auto-column-widths.
Fixes https://gitlab.com/kicad/code/kicad/issues/6591
2020-12-11 01:54:39 +00:00
fc57860caf
Formatting.
2020-12-11 01:54:39 +00:00
5888d376a7
Handle special cases for ending overbar text.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6695
2020-12-10 18:38:31 +00:00
98330098ac
Yet another overhaul to locking.
...
This unifies everything under a single architecture with a "don't
show again" dialog. Since everything now goes through the same
path it should be reasonably easy to make it do whatever we want
in the future.
Right now it presents 3 options: modify only unlocked items, override
locks and modify all items, or cancel command.
2020-12-10 17:36:19 +00:00
7fcc2e638c
Fix flickering on msgpanel paints
2020-12-09 20:21:51 -05:00
be4b6ec06a
Cleanup compiler warnings
2020-12-09 23:13:33 +00:00
ec97d1d737
Remove unnecessary decimal point notation test on application start.
2020-12-09 13:53:50 -05:00
c87a1ca17a
Allow checkboxes in Windows with/without bitmaps
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6675
2020-12-08 16:14:22 -08:00
17d0ad53b4
Update Show DCode icon
2020-12-08 15:14:24 -08:00
211f9199f8
Remove edit_module in favor of module.svg
2020-12-08 12:22:17 -08:00
fec0a1fbc8
Take II.
2020-12-08 18:43:43 +00:00
ef39711e3e
Remove accidentally checked-in debuggin code.
2020-12-08 18:34:34 +00:00
b26a5972c5
LIB_TREE's SetFocus() override no longer getting called.
...
The KIPLATFORM stuff forces focus, but not through the SetFocus()
call.
Fixes https://gitlab.com/kicad/code/kicad/issues/6657
2020-12-08 17:46:10 +00:00
d1a9efa5fc
Try out an animating, obscuring infobar.
2020-12-08 15:05:35 +00:00
b1f0bf7334
More consistent naming.
2020-12-08 13:05:39 +00:00
abb5cb8310
Fix up msg panel status on save slightly
...
- pcbnew should use status bar on success like eeschema
- Add a helper to clear msgpanel and set it in one go to avoid redraw delays due to doing processing in between
2020-12-08 00:28:07 -05:00
27fa3a422a
Restore trace strings in the tool stack
...
This is a partial revert of d43eefbad5
2020-12-07 22:03:43 +00:00
413ff4525b
DIALOG_CONFIGURE_PATHS: fix issue: html help window never destroyed.
...
Once the help button is clicked, the html help window is created but never destroyed.
It prevent Kicad to be fully closed
(closing Kicad does not fully close Kicad and leave something like a zombie process)
2020-12-07 10:28:54 +01:00
d0f9503ee0
Add grouping for violation severities.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6616
2020-12-06 19:14:48 +00:00
3e6b658b92
Use stronger language when talking to wx.
2020-12-06 14:57:26 +00:00
9234745d6d
Formatting.
2020-12-06 11:51:14 +00:00
d43eefbad5
Formatting.
2020-12-05 19:44:01 +00:00
3704c1cdb7
New icons for v6
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2542
2020-12-05 11:17:15 -08:00
8781ce7efb
Huge performance win for Preferences.
...
The Hotkey list was recalculating the widths of all columns on
every single cell addition.
2020-12-05 01:19:10 +00:00
4d3224a9cb
Fix off-by-one error when deleting single marker.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6625
2020-12-04 14:01:54 +00:00
c47871e775
EDA_BASE_FRAME::ShowInfoBarMsg: add option to show a close button.
...
Same for EDA_BASE_FRAME::ShowInfoBarError and EDA_BASE_FRAME::ShowInfoBarWarning
2020-12-04 14:45:14 +01:00
0533a23185
Fix/workaround GTK libtree issue with multi-unit symbols
...
When preparing for clearing the tree, GTK requires walking through
parents. After calling "Freeze()" to protect against returning bad data
(see #6458 and #4471 ), we can no longer access Parent() from GTK and the
tree cannot be cleared.
The fix is to collapse the first element if it is open. This prevents
the common case of the history elements being expanded in the tree
Fixes https://gitlab.com/kicad/code/kicad/issues/6102
(cherry picked from commit 7eea344f91
2020-12-03 14:39:05 -08:00
e0b4e5135c
Tilt real-estate allocation more toward net membership.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6601
2020-12-03 15:58:17 +00:00
599a33a9c6
Make PLEditor greedy selections of rectangles sparse.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6278
2020-12-02 23:18:33 +00:00
64f555079a
Code cleanup related to zoom:
...
- remove outdated code or comment coming from old drawing code using wxDC
- move zoom values lists to zoom_defines.h
- fix incorrect zoom max and min values (gal scaling factor limits).
2020-12-02 18:35:28 +01:00
71ab42e60a
Minor fixes and cleanup related to zoom definitions.
...
Mainly move 2 define relative to Zoom from convert_to_biu.h to zoom_defines.h.
Will make some changes/fixes in zoom code more easy.
2020-12-02 10:14:35 +01:00
4b2d9a5054
Don't draw ruler ticks outside the viewport.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6518
2020-12-02 00:29:00 +00:00
df262eaa06
Make prev/next marker work reliably on all platforms.
...
Requires us to move from arrow-keys to our own commands (the only
way that the OSX wxWidgets impl doesn't eat the keys when the dataVIew
has focus).
While there we might as well add a command to exlucde markers.
ADDED Prev Marker, Next Marker, Exclude Marker
Fixes https://gitlab.com/kicad/code/kicad/issues/6575
Fixes https://gitlab.com/kicad/code/kicad/issues/5501
2020-12-01 22:37:07 +00:00
3c521942ed
Smarten isEmpty checks to include nothing-but-whitespace.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6567
2020-12-01 16:39:06 +00:00
7f8faffa3a
Trim down ever-expanding context menu.
2020-12-01 14:04:01 +00:00
308ab8cafa
Properly scale the ticks for all imperial units on the preview ruler
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6564
2020-12-01 01:20:28 +00:00
de9d1eb93e
Don't write local settings of imported project into current settings.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6552
2020-11-30 23:10:21 +00:00
3a9a6e22bc
Fix issues in reporting netclasses.
...
1) make sure we get the default netclass when we want it
2) escape for HTML (particularly important for "<invalid>", but also
for reporting user rule names, netclass names, etc.)
2020-11-30 14:38:06 +00:00
e09271ca0e
Fixes for hole clearance and hole-to-hole tests.
...
1) Separate out CONSTRAINT types
2) Filter both source and dest pads/vias for drilled holes when doing
hole-to-hole checks. We were checking the items being put into the
DRC RTree, but not the items we were scanning.
3) Add hole clearance to Board Setup Constraints panel.
Fixes https://gitlab.com/kicad/code/kicad/issues/6546
Fixes https://gitlab.com/kicad/code/kicad/issues/4683
2020-11-29 23:35:23 +00:00
d3d26f2892
Update the zoom level as soon as it is modified by the mouse wheel
...
The zoom level displayed on the bottom of the canvas was not immediately
displayed, only after a mouse move.
Fixes #6542
https://gitlab.com/kicad/code/kicad/issues/6542
2020-11-29 17:46:24 +01:00
3b18fa84bf
Null pointer safety (from Coverity).
2020-11-29 10:57:45 +00:00
056ff36b4b
Fix indentation in migrate settings dialog.
2020-11-29 10:57:45 +00:00
b8303a3484
Fix migrate settings dialog ui bug
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6258
2020-11-29 08:41:15 +00:00
f2ba9f7ac3
CADSTAR PCB Archive Importer: Correctly load the pad numbers as per the original design
...
To load the pad numbers correctly we need to also check the PART DEFINITION for each component
2020-11-28 17:18:17 +00:00
005c3b84ad
Better fix for incorrect page preview in Page Settings when the worksheet contains a bitmap
...
The actual size of pixels was incorrectly set.
Fix also bad names for a few vars and methods in BITMAP_BASE.
2020-11-28 10:53:26 +01:00
896ad4a749
Rewrite PCBNew selection disambiguation based on shapes.
...
The new shape architecture gives us the opportunity to make text
selection much more intuitive by actually looking at the glyph
shapes. Before text would be selected when you clicked in the
descenders area (which was usually blank given uppercase letters
and digits).
Fixes https://gitlab.com/kicad/code/kicad/issues/6525
2020-11-27 22:03:14 +00:00
4f651901aa
Fix incorrect page preview in Page Settings dialog when the worksheet contains a bitmap
2020-11-27 15:42:27 +01:00
ef75ce9035
Fix: refusal of creation of non-existent directory tree on plotting
...
Fixed https://gitlab.com/kicad/code/kicad/-/issues/6394
wxWidgets uses wxFileName::Mkdir to create a directory tree like `mkdir
-p`.
2020-11-27 07:24:14 +00:00
fc2bdc49de
Once more into the depths of hell... er, I mean fix a focus issue.
...
So the new steals-focus protection stuff works well when there's a
focused control, but not as well when there's a modal dialog up which
happens not to have a focused control (or worse, a focusable control).
This adds a second mechanism for also checking to see if a modal dialog
is up (something that wxWidgets, true to form, makes very difficult).
Fixes https://gitlab.com/kicad/code/kicad/issues/6520
2020-11-26 16:47:40 +00:00
2a87980d45
Remove overly verbose messaging.
2020-11-26 16:47:40 +00:00
94de8ada97
Formatting and naming conventions.
2020-11-26 16:47:40 +00:00
b8414174af
Duplicate Eeschema's select-ref-number strategy in PCBNew.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6504
2020-11-25 17:13:00 +00:00
f436360196
Consistency in capitalization and plurality.
2020-11-25 17:13:00 +00:00
d50d728d19
Cleanup compiler warnings
2020-11-25 00:08:09 +00:00
9c7c05c161
Mostly formatting cleanup but a few type-casting cleanups too.
2020-11-24 22:16:41 +00:00
696fc7e46e
Fix a minor issue in PANEL_SETUP_NETCLASSES, when resizing it. Second attempt.
...
If a class name choice widget is selected, resizing the panel does not
move the opened widgets, until it is closed.
Fixes #6474
https://gitlab.com/kicad/code/kicad/issues/6474
2020-11-24 17:03:48 +01:00
dbc7831d0c
Potential fix for recursive error crash.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6471
2020-11-24 13:48:33 +00:00
1b7bfa2424
Revert "Fix a minor issue in PANEL_SETUP_NETCLASSES, when resizing it."
...
This reverts commit 52d8b70d3a
2020-11-24 14:36:12 +01:00
52d8b70d3a
Fix a minor issue in PANEL_SETUP_NETCLASSES, when resizing it.
...
If a class name choice widget is selected, resizing the panel does not
move the opened widgets, until it is closed.
Fixes #6474
https://gitlab.com/kicad/code/kicad/issues/6474
2020-11-24 11:29:37 +01:00
78b505f36a
Count head and tail lists as well.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6461
2020-11-23 23:54:54 +00:00
298bc13f5d
Delay deletion of the RC_ITEM tree nodes
...
The wxWidgets call "ItemDeleted" still requires access to the item in
memory, so we delay deletion by storing removed items to the end of the
call
Fixes https://gitlab.com/kicad/code/kicad/issues/6301
2020-11-23 09:52:46 -08:00
064ebd4dc8
Minor fix for include files.
2020-11-23 11:43:22 +01:00
b32c2a6c90
Refactor EDA_TEXT::TransformToSegmentList() to return a vector of points
...
This allows reading text object as it is rendered through python API.
2020-11-23 07:50:54 +00:00
e761df17f5
Netnames are case sensitive.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6460
2020-11-23 01:10:08 +00:00
c1b94f9ebf
Handle escaped netnames better.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6404
2020-11-22 18:20:13 +00:00
3a4bd6fb8b
Fix uninitialized variable.
2020-11-21 20:57:36 +00:00
1391774f64
Re-factor boundary/courtyard checker error handling.
...
ADDED Footprint Checker dialog to display the results in.
Fixes https://gitlab.com/kicad/code/kicad/issues/6446
2020-11-21 20:57:35 +00:00
Jon Evans
Ian McInerney
Wayne Stambaugh
Jeff Young
Roberto Fernandez Bautista
Marcus A. Romer
Thomas Pointhuber
jean-pierre charras
Marek Roszko
Mikolaj Wielgus
Dominik Wernberger
Jonathan Haas
Seth Hillbrand
Konstantin Baranovskiy
Tomasz Wlostowski
PJM
Adam Wolf
Tokita, Hiroshi
Zoltan Gyarmati
Simon Richter
Michael Kavanagh
mitxela
Alexis Lockwood
Hanya
Drew Fustini
lê văn lập
Ben Dooks
RigoLigoRLC
qu1ck