9782 Commits

Author	SHA1	Message	Date
Jeff Young	00fc225306	Give <esc>-with-no-selection-clears-net-highlight a test. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8760	2022-07-09 11:56:16 -06:00
jean-pierre charras	fb5604022c	Eeschema: DIALOG_SCH_FIND: ensure the search flags actually used are up to date. ... Flags are encoded using internal wx values, that can change with wxWidgets versions. They need to be always rebuilt from the displayed options in dialog. Fixes #11960 https://gitlab.com/kicad/code/kicad/issues/11960	2022-07-09 10:28:53 +02:00
Jeff Young	70aec5d576	Don't drag both ends after Break Wire. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11915	2022-07-08 23:03:41 -06:00
Jeff Young	0953395c87	LIB_SHAPE slightly abuses SHAPE_POLY_SET by using it for line chains. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11956	2022-07-08 21:35:40 -06:00
Jeff Young	ded611aed5	Patch annoying large checkbox cols in wxWidgets 3.1.x on OSX.	2022-07-08 17:27:05 -06:00
Jeff Young	5479514819	Honour m_resolveTextVars flag for properties as well as fields. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11937	2022-07-08 17:27:05 -06:00
Jeff Young	a16fc5b537	Go back to native headers for Symbol Fields dialog. ... Some of the drag issues are fixed in wxWidgets 3.1.x, and the balance of problems now favours native. Fixes https://gitlab.com/kicad/code/kicad/issues/9771 Fixes https://gitlab.com/kicad/code/kicad/issues/11835 Fixes https://gitlab.com/kicad/code/kicad/issues/11836	2022-07-08 17:27:05 -06:00
Jeff Young	fe1bff7d29	Remove empty infobar message. ... I'm not sure what this was for, but it seems like a bad idea and I got a few crashes near here.	2022-07-08 17:27:05 -06:00
Jeff Young	62cef3d830	Add LAYER_PRIVATE_NOTES for private text & graphics in symbol editor. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11957	2022-07-08 17:27:05 -06:00
jean-pierre charras	f47a4ec92a	Eeschema: fix typo in commit 428bbc2 that make it not working.	2022-07-08 09:48:34 +02:00
Seth Hillbrand	428bbc201b	Ensure last column of csv export has terminator ... Last shown column can be different from the last exported column Fixes https://gitlab.com/kicad/code/kicad/issues/11981	2022-07-07 11:23:18 -07:00
Seth Hillbrand	6fef054c51	Handle basic rounding error in schematic import ... The fractional part of Altium schematic units is an integer number of 1/10000 mil segments, which is 2.54 nm. The internal unit of eeschema is 10 nm, so each fractional unit in Altium is 0.254 base eeschema units. To be consistent with cf33cfcad1 we round to the nearest 10nm for each element Fixes https://gitlab.com/kicad/code/kicad/issues/11742	2022-07-07 11:13:11 -07:00
jean-pierre charras	4db72f2d55	Fix minor compil and Coverity warnings.	2022-07-07 12:38:34 +02:00
jean-pierre charras	7b28804f67	Fix a minor compil and Coverity warning	2022-07-06 13:54:17 +02:00
Seth Hillbrand	ff54b8c718	Overplot schematic symbol fields and pins ... In the absence of z-ordering, we need to ensure that pin text and symbol fields are always visible in plots as they are in the schematic window. We do this by overplotting the fields/pins when symbols overlap each other. This can be removed if/when we implement https://gitlab.com/kicad/code/kicad/-/issues/2211 Fixes https://gitlab.com/kicad/code/kicad/issues/11969	2022-07-05 16:39:53 -07:00
Miklos Marton	d30af7c164	eeschema: Add automatic rotate feature for placing global and ... hierarchial labels	2022-07-05 17:02:45 +00:00
Seth Hillbrand	cde30d3dba	Clarify cross-probing options ... Previous the cross-probing options were mixed between sending and receiving cross-probe events. This clarifies so that all of the pcbnew cross-probe options deal with whether the cross-probe is seen in pcbnew and all of the eeschema options deal with seeing the event in eeschema. Also updates the wording in the options panels to be the same where possible and adds tooltips Fixes https://gitlab.com/kicad/code/kicad/issues/11454	2022-07-01 16:47:09 -07:00
Seth Hillbrand	939313088e	Units are stored in the instance data ... At the moment, units are stored in the instance data, so when loading the file, all symbols will have bbox for the first unit. After calling `UpdateUnit()`, we need to recache the rtree bounding boxes to get correct hit tests Fixes https://gitlab.com/kicad/code/kicad/issues/11681	2022-06-30 14:59:17 -07:00
Marek Roszko	9b0531db54	Drop xsl/xslt files ... Users may still use xsltproc with kicad as the invocation of third party tools remains. We simply are not maintaining these xsl sample scripts anymore nor bundling xsltproc. Fix https://gitlab.com/kicad/code/kicad/-/issues/9074	2022-06-29 21:22:34 -04:00
Mike Williams	66b3b48e93	Library Editor: Fix missing automatic annotation ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11818	2022-06-29 14:17:21 +00:00
Jeff Young	dbbdc9d2e6	Don't rely on the penWidth already being set when setting the dash style. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11908	2022-06-29 07:34:45 -06:00
Jeff Young	4a8aaefdc0	Implement line style printing for LIB_SHAPE. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11883	2022-06-29 07:34:45 -06:00
Seth Hillbrand	66d3bf2bc2	Refresh draw objects when common settings change ... Common settings may change colors so make sure that we refresh the draw objects when the settings change to draw them in the proper colors. Failing to do this may also cause left over lines on the screen depending on OpenGL drivers Fixes https://gitlab.com/kicad/code/kicad/issues/11921 (cherry picked from commit 8aabdcff9c)	2022-06-28 16:46:19 -07:00
Seth Hillbrand	6a8519dfd9	Fix ERC error missing on stacked pins ... Stacked pins are not connected, so they should be flagged as such. This checks for stacked pins that are not part of different symbols Fixes https://gitlab.com/kicad/code/kicad/issues/11926 (cherry picked from commit 90ef84b958)	2022-06-28 15:04:14 -07:00
Wayne Stambaugh	4e7b5b9784	Eeschema: fix project rescue bug. ... When a rescue library already existed, the disabled writing of legacy symbol library table entries prevented the rescue library from being updated. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11897	2022-06-28 15:05:06 -04:00
Mike Williams	252afe41f3	Schematic: remove old, invalid angle choice from editing options	2022-06-28 16:29:14 +00:00
Jeff Young	83a2f43661	Apply DRC fixes to ERC. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11844	2022-06-27 21:07:03 -06:00
Jeff Young	d5a6452934	Get rid of special default line style for Eeschema. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11882	2022-06-27 19:12:45 -06:00
Jeff Young	d9cfbc7b96	Fix missing SCH_LABEL case in SCH_PLUGIN. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11913	2022-06-27 16:21:32 -06:00
Jeff Young	14886e426b	Move prior fix from SCH_GLOBAL_LABEL to SCH_LABEL_BASE. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11768	2022-06-26 20:55:25 -06:00
Seth Hillbrand	03c279ffd4	ADDED: Threadpool ... Thread pools are long-lasting executors that have close to zero overhead when launching new jobs. This is advantageous over creating new threads as we can use this for threading smalling jobs and smaller quanta. It also avoids the heuristics needed to determine the optimal number of threads to spawn	2022-06-24 22:59:24 +00:00
jean-pierre charras	de45e2b1fd	Textbox in symbols: fix incorrect position of the box when printing. ... Fixes #11884 https://gitlab.com/kicad/code/kicad/issues/11884	2022-06-24 17:08:29 +02:00
jean-pierre charras	554b31bb2a	eeschema: fix crash when changing the GAL engine, especially if the grid is shown. ... GetGAL()->DrawGrid() was called when switching the engine, outside a paint event, thus creating a crash (at least on Windows) probably because the new Gal stuff was not fully initialized.	2022-06-24 15:49:28 +02:00
Seth Hillbrand	7b9dc1b9f0	Fix Eeschema Arc plotting ... The start/end point plotting is not reliable for eeschema. We need to preconvert to angles to get the correct winding as the default plotter conversion in the PLOTTER class makes pcbnew-based assumptions Fixes https://gitlab.com/kicad/code/kicad/issues/11885	2022-06-22 16:46:28 -07:00
Ian McInerney	b51d8c9825	Introduce new CMake variable to store kiface install location	2022-06-22 23:40:25 +01:00
jean-pierre charras	82b2df67be	Add 2 automatically generated files to the source tree. ... These files are needed by translators, so it is better to add them to the source without need to build kicad.	2022-06-22 08:51:04 +02:00
Seth Hillbrand	a852286eb5	Cleanup compile warnings	2022-06-21 17:04:56 -07:00
Miklós Márton	f2382a7bd1	Add Make selected active/inactive actions to the symbol libraries ... context menu Fixes #11372	2022-06-21 23:32:02 +00:00
Seth Hillbrand	aeef5b00a8	Unify symbol browser/editor unit display ... Fixes https://gitlab.com/kicad/code/kicad/issues/11881	2022-06-21 16:22:54 -07:00
Jeff Young	494d79423e	Fix typo. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11809	2022-06-19 20:56:22 +01:00
Jeff Young	45ab15dc95	Use unit references in status bar. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11854	2022-06-19 12:54:30 +01:00
jean-pierre charras	50b68df666	Eeschema, SCH_PIN: fix incorrect initialization of m_layer member (now is LAYER_PIN) ... m_layer was not re-initialized in CTOR, so it was the default value (LAYER_WIRE) This is incorrect for a pin, and can create errors in some functions (like IsType() ) Fixes #1818 https://gitlab.com/kicad/code/kicad/issues/1818	2022-06-17 11:01:49 +02:00
Jeff Young	34e706bcbc	Border colours and line styles for symbol editor. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11810	2022-06-16 14:52:38 +01:00
jean-pierre charras	c79dd09464	PANEL_SYM_LIB_TABLE: fix a bug in filenames from wxFileDialog dialog. ... We want the full path, so use GetPaths. GetFilenames sometimes return the full path in wxWidgets 3.1.7, not always the filename Fixes #11821 https://gitlab.com/kicad/code/kicad/issues/11821	2022-06-16 13:04:27 +02:00
Roberto Fernandez Bautista	8725c3a35f	CADSTAR Schematic: Load symbols even if part definition is incomplete ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/11671	2022-06-15 19:47:50 +01:00
jean-pierre charras	631eecd7d6	symbol_checker: better message about reference prefix.	2022-06-15 18:37:27 +02:00
Jeff Young	2c280e83c3	Handle junctions in MarkConnections. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8579	2022-06-15 16:28:33 +01:00
jean-pierre charras	b56917210d	symbol_checker: add test for valid reference prefix.	2022-06-14 20:45:26 +02:00
jean-pierre charras	1140fd0fb0	Eeschema, context menus: move edit value, ref and footprint to a submenu. ... remove also Select All menuitem from the move context menu.	2022-06-13 11:35:17 +02:00
Jeff Young	52bc2511cd	Add a radioButton mode to IMAGE_BUTTON. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11797	2022-06-12 20:09:46 +01:00
Jeff Young	c6604e3576	Labels can connect directly to symbols, other labels, etc. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11768	2022-06-12 18:15:58 +01:00
Jeff Young	69c1f88e53	Update symbol instances after sheet rename. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11782	2022-06-12 15:46:37 +01:00
Marek Roszko	08dbc3a53c	Move the symbol editor to the new filedlg customize	2022-06-11 22:59:59 -04:00
Marek Roszko	ff94d289c7	Move the eeschema standalone to the new save dialog	2022-06-11 22:06:42 -04:00
Jeff Young	a0421b172a	Add missing color swatch to Symbol Editor Text Properties. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11791	2022-06-11 22:14:14 +01:00
Jeff Young	e4798199c6	Handle alt pins in plot code. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11728	2022-06-10 22:38:01 +01:00
Jeff Young	29900cad34	Add create-wire logic to labels. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11768	2022-06-10 22:38:01 +01:00
jean-pierre charras	e0f0bb2edd	Eeschema: Fix issues when converting a label/text to another label text type. ... - make convert to/from SCH_DIRECTIVE_LABEL working. - Autoplace fields of new labels Fixes #11779 https://gitlab.com/kicad/code/kicad/issues/11779	2022-06-10 14:13:22 +02:00
jean-pierre charras	b712c2c0da	Eeschema: fixes about Hierarchy panel/pane handling	2022-06-09 19:43:09 +02:00
Jeff Young	bce1fd337b	Second tool hotkey accepts action (ie: acts as click). ... Fixes https://gitlab.com/kicad/code/kicad/issues/11729	2022-06-09 16:54:04 +01:00
jean-pierre charras	35bde4710c	Eeschema, context menu selection: move convert to ... menuitems to a submenu. ... Add also missing icons in a few menuitems. Fixes #11776 https://gitlab.com/kicad/code/kicad/issues/11776	2022-06-09 16:46:21 +02:00
jean-pierre charras	ef2e51b493	Eeschema: code refactor and fix missing save project setting when closing the sch editor.	2022-06-09 13:39:09 +02:00
Jeff Young	6bfd106bed	Add missing text colour to symbol editor textbox dialog. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11770	2022-06-09 10:37:23 +01:00
Jeff Young	b710982875	Fix broken logic for hidden pins. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11771	2022-06-09 10:37:23 +01:00
Jeff Young	6e50a3518f	Fix typo. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11769	2022-06-08 23:53:18 +01:00
Jeff Young	ec40a98fe2	wxT	2022-06-08 23:53:18 +01:00
jean-pierre charras	b401e98c80	Eeschema, hierarchy navigator: fixes and enhancements. ... Work in progress.	2022-06-08 18:23:03 +02:00
Jeff Young	46fd32b738	Update grid attributes after sorting. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11753	2022-06-08 15:25:13 +01:00
Jeff Young	34932e097c	Minor dialog cleanup.	2022-06-08 15:25:13 +01:00
Jeff Young	c55a0e4561	Separate last-created-params for textboxes from shapes. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11755	2022-06-08 15:25:13 +01:00
jean-pierre charras	185016b84b	Eeschema, Hierarchy navigator: add tool to Hide/show the panel. ... Add also a close button to the pane.	2022-06-07 11:11:10 +02:00
Jeff Young	244042ce51	Keep footprint selection in Symbol Chooser history list. ... Fixes https://gitlab.com/kicad/code/kicad/issues/1841	2022-06-06 22:24:02 +01:00
Wayne Stambaugh	dfea73f78c	Eeschema: fix symbol library remap bug. ... The original decision to escape the legacy symbol library names results in them being escaped every time they are opened which cause the curly braces '}' from the original escaping to be escaped on subsequent openings. This resulted in the symbol library names in the rescue library not matching the library ID in the schematic. This fix is likely to have other corner case bugs given the potential for escaped characters in legacy symbol libraries. Given that we now have escaped rescue libraries in play, removing the escaping will only result in more issues so we will have to fix the corner cases as we go. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563	2022-06-05 17:00:57 -04:00
jean-pierre charras	9f38fa43cd	Fix some minor compil and Coverity warnings.	2022-06-05 11:44:49 +02:00
Jeff Young	31316760f6	Separate power and symbol saved search strings. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11747	2022-06-04 22:15:39 +01:00
Jeff Young	718bb461d2	Textbox defaults for libedit. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11739	2022-06-04 21:25:37 +01:00
Roberto Fernandez Bautista	ecbf5c1e14	Don't display unit in single unit symbols of annotation error message ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/11748	2022-06-04 16:04:33 +02:00
Jeff Young	099061f46d	Process nested formatting within a variable cross-reference.	2022-06-04 00:34:14 +01:00
Roberto Fernandez Bautista	78e465bbd8	Fix crash in sch_navigate_tool when history was empty	2022-06-03 23:07:12 +02:00
Jeff Young	ce79a16ed8	Use default schematic text size for textboxes. ... Also adds support for remembering stroke info, fill info, and spin style for sch text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/11739	2022-06-03 21:48:12 +01:00
Seth Hillbrand	407514919d	Prevent null dereference	2022-06-03 10:05:55 -07:00
Mike Williams	8d51b6b6d3	Schematic: Add icons for Any/90/45 angle modes ... Also add a dark mode icon for existing 45hv icon. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11332	2022-06-03 15:04:52 +00:00
Mike Williams	857990a883	Hierarchy: turn into a left side pane ... Drop auto-closing option as well.	2022-06-02 21:56:17 +00:00
Jeff Young	aaff163d7c	Repair Eagle importer page number handling. ... The root sheet needs a page number, and the other sheets need to not have their last step in the path duplicated. Fixes https://gitlab.com/kicad/code/kicad/issues/11409	2022-05-31 17:48:38 +01:00
Jeff Young	abba1b04bd	Add "Enter Sheet" to Sheet tool (context menu & double-click). ... Fixes https://gitlab.com/kicad/code/kicad/issues/11531	2022-05-30 14:08:26 +01:00
jean-pierre charras	2701642b1b	minor fixes and French translation update	2022-05-30 11:23:20 +02:00
Jeff Young	d5d8d36d86	Implement expanding Select Connection. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8579	2022-05-29 22:51:33 +01:00
Eduardo Behr	f246646d7a	Fix severe simulation memory leaks	2022-05-28 20:40:24 +00:00
Mike Williams	f2cf934083	Schematic: Annotation Tweaks ... Fix newly placed symbols to be annotated and not show a ? until placement.	2022-05-27 15:54:00 +00:00
Mike Williams	efa23a5cbe	Schematic: better automatic/recursive annotate	2022-05-27 15:54:00 +00:00
Mike Williams	7f3e5e9b79	Schematic: add recursive annotation control	2022-05-27 15:54:00 +00:00
Mike Williams	85516a4691	Schematic: add automatic annotation toggle	2022-05-27 15:54:00 +00:00
Mike Williams	dabd42bbc4	Schematic: Automatic Symbol Annotation	2022-05-27 15:54:00 +00:00
Jeff Young	6114a5d72c	Escape pin names when used as netnames. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11687	2022-05-26 23:54:55 +01:00
Jeff Young	cb15bd1635	Fix compile issue.	2022-05-26 10:54:54 +01:00
Jeff Young	616e9b4f4b	Be cognizant of symbol transform when setting justification. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11465	2022-05-26 10:54:08 +01:00
Roberto Fernandez Bautista	55f22c526a	Fix annotation of incomplete multi-unit symbols and re-annotation of duplicates ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/11496	2022-05-26 09:23:36 +00:00
Seth Hillbrand	11ae5b75b7	Remove broken assert ... Fixes compile issue for linux/gcc which expects a boolean in the assert statement that it cannot find from std::map	2022-05-25 16:36:47 -07:00
Eduardo Behr	6aa50304d9	Eeschema: Fixing simulation plot CSV exporter	2022-05-25 15:00:03 +00:00
Miklós Márton	487c8f8e39	symbol editor: Improve pin duplication ... When duplicating pins in the symbol editor the duplicated pins will have unique pin numbers assigned if the duplication target had the pin number specified	2022-05-25 00:02:16 +00:00
Fabien Corona	0536ab4f6c	Remove kicad_pair in transmission lines ... This was a misread from the ngspice doc	2022-05-25 00:00:07 +00:00
jean-pierre charras	eae5e9f00e	Symbol checker: fix incorrect test for duplicate pins. ... Fixes #11660 https://gitlab.com/kicad/code/kicad/issues/11660	2022-05-23 11:20:12 +02:00
Roberto Fernandez Bautista	ea29c66608	Fix formatting	2022-05-22 07:14:24 +00:00
Chetan Shinde	4e5febdb19	Fixes the import pin issue, that the they are shown in two different way https://gitlab.com/kicad/code/kicad/-/issues/11391	2022-05-22 04:42:22 +00:00
Jeff Young	8e94c307d2	Provide default case for mirroring single objects. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11649	2022-05-21 22:50:55 +01:00
Jeff Young	d381fd8b29	Typo. ... LIB_SYMBOL's value field is the name; SCH_SYMBOL's value field is not. Fixes https://gitlab.com/kicad/code/kicad/issues/11556	2022-05-20 18:01:01 +01:00
Jeff Young	23fb4c7433	Uniformly use a single facility for location-less prime events. ... Also implements a uniform mechanism for avoiding auto-scroll after a prime event or dialog which results in a mouse position at the edge of the canvas. Fixes https://gitlab.com/kicad/code/kicad/issues/11057	2022-05-16 23:43:00 +01:00
Jeff Young	f2fc78f380	Don't copy modifiers to prime events. ... The modifiers go with the hotkey, not with the action. Fixes https://gitlab.com/kicad/code/kicad/issues/11618	2022-05-16 13:51:40 +01:00
jean-pierre charras	359c99991b	Eeschema: do not leave a temporary flag set after use in draw symbol function. ... Fixes #11617 https://gitlab.com/kicad/code/kicad/issues/11617	2022-05-15 18:35:07 +02:00
Roberto Fernandez Bautista	9049c907a1	Fix wxWidgets assert in symbol preview widgets	2022-05-15 15:26:53 +01:00
Jeff Young	79a0ce9137	Unset forced cursor before leaving two-click place. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11607	2022-05-14 22:38:54 +01:00
Jeff Young	38e5faf21b	Overhaul bitmap text for performance. ... Also adjusts metrics to better match stroke font. Also removes text-halo highlighting as it's too expensive to re-render when the zoom changes. Fixes https://gitlab.com/kicad/code/kicad/issues/11460	2022-05-14 20:09:54 +01:00
Jonathan Haas	5802ede3fd	Change default value of MatchByReference to false. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11382	2022-05-14 12:41:25 +00:00
Marek Roszko	88c7322a0d	EDA_TEXT Get/SetTextSize should use VECTOR2I	2022-05-14 08:16:15 -04:00
jean-pierre charras	45b167dff5	Some fixes related to translated/not translated mandatory field names. DIALOG_SYMBOL_FIELDS_TABLE: add new fields to symbols only if the field is not empty.	2022-05-13 11:45:38 +02:00
jean-pierre charras	20d1d0705e	Fix a few issues related to field names and their translation. - Do not use translated field names outside strings displayed in dialogs. - fix code that does not work well with default locale. - fix some (not all) I18n issues in DIALOG_UPDATE_SYMBOL_FIELDS.	2022-05-13 11:45:37 +02:00
Seth Hillbrand	bbc250720f	Resolve title variable when plotting ... Be sure to use variable name if it exists when plotting the file Fixes https://gitlab.com/kicad/code/kicad/issues/11608 (cherry picked from commit d971cbefcb)	2022-05-12 15:31:15 -07:00
jean-pierre charras	b68514afb1	Fix a wxWidgets alert.	2022-05-12 20:58:48 +02:00
Marek Roszko	5c4f49351d	Remove extra compilation of common.cpp ... It's already built in the common target, no eeschema specific code	2022-05-10 21:31:31 -04:00
Marek Roszko	f85251ef75	Fix eda_doc not looking for schematic locally ... It looks like this was overlooked by Jeff in 2020 not realizing eda_doc isn't built under eeschema but common in cc9ac37a0e	2022-05-10 21:28:48 -04:00
dsa-t	ad066ef09a	Fix cross-probing in complex hierarchies, remove unused code. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11493	2022-05-09 23:22:03 +03:00
jean-pierre charras	4bd349d922	Update some demos	2022-05-09 19:06:14 +02:00
Mike Williams	b7a77a9498	Schematic: Add CSV export to Symbol Fields Table	2022-05-09 12:02:12 -04:00
Jeff Young	8f937b17a2	Remove wxWidgets 3.0.x hack. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11540	2022-05-07 23:24:55 +01:00
Jeff Young	f9f0f6fe24	Implement cross-references for labels. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11564	2022-05-07 21:10:04 +01:00
Seth Hillbrand	5cd3c07862	Catch throws in DeleteSymbol ... DeleteSymbol may call SaveSymbol if the name is changed. In this case, SaveSymbol may throw back and needs to be caught Fixes https://gitlab.com/kicad/code/kicad/issues/11566 (cherry picked from commit e05c8f8852)	2022-05-06 16:13:59 -07:00
Miklós Márton	7e20c0ed9c	eeschema: removed unused code ... Fixes #11533	2022-05-06 17:17:55 +00:00
Jeff Young	a644aad1cf	Hand-code tab navigation from value field of Label Properties dialog. ... wxWidgets doesn't appear to handle it correctly, doing nothing on OSX and potentially crashing on GTK. Fixes https://gitlab.com/kicad/code/kicad/issues/11572	2022-05-06 18:14:25 +01:00
Seth Hillbrand	5f7ac58f95	Catch errors when saving individual symbols ... Fixes https://gitlab.com/kicad/code/kicad/issues/11566 (cherry picked from commit f4d4f23876)	2022-05-06 09:55:28 -07:00
Wayne Stambaugh	a19490b097	Eeschema: fix broken project symbol rescue. ... The legacy symbol library plugin code was changed to escape symbol names which broke the LIB_ID string comparison when checking to see if symbols needed to be rescued. Escaping the LIB_ID names before comparison resolves the issue. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563	2022-05-06 08:50:09 -04:00
jean-pierre charras	32077673e8	Symbol editor crash: Fix use of a null pointer. ... LIB_TEXT::Clone() did not copy a member set to nullptr. Fixes #11569 https://gitlab.com/kicad/code/kicad/issues/11569	2022-05-06 12:51:26 +02:00
Jeff Young	1751c8e1cf	Save selection *before* clearing it. Saving after doesn't do much good. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11242	2022-05-06 00:06:00 +01:00
Jeff Young	9c5aa5c3c1	Font and color for FIELDS_GRID_TABLE. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11459	2022-05-06 00:06:00 +01:00
Jeff Young	e80c5a4e4e	Add text colour to Edit Text & Graphics Properties. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11459	2022-05-06 00:06:00 +01:00
Simon Richter	bd7447cff3	Fix variable name ... This is the top left position, not the top right.	2022-05-05 10:27:19 +00:00
Jeff Young	f14dc9e305	Don't plot private symbol text. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11548	2022-05-03 19:41:20 +01:00
Jeff Young	babfb29c54	Formatting cleanup.	2022-05-03 13:39:14 +01:00
Jeff Young	67f352717e	Fix dodgy type-cast and init line-widths to "inherit". ... Fixes https://gitlab.com/kicad/code/kicad/issues/11535	2022-05-03 13:39:14 +01:00
jean-pierre charras	3f470359a2	Eeschema, backannotate: fix minor issues in displayed messages. ... Fixes #11530 https://gitlab.com/kicad/code/kicad/issues/11530	2022-05-03 09:20:46 +02:00
Seth Hillbrand	a56955443f	Fix botched commit ... (cherry picked from commit ba276fe470)	2022-05-02 16:29:07 -07:00
Seth Hillbrand	2079d15b3f	Catch IO_ERRORs that we throw ... FILEOUTPUT_FORMATTER likes to throw when it gets an issue. We need to catch this to avoid the app falling apart Fixes https://gitlab.com/kicad/code/kicad/issues/11516 (cherry picked from commit 4d47857738)	2022-05-02 15:15:52 -07:00
Jeff Young	f6f316bd8c	Promote field selection to field-owner for Autoplace. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11529	2022-05-02 20:11:21 +01:00
Jeff Young	d2610736ff	Fix bugs with printing bordered shapes. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11536	2022-05-02 19:45:55 +01:00
Jeff Young	585ea85f95	LIB_SHAPE default line style is SOLID, not DASHED. ... (Copy/paste error from SCH_SHAPE.) Fixes https://gitlab.com/kicad/code/kicad/issues/11527	2022-05-02 17:22:13 +01:00
Jeff Young	036d283433	Don't muck with linestyle default when setting it. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11520	2022-05-02 17:22:13 +01:00
Jeff Young	804ab5609e	Add dash-dot-dot to Edit Text & Graphics Properties. ... Also fixes a bug where textboxes and shapes weren't correctly updated. Fixes https://gitlab.com/kicad/code/kicad/issues/11522	2022-05-02 17:22:13 +01:00
jean-pierre charras	50223c9337	Eeschema print: Do not print private graphics in symbols. ... Fixes #11532 https://gitlab.com/kicad/code/kicad/issues/11532	2022-05-02 16:29:08 +02:00
jean-pierre charras	ece15b6472	Fix a compil warning (shadowed var).	2022-05-02 15:25:55 +02:00
Jeff Young	dfa6b9ed15	Reset plotter dash-style after use. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11527	2022-05-02 13:21:46 +01:00
jean-pierre charras	40c75c74fa	EEschema/Cvpcb: make assign footprints from CvPcb undoable. ... Fixes #11508 https://gitlab.com/kicad/code/kicad/issues/11508	2022-05-02 12:49:14 +02:00
Jeff Young	772bdc4bbf	Turn off auto-dialog for text objects when immediateActions == false.	2022-05-02 11:25:40 +01:00
Jeff Young	de0bb26c4c	Init global label's intersheet ref's visibility from schematic settings.	2022-05-02 09:42:38 +01:00
Miklós Márton	7ebdb4853c	Do not open label edit dialog when adding label to an already named wire	2022-05-02 08:42:15 +00:00
Jeff Young	6d44ca2145	Ellipsize long heirarchical paths. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11499	2022-04-30 14:09:30 +01:00
Jeff Young	9fbf8e6f5d	Respect default layer color for textbox borders. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11497	2022-04-29 14:10:48 +01:00
Jeff Young	dc1e063b00	Iron out some issues with linestyle handling in SCH printing and plotting. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11498	2022-04-29 13:52:30 +01:00
Jeff Young	3589eb33f0	Handle text color when printing and plotting. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11491	2022-04-29 10:51:00 +01:00
Jeff Young	2cccd5b090	Fix minor layout issue in dialog. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11490	2022-04-27 17:14:33 +01:00
Jeff Young	8a97a46e6b	Release file before re-loading it for Revert. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11481	2022-04-26 22:28:35 +01:00
Jeff Young	e0f2a5f07c	Update findnext to handle new instance data architecture. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11424	2022-04-26 20:21:15 +01:00
Jeff Young	47e002a33d	Add font to status bar for text objects.	2022-04-26 18:52:53 +01:00
Jeff Young	e6f11c5c39	Reset outline font if bold or italic changed. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11462	2022-04-26 12:52:29 +01:00
Jeff Young	85680886f8	Adjust outline font SCH_TEXT positioning so it better matches SCH_FIELD text.	2022-04-26 12:52:29 +01:00
Seth Hillbrand	25474b347c	Fix frustration with mirroring autoplaced fields ... When the user asks to mirror a symbol is is frequently to get the reference/value on the other side of the symbol for placement purposes. Autoplacing the fields here keeps the text where they were initially which can be frustating to work around. This commit treats the mirror command as a user request to change where the fields are	2022-04-25 12:50:45 -07:00
Seth Hillbrand	1a70465927	Use instance data to store values ... Previous use of instance was as an "override" of the default value. This has changed to be used as the primary storage location for all values. This means that we cannot clear the instance data when setting a new value for all instances, instead we have to change the instance data and the default value is superfluous Fixes https://gitlab.com/kicad/code/kicad/issues/11439	2022-04-25 12:47:48 -07:00
Jeff Young	f5d612eaed	Switch <insert> replacement on OSX to <f1>. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11413	2022-04-25 10:01:33 +01:00
Jeff Young	90bfe2d94b	Remove Save Copy As from fp editor, and rename to Save a Copy elsewhere. ... It's still used by Eeschema and PCBNew when not in stand-alone mode. Fixes https://gitlab.com/kicad/code/kicad/issues/9185	2022-04-24 19:46:57 +01:00
Jeff Young	6738708a7f	Disable background color when printing in black & white. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11180	2022-04-24 19:46:57 +01:00
Jeff Young	52eb210aa8	Initialize virtual page no. to something more reasonable. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11295	2022-04-24 19:46:57 +01:00
jean-pierre charras	3bc34590c7	Eeschema: fix missing call to UpdateMessagePanel() due to commit e09147db. ... EE_INSPECTION_TOOL::UpdateMessagePanel was called by EVENTS::SelectedEvent But This event after commit calls E_INSPECTION_TOOL::CrossProbe(), and no longer UpdateMessagePanel. So CrossProbe() now calls UpdateMessagePanel. Fixes #11447 https://gitlab.com/kicad/code/kicad/issues/11447	2022-04-24 18:40:10 +02:00
Jeff Young	c6f83b6dec	ADDED Duplicate Footprint, Rename Symbol and Rename Footprint.	2022-04-22 22:06:51 +01:00
Mike Williams	b42365190e	Schematic/PCB: deleting fields sets them to invisible	2022-04-21 16:20:23 +00:00
Jeff Young	eb1a238a53	Remove extra event handler. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11418	2022-04-20 16:19:42 +01:00
Jeff Young	fc2eb2d7c9	Fix missing line keeping tabs from switching. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11417	2022-04-20 14:51:08 +01:00
Seth Hillbrand	aac6f576c2	Fix broken comparison in pin_numbers ... Pin names like "+V" were incorrectly parsed as doubles leading to broken comparisons. These caused heap overflows when sorting pin tables This corrects the comparison so that numeric sorts are only performed when there is an actual number in the symbol segment. Also adds unit tests for common error cases	2022-04-19 14:46:05 -07:00
Jeff Young	4ab2c93070	Update Selection Filter title bar with language changes. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11421	2022-04-19 21:12:13 +01:00
Jeff Young	ffc28f23e5	Repair GetFullRef() and use it when running Symbol Fields Table filtering. ... (Previously GetFullRef() failed to add the number between the prefix letter and the unit designator.) Fixes https://gitlab.com/kicad/code/kicad/issues/11419	2022-04-19 19:55:30 +01:00
Jeff Young	08f15fe587	ADDED New Library functionality to Footprint/Symbol Save As. ... Fixes https://gitlab.com/kicad/code/kicad/issues/2343	2022-04-19 19:55:30 +01:00
Jeff Young	84f620a96e	Minor dialog beautification.	2022-04-19 19:55:30 +01:00
Jeff Young	c3bed8f6ee	Resolve textvars before opening file browser. ... Fixes https://gitlab.com/kicad/code/kicad/issues/6436	2022-04-18 22:45:02 +01:00
Jeff Young	cc18c31cb5	Fix some layout issues in the Project Template Selector. ... Fixes https://gitlab.com/kicad/code/kicad/issues/5222	2022-04-18 22:45:02 +01:00
Mike Williams	653baf270c	Schematic: drag created / changed segments need junction checks ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10844	2022-04-18 17:24:02 +00:00
Simon Richter	801c5deb87	Fix minimum size calculation for new hierarchical sheets ... These constants are given in mil, but are used in a context of internal units.	2022-04-18 15:01:59 +00:00
Simon Richter	1e505d4c22	Remove a few call sites of SCH_SHEET::SetSize ... This function is dangerous and should be used only by parsers, and not even those, really. For new objects, the size can be passed to the constructor.	2022-04-18 16:23:03 +02:00
Jeff Young	55a8fb39c4	ADDED filtering for Symbol Fields Table dialog. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11224	2022-04-17 20:02:58 +01:00
Jeff Young	71c2cb3180	ADDED revert for pcbnew and eeschema. ... Fixes https://gitlab.com/kicad/code/kicad/issues/6802	2022-04-17 20:02:58 +01:00
jean-pierre charras	38c54ffa8f	Eeschema, Symbol Library Browser: fix crash when left clicking on the canvas.	2022-04-17 09:54:19 +02:00
Jeff Young	e09147db30	Cross-probing for ERC dialog. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11411	2022-04-17 00:33:56 +01:00
Jeff Young	7f4f5f2882	Save and re-load query string in Choose Symbol dialog. ... While this has been requested on its own, it's primarily done here because wxWidgets decided to send a SEARCH_CANCEL from a wxSearchCtrl when hitting <ENTER> if the search control holes the empty string. This causes us to not do a symbol instert in the Chooser dialog. Fixes https://gitlab.com/kicad/code/kicad/issues/10169 Fixes https://gitlab.com/kicad/code/kicad/issues/7699	2022-04-17 00:33:56 +01:00
Seth Hillbrand	250a246761	Clear flags after we're done with them ... The CANDIDATE flag is a temporary element that should not be maintained outside of the routine in which is it temporarily set Fixes https://gitlab.com/kicad/code/kicad/issues/11361	2022-04-16 15:45:17 -07:00
jean-pierre charras	65f7d9f97a	EEschema: move symbol checker code in symbol_checker.cpp. ... - Add some tests for Power symbols. - Fix incorrect print format in some messages.	2022-04-16 18:56:06 +02:00
Seth Hillbrand	ce9bd780d1	Fix crash due to cleared view data ... When changing fields, we need to update the view before allowing canvas updates (cherry picked from commit 851f893e8e)	2022-04-15 15:14:29 -07:00
Jeff Young	4ee6cfe5b6	Disable all use of the default instance reference prefix for annotation. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11385	2022-04-14 17:55:35 +01:00
Jeff Young	6ef6e37edb	Disable using default instance data when writing to clipboard. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11379	2022-04-14 17:09:27 +01:00
Jeff Young	160240166c	Cleanup.	2022-04-14 17:09:27 +01:00
Jeff Young	034b57d9c0	When reannotating keep existing prefix in most cases. ... (Execption is reannotating entire schematic, in which case we reset all of them.) Fixes https://gitlab.com/kicad/code/kicad/issues/11379	2022-04-13 23:38:45 +01:00
Jeff Young	184b67098f	Meet user expectations on life-cycle of symbol fields. ... In other words, support empty fields. Also adds deleting fields to Symbol Fields Table. Fixes https://gitlab.com/kicad/code/kicad/issues/8999	2022-04-12 22:11:31 +01:00
Roberto Fernandez Bautista	85f6ff48e7	CADSTAR Sch: Clear symbol of all elements before overwriting with new one ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/11378	2022-04-12 21:34:23 +01:00
Jeff Young	306dfef7e5	Fix typo.	2022-04-12 19:18:15 +01:00
Jeff Young	576f3dc2fd	Keep pins aligned to grid when possible. ... This uses the first pin as the anchor point in a mulitple-item selection. Fixes https://gitlab.com/kicad/code/kicad/issues/11151	2022-04-12 18:14:21 +01:00
Marek Roszko	f88e0481c8	Change the behavior of ACTION_MENU::Add to require clones if required outside the function ... This reverts commit 2a5769607f.	2022-04-11 19:03:01 -04:00
Jeff Young	16acba34d3	Don't save schematic symbol back to lib manager. ... Also, since it doesn't get saved, changing symbols will lose any edits. Make sure to ask the user first. Fixes https://gitlab.com/kicad/code/kicad/issues/10767	2022-04-11 22:43:39 +01:00
Seth Hillbrand	2a5769607f	Revert "Change the behavior of ACTION_MENU::Add to require clones if required outside the function" ... This reverts commit 403992a6f4.	2022-04-11 11:39:03 -07:00
Jeff Young	546b3bfbc0	Select wire ends in select all. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10958	2022-04-11 19:36:54 +01:00
jean-pierre charras	f0f10a43a2	Ensure "Clear Recent Files" menuitem titles are updated after language change. ... (missing fixes in commit ac8e2d076)	2022-04-11 18:11:17 +02:00
Jeff Young	74a578047c	Make sure to add any now-necessary junctions after a rotate. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11242	2022-04-11 12:02:20 +01:00
Jeff Young	8358685920	Dual-purpose IsMovableFromAnchorPoint to keep from moving symbols off-grid. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11360	2022-04-11 12:02:20 +01:00
jean-pierre charras	ac8e2d0768	Ensure "Open Recent" and "Clear files" menu titles are updated after language change.	2022-04-11 11:09:05 +02:00
Marek Roszko	403992a6f4	Change the behavior of ACTION_MENU::Add to require clones if required outside the function ... Fix https://gitlab.com/kicad/code/kicad/-/issues/10994	2022-04-10 22:38:13 -04:00
Marek Roszko	5bb2cdf73d	Revert "Stop leaking submenu items" ... This reverts commit 34c70a51ea.	2022-04-10 22:33:43 -04:00
Marek Roszko	34c70a51ea	Stop leaking submenu items ... Our menu bar code is interestingly complex. But we were throwing away newly made menu items to the void in the cases of constructed on the fly submenus	2022-04-10 22:04:48 -04:00
Jeff Young	117bd4fc22	Adjust LIB_SYMBOL compare for use with ERC. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10783	2022-04-09 20:12:29 +01:00
Roberto Fernandez Bautista	0015574a60	${SHEETNAME} represents the sheet name + introduce ${SHEETPATH} ... CHANGED: The text variable ${SHEETNAME} now always represents the name of the sheet when used anywhere in the schematic editor, including the title block ADDED: A new text variable ${SHEETPATH} which is replaced with the path to the current sheet - e.g. "/Sheet 1/Sheet 2". To ensure backward compatibility, the default drawing sheet now uses ${SHEETPATH}. Custom drawing sheets will need to be manually edited.	2022-04-09 15:45:58 +01:00
Wayne Stambaugh	239f0214ac	Eeschema: add support for default schematic symbol instance data. ... Prior to fixing the schematic file change churn do to instance data changing to the last selected sheet instance, the symbol instance data was set rather than empty. This change allows for users to set the default instance data which is used for every new instance of the schematic. ADDED: Default schematic symbol instance data (unit and reference, value, and footprint fields) can be set to be used as the default settings for all new instances of the schematic. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11113	2022-04-09 07:49:36 -04:00
Jeff Young	007906cd16	Fix a degeneracy bug in arc collisions. ... This also fixes a failure to use the correct effective width for shapes (which might, for instance, inherit their widths from schematic defaults, netclasses, etc.). Fixes https://gitlab.com/kicad/code/kicad/issues/11358	2022-04-08 16:15:58 +01:00
Seth Hillbrand	702623ef87	Don't flag pin missing driver when there is an NC ... The NC flag indicates user intention to override the lack of connection to input pins (cherry picked from commit e02229a234)	2022-04-07 09:35:23 -07:00
Jeff Young	c17b90c8dc	Run pinning on sides as well as corners. ... Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339	2022-04-07 11:51:58 +01:00
Seth Hillbrand	4b0b4c0ddc	Show non-driven error on single-pin nets ... Better to have both the single-pin error message and the non-driven error message when an input pin is not connected than miss error messages when the pin is connected to a blank net Fixes https://gitlab.com/kicad/code/kicad/issues/10430 (cherry picked from commit e740db61f5)	2022-04-06 16:54:04 -07:00
Jeff Young	356d565d48	Normalize rectangular shapes before feeding to point editor. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11339	2022-04-06 18:18:29 +01:00
Jeff Young	67d54ecb4c	A bit of dialog layout cleanup.	2022-04-06 16:58:26 +01:00
Jeff Young	06df90636b	Rationalize negative line-width handling. ... Make "don't stroke" an explicit property in the GUI. Silently enforce line width to >= 0 when stroking. Make layouts between dialogs more consistent. Interpret unspecified fill colour as layer colour. Fixes https://gitlab.com/kicad/code/kicad/issues/11279	2022-04-05 23:59:25 +01:00
Sylwester Kocjan	a9c61d21ca	eeschema: fix crash when closing simulation frame ... Destructor of SIM_PLOT_FRAME calls sim->Attach( nullptr ) in order to destroy circuit model (former netlist exporter). If this is skipped, eeschema crashes when program is closed. nullptr is a valid parameter for Attach()	2022-04-05 19:28:05 +00:00
Jeff Young	1594df3498	Fix egregious typo.	2022-04-05 20:10:25 +01:00
Jeff Young	0bd3341f0f	Allow textboxes to have no text. (They still have a defined box.) ... Fixes https://gitlab.com/kicad/code/kicad/issues/11286	2022-04-05 16:29:21 +01:00
Jeff Young	ed361925ba	Repair code that was supposed to be after LoadSymbol(). ... (Even the comment said so.) Fixes https://gitlab.com/kicad/code/kicad/issues/11199	2022-04-05 14:38:05 +01:00
Jeff Young	68ca385e07	On-the-fly translations for pin electrical types. ... Also add on-the-fly translation for editor title bars. Fixes https://gitlab.com/kicad/code/kicad/issues/11324	2022-04-05 13:57:28 +01:00
Jeff Young	3196857449	Fix incorrectly initialized variable. ... The SCH_ITEM default is LAYER_WIRE, which we don't want for a symbol. Fixes https://gitlab.com/kicad/code/kicad/issues/11307	2022-04-05 13:57:28 +01:00
markus-bonk	dc8556726b	Fix building QA tests with options -DKICAD_USE_3DCONNEXION=ON	2022-04-05 06:47:49 +00:00
Jeff Young	3f9cfc0ac1	Fix incorrect m_SyncPinEdit setting. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11331	2022-04-04 16:56:53 +01:00
Sylwester Kocjan	05fbe47a1b	eeschema: two fixes for simulation tuners ... - fix irrelevant warning message box when tuners moved too quickly and simulation was slow - fix for rerun simulation when tuning and result tab was changed	2022-04-02 15:05:54 +00:00
Seth Hillbrand	0625e20fc0	Cleanup spacemouse plugin ... Sets std:: convention and unifies the defined/non-defined interface	2022-04-01 15:14:41 -07:00
Jeff Young	a12f77b8f6	Don't render fills in black & white mode. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11303	2022-04-01 21:24:56 +01:00
Seth Hillbrand	5d5a2f9270	Allow common greek letters in passive regex ... Adds common letters (µ and Ω) as prefix and unit Fixes https://gitlab.com/kicad/code/kicad/issues/11289 (cherry picked from commit 15fe2f2fd0)	2022-04-01 12:51:43 -07:00
Sylwester Kocjan	4719fdc9bf	eeschema: rename m_exporter to m_circuitModel	2022-04-01 19:28:31 +00:00
Sylwester Kocjan	f5dedd77c6	eeschema,sim: add SIMULATOR and SIM_MODEL interface ... SIMULATOR has now an Attach() method, which should be called with proper SIMULATION_MODEL that should be simulated, before calling Run() Concrete class of SIMULATION_MODEL for ngspice is NGSPICE_CIRCUIT_MODEL, renamed from NETLIST_EXPORTER_PSPICE_SIM. DIALOG_SIM_SETTINGS relies on above mentioned object, so it was added as an argument of the constructor.	2022-04-01 19:28:31 +00:00
jean-pierre charras	be6379a8f6	Fix minor Coverity and compil warnings.	2022-04-01 20:43:21 +02:00
Jeff Young	6f818f4c2e	Editing support for sheet-pin fonts, text styles and text colors. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11300	2022-04-01 19:26:27 +01:00
jean-pierre charras	5d9668938b	SYMBOL_EDITOR_CONTROL::DuplicateSymbol(): fix incorrect validation test. ... DuplicateSymbol() is called both to duplicate and paste. Only duplicate needs a test to know if a symbol is selected. Fixes #11053 https://gitlab.com/kicad/code/kicad/issues/11053	2022-04-01 10:42:20 +02:00
Seth Hillbrand	49c48e2fe0	Consistently handle env/prj variables ... User-defined variables cannot be used for internally-reserved variables Fixes https://gitlab.com/kicad/code/kicad/issues/11232 (cherry picked from commit c23679d9bd)	2022-03-31 17:05:53 -07:00
Jeff Young	6b99a937d8	Look for sheet pins inside sheets. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11297	2022-03-31 22:10:45 +01:00
markus-bonk	1a9ef4bd0f	Add support for using a SpaceMouse to pan & zoom in the schematic editor.	2022-03-31 19:03:41 +00:00
Jeff Young	e8a543f1ea	Colors for text in PL_Editor and Eeschema. ... Fixes https://gitlab.com/kicad/code/kicad/issues/1952	2022-03-31 19:43:56 +01:00
Jeff Young	748cc1a59a	Pay better attention to aPlotter->GetColorMode(). ... Fixes https://gitlab.com/kicad/code/kicad/issues/11287	2022-03-30 20:38:24 +01:00
Jeff Young	7c21a0bdd4	Dirty text render caches in point editor. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11284	2022-03-30 16:32:23 +01:00
Jeff Young	5c7b022f40	Be more pedantic about setting GAL line width. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11280	2022-03-30 16:32:23 +01:00
Jeff Young	91ea0903d0	Add infobars for individual-item-color-overrides.	2022-03-29 20:41:03 +01:00
Jeff Young	8dc680adbb	Implement align-to-grid for sheets. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11201	2022-03-29 19:31:02 +01:00
Seth Hillbrand	719874fe9c	Thread the connectivity vector updates ... Now that we are dealing with individual connection elements that do not update their connected elements as well, we can thread the update, just being careful to guard any remaining updates (bus_enty/busLine) that need reciprocal updating Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit 6a53e318e5)	2022-03-28 15:36:55 -07:00
Seth Hillbrand	6a33bcdc78	Avoid generating SCH_CONNECTION if not needed ... If the SCH_ITEM has already been processed, the extra time needed to iterated over the memberset and get the SCH_CONNECTION when we won't use it is not neccesary. Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit 776a28a10e)	2022-03-28 15:36:55 -07:00
Seth Hillbrand	41f7354b7a	Handle connection vector inline ... Normally, you will gain by resursing a nested loop only over the pairs that are not already handled. In this case, however, you lose time because you step outside of the cache by adding the reciprocal test at each step. Instead, we process one element at a time, keeping it cached and loop over all other elements to add to the connection. This saves us about 75% of the time for larger loops (e.g. stacked power pins on a large BGA) Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit 3a98eacdb9)	2022-03-28 15:36:55 -07:00
Jeff Young	09ba7468ae	A better is-modified test. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10791	2022-03-28 21:54:24 +01:00
Jeff Young	4ee6f9e138	Make sure setting the cursor gets put into the right tool context. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10141	2022-03-28 21:54:24 +01:00
Seth Hillbrand	8706bea3c6	Fix renamed flag ... Snuck in between MR reviews	2022-03-28 13:50:44 -07:00
Mike Williams	2a726a882f	Schematic: new feature, force 45 degree lines ... * New modes to force 45 deg angle at beginning or end of line * Backspace will undo most recent segment added * / will toggle posture of 90 and 45 degree lines * Added alg::signbit for convenience Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869 Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175	2022-03-28 16:07:23 -04:00
Mike Williams	e51ab86225	Schematic Drag: fixes and improvements ... Fixes: * Various special cases around junctions on pins and dragging. * Some rotations of endpoints resulting in a 45 degree rotate. * Some cases where it was possible to get a line with neither endpoint selected, and also substractive unselecting only one of two selected endpoints unselecting both. * Use line midpoint for sorting. Start and endpoints aren't consistent in the order they appear on the X or Y axis. So, we need to use the midpoint for our position for consistent sorting when dragging groups of parallel lines where some have the start and end reversed. Other: * Rename TEMP_SELECTED TO SELECTED_BY_DRAG. This is the actual meaning of the flag, and should reduce confusion as to when it should be used. * Move usage of TEMP_SELECTED as an algorithmic mark to CANDIDATE instead. * Fix mistaken clearing of START_POINT and ENDPOINT. * Move endpoint setting and clearing out of narrowSelection, and into selectPoint and selectMultiple. * Don't show dangling end warnings on new lines	2022-03-28 16:02:48 -04:00
Jeff Young	47f4503564	SCH textboxes start/end -> at/size. ... The at token can handle an angle; start/end does not. Fixes https://gitlab.com/kicad/code/kicad/issues/11252	2022-03-28 11:16:39 +01:00
Jeff Young	343b2681d4	Midpoints for eeschema rectangles and text boxes. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10362	2022-03-28 11:16:39 +01:00
Jeff Young	265ff90e19	Use selection highlight color for sel shadows even when brightened. ... This allows Find & Change to show both matches and current match. Fixes https://gitlab.com/kicad/code/kicad/issues/11101	2022-03-28 11:16:39 +01:00
jean-pierre charras	cfe0003ca4	Eeschema: fix misplaced nullptr test that prevent saving SCH_TEXT items. ... Fixes #11250 https://gitlab.com/kicad/code/kicad/issues/11250	2022-03-27 18:48:55 +02:00
jean-pierre charras	38bd612c01	sch_sexpr_parser.cpp: allows reading a polyline descr with more than 2 points ... In symbols, a polyline descr is already a true polyline / polygon descr. In schematic, a polyline descr was restricted to only 2 points (a line). A true polyline / polygon descr is now allowed in schematic that support already polygons. For compatibility reason, a 2 points polygon (SCH_SHAPE) is converted to a SCH_LINE.	2022-03-27 10:31:21 +02:00
Jeff Young	48dd810cd1	ADDED grouping of selected pins in Pin Table. ... Fixes https://gitlab.com/kicad/code/kicad/issues/4956	2022-03-26 21:07:10 +00:00
Jeff Young	a54457386c	Enable immediate mode for pin tool. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10156	2022-03-26 21:07:10 +00:00
Sylwester Kocjan	53ccd8bd67	eeschema,sim: refactor NETLIST_EXPORTER_PSPICE_SIM creation	2022-03-26 15:50:15 +00:00
jean-pierre charras	9a342458fa	Fix a few Coverity and compil warnings.	2022-03-26 16:21:23 +01:00
Jeff Young	0652c7b429	More visible Synchronized Pins Mode informatics. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10340	2022-03-26 15:16:08 +00:00
Jeff Young	1c158a4ea4	Use a standard HTML reporter for Symbol Checker.	2022-03-26 14:22:31 +00:00
Jeff Young	d5533e7999	ADDED unit-filtering for pin table. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9382	2022-03-26 11:53:48 +00:00
Jeff Young	e6c2b12ddf	ADDED allow pin conversion to be edited in Pin Table. ... Added a De Morgan column.	2022-03-26 11:53:48 +00:00
Jeff Young	2681ad6cfc	Don't rely on HasConversion() for Symbol Properties in Symbol Editor. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11200	2022-03-26 11:53:48 +00:00
Wayne Stambaugh	7da7864f5e	Fix some Coverity issues.	2022-03-25 15:51:05 -04:00
Seth Hillbrand	c686105afc	Correctly order swap test ... MapAngles() will modify parameters and C++ does not guarantee LTR evaluation, so we need to separate the calls into the proper order before comparing the returns Fixes https://gitlab.com/kicad/code/kicad/issues/11135	2022-03-24 09:23:50 -07:00
Jeff Young	92a229eec7	ADDED separate user-defined color for page limits. ... Fixes https://gitlab.com/kicad/code/kicad/issues/5271	2022-03-24 14:11:41 +00:00
Wayne Stambaugh	b87fc45e33	Fix broken symbol field table editor dialog. ... Do not use the symbol field string to populate the value and footprint grid cells. The field strings may be empty because the symbol has not been instantiated yet by entering a sheet. This fix makes an incorrect assumption that the first instance value and footprint data in the symbol is the same for all instances. Note: this fix is incomplete because the value and footprint fields are can now be different between sheet instances. The entire field table editor design will need to be rethought because the current grouping doesn't allow different value and footprint instance changes. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11194	2022-03-23 11:46:49 -04:00
Jeff Young	535ecb9b7b	Don't leave dangling pointers to old document when importing. ... This goes for both selection pointers and undo/redo pointers. Fixes https://gitlab.com/kicad/code/kicad/issues/10145	2022-03-22 18:08:05 +00:00
Jeff Young	8eb10c41d8	Name any unnamed fields so they don't clobber each other. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10039	2022-03-22 18:08:05 +00:00
jean-pierre charras	21144481d2	PLOTTER: do not clamp coordinates to an arbitrary value. ... Previously, coordinates were clamped to +- 60 inches. It makes no sense to clamp them at plotter level: max cooed depends on the editor (schematic/board...) Rename MAX_PAGE_SIZE_MILS to MAX_PAGE_SIZE_EESCHEMA_MILS and use it only for Eeschema. Fixes #11196 https://gitlab.com/kicad/code/kicad/issues/11196	2022-03-22 10:32:36 +01:00
Wayne Stambaugh	e336a0e403	Improve sheet schematic import messages and simplify code. ... There was also a logic bug when the selected schematic was in a different path than the current project and was already part of the current project. The symbol library table reconciliation code was still run which was wrong. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11075	2022-03-21 17:09:49 -04:00
Sylwester Kocjan	2fed8aa4b8	eeschema: Add sync functions to SPICE_SIMULATOR ... SPICE simulator can be called also during IBIS model determination, and in the future in ERC. Therefore a necessity arises to implement exclusive access.	2022-03-21 19:10:08 +00:00
Jeff Young	e77a71bf7a	Fix typo found in code review.	2022-03-21 10:32:36 +00:00
Jeff Young	4f62960334	Update message panel from PCB point editor and SCH drawing tools. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11186	2022-03-21 10:32:36 +00:00
Jeff Young	58c146a7c0	ADDED ki_description and ki_keywords to footprint properties. ... Also a bunch of wxT(). Fixes https://gitlab.com/kicad/code/kicad/issues/7783	2022-03-19 23:16:56 +00:00
Jeff Young	cc165129fd	Special case undo for items with instance data. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11102	2022-03-19 19:37:01 +00:00
Jeff Young	63b5ad7df1	Fix some issues with global-label fields' bounding boxes.	2022-03-19 19:37:01 +00:00
jean-pierre charras	2bba277c5e	Unit binder: fix hang and DIALOG_WIRE_BUS_PROPERTIES: fix uninitialized variable. ... The hang can be Windows specific.	2022-03-19 10:22:41 +01:00
Jeff Young	7b82c2ba85	Preload eeschema find with selection when appropriate. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11148	2022-03-18 23:31:30 +00:00
Jeff Young	41c0009c51	Off-grid ERC warnings. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10379	2022-03-17 20:23:56 +00:00
jean-pierre charras	77c52ad5df	Fix a compil warning (shadowed var).	2022-03-17 20:13:17 +01:00
Jeff Young	400cff994d	Update value & footprint from clipboard whether keeping annotation or not. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11116	2022-03-17 18:19:13 +00:00
Seth Hillbrand	deb7a0beff	Avoid marking symbols that will not be processed ... We want to shorting the processing time by marking symbols that have already been processed. But we must avoid marking symbols that will not be processed due to their other flags Fixes https://gitlab.com/kicad/code/kicad/issues/11164 (cherry picked from commit 2208e0db16)	2022-03-17 10:10:56 -07:00
Jeff Young	05bca282f7	Re-entrancy blocker for line/wire/bus tool. ... Also clear infobar messages after a cancelInteractive. Fixes https://gitlab.com/kicad/code/kicad/issues/11155	2022-03-17 15:27:33 +00:00
Jeff Young	e68e2e973e	Separate Line Properties dialog from Bus/Wire, and handle Junctions in Bus/Wire. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9979	2022-03-16 14:56:32 +00:00
Jeff Young	1434988bf8	Formatting.	2022-03-16 14:56:32 +00:00
Wayne Stambaugh	c16090cc42	Improve sheet schematic import from different project message. ... https://gitlab.com/kicad/code/kicad/-/issues/11075	2022-03-15 18:16:56 -04:00
jean-pierre charras	1f5ec30566	Fix and issue about 180 deg arcs in symbols from "old" libraries. ... Can be seen with lib version 20201005, not with latest version. The fix is similar to commit 8a17fb8d, but for arcs defined by start, end, angles (modify 180 deg arcs) Fixes #11130 https://gitlab.com/kicad/code/kicad/issues/11130	2022-03-15 11:31:58 +01:00
jean-pierre charras	2cb719f0cf	Fix crash in SCH_LABEL_BASE::IsType() when the item is not living in a schematic. ... It happens for instance when copying the item from the clipboard. Fixes #11128 https://gitlab.com/kicad/code/kicad/issues/11128	2022-03-14 09:23:16 +01:00
Jeff Young	38cde901b0	Don't use last-resolved caches for graphic lines. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11127	2022-03-14 00:31:56 +00:00
Jeff Young	ec44dfa60f	Unescape value fields when pasting from legacy schematics. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11124	2022-03-13 22:17:44 +00:00
Seth Hillbrand	d653484d72	Move connected_items from hash table to tree ... This gains about 10% speed in heavily connected sheets Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit 187aa1c171)	2022-03-11 16:58:38 -08:00
Seth Hillbrand	5b5c7d41b4	Break up buildConnectionGraph for debugging ... Needed to find bottlenecks in fns, so break out individual sections of the massive function for easier understanding. buildItemSubgraphs (one section of the previous function) would build millions of connections that were never used as stacked pins created X! connections. Also tested using sets instead of lists and keeping unique lists to avoid flagging but none of these were as performant as using flags to remember which items had already been processed. Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit 17b1b68ac7)	2022-03-11 16:58:38 -08:00
Jeff Young	7ab4d67e94	Make sure line style comboboxes get a default entry. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11083	2022-03-11 23:19:16 +00:00
Wayne Stambaugh	dd1dbb81f6	Improve shared schematic file churn heuristics. ... The previous solution cleared all of the fields and force the unit setting to unit one which would have less than desirable effects when reusing a schematic in another project. This solution forces all of the instance settings to the first sheet instance of the current project to prevent file change churn when changing shared sheets in the current project. This will not prevent shared schematic file changes when the first sheet instance data differs between projects.	2022-03-11 12:37:30 -05:00
Wayne Stambaugh	bf5d585e24	Reduce shared schematic file change churn.	2022-03-11 00:32:34 +00:00
Jeff Young	a9eb7a0e28	Make sure LIB_ID escape context allows for formatting constructs. ... Also make sure that value field is updated from name changes when the symbol is a power symbol (even if it's from the schematic instead of the library). Fixes https://gitlab.com/kicad/code/kicad/issues/11093	2022-03-10 13:46:42 +00:00
Seth Hillbrand	16a266301a	Remove double-call of settings from Netlister ... Double-calls are no longer needed when using settings. They can interfere depending on how the system executes the commands. Removing keeps the last used plugin as the default, rather than the last selected Fixes https://gitlab.com/kicad/code/kicad/issues/11094 (cherry picked from commit e8ef863861)	2022-03-09 17:12:41 -08:00
Seth Hillbrand	fd59179cd2	Avoid implementation dependent on events ... Adding a page in the ctor can generate events that change the default page. Instead, we set the default after all pages have been added, avoiding the reset Fixes https://gitlab.com/kicad/code/kicad/issues/10910 (cherry picked from commit 5314ba6440)	2022-03-09 15:42:29 -08:00
Seth Hillbrand	6934bc124c	Move temp save files to temporary directory ... Avoid excess writes to the project directory to dodge issues with remote file systems not fully writing data. wxRename works across disk boundaries (in theory) and falls back to wxCopy/wxRemove when it fails Fixes https://gitlab.com/kicad/code/kicad/issues/10747	2022-03-07 20:13:28 -08:00
Seth Hillbrand	c9fb95b888	Fix the order of evaluation in the arc printing ... MapAngles will adjust by small amounts the angles t1 and t2. This adjustment will determine the CW/CCW drawing. Therefore, the MapAngles needs to be called explicitly before the Normalize180() call. Left-to-Right evaluation is not a given for MSVC Fixes https://gitlab.com/kicad/code/kicad/issues/11050	2022-03-07 16:43:13 -08:00
Jeff Young	bf0f2aa4a8	Adjust bitmap text spacing a bit so it's closer to the stroke font. ... This helps the text better match the highlighting when it gets small enough that we switch to the bitmap font for performance.	2022-03-07 20:30:50 +00:00
Jeff Young	1f745b000d	Special-case synthetic click after tool selection. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11057	2022-03-07 20:30:50 +00:00
Jeff Young	39fa4e2065	Include textbox in movable objects. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11058	2022-03-07 10:33:59 +00:00
Jeff Young	d3716b9956	Reentrancy block for symbol editor symbol properties dialog. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11060	2022-03-07 10:26:18 +00:00
Jeff Young	4923f02651	Reset GAL pen width between drawing text and border. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11059	2022-03-06 20:32:28 +00:00
Jeff Young	3969045009	Don't bitmap multi-line SCH_TEXT. ... The linespacing isn't even close and multi-line text is also likely to have longer lines which makes the X offset get way off too.	2022-03-06 20:17:56 +00:00
Jeff Young	6b3ed89248	Handle justified LIB_TEXT. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11052	2022-03-06 19:54:06 +00:00
Jeff Young	14304215b3	Copy m_private flag in LIB_TEXT's clone(). ... Fixes https://gitlab.com/kicad/code/kicad/issues/11051	2022-03-06 17:00:13 +00:00
Jeff Young	c919817c18	Don't reserve space for private items when autoplacing.	2022-03-06 16:12:49 +00:00
jean-pierre charras	dbfdd3fb56	Fix some Coverity warnings.	2022-03-06 09:48:33 +01:00
Seth Hillbrand	8fd87e1f04	Change connectivity item group from set to vector ... Reserve space for new items to speed construction of connectivity graph Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit 7aebc4b11f)	2022-03-05 13:04:11 -05:00
Seth Hillbrand	cd7141fd10	Cache read arc data for stability ... Arcs can be altered by the process of changing from on-disk representation to in-memory representation. Saving back to disk without modifying the arc should not modify the calculated values. This stores a copy of the on-disk representation that is only used to save back to disk in the event that the arc is not modified during editing. Fixes https://gitlab.com/kicad/code/kicad/issues/10442	2022-03-04 15:20:31 -08:00
Seth Hillbrand	7ecc70a79d	Duplicate from selected or current ... When double-clicking to open a symbol, it is no longer selected in the tree. We need to use the `GetTargetLibId()` to pick the correct symbol (first selected, then current) when using the duplicate command Fixes https://gitlab.com/kicad/code/kicad/issues/11034 (cherry picked from commit 802d20c409)	2022-03-03 16:04:22 -08:00
Jeff Young	c025b4c73d	Save all stroke parameters of sch & lib shapes. ... We were failing to save the line style, which caused ERC errors when DEFAULT != SOLID.	2022-03-03 14:37:04 +00:00
Jeff Young	76535d8572	Make LIB_ITEM::COMPARE_FLAGS really a flags field, and add ERC. ... Before they were 1/2 treated as flags and 1/2 treated as a mode enum. The ERC flag relaxes constraints on data that is settable in the schematic editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11018	2022-03-03 13:27:18 +00:00
jean-pierre charras	a0d68b8426	SCH_DIRECTIVE_LABEL: add missing virtual SwapData. ... Fixes #11027 https://gitlab.com/kicad/code/kicad/issues/11027	2022-03-03 10:27:17 +01:00
Jeff Young	c5d85e0b7e	Don't try to open cell editor on first focus. ... It hasn't worked since we rejiggered the default grid selection mode anyway, and for some reason it eats <esc> key events after the dialog has been resized. Fixes https://gitlab.com/kicad/code/kicad/issues/11015	2022-03-03 02:06:48 +00:00
Jeff Young	fd4b4533b1	Remove some code that isn't used anymore.	2022-03-03 02:06:48 +00:00
Seth Hillbrand	548936bb22	Fix broken unit select context menu ... The fix for https://gitlab.com/kicad/code/kicad/issues/10529 kicked the subsequent IDs for unit selection off the maximum ID value for popup menus. This increases the maximum popup number (integers are free) (cherry picked from commit 79b6991d7b)	2022-03-02 16:33:28 -08:00
Seth Hillbrand	8c36ba3653	Explicitly give unit values ... Removes the ability to hide symbol units in file formats. This was mostly the case for a while but there remained corner cases where we left a default/hidden option Fixes https://gitlab.com/kicad/code/kicad/issues/10888	2022-03-02 16:01:08 -08:00
Seth Hillbrand	984eb0fb40	Handle locally-coded file names for sheets ... Windows can accidentally create forward slash-coded files. This simply converts them to the proper unix-coded value when set Fixes https://gitlab.com/kicad/code/kicad/issues/10964 (cherry picked from commit 429544c188)	2022-03-01 17:23:30 -08:00
Seth Hillbrand	61acd607ad	Ensure fields are properly ordered ... When reading sheet fields, we need to maintain a consistent order for the mandatory fields as they are dereferenced by place. We force this during the `SetFields()` call. (cherry picked from commit 8385ce3021)	2022-03-01 17:10:35 -08:00
Seth Hillbrand	ac87d5e940	Resolve text when requested ... Getting resolved text for a symbol should always happen, even if we have unresolved data in the instances Fixes https://gitlab.com/kicad/code/kicad/issues/11003 (cherry picked from commit acb5ce7108)	2022-03-01 15:11:06 -08:00
Jeff Young	79ad15b4fa	Fix copy/pasta. ... Fixes https://gitlab.com/kicad/code/kicad/issues/11005	2022-03-01 14:59:29 +00:00
Jeff Young	4dc652497d	Put device-coloured fills on device layer. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10993	2022-02-28 21:11:01 +00:00
Seth Hillbrand	eb06ecab10	Avoid resolving text vars without screen ... We need to keep the screen blank while initially loading a sheet before the hierarchy is developed. Avoid resolving text variables during this process Fixes https://gitlab.com/kicad/code/kicad/issues/11000 (cherry picked from commit 63b06af6b1)	2022-02-28 12:28:02 -08:00
Jeff Young	b55bda8d6f	Font support for drawing sheet editor. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10306	2022-02-28 18:05:26 +00:00
Mike Williams	5503afc09a	Schematic: disallow center rotation, allow both endpoint rotations ... Center rotation will often misalign lines to the grid, which is bad until fix off grid items on the schematic. We can rotate a connection end into a new connection or to become collinear with an existing line, so we need to check for this at the end of rotation. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10565 (cherry picked from commit 7d4cb91f39)	2022-02-28 08:50:12 -08:00
Jeff Young	f241617478	Be more careful about non-visible elements in fields autoplacer. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10774	2022-02-28 00:18:39 +00:00
Jeff Young	c4d2ac570f	Don't allow break commands (or labelling cmds) on multiple wire selections. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10934	2022-02-27 23:15:07 +00:00
Jeff Young	1f16092e29	Infobar warning if symbol loading was cancelled. ... Also makes sure the progress dialog is closed when we're done reading symbols (it used to stay up for much of the symbol editor initialization). Also makes sure that any cancel in the preLoad step is honoured in the sync step. (The preload is done because it is multi-threaded and therefore faster than the single-threaded sync.) Also makes sure that individual threads pay attention to the cancellation, not just the GUI thread. Fixes https://gitlab.com/kicad/code/kicad/issues/8372	2022-02-27 17:06:08 +00:00
Seth Hillbrand	535ea800c0	Honor modifier keys in diambiguation ... Needs to be reset for the new action before selecting elements at a point. Fixes https://gitlab.com/kicad/code/kicad/issues/9712 (cherry picked from commit a30ad0b54a)	2022-02-25 16:16:15 -08:00
Steffen Mauch	78620347c8	Fixing Eagle refs that do not work with KiCad ... KiCad has stricter requirements for what consititutes an annotated symbol. This checks for and corrects annotations that begin with '#', do not begin with a non-numeric character or do not end with a number	2022-02-25 23:42:47 +00:00
Seth Hillbrand	faa3829ad4	Add MRU to image placement tools	2022-02-25 13:18:43 -08:00
Jeff Young	6d8507d44f	Formatting.	2022-02-25 17:36:35 +00:00
jean-pierre charras	4c81bac9e3	Eeschema: ensure ERC exclusions list is up to date before saving it in *.kicad_pro ... Fixes #10339 https://gitlab.com/kicad/code/kicad/issues/10339	2022-02-25 18:21:46 +01:00
Jeff Young	67eb138a4b	Fix copy/pasta. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10957	2022-02-25 00:49:41 +00:00
Jeff Young	a29968fa91	Make sure bitmap fallback is only used for non-cached text. ... Also fixes backwards vertical justification for bitmap text. Fixes https://gitlab.com/kicad/code/kicad/issues/10956	2022-02-24 18:16:45 +00:00
Jeff Young	2042b08127	Performance optimizations for drawing (small) text.	2022-02-23 12:09:36 +00:00
Jeff Young	d58427a519	Don't kill entire OpenGL cache on undo. ... The comment regarding bitmaps was true for one more month in 2018, but hasn't been true for the last 3 years, and clearing the cache is a huge performance hit.	2022-02-22 23:09:55 +00:00
Jeff Young	c7dda3fbec	Formatting.	2022-02-22 22:19:55 +00:00
Mike Williams	e35c3f2b99	Schematic: handle switching h/v mode better while drawing lines ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10859	2022-02-21 17:03:43 +00:00
Jeff Young	a2772b3363	Don't crash on highight net during drag. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10866	2022-02-21 13:30:15 +00:00
Jeff Young	b0d7c82e64	Disable grid when ctrl/cmd key is down. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9995	2022-02-20 16:50:30 +00:00
Mike Williams	d0749c4e9a	Schematic: more drag undo fixes ... Drag was not clearing IS_CHANGED status of items that were moved by the drag, but weren't selected or created by it. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10845	2022-02-20 11:49:18 +00:00
Seth Hillbrand	d1a4daefbb	wxPoint->VECTOR2I correction for master	2022-02-19 19:14:41 -08:00
Seth Hillbrand	24ac516135	Trim wires based on how many pins they intersect ... If a wire intersects more than 2 pins from the same symbol, we don't trim connections. If the wire intersects exactly two pins from a single symbol, we remove the wire between the pins. We avoided doing this before because we didn't have a good metric for trimming vs. not. But the per-symbol calculation feels like the least surprising option. Fixes https://gitlab.com/kicad/code/kicad/issues/10909 Fixes https://gitlab.com/kicad/code/kicad/issues/1857 (cherry picked from commit 75a4036e45)	2022-02-19 16:54:45 -08:00
Thomas Pointhuber	8ef7252330	altium: Don't use string concatenation for paths pointing in the compound file ... * std::vector do not need to be split apart again * supports backslash in footprint names	2022-02-19 16:46:20 +01:00
Jeff Young	510dc28a5c	Resolve text variables before attempting to open datasheet.	2022-02-19 14:59:50 +00:00
Jeff Young	8a22dab83d	Fix crash bug when adding rows to pin table and then pasting to unit.	2022-02-18 17:12:46 +00:00
Jeff Young	a678b78091	Implement SCH_MARKER::GetSeverity(). ... Fixes https://gitlab.com/kicad/code/kicad/issues/10893	2022-02-18 12:14:38 +00:00
Jeff Young	944fe9637d	Fix error that prevent drawing pin selection highlighting.	2022-02-17 19:02:51 +00:00
Wayne Stambaugh	35f85dd900	Eeschema: fix broken symbol library rescue. ... Apparently at some point during V5 development, symbol cache library names were saved by replacing the LIB_ID separator character ':' with '_'. This caused the cache look up to fail there by skipping the symbol rescue which could result in broken schematics. I have no idea where this happened during V5 development. The video demo in the HEAD of the 5.1 branch shows the issue. All of the other demo cache libraries are correct. Fixes https://gitlab.com/kicad/code/kicad/-/issues/10488 (cherry picked from commit c6c4f9ae4b)	2022-02-17 09:16:33 -05:00
Jeff Young	9584849aba	Fix type which results in global fieldname templates being added to project.	2022-02-17 12:42:10 +00:00
Jeff Young	d60ed70d54	Sync all fields between units when symbol is edited. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10610	2022-02-17 12:42:10 +00:00
Jeff Young	e499793147	Update alt pin assignments in other units. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10849	2022-02-17 12:42:10 +00:00
Mike Williams	567168fffc	Schematic: make grabbing whole lines more intuitive ... Selecting end and midpoint will select whole line. Some changes for orthogonal dragging made this worse than in 6.0. Improves, but does not fully resolve: https://gitlab.com/kicad/code/kicad/-/issues/10860	2022-02-16 19:15:55 +00:00
Jeff Young	bc7742cb2e	Various text object defaults don't necessarily match file defaults. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10862	2022-02-15 23:25:59 +00:00
Jeff Young	ab5489ad30	Fix typo. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10390	2022-02-15 22:40:24 +00:00
Mike Williams	97797c44b9	Schematic: added drag wires undo/redo fix ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10845	2022-02-15 19:31:17 +00:00
Seth Hillbrand	45a1a9a715	Replace awkward double cast with binary logic ... The use of XOR with integers here is needed as MSVC doesn't implement the use of std::signbit for integers and casting up to double just to get the signbit feels wrong	2022-02-15 10:13:59 -08:00
jean-pierre charras	414dfb4745	Eeschema, DIALOG_TEXT_PROPERTIES and DIALOG_LIB_TEXTBOX_PROPERTIES: fix minor issues ... Fixes #10863 https://gitlab.com/kicad/code/kicad/issues/10863	2022-02-15 15:38:08 +01:00
Marek Roszko	3129f96686	Add awkward cast to double due to msvc conflict ... https://github.com/microsoft/STL/issues/519	2022-02-14 21:43:11 -05:00
Mike Williams	9c59c4ee12	Schematic: orthogonal drag bends should depend on move direction ... Prevents overlapping lines when possible. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10844	2022-02-14 22:52:34 +00:00
jean-pierre charras	876061369b	Fix some Pcbnew crashes due to null pointers	2022-02-14 13:46:05 +01:00
Jeff Young	4e5b30ad80	Rewrite autostart to not need connectivity. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10579	2022-02-14 01:15:06 +00:00
Mike Williams	1090403ca2	Schematic Preferences: fix grid assert on negative width	2022-02-13 22:27:41 +00:00
Mike Williams	013d6d088f	Eeschema: fix pin starting wire bus bug ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10819	2022-02-13 15:02:09 +00:00
jean-pierre charras	7e6829e834	Fix minor compil warnings	2022-02-12 11:43:38 +01:00
Jeff Young	33e57930bc	Implement undo for Eeschema find/replace. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10824	2022-02-11 22:09:22 +00:00
Mike Williams	21b59b4b6a	Eeschema: fix bus label drag adding a line ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10822	2022-02-11 21:30:50 +00:00
Jeff Young	940e03e567	Remove arc end swapping when parsing. ... See: 2366b06e77 (note_839061664)	2022-02-11 13:10:52 +00:00
Werni	946f62d949	Add separate wildcard for OrCAD netlists	2022-02-11 09:24:20 +00:00
Jeff Young	082c6f5bd6	Make sure plotter uses default font when specified.	2022-02-10 20:33:06 +00:00
Jeff Young	f11b8011cd	Separate plotting into background and foreground. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10390	2022-02-10 20:33:06 +00:00
Mike Williams	a5e8575091	Eeschema: Implement orthogonal dragging ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/1956	2022-02-10 18:38:40 +00:00
Jeff Young	2366b06e77	Don't parse multiple items in a single c'tor or function call. ... The C++ optimizer is not always your friend and may do them in the reverse order.	2022-02-10 17:54:13 +00:00
Jeff Young	d33d092e8e	Add a second fix for backwards arcs. ... This one *should* also be good when we support larger-than-180 degree arcs.	2022-02-10 15:46:02 +00:00
Jeff Young	cb8e803788	Formatting.	2022-02-10 13:04:29 +00:00
jean-pierre charras	b9843a23eb	Eeschema, legacy *lib files: fix issues with 180 deg arcs. ... 180 deg arcs are a limit, so when importing them convert them to slightly smaller arc (arc angle = 179.5 deg) Fixes #10455 https://gitlab.com/kicad/code/kicad/issues/10455	2022-02-10 12:45:54 +01:00
Jeff Young	7b84e0a7d9	Make printing/plotting/drawing of LIB and SCH arcs consistent. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10801	2022-02-10 00:35:24 +00:00
Wayne Stambaugh	3f8f90db9f	Factor out common s-expression library cache source code.	2022-02-09 11:20:14 -05:00
Wayne Stambaugh	7181f0b40b	Fix clang broken build.	2022-02-09 07:55:50 -05:00
Wayne Stambaugh	fe82f2dd40	Factor out common schematic s-expression source code.	2022-02-08 14:44:38 -05:00
Jeff Young	58c38d2830	Don't nanny users about what constitutes quality graphics. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10788 Fixes https://gitlab.com/kicad/code/kicad/issues/10374	2022-02-08 17:35:48 +00:00
Jeff Young	3600b2ce3f	Make sure temp sheet has a parent.	2022-02-08 17:09:17 +00:00
jean-pierre charras	2f79f579cc	DIALOG_TEXT_PROPERTIES: do not show fill option for texts. ... It make sense only for text boxes. Fixes #10786 https://gitlab.com/kicad/code/kicad/issues/10786	2022-02-08 09:42:22 +01:00
Mike Williams	7c91cd73e3	Eeschema: unconnected ends of wire entries should allow auto start wires	2022-02-07 23:31:24 +00:00
Wayne Stambaugh	fc3cad0b54	Hash symbol libraries per library rather than statically per cache type.	2022-02-07 15:40:21 -05:00
Kevin Lannen	f9b27a53b2	Eeschema: Edit pin numbers while grouped ... ADDED: The pin table pin numbers column supports editing the list of pin numbers to add, remove, and rename pins. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5620	2022-02-07 17:45:16 +00:00
Kevin Lannen	631d5155ef	Eeschema: Pin table support for multi unit symbols ... ADDED: Symbol editor pin table supports editing which unit each pin is displayed on Note: 6513 mentions being able to change the pin unit from the edit pin menu. This does not add that feature. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6513 Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5470	2022-02-07 17:45:16 +00:00
Kevin Lannen	56794ab829	Eeschema: Add pin count column to pin table ... ADDED: When the pin table is showing grouped pins, display a read-only column that displays the number of pins in each row. Fixes https://gitlab.com/kicad/code/kicad/-/issues/2416	2022-02-07 17:45:16 +00:00
Kevin Lannen	08ca19f95d	Eeschema: Display pin count and duplicate pin list in pin table dialog	2022-02-07 17:45:16 +00:00
Jeff Young	624dc393bf	Fix tooltip. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10708	2022-02-07 17:36:40 +00:00
Jeff Young	79c7d55a40	Add a checkbox for LIB_SHAPE borders. (We already have them for LIB_TEXTBOXes.) ... Fixes https://gitlab.com/kicad/code/kicad/issues/10365	2022-02-06 19:43:25 +00:00
Jeff Young	0ffa1288ee	Regularize how penWidths are fetched. ... Fixes https://gitlab.com/kicad/code/kicad/issues/git	2022-02-06 19:43:25 +00:00
Jeff Young	aedfe08bad	Show pin dangling symbols in Symbol Editor. ... Even though we don't have connections they're a still a good visual indication of which end of the pin is which. Fixes https://gitlab.com/kicad/code/kicad/issues/10742	2022-02-06 19:43:25 +00:00
Jeff Young	b1cc784582	Harmonize interchangeable units checkboxes. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10708	2022-02-06 19:43:25 +00:00
Jeff Young	cc69849719	Fix definition of nonFields to include textboxes. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10771	2022-02-06 19:43:25 +00:00
Jeff Young	b57ac3d517	Handle SCH_TEXTBOX in SCH_SEXPR_PLUGIN::Format. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10771	2022-02-06 19:43:25 +00:00
Marek Roszko	d9c04da407	Sprinkle in some make_unique	2022-02-05 21:26:36 -05:00
Marek Roszko	41f54349a5	Replace inserts/push_backs with emplace in some spots	2022-02-05 19:53:31 -05:00
Jeff Young	7ccac79192	More wxString wide literals.	2022-02-05 21:29:34 +00:00
Jeff Young	8d3e1639d0	Update text variables when they change. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10734	2022-02-04 12:52:46 +00:00
Marek Roszko	ca7840334c	Mark some limits as constexpr ... gcc doesn't need it and computes during compile regardless, but experimenting in godbolt, both clang and MSVC actually do need it or else it's partially computed at runtime	2022-02-04 07:50:13 -05:00
Seth Hillbrand	3badd53a96	Setup selection when repeating ... We need the item to be currently selected when repeating the last symbol insert. This ensures we have a valid selection before starting the move tool and possibly getting odd system behavior from mouse positions Fixes https://gitlab.com/kicad/code/kicad/issues/10619 (cherry picked from commit 7642a9db79)	2022-02-03 17:09:59 -08:00
Jeff Young	b9eb3e9b05	Be more explicit about string conversions.	2022-02-03 23:07:41 +00:00
Seth Hillbrand	b7c31d3b5b	When undoing creation of the sheet, get out first ... We can't stay in a sheet that is deleted by the action of undo. Checks the current sheet and, if we are currently using it, ensures that the following action is to leave the current sheet Fixes https://gitlab.com/kicad/code/kicad/issues/10733 (cherry picked from commit ccf2a63f45)	2022-02-03 11:19:51 -08:00
Jeff Young	3d0b03515d	Fix bad field names when ID == -1. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10548	2022-02-03 12:38:56 +00:00
Marek Roszko	fa1d316d84	Fix windows build error	2022-02-02 17:43:47 -05:00
Wayne Stambaugh	e590d07224	Fix clang build error.	2022-02-02 07:44:11 -05:00
Wayne Stambaugh	9260431fe4	Abstract out symbol library parser object.	2022-02-02 07:07:39 -05:00
Wayne Stambaugh	6fcc6f7c9d	Factor out common legacy schematic and symbol library parser code.	2022-02-01 16:30:15 -05:00
Jeff Young	bebfbce9b2	Move pcb file rep of text_boxes to strokes.	2022-02-01 16:29:59 +00:00
Jeff Young	a1009d7899	Fix assertion failure for labels.	2022-02-01 12:01:04 +00:00
Seth Hillbrand	59e43527a0	Add dummy defaults for textbox	2022-01-31 16:26:37 -08:00
Jeff Young	4243d7b055	Bug fixes for color handling.	2022-02-01 00:21:08 +00:00
Seth Hillbrand	098e8f7d9b	Revert "cmake: adding KICAD_MACOSX_APP_BUNDLE option" ... This reverts commit ea9f960cc1. Reverted for updates as this currently breaks kicad-mac-builder	2022-01-31 15:57:56 -08:00
Jeff Young	f3cd36d1d7	Bring EEschema textboxes in line with PCBNew's. ... Also adds Border checkboxes and fixes a bunch of bugs.	2022-01-31 21:46:40 +00:00
Jeff Young	5739505aa3	TextBoxes for PCBNew.	2022-01-31 20:00:47 +00:00
Jeff Young	60bcfd1bf1	Bug fixes in arc & textbox printing. ... Also removal of the no-longer-used clipping code from GR*.	2022-01-31 20:00:47 +00:00
Roberto Fernandez Bautista	25a7de730c	eeschema/CMakeLists.txt Sort sources alphabetically	2022-01-31 19:51:01 +00:00
jean-pierre charras	64f2adbc31	SCH_PAINTER, draw filled LIB_SHAPE: fix incorrect selection of fill color.	2022-01-30 10:20:49 +01:00
jean-pierre charras	b4826ce304	LIB_TEXT: fix incorrect position of the drawn text. ... Fixes #10654 https://gitlab.com/kicad/code/kicad/issues/10654	2022-01-30 09:11:16 +01:00
Seth Hillbrand	38706fdd95	Fully select a line for transformation ... When not trying to select points, we need to ensure that the full line is selected for transformation Fixes https://gitlab.com/kicad/code/kicad/issues/10566 (cherry picked from commit 70d00689ca)	2022-01-29 17:37:30 -08:00
Wayne Stambaugh	b36e31c49f	Factor out common and remove dead legacy symbol library code.	2022-01-29 14:13:00 -05:00
Davide Gerhard	ea9f960cc1	cmake: adding KICAD_MACOSX_APP_BUNDLE option ... ADDED: with cmake KICAD_MACOSX_APP_BUNDLE option the user can disable the macOS app bundle creation when compiling on macOS. This permit to use/install KiCad like any other *nix platform (/usr/bin, /usr/share, ecc.). By default, cmake build the app bundle.	2022-01-28 15:49:37 -08:00
Jeff Young	c6a8100d46	Schematic and symbol text boxes. ... Also fixes some plot bugs with arcs. Also moves polygonization of arcs (when required) in plotting code from 5 degrees to calculated based on ARC_HIGH_DEF. Fixes https://gitlab.com/kicad/code/kicad/issues/5017	2022-01-28 21:38:15 +00:00
Jeff Young	3409783d9f	Break sch_text.h/.cpp into sch_text and sch_label. ... Also moves SCH_NETCLASS_FLAG to SCH_DIRECTIVE_LABEL, and remaps Altium harnesses from SCH_TEXT to SCH_DIRECTIVE_LABEL.	2022-01-28 21:38:15 +00:00
Seth Hillbrand	79403ef075	Readd yield call to give slice to system. ... Note: - wxYield does not work here, indicating the need for locking - wxYieldIfNeeded does not work, possibly for the same reason as wxYield - Both Layout() and m_fieldGrid->Layout() need to be called even though the first should call the second. Fixes https://gitlab.com/kicad/code/kicad/issues/5690	2022-01-28 13:02:39 -08:00
Franck	a6203617d9	Fix Altium schematic port component import assertion. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/10322 Fixes https://gitlab.com/kicad/code/kicad/-/issues/10401	2022-01-28 15:52:30 +00:00
Mike Williams	ecb32b1fb0	Eeschema: hover start from wire end should copy wire properties ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10128	2022-01-27 17:17:45 +00:00
Seth Hillbrand	9ab2eb391f	Move delay selection out of UpdateUI ... Calling actions from within UpdateUI can cause loops that crash or substantially slow Fixes https://gitlab.com/kicad/code/kicad/issues/10616	2022-01-26 16:05:40 -08:00
jean-pierre charras	8a17fb8d19	SCH_SEXPR_PARSER::parseArc(): fix a very annoying issue: each time the lib or ... sch files are saved and reopened, 180 deg arcs were flipped. This fix is a workaround, but avoid flipped arcs after saving/reopening these files.	2022-01-26 18:19:52 +01:00
Seth Hillbrand	2dc031ee34	Prevent auto-column sizing when editor opens ... On GTK, some configurations will trigger a column resize, which will close the current editor. This blocks the column resize while the editor is open, unless the resize continues, which indicates dragging of the window edge Fixes https://gitlab.com/kicad/code/kicad/issues/5690	2022-01-25 17:59:15 -08:00
Seth Hillbrand	b6ecbc596e	Fix mistaken use of `m_width` ... This is a protected var in Linux but doesn't exist in Mac/MSW. We use the new m_fieldsSize	2022-01-25 12:45:09 -08:00
Seth Hillbrand	efb323d57d	Another stab at https://gitlab.com/kicad/code/kicad/-/issues/5690 ... This time, ensure that the grid is increased and the main form gets an event	2022-01-24 16:30:30 -08:00
Seth Hillbrand	a054a46136	Force a size event to avoid multiple yields ... When the grid editor is shown, we also want to ensure that the grid gets resized to account for the new editor. Queuing the event will ensure that happens after the editor is emplaced in the grid Fixes https://gitlab.com/kicad/code/kicad/issues/5690 (cherry picked from commit fddfce4fb1)	2022-01-24 15:32:17 -08:00
Seth Hillbrand	be5bb8c4bd	Enforce strictly weak ordering in sheets ... This ensures that irreflexivity is given in sort ordering. This may have been triggering issues in MacOS when adding sheets Fixes https://gitlab.com/kicad/code/kicad/issues/10557 (cherry picked from commit a1615cce7e)	2022-01-24 10:41:21 -08:00
Seth Hillbrand	175c4fe67c	Allow time to update editor ... On GTK, the full editor needs to be shown and, for some systems, the editor will not show correctly. By yielding we should allow the time to recalculate sizes for the editor in the grid Fixes https://gitlab.com/kicad/code/kicad/issues/5690 (cherry picked from commit 871556ebda)	2022-01-24 09:58:10 -08:00
Seth Hillbrand	0926eb3287	Get all eeschema layers properly ordered ... Layers not in the given order are drawn behind everyone else. Missing the text prevents global labels from showing properly in GAL order Fixes https://gitlab.com/kicad/code/kicad/issues/10546 (cherry picked from commit f12d0cb0e2)	2022-01-23 10:04:32 -08:00
Fabien Corona	58e167013d	SPICE: Add support for transmission lines	2022-01-23 17:23:22 +00:00
jean-pierre charras	2dbc89e5f2	DIALOG_SIM_SETTINGS: fix incorrect validation of DC souces in DC Transfer panel ... Fixes #10568 https://gitlab.com/kicad/code/kicad/issues/10568	2022-01-23 16:22:12 +01:00
Jeff Young	0283e2c246	Highlighting for schematic shapes when fill shapes is turned off. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10372	2022-01-22 22:27:41 +00:00
Jeff Young	29841ba315	Bring ERC & DRC dialogs into parity. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9350	2022-01-22 22:27:41 +00:00
Jeff Young	de49f5090d	Formatting (and auto reduction).	2022-01-22 12:16:07 +00:00
Jeff Young	4665cdcdc5	Allow more (lots more) unfold from bus menu entries. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10529	2022-01-21 17:41:05 +00:00
jean-pierre charras	242e66355c	SYMBOL_VIEWER_FRAME: fix refresh of the canvas after selecting a new symbol.	2022-01-21 16:37:58 +01:00
jean-pierre charras	694ae59664	fix a minor compil warning (shadowed vars)	2022-01-21 14:09:42 +01:00
Jeff Young	c8a50d9b50	Remove unit-less angles from VECTOR2I/D APIs.	2022-01-20 23:58:20 +00:00
Seth Hillbrand	16aca901df	Clear Undo list when renaming ... Our undo/redo list is tied to the screen that gets cleared when we reload the file after renaming. We need to clear the Undo list at this point to prevent possible crashes when moving too far back in the stack Fixes https://gitlab.com/kicad/code/kicad/issues/10504 (cherry picked from commit 323a069738)	2022-01-20 11:29:05 -08:00
Seth Hillbrand	cffc99e384	Don't close filled polylines when printing ... Eeschema/libedit support open, filled polylines. When printing, this should be drawn as a fill, followed by the polyline to avoid assumptions about closed polygons in the graphic code Fixes https://gitlab.com/kicad/code/kicad/issues/10537 (cherry picked from commit 615eda816e)	2022-01-20 10:54:36 -08:00
Jeff Young	3ba89f50ef	Maybe, just maybe, fix LibEdit arc parsing. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10455	2022-01-19 22:22:18 +00:00
Jeff Young	8445783216	Fix backwards arcs in legacy LIB_ARCs. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10455	2022-01-18 14:08:47 +00:00
jean-pierre charras	380cb452b2	fix an issue in a bom script (extra empty lines created) ... Fixes #10473 https://gitlab.com/kicad/code/kicad/issues/10473	2022-01-18 13:49:50 +01:00
jean-pierre charras	25fca2abb7	fix a minor compil warning	2022-01-18 13:49:50 +01:00
Jeff Young	f310a5b986	Excise deci-degrees from trigo.	2022-01-18 11:44:55 +00:00
Jeff Young	b828355206	A bit more angle cleanup.	2022-01-18 09:48:24 +00:00
Jeff Young	de31b813f3	Angle cleanup in the Cadstar importer.	2022-01-18 02:31:37 +00:00
Jeff Young	622f94e7b9	Angle cleanup in Altium importer.	2022-01-18 02:31:37 +00:00
Jeff Young	0218b782f4	Angle cleanup in Eagle importer.	2022-01-18 02:31:37 +00:00
Jeff Young	dcaec78cc5	A bit more angle cleanup.	2022-01-18 02:18:55 +00:00
Thomas Pointhuber	0129e49b79	altium: Introduce new ALTIUM_COMPOUND_FILE object to handle file opening and searching for streams at a central place	2022-01-17 19:54:26 +01:00
Jeff Young	2defd8d911	Move show-bounding-boxes to a tool on the toolbars.	2022-01-17 11:56:40 +00:00
Jeff Young	5cc3368b14	Fix bounding boxes and hittesting for arcs in eeschema.	2022-01-16 23:54:59 +00:00
Jeff Young	e61144d45a	Finish with EDA_ANGLE.	2022-01-16 21:15:40 +00:00
dsa-t	bc1ff6756f	Cross-probing/selection for multiple items (SCH->PCB)	2022-01-16 20:29:03 +00:00
Jeff Young	e84c574830	Some more EDA_ANGLE cleanup.	2022-01-16 19:16:18 +00:00
jean-pierre charras	516d038bdf	Eeschema: fix incorrect stored rotation value in file of the global and hierarch. labels. ... The stored value was the rotation of the text (always 0 or 90 deg), but these labels can also be rotated by -90 or 180 deg Fixes #10450 https://gitlab.com/kicad/code/kicad/issues/10450 Fixes #10457 https://gitlab.com/kicad/code/kicad/issues/10457	2022-01-16 17:19:36 +01:00
Jeff Young	9b661aea10	EDA_ANGLE for plotters. ... Also fixes a compile error in the PNS Playground.	2022-01-16 01:19:45 +00:00
Jeff Young	2b14b60c32	Resolve text variables in eeschema before passing to pcbnew. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10429	2022-01-15 01:30:03 +00:00
Jeff Young	a533d64417	Apply default line style. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10388	2022-01-14 16:08:19 +00:00
Jeff Young	07013d00e1	More EDA_ANGLE.	2022-01-14 16:08:19 +00:00
Jeff Young	1b19ff5f42	More EDA_ANGLE changes.	2022-01-14 16:08:19 +00:00
Jeff Young	70ad554343	Coverity fixes.	2022-01-14 16:08:18 +00:00
Jeff Young	e048e51f5d	Improve SNR of EDA_ANGLE stuff.	2022-01-14 16:08:18 +00:00
jean-pierre charras	d0f2c20235	Define our kicad font name only once, and do not translate it. ... Especially using a translated name breaks kicad config and files because in non English languages both translated and not translated names were used in code.	2022-01-13 14:32:55 +01:00
Seth Hillbrand	e244ce1431	Fix cherry-picked wxPoint	2022-01-12 15:49:03 -08:00
Seth Hillbrand	d3f24308e6	Handle rotated symbol rectangles in Eagle import ... Fixes https://gitlab.com/kicad/code/kicad/issues/10360 (cherry picked from commit dcb8f29317)	2022-01-12 15:11:18 -08:00
dana	8373180cbb	Handle Unicode clipboard data in pcbnew and symbol editor ... Fixes #10323	2022-01-12 17:15:47 +00:00
Seth Hillbrand	5a3d53d9e4	Catch default autowire case ... Since we are dereferencing the optional, we need to ensure it exists in all cases Fixes https://gitlab.com/kicad/code/kicad/issues/10394 (cherry picked from commit 56d87a8613)	2022-01-12 09:03:44 -08:00
jean-pierre charras	a709d97a32	SCH_LABEL_BASE::Plot(): Plot fields.	2022-01-12 11:08:34 +01:00
jean-pierre charras	b3072cc16b	SCH_PAINTER, DrawLine: gives a minimal length to lines having a 0 length ... Lines with start point = end point always create problems in OpenGL (not drawn).	2022-01-12 09:44:30 +01:00
Franck Bourdonnec	3d8288f919	Remove unused vars, verified there was no other intention with them; ... rectangle are OK	2022-01-11 20:16:35 +00:00
Jeff Young	062f5e3177	Undo for SCH_SHAPEs. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10373	2022-01-11 18:33:54 +00:00
Jeff Young	a23f6e4e92	Handle border colors for SCH_SHAPEs. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10361	2022-01-11 18:18:11 +00:00
Jeff Young	184bcf6520	Fix failure of SCH_SHAPE to pick up default line width. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10376	2022-01-11 17:40:49 +00:00
Jeff Young	f9927ab675	Fix Text Properties dialog layout. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10368	2022-01-11 16:00:38 +00:00
Jeff Young	267eca28cd	Font support for global edit text & graphics dialogs.	2022-01-11 15:34:24 +00:00
Jeff Young	8f7d2dd06a	More VECTOR2D -> VECTOR2I and wxPoint cleanup.	2022-01-11 14:20:14 +00:00
Seth Hillbrand	d5faac7614	Better fix for missing end segment ... Rather than skipping our endEdit() call in libedit, we need to parameterize whether we want the shape open/closed. Closed will remove the last segment if it lands on the first point. We don't want that but we do want to remove the last point if it duplicates the second to last (in the case of double-clicking) Fixes https://gitlab.com/kicad/code/kicad/issues/10334 (cherry picked from commit 55020c2b89)	2022-01-10 13:39:39 -08:00
Jeff Young	7d032f9c2f	Outline font rendering for Cairo, plotter, printer and 3D viewer. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10319	2022-01-10 01:54:28 +00:00
Jeff Young	76368af7b9	Font cleanup and bug fixes.	2022-01-09 18:33:53 +00:00
Jeff Young	92d5a3e763	Clear caches when changing global default font.	2022-01-09 11:34:20 +00:00
Jeff Young	27c967421c	Commenting and "auto" reduction.	2022-01-08 16:47:45 +00:00
Jeff Young	04c76f10e9	Performance enhancements for fonts.	2022-01-08 16:47:45 +00:00
Jeff Young	438c63f587	Fix outline font boundingbox issues.	2022-01-08 16:47:45 +00:00
Jeff Young	aef2a3fca4	Default font for eeschema.	2022-01-08 16:47:45 +00:00
Jeff Young	a2030a5956	GUI for font selection.	2022-01-08 16:47:45 +00:00
Ola Rinta-Koski	72b69e8d7f	File format changes for fonts.	2022-01-08 16:47:45 +00:00
Seth Hillbrand	04c46a8fd2	Correct return type in mapCoords	2022-01-07 09:08:40 -08:00
Seth Hillbrand	3d88f37949	Switch mapCoords to VECTOR2I	2022-01-07 08:37:37 -08:00
Seth Hillbrand	eb271ca7fb	Don't deduplicate schematic polygon points	2022-01-07 08:29:34 -08:00
Seth Hillbrand	4cdc9d3857	Don't deduplicate symbol polygons ... SHAPE_LINE_CHAIN will, by default, remove duplicate points when appending. We don't want to do this when constructing our polygons in symbol editor, so we need to explicitly call the routine without deduplication Fixes https://gitlab.com/kicad/code/kicad/issues/10289 (cherry picked from commit 62f8603353)	2022-01-07 08:25:49 -08:00
Seth Hillbrand	c9fc15b5eb	Clear edited point when exiting tool ... When leaving the main point editor loop, we need to ensure that the edit point is cleared as well. This is usually cleared by a ClearEvent call but in case this is missed, we need to ensure that other tools are not caught out Fixes https://gitlab.com/kicad/code/kicad/issues/10288 (cherry picked from commit 9a2332dfcf)	2022-01-07 08:25:49 -08:00
jean-pierre charras	e00e9ff41f	PANEL_TEMPLATE_FIELDNAMES: fix incorrect management of boolean options ... (it was impossible to disable them) Fixes #10280 https://gitlab.com/kicad/code/kicad/issues/10280	2022-01-06 19:00:52 +01:00
Seth Hillbrand	3ace4446e7	Use 'special' escaping for certain fields ... Most fields are escaped using the `\` notation. But the VALUE field and the symbol name need to be escaped using braces notation. Fixes https://gitlab.com/kicad/code/kicad/issues/10097 (cherry picked from commit 71e7b4b77b)	2022-01-05 17:19:36 -08:00
Seth Hillbrand	88a8ad2ca1	Keep symbol synced with edit tool ... Undo/Redo can change the symbol referenced by the symbol drawing tool. This updates the current symbol before important steps to keep the system synced Fixes https://gitlab.com/kicad/code/kicad/issues/10125 (cherry picked from commit b8a7a66a0a)	2022-01-05 16:52:02 -08:00
Seth Hillbrand	5a8b0921eb	Don't remove last point in libedit ... SHAPE_LINE_CHAIN in libedit doesn't make a polygon, so we always need the last point and it shouldn't be closed Fixes https://gitlab.com/kicad/code/kicad/issues/9934 (cherry picked from commit 55087a9e82)	2022-01-05 16:06:38 -08:00
Steffen Mauch	3ced3afa68	eeschema: automatic generated symbol library from EAGLE plugin does not include footprint reference ... Fixes https://gitlab.com/kicad/code/kicad/issues/10262	2022-01-05 19:48:40 +00:00
Seth Hillbrand	e4961cb956	Update pin cache when undoing ... The pin cache is invalidated by swap, so we need to ensure that it is reset when we undo a change to the pins in schematic editor Fixes https://gitlab.com/kicad/code/kicad/issues/10272 (cherry picked from commit 7f1648934f)	2022-01-05 11:33:35 -08:00
Steffen Mauch	502e34349e	eeschema: EAGLE plugin does not reference footprint with library suffix ... Fixes https://gitlab.com/kicad/code/kicad/issues/10261	2022-01-05 19:14:27 +00:00
Seth Hillbrand	30549a5e6a	Don't strip extensions twice in BOM export ... Exporting the Bill of Materials uses the netlist exporter. Both of these routines were stripping the extension, leading to projects like "test.project.kicad_pro" having the project name stripped. We separate the BOM netlist export from generic plugin netlist export to allow the correct behavior when exporting netlists and generating BOMs Fixes https://gitlab.com/kicad/code/kicad/issues/10270 (cherry picked from commit bef762e652)	2022-01-05 11:07:49 -08:00
Seth Hillbrand	9ca41cc8ee	Set readable flags correctly on open ... Missing files may be thrown during open. These should have existence and readable flags set correctly (cherry picked from commit a05ec04ee8)	2022-01-05 09:55:51 -08:00
jean-pierre charras	cd0ac9e698	eeschema, DIALOG_FIELD_PROPERTIES: fix a few issues. ... (incorrect handling of H and V justify bitmap buttons Fixes #10267 https://gitlab.com/kicad/code/kicad/issues/10267	2022-01-05 17:25:18 +01:00
Seth Hillbrand	b0fddef9b4	Don't rename existing schematic file ... We should never leave a situation where the schematic file may no longer exist (if the first rename succeeds and the second fails). So, make a backup copy of the original schematic file and then attempt to rename the autosave over the first file. In this case, if either attempt fails, we do not lose the original file Fixes https://gitlab.com/kicad/code/kicad/issues/10074 Fixes https://gitlab.com/kicad/code/kicad/issues/10256 Fixes https://gitlab.com/kicad/code/kicad/issues/10219 (cherry picked from commit b1658fdf9a)	2022-01-04 20:28:21 -08:00
Marek Roszko	726d873c53	Tear down the wxPoint trigo helpers	2022-01-04 21:23:11 -05:00
Seth Hillbrand	dda569d486	Don't split legacy paths ... The '.' is a valid character in the legacy preferences, not a separator. Also adds fail-safe catch for JSON throws Fixes https://gitlab.com/kicad/code/kicad/issues/10211 (cherry picked from commit a326d777f0)	2022-01-04 11:09:40 -08:00
jean-pierre charras	c2b54faceb	CvPcb: fix crash due to a null pointer: pcbconfig() can return null. ... CvPcb has no config option and pcbconfig() returns nullptr. In this case use default settings. Fixes #10250 https://gitlab.com/kicad/code/kicad/issues/10250	2022-01-04 14:51:32 +01:00
Marek Roszko	ac715d2e51	Scoop up some more wxPoint instances	2022-01-03 20:00:53 -05:00
Jeff Young	e21fa31f64	Rip out rest of macHack architecture.	2022-01-03 22:09:56 +00:00
Roberto Fernandez Bautista	2d3624a016	Rename ComparePageNumAndName -> ComparePageNum	2022-01-02 23:20:17 +00:00
Jon Evans	9daa4d0e2c	Move duplicate field handling into field parser ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/10130 (cherry picked from commit ea99c42df6)	2022-01-02 13:19:54 -05:00
Jeff Young	89c0f8e297	Move to new font engine.	2022-01-02 14:57:03 +00:00
jean-pierre charras	c108d25897	Fix mirroring tests issues in qa tests for eeschema	2022-01-02 15:44:52 +01:00
jean-pierre charras	e6087f361a	Add forgotten fix	2022-01-02 15:08:09 +01:00
jean-pierre charras	797de9d327	Fix some issues (but not all) in qa tests for eeschema ... The main fix is for errors in SCH_TEXT and derived: qa test expects 4 rotations is an identity transform: This is false if the item has autoplaced fields. The fix clears autoplaced flags.	2022-01-02 14:54:27 +01:00
Simon Richter	d25fe17b28	Bump minimum required CMake version to 3.11 ... Signed-off-by: Marek Roszko <mark.roszko@gmail.com>	2022-01-01 21:35:08 -05:00
Seth Hillbrand	a365afde3c	Ensure merged line gets selected if either parent is ... We were only checking for the selection of a single line that gets merged. This prevents the merged line from being highlighted but not selected after merging Fixes https://gitlab.com/kicad/code/kicad/issues/10202 (cherry picked from commit addc5574b4)	2022-01-01 16:53:52 -08:00
Jeff Young	93018375f8	Fix some test errors and update gold files for better netnames.	2022-01-01 20:46:45 +00:00
Jeff Young	32dec0127e	Fix some issues with Eeschema's Shape Properties dialog. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10140	2022-01-01 20:46:45 +00:00
Marek Roszko	34e90e5045	Silence MSVC warnings about type mismatch and unused var	2022-01-01 14:41:36 -05:00
Marek Roszko	c91d3e3cf9	Remove some more wxPoint	2022-01-01 14:12:20 -05:00
Roberto Fernandez Bautista	a0d708e04d	Use virtual page number when real page numbers are blank ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/10158	2022-01-01 18:36:56 +00:00
Marek Roszko	ea613cf448	Another batch of point changes	2022-01-01 13:17:12 -05:00
Marek Roszko	d1552c3fec	Some more wxPoint removal	2022-01-01 12:11:21 -05:00
Marek Roszko	c4c56de708	Neurotically update position wxPoint usages	2022-01-01 11:55:51 -05:00
Marek Roszko	cadc0639eb	Update BASE_SCREEN to VECTOR2I	2022-01-01 11:30:33 -05:00
Marek Roszko	347e03363a	Convert wxPoint/wxSize starting from EDA_RECT usages	2022-01-01 11:30:33 -05:00
jean-pierre charras	640cc60bf4	fix a compil warning.	2021-12-31 15:53:24 +01:00
Ian McInerney	0e9cfd0af2	Add missing initialization values to variables ... Flagged by Coverity.	2021-12-30 23:42:06 +00:00
Ian McInerney	0f2e649b18	Cleanup formatting and warnings in tuner_slider	2021-12-30 23:03:13 +00:00
Roberto Fernandez Bautista	701e256b3f	Correctly handle excluding an ERC marker in eeschema when right clicking ... In addition, hide the option to exclude a marker if the selected marker is already excluded. Fixes https://gitlab.com/kicad/code/kicad/-/issues/10173	2021-12-30 17:14:36 +00:00
jean-pierre charras	480a548171	PCB_PAINTER: do not show track arc clearance when not needed ... fix also a minor compil warning. Fixes #10137 https://gitlab.com/kicad/code/kicad/issues/10137	2021-12-30 09:21:35 +01:00
jean-pierre charras	7c3f0612f1	DIALOG_SPICE_MODEL: fix a cosmetic issue (no room for the help text) ... Fixes #10170 https://gitlab.com/kicad/code/kicad/issues/10170	2021-12-30 09:19:00 +01:00
Mark Roszko	44dc602d6b	Yeet wxPoint/wxSize out of PLOTTER	2021-12-29 19:02:50 +00:00
Jeff Young	ccb94fd1a7	APIs for passing KIFONT::FONT pointers around. ... Also some clean-up and bug fixes.	2021-12-29 17:32:19 +00:00
Jeff Young	dd6cd7d184	Pull some more improvements in from rockola/kicad-strokefont. ... This one is primarily about pushing TEXT_ATTRIBUTES in to the GAL API, but it also includes adding EDA_ANGLE signatures to some trig routines to ease integration.	2021-12-29 17:32:19 +00:00
Mikolaj Wielgus	906eee68a5	Another small cleanup after !490	2021-12-29 17:41:21 +01:00
Marek Roszko	3f711b8958	Add win32 VERSION_INFO resource blocks for the DLLs	2021-12-28 23:54:27 -05:00
Mike Williams	bf2c4c1584	Eeschema: draw dangling end shadows	2021-12-29 00:06:12 +00:00
Jeff Young	56a31900d3	Formatting.	2021-12-28 22:47:05 +00:00
Jeff Young	86cb57f4a7	Cherry-pick TEXT_ATTRIBUTES and EDA_ANGLE from rockola/kicad-strokefont	2021-12-28 22:15:20 +00:00
Mikolaj Wielgus	a0c4f05c17	Small cleanup after !490	2021-12-28 23:07:30 +01:00
Wayne Stambaugh	7b1b96c933	Fix broken tree book selection in paged dialogs. ... This only affected the tree controls that only parented sub-pages. Do not use the dialog ctor to select the initial page. Queuing a page changed event to fire after the dialog is shown is the proper solution.	2021-12-28 09:43:57 -05:00
Frank Zeeman	8167c69508	Add transformation function for characteristic curves of tuners	2021-12-28 02:53:39 +01:00
Frank Zeeman	f004665df8	Add tuner support for potentiometer code model	2021-12-28 02:53:39 +01:00
Frank Zeeman	e618ef98e9	Add potentiometer code models to model selection	2021-12-28 02:53:39 +01:00
Marek Roszko	705aa64c24	Fix parent of schematic setup parent nodes	2021-12-27 19:08:41 -05:00
Thomas Pointhuber	9ba733f23f	altium: Import POLY shape instead of line approximation (#8741)	2021-12-27 17:22:28 +01:00
Thomas Pointhuber	82ab04c1d6	altium: Use newly introduced RECT shape, apply fill and improve stroke handling (#8741)	2021-12-27 16:50:30 +01:00
Thomas Pointhuber	8b714deae1	altium: Add support for circle and arc in schematic (#8741)	2021-12-27 16:02:12 +01:00
dsa-t	d105e773a1	Update columns when height changes too	2021-12-25 15:26:43 +00:00
Alex	45c50535c5	Use GetUnobscuredSize in dialogs/panels	2021-12-25 15:26:43 +00:00
Alex	c4a4862e8f	Try with KIPLATFORM	2021-12-25 15:26:43 +00:00
dsa-t	b0cca4a89e	Symbol Fields Table: Make list look as good as possible on Windows too	2021-12-25 15:26:43 +00:00
Jeff Young	933b82495d	Use ISO 128-2 values for dashed line defaults.	2021-12-25 14:00:57 +00:00
Jeff Young	ec104e4ab0	Add hint to symbol editor defaults. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9776	2021-12-24 23:25:07 +00:00
Jeff Young	03a2723b67	Improve GUI of lib item colors.	2021-12-24 21:21:11 +00:00
Jonathan Haas	e2fc105201	Add custom fill color selection to shape properties dialog	2021-12-24 21:21:04 +00:00
Jonathan Haas	45d7f68f38	Use actual custom fill color for painting	2021-12-24 21:20:59 +00:00
Jonathan Haas	80e7b6eb1f	Save and load fill color of SHAPE_T objects properly	2021-12-24 21:20:54 +00:00
Jeff Young	3b04fc7dca	Use real text measurement for pin bounding boxes.	2021-12-24 21:10:28 +00:00
Jeff Young	29c942816e	Reduce duplication of settings.	2021-12-24 21:10:28 +00:00
Jeff Young	24ce4d8aa2	Improve help text now that we're past string freeze.	2021-12-24 18:13:26 +00:00
Jeff Young	e48d4a653a	Pick better auto-generated netnames. ... Fixes https://gitlab.com/kicad/code/kicad/issues/4312	2021-12-24 18:13:16 +00:00
Jeff Young	c3552a940a	Make sure standard OK/Cancel buttons respond to current language. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9635	2021-12-24 18:13:11 +00:00
Jeff Young	af13533b42	Add show/hide controls for ERC markers. ... ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270	2021-12-24 17:38:50 +00:00
Jeff Young	a6dd1bf09b	Implement Reset to Defaults for all preferences panels.	2021-12-24 17:38:39 +00:00
Jeff Young	4cf3f44532	More consistency with hint messages.	2021-12-24 17:23:41 +00:00
Jeff Young	9de62d1dd4	Promote to cell selection for spreadsheet-style paste. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9211	2021-12-24 16:29:23 +00:00
Jeff Young	889970a449	SCH_NETCLASS_FLAGs and SCH_FIELDs for labels. ... ADDED: a new label type for netclass flags. ADDED: the ability to define fields on labels.	2021-12-24 16:13:27 +00:00
Jeff Young	f7721dd274	Add highlight shadows for highlighted nets. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8817	2021-12-24 15:43:28 +00:00
Jeff Young	9ee28ea8f5	Flatten out some more preferences.	2021-12-24 15:43:20 +00:00
Jeff Young	68d2630d08	Flatten a layer of indirection out of 3D config settings.	2021-12-24 13:08:54 +00:00
Jeff Young	d28714167c	All the preferences, all the time. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7877 Fixes https://gitlab.com/kicad/code/kicad/issues/5153	2021-12-24 13:08:44 +00:00
Jeff Young	f1410f0240	Line styles for PCBNew shapes. ... Fixes https://gitlab.com/kicad/code/kicad/issues/2150	2021-12-24 12:36:59 +00:00
Jeff Young	e92efebb5f	Formatting.	2021-12-24 11:39:57 +00:00
Jeff Young	295a6408c3	User-configureable dash styles (and dash-dot-dot). ... ADDED: Schematic Setup properties for dash length and gap length. ADDED: dash-dot-dot line style Fixes https://gitlab.com/kicad/code/kicad/issues/2206	2021-12-23 20:36:24 +00:00
Jeff Young	e26341d424	Cleanup.	2021-12-23 20:36:18 +00:00
Jeff Young	92e589b398	Use board maxError value, and return SH_ARC for unfilled circle.	2021-12-23 20:36:11 +00:00
Jeff Young	2bc86fa0a8	Shapes for schematic. ... ADDED arc, circle and rectangle shapes for schematic. Shapes support line styles and fill colors. CHANGED sheet background color in Edit Text & Graphics Properties to fill color (and it now affects shapes). Pushed STROKE_PARAMS down into common and moved all shapes to using it for stroke descriptions.	2021-12-23 20:36:07 +00:00
Jeff Young	f089cf44a7	Allow a 0 pin-symbol-size. ... This is particularly important when reading legacy projects as 0 is what signals the painter to use the old algorithm (1/2 pin name/number size). Fixes https://gitlab.com/kicad/code/kicad/issues/10100	2021-12-23 16:54:03 +00:00
Jeff Young	6e2460ad37	Add hot-updating of units in common wxGrids. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10020	2021-12-23 16:54:03 +00:00
Jeff Young	9af33cdfe8	Don't leave stranded symbols/footprints in editors when doc closes. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10026	2021-12-23 16:54:03 +00:00
Jeff Young	ee5db73113	Use a bigger hammer to update adjacent segments. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9927	2021-12-23 16:54:03 +00:00
Jeff Young	aa4dcb2bf1	Make sure undo/redo of pagesetup is done to correct sheet. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9999	2021-12-23 16:54:03 +00:00
Jeff Young	8b52e969d6	Restore units to a bunch of wxGrids. ... Fixes https://gitlab.com/kicad/code/kicad/issues/10063	2021-12-23 16:54:03 +00:00
Jeff Young	160328abc7	Fix arc printing for flipped shapes.	2021-12-20 18:07:27 +00:00
dsa-t	f2ad8bffe0	Fix a mistake in Altium parser ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/10011	2021-12-16 05:49:39 +03:00
Seth Hillbrand	40d44c94cd	Fix single-threaded loads/connectivity ... We cannot set thread counts to hardware_concurrency()-1 without considering that single core machines will get a thread count of 0.	2021-12-14 17:18:46 -08:00
Jeff Young	1ca90f31bf	Fix hidden column in DIALOG_SYMBOL_FIELDS_TABLE. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9987	2021-12-15 00:03:33 +00:00
Mikolaj Wielgus	2dbc6ef6ca	If present, tune Spice_Model instead of Value ... Fixes https://gitlab.com/kicad/code/kicad/issues/9880	2021-12-14 14:02:25 +01:00
Adam Wolf	4fd5c9cfa8	Adjust macOS BOM plugin Python path	2021-12-13 22:52:31 +00:00
Adam Wolf	5e2ca2aa2a	Install kicad_utils.py BOM plugin helper	2021-12-13 22:52:31 +00:00
Wayne Stambaugh	755607b8f8	Fix a few wxUpdateUIEvent retrigger loops.	2021-12-13 15:46:13 -05:00
Jeff Young	653c7b78d7	Move NC pin logic so we set it before we need it. ... Also fixes drawing the dangling symbol in the Pin Properties dialog and when printing. Fixes https://gitlab.com/kicad/code/kicad/issues/9962	2021-12-12 22:25:36 +00:00
Wayne Stambaugh	067fa65756	Eeschema: fix a multitude of LIB_FIELD object comparison and index bugs. ... It is no longer acceptable to set a LIB_FIELD index to -1. This was trashing the sorting on load cause all kinds of false field comparison failures. There are now assertions when attempting to use -1 as a field index. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9811	2021-12-12 17:06:32 -05:00
dsa-t	4ccfc21324	Fix event id intersections when toggling some columns via popup. ... Also increases maximum show/hide column count to 50. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9765	2021-12-13 00:35:44 +03:00
Jeff Young	885979ba75	Fix selection logic to handle LIB_ITEM as well as SCH_ITEM. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9954	2021-12-12 17:38:38 +00:00
Jeff Young	88fc6d25a7	Correctly handle deleting multiple selections in some grids. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9952	2021-12-12 17:28:17 +00:00
Jeff Young	d1e6c216e1	And the modify bit wasn't getting set either. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9926	2021-12-11 01:09:13 +00:00
Jeff Young	15d1abeeef	Sigh. But addCorner() *does* need mapCoords(). ... And it's got an off-by-one error in it too. I don't think this ever worked at all. Fixes https://gitlab.com/kicad/code/kicad/issues/9926	2021-12-11 01:06:36 +00:00
Jeff Young	1f126c5619	Hittesting already handles inverse coordinate system. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9926	2021-12-11 00:32:24 +00:00
Seth Hillbrand	91dace3e5e	Update Eagle importer ... Fixes arc orientation Sets root schematic and page numbers Fixes https://gitlab.com/kicad/code/kicad/issues/9907	2021-12-10 15:41:25 -08:00
Jeff Young	8c5dd46861	Undo for SCH add/remove corner. ... (PCB_POINT_EDITOR uses a BOARD_COMMIT and so already handles undo.) Fixes https://gitlab.com/kicad/code/kicad/issues/9925	2021-12-10 23:08:16 +00:00
Jeff Young	1b2a278de9	Don't put "exclude from board" symbols in CvPCB netlist. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9939	2021-12-10 23:00:50 +00:00
jean-pierre charras	65cbf2d2b7	Eeschema: fix draw issue for global labels in Cairo mode. ... Fixes #9933 https://gitlab.com/kicad/code/kicad/issues/9933	2021-12-10 20:47:17 +01:00
Jeff Young	0ad0627bb0	Overhaul drag-select logic to handle children better. ... Fixes https://gitlab.com/kicad/code/kicad/issues/6662	2021-12-10 18:44:07 +00:00
Jeff Young	4f60d7ac78	Don't use lib tree target if lib tree isn't shown. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9913	2021-12-10 00:34:22 +00:00
Jeff Young	832eb0d019	Fix off-by-one error in grid snapping. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9013	2021-12-09 16:35:11 +00:00
Wayne Stambaugh	af280f80e0	Fix debug assertion in Altium and CADSTAR schematic importers.	2021-12-09 12:56:03 +00:00
Wayne Stambaugh	b7af66e3f9	Eeschema: fix broken page numbers when renaming a sheet file name. ... Always use full sheet paths when storing sheet instances. Partial sheet paths cannot be full resolved resulting in lost page numbers when renaming sheet file name. Fixes #9782	2021-12-09 12:56:03 +00:00
Seth Hillbrand	f7fb756f78	All imported schematics need connectivity update ... Fixes https://gitlab.com/kicad/code/kicad/issues/9907	2021-12-08 16:27:24 -08:00
dsa-t	9c619d8f4e	Allow some navigation tools when selecting ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9565	2021-12-07 23:00:39 +00:00
Jeff Young	3d97138d92	Bug fix for dangling symbols on pins. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9667	2021-12-07 21:39:06 +00:00
Jeff Young	c4336de868	Bug fixes in new dangling symbol drawing code.	2021-12-07 21:31:42 +00:00
Seth Hillbrand	84cdc9701f	Partially reverts d877f041 ... Based on discussion in https://gitlab.com/kicad/code/kicad/-/merge_requests/1029 we will keep the original behavior. The new routines to get stock paths are still useful (possibly in scripting) and are kept	2021-12-06 16:14:40 -08:00
Jeff Young	73b39e836d	Set modify bit when editing page layout. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9891	2021-12-06 23:08:33 +00:00
Jeff Young	2e342ed8c9	Draw dangling symbols on a separate layer. ... This allows us to draw them in front of wires, pins, and most importantly, junction dots. Fixes https://gitlab.com/kicad/code/kicad/issues/9667	2021-12-06 18:50:50 +00:00
Wayne Stambaugh	a03e6e4926	Revert "Eeschema: fix broken page numbers when renaming a sheet file name." ... This reverts commit a468a79948.	2021-12-06 07:47:18 -05:00
Wayne Stambaugh	5ae844ba93	Revert "Fix SCH_SHEET object assignment operator bug." ... This reverts commit 37d53a7147.	2021-12-06 07:47:02 -05:00
Jon Evans	a205595404	PROF_COUNTER -> PROF_TIMER ... I want to add an event counter, and this one is a timer	2021-12-05 14:25:37 -05:00
Mikolaj Wielgus	10be483430	Make an exception for SCH_TEXT in SELECTION::GetCenter() ... And undo the previous changes in SCH_TEXT::Rotate(). We continue hitting this with a wrench until it gets fixed or becomes broken beyond any recognition.	2021-12-04 05:32:48 +01:00
dsa-t	cb482eb8eb	Symbol Fields Table: Highlight proper symbols even if they aren't annotated	2021-12-03 20:35:54 +00:00
Mikolaj Wielgus	9efbeaa064	Dark theme support for SPICE model editor	2021-12-03 03:41:32 +01:00
Mikolaj Wielgus	83162364e7	Restore old rotation behavior for SCH_LABEL ... Fixes https://gitlab.com/kicad/code/kicad/issues/9861	2021-12-03 01:43:02 +01:00
Franck Bourdonnec	d877f04198	fixe paths	2021-12-02 20:23:00 +00:00
Jeff Young	863699f2d1	Fix logic error in selection tool. ... Any new selection made by clicking is not a hover selection. Fixes https://gitlab.com/kicad/code/kicad/issues/9857	2021-12-02 16:56:47 +00:00
Mikolaj Wielgus	4ba110e1ec	Restore original SCH_TEXT::GetBoundingBox() ... Didn't intend to commit this, it was a mistake.	2021-12-02 16:43:19 +01:00
Mikolaj Wielgus	bb08ef2f41	Fix SCH_TEXT rotation around a reference point ... Fixes https://gitlab.com/kicad/code/kicad/issues/9690	2021-12-02 16:35:35 +01:00
Marek Roszko	50c1a91d44	Add a simple open wrapper for the bom python plugins to handle directory creation	2021-12-02 01:07:55 -05:00
Mikolaj Wielgus	3960c2441b	Snap rotation center to half-grid, not grid	2021-12-01 17:53:42 +01:00
kliment	9f568d3658	Eeschema: Add support for leading zeroes when auto-incrementing names (fixes #9831)	2021-12-01 13:20:35 +00:00
Wayne Stambaugh	37d53a7147	Fix SCH_SHEET object assignment operator bug.	2021-12-01 07:19:30 -05:00
jean-pierre charras	3a00d76207	Fix a compil warning (shadowed var) and add a comment.	2021-12-01 11:05:16 +01:00
dsa-t	bfe595819a	Prevent error when loading bitmaps from some old schematics	2021-12-01 09:54:48 +00:00
Ian McInerney	6d8642e44c	Remove default settings missed in 025d9f82ea	2021-12-01 01:59:40 +00:00
Seth Hillbrand	85ab4e5886	Don't deselect wires when aligning ... This makes undo/redo look really strange as the other elements get aligned but the wires do not (or rather their unconnected ends do not) Fixes https://gitlab.com/kicad/code/kicad/issues/9275	2021-11-30 16:30:28 -08:00
Wayne Stambaugh	a468a79948	Eeschema: fix broken page numbers when renaming a sheet file name. ... Remove duplicate instance data saved in both root SCH_SCREEN and SCH_SHEET objects that was causing them to be out of sync. All sheet instance data is stored in the SCH_SHEET object itself and rebuilt on the fly so it is always current. Remove Get/SetPageNumber from SCH_SHEET_PATH object so it doesn't obfuscate where the actual sheet page number information exists. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9782	2021-11-30 08:11:24 -05:00
dsa-t	5750e38102	Re-enable and fix Move+Autoplace Fields ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9766	2021-11-29 20:48:16 +00:00
Jeff Young	a0711bdb56	Keep previous commit from violating string freeze.	2021-11-29 20:09:35 +00:00
Jeff Young	78be5df39a	Don't allow negative line widths to shrink bounding box. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9776	2021-11-29 20:02:03 +00:00
Jeff Young	a0f1d77eaa	Quiet wxWidgets assert.	2021-11-29 18:54:47 +00:00
jean-pierre charras	91363dd93c	PANEL_EESCHEMA_COLOR_SETTINGS: fix a minor cosmetic issue.	2021-11-29 15:30:38 +01:00
Jeff Young	3a51fb6ac6	Be more consistent about annotation warngings. ... This can be a particular problem if you go to run ERC, it shows the annotation warnging so you re-annotate (but don't notice that your scope is set to Selection). Also adds some missing defensive code around closing a modeless RC checker before the document (which we had for DRC dialog but not the ERC dialog). Also fixes a missing override of GetSeverity which kept ERC messages from having the right prefix.	2021-11-29 14:24:45 +00:00
Jeff Young	a224d8dd6c	Disable autoplace fields when dragging/moving. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9766	2021-11-28 19:18:08 +00:00
Mikolaj Wielgus	9bb370e6b4	SCH_SHEET_PIN: Rename GetEdge, SetEdge to GetSide, SetSide	2021-11-28 20:07:06 +01:00
Jeff Young	80d6b9e76d	Tighten up hittesting for symbols and other items. ... Grid-based accuracy doesn't need to be any larger than 1/2 the diagonal as we'll snap to one side or the other. And symbols don't need as much slop as other items since there's plenty of "meat" on them. Fixes https://gitlab.com/kicad/code/kicad/issues/9805	2021-11-28 19:03:51 +00:00
Mikolaj Wielgus	71bfbfaa70	Test SCH_PIN rotation and mirroring	2021-11-28 19:37:13 +01:00
Mikolaj Wielgus	2e1862de1c	Run AutoAutoplaceFields() in SCH_SHEET constructor ... A constructor should create a fully initialized object.	2021-11-28 18:46:28 +01:00
Jeff Young	75d750a3cb	Copy lastResolved stuff when pasting. ... This of course assumes the paste came from the same document. If not then pasted items will get default lastResolved stuff.	2021-11-28 17:09:24 +00:00
Jeff Young	58b5ac4970	Don't create SCH_LINE till we know the layer. ... The CTOR makes some decisions on initialization based on the layer.	2021-11-28 17:09:24 +00:00
Jeff Young	f23cd9c9e5	Clearer naming.	2021-11-28 17:09:24 +00:00
Jon Evans	d7f5917fb0	ERC: flag duplicated local labels with no pins as floating ... See https://gitlab.com/kicad/code/kicad/-/issues/9593	2021-11-27 22:34:11 -05:00
Mikolaj Wielgus	65af3a8568	Make sheet pin positions invariant to four rotations more often	2021-11-28 02:18:18 +01:00
Roberto Fernandez Bautista	dd219419a0	Quiet wxWidgets asserts (sheet & symbol properties dialogs) ... Ensure we don't set column size smaller than 1. If so, set to -1 to auto size.	2021-11-27 21:03:42 +00:00
Roberto Fernandez Bautista	3660597082	Use canonical names when saving sheet name and filename fields	2021-11-27 20:38:51 +00:00
Mikolaj Wielgus	f35b0446e6	Properly initialize SCH_TEXT spin style	2021-11-27 19:42:11 +01:00
Jeff Young	9f7db24871	Selection bug fixes for Symbol Editor. ... 1) Make sure the y-coord is correctly inverted before calling collision routines. 2) Give LIB_SHAPE poly lines the same extra slop as SCH_LINEs. Fixes https://gitlab.com/kicad/code/kicad/issues/9791	2021-11-27 15:17:05 +00:00
Jeff Young	87e71072b1	Default line width to 0 in symbol editor. ... Also removes some atrophied settings for repeated non-pins in symbol editor (which only ever repeats pins). Fixes https://gitlab.com/kicad/code/kicad/issues/9776	2021-11-27 11:53:38 +00:00
jean-pierre charras	b8b8c0d34c	dialog text properties: fix a focus issue. ... Fixes #9792 https://gitlab.com/kicad/code/kicad/issues/9792	2021-11-27 10:08:30 +01:00
Jeff Young	698a668af7	Coverity fixes.	2021-11-26 18:14:29 +00:00
Jon Evans	08cb573e11	Do not propagate bus entries across buses and wires at the same point ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9678	2021-11-25 13:36:30 -05:00
Jon Evans	aa5f496727	Properly migrate bus-bus entries on load of legacy schematic ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9678	2021-11-25 12:12:01 -05:00
Jeff Young	5863bc0937	Put Repair Schematic behind Advanced Config.	2021-11-25 12:56:46 +00:00
Simon Schaak	c7dd98fb1a	Fix outdated syntax in help text	2021-11-25 12:53:29 +00:00
Jon Evans	9f6910f1e6	Expand autoplace collision search to include potential field locations ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9762	2021-11-25 07:48:05 -05:00
Jeff Young	5e6da9f964	Auto-start-wire tool requires an up-to-date connectivity. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9628	2021-11-25 01:24:35 +00:00
Jeff Young	5d751bef74	Be cognizant of connectivity dirtiness when cloning wires. ... While the root case is wires, it really applies to all SCH_ITEMs. Fixes https://gitlab.com/kicad/code/kicad/issues/9628	2021-11-25 01:24:35 +00:00
Jeff Young	f11cc904d2	More fixes for realtime connectivity being off. ... Don't update net highlighting until after connectivity has been rebuilt. Fixes https://gitlab.com/kicad/code/kicad/issues/9628	2021-11-25 01:24:35 +00:00
Jeff Young	ed705986e0	No realtime connectivity fixes for junctions. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9628	2021-11-25 01:24:35 +00:00
Roberto Fernandez Bautista	2eb5d4fa7a	Symbol Editor: Allow save as all the time, as long as we have a symbol to save ... There doesn't appear to be any reason why the LIBID needs to be populated before a "save as", seeing as the user will be inputting the new lib name and lib nickname via the dialog. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9744	2021-11-24 19:43:09 +00:00
Jeff Young	7fc04c3cf2	Fixes for realtime connectivity being off. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9628	2021-11-24 13:20:44 +00:00
Jeff Young	9e999f4de4	ADDED Repair Schematic. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9749	2021-11-24 13:20:44 +00:00
Jeff Young	228edd4121	Don't generate duplicate IDs in line/wire/bus tool. ... Also cleans up existing duplicate IDs when reading. Fixes https://gitlab.com/kicad/code/kicad/issues/9749	2021-11-24 13:20:44 +00:00
Jeff Young	b052d56c7b	R/W uuids for junctions.	2021-11-24 13:20:44 +00:00
Jeff Young	696f7c47fb	Reduce use of auto.	2021-11-24 13:20:44 +00:00
Seth Hillbrand	65fc47cb8f	Don't lose track of the sheet's screen ... Corner cases need to clear screen before loading a new file. Aborting needs to restore the screen or risk segfaults Fixes https://gitlab.com/kicad/code/kicad/issues/9739	2021-11-23 10:57:12 -08:00
Seth Hillbrand	126563c839	Fix initilization project / ordering ... We cannot resolve the Canvas type without the canvas being initialized. But saving settings sometimes requests canvas access. This protects the calls against failure by checking for canvas before saving canvas-specific settings Fixes https://gitlab.com/kicad/code/kicad/issues/9729	2021-11-22 11:47:42 -08:00
Seth Hillbrand	3f2d86adec	Make OpenGL default for all apps ... Fixes https://gitlab.com/kicad/code/kicad/issues/9699	2021-11-21 12:33:07 -08:00
Jeff Young	016a98df86	Increment numbers which have suffixes too. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9706	2021-11-21 18:02:17 +00:00
Jeff Young	15f309c8a8	Add a SCH_ITEM::operator= so the connections caches don't get copied. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9710	2021-11-21 16:54:46 +00:00
Jeff Young	c1703212dc	"Document" properties go in File menu; Edit menu is for item props.	2021-11-20 22:44:43 +00:00
Seth Hillbrand	2159acc9ce	Fix missing handler for multiple labels ... This was intended to handle multiple labels but we missed the selection condition. Fixes https://gitlab.com/kicad/code/kicad/issues/9704	2021-11-20 14:37:18 -08:00
Jeff Young	5a5af91d88	Tidy up the SCH_PREVIEW_PANEL visibility flags. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9701	2021-11-20 15:28:17 +00:00
Seth Hillbrand	766a09c338	Remove autocomplete when we lose focus ... Prevents the excess dropdown from persisting over windows Fixes https://gitlab.com/kicad/code/kicad/issues/9651	2021-11-19 17:24:16 -08:00
Jeff Young	c01649fc6e	Make it easier to open legacy files.	2021-11-19 13:36:14 +00:00
Jeff Young	7bda077f69	Disable EE_POINT_EDITOR for uneditable symbol graphics. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9675	2021-11-18 15:38:46 +00:00
Jeff Young	1bb750814d	Cleanup dead code.	2021-11-17 12:49:53 +00:00
Jon Evans	9238b27f63	Silence IsWritable warning message ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9656	2021-11-16 21:02:32 -05:00
Jeff Young	969bef9a36	Fix stroking error when printing polygons.	2021-11-17 01:53:44 +00:00
Jeff Young	7760d3275d	Fix printing of LIB_SHAPE arcs.	2021-11-17 01:39:16 +00:00
Jeff Young	20328ab331	Back out last arc change.	2021-11-17 01:03:22 +00:00
Jeff Young	18d8053a6c	Fix an arithmetic precedence order bug and fine tune autoplacement. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9345	2021-11-17 00:49:42 +00:00
Jeff Young	b4ac53d93d	Attempt #1 to fix LIB_SHAPE arc printing.	2021-11-17 00:34:05 +00:00
Simon Schaak	399f2c116e	Symbol editor: save changed field properties ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9648	2021-11-15 20:40:32 +01:00
Jeff Young	12a75ffb94	A fuller implementation of allowing cut/copy/paste in search boxes. ... This one also works for other text entry widgets, and also works for other frames.	2021-11-15 18:13:35 +00:00
Christian Pfluger	9941a52e75	fix for issue #9345 autoplacing in schematic ... this fix moves designator fields to the side in case of collision with symbols or wires.	2021-11-14 18:02:36 +01:00
Jon Evans	ae24daa033	Do not include text when computing drag origin for a group ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9630	2021-11-14 11:54:04 -05:00
Jeff Young	b747ae5bdf	Make sure redraw happens regardless of order of panel commits. ... (We don't control the order of the TransferDataFromWindow calls for the various panels and here the junction dot size is dependant on the default netclass wire size. So that calc has to be done after all the various TransferDataFromWindow calls are made.) Fixes https://gitlab.com/kicad/code/kicad/issues/9541	2021-11-13 23:20:56 +00:00
Jeff Young	025d9f82ea	Remove atrophied schematic default wire and bus widths. ... (They're now in the netclasses, and specifically the default netclass if no other netclass is assigned.) Fixes https://gitlab.com/kicad/code/kicad/issues/9628	2021-11-13 22:56:50 +00:00
Jeff Young	efc64e972c	Fix pasting into LIB_TREE search control. ... We have a hack for turning accelerator keys that wxWidgets turns into menu commands back in to accelerator keys -- but it requires that the corresponding menu items be enabled in order to work.	2021-11-13 19:45:10 +00:00
Jeff Young	cc6e3841ae	Formatting.	2021-11-13 19:45:10 +00:00
Wayne Stambaugh	80c5b1efb1	File formatting improvements and fixes. ... Symbol library IDs included the library nickname which is incorrect and meaningless since it will be overwritten by the symbol library table code. This is not a file format change as there are no behavioral differences.	2021-11-13 12:57:18 -05:00
Wayne Stambaugh	53f5d616aa	Coverity issue fixes.	2021-11-13 11:38:31 -05:00
jean-pierre charras	e218471d24	DIALOG_CHANGE_SYMBOLS: fix a bug introduced by my commit 686b32db ... the filtering for mandatory fields was disabled.	2021-11-13 13:47:09 +01:00
Jeff Young	1e151b1bcb	Fix effective pen width when plotting wires. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9625	2021-11-12 16:27:55 +00:00
Jeff Young	da58e9ee4c	Don't rely on selection when updating edited symbol in schematic. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9600	2021-11-11 16:43:06 +00:00
jean-pierre charras	686b32dbd3	fix issue in DIALOG_CHANGE_SYMBOLS, in non English locale. ... Mandatory field names where compared in list, using translated and not translated names. Fixes #9596 https://gitlab.com/kicad/code/kicad/issues/9596	2021-11-11 10:56:09 +01:00
Jeff Young	54e00569d8	Don't fetch the root sheet's UUID out of the sheet instances. ... 1) we're storing it now anyway 2) the root sheet UUID is the one UUID that's *not* in the instance array, and previously we were erroneously grabbing the first sub-sheet's UUID (producing duplicate UUIDs).	2021-11-09 16:07:30 +00:00
Seth Hillbrand	6e5a918377	Writeable -> Writable	2021-11-08 15:56:51 -08:00
Jeff Young	de93a071e2	Fix error in python command string generation. ... (We can now go back to using double-quotes since that bug is fixed.) Fixes https://gitlab.com/kicad/code/kicad/issues/9552	2021-11-08 21:05:54 +00:00
Seth Hillbrand	cd3ecdfc78	Fix sort to be irreflexive ... Switching the order of the parameters must switch the sort order (no <=) otherwise the sort is non-determinant and fails std::sort preconditions	2021-11-08 11:25:13 -08:00
Mikolaj Wielgus	38bd4b07e4	Close the simulator before changing schematic ... Fixes https://gitlab.com/kicad/code/kicad/issues/9501	2021-11-07 23:35:06 +00:00
Roberto Fernandez Bautista	04a30638f0	eeschema: Pasted items are moving as soon as they are pasted ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9539	2021-11-07 15:14:11 +00:00
Jeff Young	f9a282278c	Update junction-dot-size-cache when Schematic Setup changes. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9541	2021-11-07 14:12:44 +00:00
Roberto Fernandez Bautista	b572781a8a	eeschema: Update anchor position of pasted items after initial move ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9534	2021-11-06 16:03:41 +00:00
Roberto Fernandez Bautista	d1bab3116d	eeschema: Warp to origin when moving - add missing text items ... Schematic fields and text items were not being warped to origin when moving.	2021-11-06 15:19:22 +00:00
jean-pierre charras	2f22b9dd81	Do not replace delimiter " by ' inside a command string, round 2.	2021-11-05 18:28:44 +01:00
Jeff Young	83e5208213	Fix a couple of holes in the IsTestEnabled() checks. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7270	2021-11-04 16:24:06 +00:00
Jeff Young	996a5b85a6	Overhaul IsJunctionNeeded logic to support all the different cases. ... Several clients were using this with different needs. The API is now more explicit (and there are more options under the hood). Fixes https://gitlab.com/kicad/code/kicad/issues/9518	2021-11-04 12:57:16 +00:00
Seth Hillbrand	cf6b18ec7e	Remove escaped double-quotes ... For some reason, escaped double quotes in wxString::Format cause issues on Mac. We can replace them with single quotes in most places without loss of clarity	2021-11-03 17:03:14 -07:00
Jeff Young	179628d1d2	Repair field properties dialog for rotation and mirroring. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9508	2021-11-03 18:11:59 +00:00
Roberto Fernandez Bautista	5e040ad126	eeschema settings: Default to mouse drag is drag action on first install ... This is to be consistent with other EDA tools like Altium and CADSTAR.	2021-11-03 16:58:11 +00:00
Jeff Young	c2371f3943	Revert e4b61de792. ... It doesn't seem to fix the testcase on Linux, and the tests pass on my machine in either configuration.	2021-11-03 10:30:34 +00:00
Jeff Young	e4b61de792	Special case sheet ordering in file.	2021-11-02 23:14:01 +00:00
Seth Hillbrand	7cf72aaa41	Fix bezier import in Altium schematics	2021-11-02 15:45:30 -07:00
Jeff Young	4d46445ce1	Fix Bezier reading. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9512	2021-11-02 22:19:41 +00:00
Jeff Young	4acff58c7a	Implement a forced ordering for LIB_ITEMs until we have UUIDs. ... (Once we read/write the UUIDs, we should just compare the type and then the UUID like we do for SCH_ITEMs.)	2021-11-02 20:07:34 +00:00
Jeff Young	eaf10a04dd	Improved naming.	2021-11-02 20:07:34 +00:00
Jeff Young	21cb56dfe7	Formatting.	2021-11-02 20:07:34 +00:00
Seth Hillbrand	9e760512ac	Update schematic when saving tuned value ... Also avoids a known(!) crash when the existing item has been deleted while tuning. Fixes https://gitlab.com/kicad/code/kicad/issues/9502	2021-11-01 17:05:22 -07:00
Simon Schaak	f79cb382c4	Symbol editor: fix name corruption in pin table ... Discard changes to pin numbers of grouped pins in the pin table to avoid setting all pins of the group to the same number.	2021-11-01 22:10:13 +00:00
Jeff Young	af95a4b424	Fix duplicate stroke when formatting circles. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9507	2021-11-01 21:29:46 +00:00
Jeff Young	40b4052ad4	Improve text hittesting in schematics. ... Text has a fairly big bounding box to account for descenders, overbars, etc., but it makes it feel too sloppy for hittesting. This change allows selection disambiguation to look at the actual strokes of the text when deciding what's "closest". Fixes https://gitlab.com/kicad/code/kicad/issues/9506	2021-11-01 21:13:12 +00:00
Wayne Stambaugh	bf85ddd577	Eeschema: fix bug printing polygon (possibly other) filled shapes.	2021-11-01 16:09:32 -04:00
Jeff Young	9f806d9304	Don't assume the grid size. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9013	2021-11-01 15:26:39 +00:00
Jeff Young	cec788d454	Must use GetEffectivePenWidth for output. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9504	2021-11-01 14:49:12 +00:00
Roberto Fernandez Bautista	b6c12b6b55	CADSTAR Sch: Fix positioning of symbol fields when the symbol is mirrored ... The text aligment needs to be rotated and/or mirrored depending on whether the text field is vertical or horizontal.	2021-10-31 16:12:08 +00:00
Roberto Fernandez Bautista	8367c7f238	CADSTAR Sch: Fix calculation of page size ... Don't attempt to calculate bounding box of text variables. We do not know the resolution of the text variable inside the importer. The resolved text could be shorter than the text variable (e.g. ${#} page number)	2021-10-30 21:49:34 +01:00
Roberto Fernandez Bautista	0aba025d66	CADSTAR Sch: Autoplace intersheet references (instead of 0,0)	2021-10-30 21:49:34 +01:00
Roberto Fernandez Bautista	18e36155a5	CADSTAR sch: Include gate in error message when symbols are scaled	2021-10-30 21:49:34 +01:00
Roberto Fernandez Bautista	52a936ac61	CADSTAR Sch: Fix spurious pin length and orientation of some symbols ... Ensure deterministic sorting of std::map in fixUpLibraryPins	2021-10-30 21:49:34 +01:00
Jeff Young	f345eacf13	Be more careful with undo, and don't re-merge a bus over a bus entry. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9475	2021-10-30 19:58:09 +01:00
Roberto Fernandez Bautista	c5cdda26ae	Fix crash in libedit when moving/editing pins in synchronised mode ... Unit numbers start at 1, not 0. Our vector needs to be size + 1 if we want to use the unit number as an index. 0 is reserved for "all units"	2021-10-30 18:14:23 +01:00
Roberto Fernandez Bautista	c1515dd31c	CADSTAR Sch: Fix block names - load as stand-alone text items instead ... KiCad doesn't support multi-line text in fields, so we can't load it as a text field (even if that would be the closest thing). We should update this when KiCad supports multi-line text in fields.	2021-10-30 18:14:23 +01:00
Jon Evans	d426abafd7	Handle empty shape in removeCornerCondition ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9495	2021-10-30 13:10:12 -04:00
Jon Evans	80e372b7d9	Fix blank DC sources causing crash in dialog creation ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9482	2021-10-30 11:17:10 -04:00
Jeff Young	5f8e0ef1e0	Patch up arc hit-testing and printing for 6.0 ... This could use another look when we're not so near release. We really shouldn't need to special case eeWinding vs. not eeWinding. Fixes https://gitlab.com/kicad/code/kicad/issues/9491	2021-10-30 15:10:07 +01:00
Jeff Young	b967610e05	Remove confirmation for De Morgan (and spell his name right). ... Fixes https://gitlab.com/kicad/code/kicad/issues/9483	2021-10-29 20:30:37 +01:00
Jeff Young	1fa9ad227a	Repair new junction logic for crossing wires. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9484	2021-10-29 19:09:02 +01:00
Jeff Young	fe6cb7dbb4	Mirror sheet fields when mirroring sheet. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9479	2021-10-28 21:45:22 +01:00
Jeff Young	0cdffa16d4	Fix off-by-one error in fill mode writing. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9111	2021-10-28 19:29:47 +01:00
Jeff Young	8fdfc0e63d	Replace legacy sch writing code for rescue functionality.	2021-10-28 15:11:15 +01:00
jean-pierre charras	cf6acae791	TUNER_SLIDER: add missing skip event in wxFocusEvents.	2021-10-27 20:33:51 +02:00
Seth Hillbrand	18318c73b5	Fix swapped parameters	2021-10-27 08:59:39 -07:00
jean-pierre charras	c3a4c40d4c	DIALOG_CHANGE_SYMBOLS: add missing skip event in wxFocusEvents. ... Fixes #9467 https://gitlab.com/kicad/code/kicad/issues/9467	2021-10-27 17:17:44 +02:00
Jeff Young	cb1709b4ca	Improve Eagle importer's label positioning. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9466	2021-10-27 13:49:13 +01:00
Jeff Young	e14864b35c	Invert Y axis for pin root bounding box. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9465	2021-10-27 01:44:15 +01:00
Jeff Young	3d2ffc12c1	Fix bugs in B&W plotting. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9411	2021-10-26 22:58:55 +01:00
Seth Hillbrand	dd99b2dc2f	Add action to edit symbol from Library ... Analog of ea4e06124e for symbol editor. Allows scripting to open library symbol	2021-10-26 12:59:59 -07:00
Jeff Young	f724fe7eff	Move bbox padding to RTrees so it doesn't interfere with hittesting. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9361	2021-10-26 13:46:30 +01:00
Jon Evans	8e5cbc5cf0	Fix highlighting complex connections from subsheets ... Sheet() can't be used for local sheet recall in these cases Fixes https://gitlab.com/kicad/code/kicad/-/issues/9403	2021-10-25 22:14:48 -04:00
Jeff Young	c52cb229d0	Add unsaved-changes indication to Symbol Properties. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9443	2021-10-25 12:35:04 +01:00
Jeff Young	e30d867439	Use consistent terminology for various constraint modes.	2021-10-23 12:18:08 +01:00
Jeff Young	30027030b5	Threading safety. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9399	2021-10-23 11:38:03 +01:00
Roberto Fernandez Bautista	3ea3d5274c	CADSTAR Schematic: Hide all KiCad sheet properties ... Sheet name/filename not applicable in CADSTAR so displaying it just makes the import look messy.	2021-10-23 10:58:15 +01:00
Seth Hillbrand	927b633c01	Make sure spice command doesn't assert ... Fixes https://gitlab.com/kicad/code/kicad/issues/4328	2021-10-22 16:50:29 -07:00
Jeff Young	4dcc847f85	Remove artificial limits from label increment control. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9340	2021-10-22 22:20:20 +01:00
jean-pierre charras	29756278e0	eeschema: fix crash when the simulator frame is open and the Tune tool is actived. ... In some cases when the Tune tool is actived and a symbol is selected, if the tool is deactivated from the right toolbar in Eeschema, Eeschema crashes.	2021-10-22 20:00:14 +02:00
Mikolaj Wielgus	28d7a2d7c9	Sim: Update tuner dialog values when focus is lost ... Fixes https://gitlab.com/kicad/code/kicad/issues/7841	2021-10-21 13:34:27 +00:00
Wayne Stambaugh	0795fcb810	Minor dialog layout fixes.	2021-10-21 08:59:55 -04:00
jean-pierre charras	bb4330db1e	DIALOG_BOM: do not quote filename when calling the editor. ... Due to previous changes in code, filenames must be not quoted. Fixes #9436 https://gitlab.com/kicad/code/kicad/issues/9436	2021-10-21 13:53:52 +02:00
Jeff Young	c5e5d8e0d4	Fix multi-sheet find/replace issues. ... 1) When replacing symbol fields, make sure we do it for all sheets 2) Honour "find on current sheet only" Fixes https://gitlab.com/kicad/code/kicad/issues/9431	2021-10-20 18:28:57 +01:00
Jeff Young	75b5bcf46d	Make Coverity happy.	2021-10-19 17:14:04 +01:00
Wayne Stambaugh	1e1da55840	Coverity fixes.	2021-10-19 07:42:27 -04:00
Seth Hillbrand	512ba167e8	Escape symbols when adding to library ... Can't escape by default because the allowed characters differ in the read-only libraries and existing schematics that reference them. So, escape when we import into standard KiCad Libraries Fixes https://gitlab.com/kicad/code/kicad/issues/9419	2021-10-18 10:42:58 -07:00
Seth Hillbrand	9b4c293f14	Ensure that any excess spaces removed ... The sim command may have additional whitespace between the type and first char	2021-10-18 10:12:53 -07:00
Jeff Young	4e48a16847	Look for all types of label conficts in ERC. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9367	2021-10-18 18:09:40 +01:00
Jeff Young	b8d193485d	Respect selection reference point when set. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8520	2021-10-18 18:09:40 +01:00
Jeff Young	1d4d83cb7c	Fix copy/paste error.	2021-10-18 18:09:40 +01:00
Seth Hillbrand	82ba456567	Remove unnecessary RegEx ... This broke for signals using underscores. More critically, RegEx is fragile and should not be used with user input if at all possible Fixes https://gitlab.com/kicad/code/kicad/issues/9421	2021-10-18 10:08:29 -07:00
Seth Hillbrand	64bcaaefd1	Fix radiobox order for FILL_T ... Fixes https://gitlab.com/kicad/code/kicad/issues/9412	2021-10-17 17:01:21 -07:00
Ian McInerney	5817a8b5f4	Remove unused m_host variable ... This variable isn't needed anymore after 5f53019290 pushed dark mode handling into the HTML window itself.	2021-10-18 00:29:40 +01:00
Ian McInerney	280743d9e9	Fix missing reference in for loop	2021-10-18 00:29:10 +01:00
Roberto Fernandez Bautista	d6d800ccbb	CADSTAR Schematic: Fix crash when trying to fix library pins ... Need to copy the chain as we might have deleted it.	2021-10-17 17:57:51 +01:00
Jeff Young	a1c1f60665	Coverity fixes.	2021-10-16 16:27:35 +01:00
Jeff Young	ce55dd2893	Fix botched merge.	2021-10-15 21:27:16 +01:00
Adam Wolf	ec10b12c6a	On macOS, copy libngspice dylibs and symlinks ... Now that ngspice creates soversion'ed libraries, we need to tweak how we copy the dylibs around. This is meant to address https://gitlab.com/kicad/code/kicad/-/issues/9143.	2021-10-15 17:34:27 +00:00
Jeff Young	f9861b4a6c	Finish arc rework and push out to file formats.	2021-10-15 12:45:43 +01:00
Jeff Young	b52529521e	Replace individual LIB_* shapes with LIB_SHAPE (based on EDA_SHAPE). ... Also moves to more capable FILL_T model that can be shared.	2021-10-15 12:45:43 +01:00
Jeff Young	9b9e379aa0	Overhaul arc internal model to not over-specify information.	2021-10-15 12:45:43 +01:00
Wayne Stambaugh	c61af21da8	Eeschema: don't stat files when updating title bar text. ... The tests for file existence and write status perform two file stats which cause performance issues on slow network shares. Now the file state is determined at load time and stored in the SCH_SCREEN object so file access is no longer required. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9343	2021-10-14 10:52:58 -04:00
Wayne Stambaugh	c4d0a06701	Eeschema: fix broken auto save feature. ... Make auto save recover all auto saved sheet files not just the root sheet. This does not fix existing auto save issues because recovery would require an iterative reload for each automatically saved sheet file and would only happen once. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9288	2021-10-13 14:51:00 -04:00
Mikolaj Wielgus	5f53019290	Substitute all wxHtmlWindow with HTML_WINDOW ... Remove other places where <body> tag is used to override the default black-on-white theme.	2021-10-12 07:07:15 +00:00
Roberto Fernandez Bautista	7aa3514042	CADSTAR Schematic: Add net labels for named nets on symbol pins ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9371	2021-10-11 18:30:21 +01:00
Seth Hillbrand	52bbfb9109	Remove dependency of dot size on linear mils ... Changes a dot to be a square pixel (linewidth x linewidth). This allows the removal of IU dependencies and ensures that a dot is always visible on screen. Also makes sure that cairo is setting the current linewidth during its stroke routines Fixes https://gitlab.com/kicad/code/kicad/issues/9362	2021-10-10 09:40:26 -07:00
Seth Hillbrand	48f9dfa988	Revert "Fix grid cell highlight not functioning on Windows in the symbol pin table" ... This reverts commit 94552ed838. Breaks cell-based copy/paste	2021-10-10 08:04:11 -07:00
Jeff Young	57c7d663b0	Fix bone-headed mistake when moving panel disabling.	2021-10-07 00:17:42 +01:00
Seth Hillbrand	b5cd976845	Don't arbitrarily exclude components from BOM ... We already exclude components based on the schematic property when generating the XML. Don't make a hidden second pass in the python netlist reader by default Fixes https://gitlab.com/kicad/code/kicad/issues/9326	2021-10-06 12:58:05 -07:00
Seth Hillbrand	2c7da5e2bd	Handle deleting segment ... Edited point needs to clear to allow us to use the click timer for left-click after the drawing is deleted. Fixes https://gitlab.com/kicad/code/kicad/issues/9320	2021-10-06 10:21:04 -07:00
Jeff Young	95f841a037	A more nuanced method of making Board & Schematic Setup read-only. ... This one still allows you to scroll to see all contents. Fixes https://gitlab.com/kicad/code/kicad/issues/9302	2021-10-06 11:16:46 +01:00
Jeff Young	935a307674	Formatting and iterator safety.	2021-10-06 11:13:16 +01:00
Seth Hillbrand	bb5c58b3cf	Set default force cursor off in auto-lines ... Leaving the forced position on results in the auto-line linking to a pin for far longer than we intend if there are other hits in the area of the cursor Fixes https://gitlab.com/kicad/code/kicad/issues/9321	2021-10-05 20:28:05 -07:00
Seth Hillbrand	854472d550	Prevent automatic RTree recaching ... Calling UpdateItem() may be performed by in a common loop, e.g. for( SCH_ITEM* item : GetScreen()->Items() ) or similar. We cannot call GetScreen()->Update( SCH_ITEM* ) in this routine as it will remove and re-add the item to the RTree, invalidating iterators. If needed, the items need to be cached to an external container before updating Fixes https://gitlab.com/kicad/code/kicad/issues/9318	2021-10-05 20:13:15 -07:00
Seth Hillbrand	9a8d1246cc	We don't keep a CHANGELOG.TXT ... Direct interested readers to AUTHORS.TXT instead.	2021-10-05 19:46:53 -07:00
Seth Hillbrand	548e5f49bd	Clean up unused variable usage ... Unused variables in function calls can be commented out. Unused return variables get a new routine `ignore_unused()` that silences the warnings with zero overhead.	2021-10-05 10:00:30 -07:00
Jeff Young	92008a089a	Disable Board & Schematic Setup controls when project is locked. ... (or missing). Fixes https://gitlab.com/kicad/code/kicad/issues/9302	2021-10-04 16:47:27 +01:00
Jeff Young	7c432d7a50	When annotating for another feature, make sure scope is entire schematic. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9303	2021-10-03 19:42:29 +01:00
Jeff Young	574bef2237	Normalize drawing sheet path to env vars & prj, not just prj. ... Also cleans up the dialog a bit. Also changes the workings of NormalizePath to return the input if it couldn't be shortened which saves open coding that behaviour in all its callers. Fixes https://gitlab.com/kicad/code/kicad/issues/9036	2021-10-02 23:39:45 +01:00
Jeff Young	10dd70881c	New paramaterized interface doesn't like quoted parameters. ... (At least on MSW, anyway.)	2021-10-02 14:08:36 +01:00
Marek Roszko	94552ed838	Fix grid cell highlight not functioning on Windows in the symbol pin table ... Fixes https://gitlab.com/kicad/code/kicad/issues/9290	2021-10-01 23:44:16 -04:00
Jeff Young	ef74421922	Move centering of lib-tree item to idle event. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9294	2021-10-01 22:46:14 +01:00
Jeff Young	5f5ee7335d	Formatting.	2021-10-01 21:49:14 +01:00
Jeff Young	f606679164	Proper numeric sorting for intersheet refs. ... Also expunges the horrifically named std::remove and std::remove_if (neither of which remove anything).	2021-10-01 18:29:21 +01:00
Jeff Young	5d579d14c1	Give intersheet refs a bit more breathing room.	2021-10-01 18:29:21 +01:00
Seth Hillbrand	dd1d36d40a	Fix segfault when check for editing points ... The point editor is not always available when checking for points. We need to handle the missing tool without crashing	2021-09-30 17:25:33 -07:00
Jeff Young	b9596a0a5d	Update dangling flags in color settings' preview.	2021-09-30 18:53:39 +01:00
Jeff Young	c7e6c273b4	Fix missing RTREE update.	2021-09-30 18:53:39 +01:00
Seth Hillbrand	13d913a014	Choose centering after zoom ... When we zoom after centering, the screen does not display the item at the appropriate location until you center again. Choose the zoom first to set the appropriate scale before translating the viewport	2021-09-29 16:30:52 -07:00
Jeff Young	12b726ba2f	Prevent the point editor from fighting with other tools. ... 1) Don't start a long-click timer when the point editor is active. 2) Don't auto-start a wire when the point editor is active. Fixes https://gitlab.com/kicad/code/kicad/issues/9270	2021-09-29 19:16:06 +01:00
Jeff Young	9cf9abbd66	Don't allow Text Properties dialog on intersheets references field.	2021-09-29 16:04:36 +01:00
Jon Evans	62ef27e372	Remove hard-coded anchor color in eeschema	2021-09-28 20:26:47 -04:00
Seth Hillbrand	2225c4e4ed	Replace GetRows() with GetNumberRows() because wx	2021-09-28 10:48:04 -07:00
Seth Hillbrand	880f209563	When deleting pin row, show new highlight ... When the user deletes a pin row, they need to see which row is now selected for them to delete again. Otherwise, deleting will have unexpected consequences	2021-09-28 09:29:55 -07:00
Seth Hillbrand	42a21e15f0	Check before dereference ... Fixes a crash where the screen was destroyed during new loading but still gets dereferenced by the UI update. Also puts defensive checks in the UI conditions against null configuration settings	2021-09-28 08:42:55 -07:00
Jeff Young	f73042fe24	Some minor performance enhancements.	2021-09-28 14:28:35 +01:00
Roberto Fernandez Bautista	7089a837f6	Update Editing Options Panel in eeschema with latest modifier keys ... We now use Long Click, Ctrl and Shift (Alt is no longer used) Fixes https://gitlab.com/kicad/code/kicad/-/issues/9234	2021-09-27 21:11:56 +01:00
Mike Williams	d90dc77e00	Selection: Don't drop small moves ... If we do a real drag, the timer will be cancelled. If we don't, then the user is still holding the mouse button down and would probably like to see the menu. Otherwise it appears the action is dropped.	2021-09-27 16:44:32 +00:00
jean-pierre charras	d362cbc530	EEschema: change Save Copy As... to Save Current Sheet Copy As... ... Save Copy As did not work with hierarchies (was not able to manage subsheets) Fixes #9245 https://gitlab.com/kicad/code/kicad/issues/9245	2021-09-27 18:23:11 +02:00
Jeff Young	c508c89a81	Pretty-up some warning messages.	2021-09-27 13:24:53 +01:00
Jeff Young	5f3c67bd2b	Fill in some missing GetMsgPanelItems and make some others consistent. ... Also expunges a std::vector<MSG_PANEL_ITEM> cover type.	2021-09-27 00:23:40 +01:00
Jeff Young	8636afdc73	Use FocusOnLocation for symbol fields cross-probing too.	2021-09-27 00:23:40 +01:00
Jeff Young	5bf042fcc1	Use individual parameter version of wxExecute. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9236	2021-09-26 15:03:06 +01:00
Jeff Young	f6571c18cb	Formatting.	2021-09-26 11:02:57 +01:00
Jeff Young	c9aebb8529	Fix symbol fields sorting. ... In the symbol fields table the reference contains only the letter, so the number must be appended. Conversely, we don't want the unit suffix as all units are folded into a single symbol. Fixes https://gitlab.com/kicad/code/kicad/issues/9238	2021-09-25 21:24:16 +01:00
jean-pierre charras	f11687c5e5	Do not allow sheet filename change from DIALOG_SCH_FIELD_PROPERTIES. ... It does not work. Changing a sheet filename is complex, and can be made only in sheet properties dialog.	2021-09-25 18:28:19 +02:00
Jeff Young	0dc585e518	Use different dangling state initialization for wires and graphic lines.	2021-09-25 00:34:51 +01:00
Jeff Young	1b8506c6b6	Default dangling state to true. A wire on it's own is dangling.	2021-09-24 20:59:37 +01:00
Jeff Young	7901d705ba	Fix optimization to not fetch all possible endpoints for non-connectable.	2021-09-24 20:08:42 +01:00
Jeff Young	fad385785d	Fix botched merge.	2021-09-24 20:08:29 +01:00
Jeff Young	a1a2076aee	Include pin roots for symbols that don't have well-defined bodies. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8508	2021-09-24 16:19:54 +01:00
Jeff Young	a4f83073e3	Use RTree to optimize searches. ... Should produce an order of magnitude speedup on dangling end tests in some documents.	2021-09-24 12:42:22 +01:00
Jeff Young	2d72ccb6ae	Simplify dangling end stuff a bit and remove graphic lines from it.	2021-09-24 12:19:27 +01:00
Marek Roszko	d39f79b55b	Fix schematic custom paper size check to use same limits as rest of eeschema ... Fix #9223	2021-09-24 00:46:02 -04:00
Jeff Young	42687f5d9d	Give selection preference to pins over wires. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9063	2021-09-23 23:59:20 +01:00
Jeff Young	9ea6b44ee8	Formatting.	2021-09-23 23:59:20 +01:00
Marek Roszko	064ab933dd	Always update the hierarchy navigator when setting the current sheet in the frame ... Fix #9221	2021-09-23 18:14:44 -04:00
Seth Hillbrand	71602475eb	Allow rotate/mirror even when dragging ... Keeps the lines connected but doesn't solve the crossed-wire mixups. This allows common usage (mirroring labels/rotating segments) and leaves prevention of the crossed wires to the user. We can't really prevent crossed wires when rotating e.g. a part with wires connected to 4 sides and users will not expect that. But we should not disable useful features like mirroring multiple parallel items to avoid a known impossible situation Also provides an alternative solution to 345f506f0c that allows us to rotate groups without destroying connections on hover Fixes https://gitlab.com/kicad/code/kicad/issues/8403 Fixes https://gitlab.com/kicad/code/kicad/issues/8523	2021-09-23 14:47:49 -07:00
Jeff Young	4b38bd1543	Favour junction dots to wires inside the dot. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9187	2021-09-23 22:13:56 +01:00
Jeff Young	552f053a55	Remove pins from symbol hit-testing. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8508	2021-09-23 22:07:51 +01:00
Seth Hillbrand	671aec5da6	In fallback selection, handle cancelled menu ... doSelectionMenu returns false to indicate a cancelled menu. This needs to be handled in selectPoint when directly accessing doSelectionMenu in the same manner as SelectionMenu() events Fixes https://gitlab.com/kicad/code/kicad/issues/9218	2021-09-23 11:48:29 -07:00
Seth Hillbrand	3b04b602d9	Don't walk text/labels when mirroring ... We have a fixed bottom-align for the text and labels in eeschema. Therefore, mirroring vertically needs to account for the text's offset from the bounding box center. Fixes https://gitlab.com/kicad/code/kicad/issues/9208	2021-09-22 09:24:16 -07:00
Jeff Young	ec2ac181a2	Further simplify selection logic. ... The select-single-wire stuff is no longer needed, and the prefer-wire-ends stuff needs to be distance-based. Also improved wire hit-testing to include bubbles the size of the dangling symbol at each end. Fixes https://gitlab.com/kicad/code/kicad/issues/9187	2021-09-21 20:27:35 +01:00
Jeff Young	2ec1c215cd	Drop selection after hiding items. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8605	2021-09-21 17:02:34 +01:00
Jeff Young	469d3ea329	Don't add global labels when a power symbol is connected. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7497	2021-09-20 21:31:19 +01:00
Jeff Young	ae8f817938	Use consistent label size and fix issues with rotation. ... Fixes https://gitlab.com/kicad/code/kicad/issues/5950	2021-09-20 21:31:19 +01:00
Jeff Young	40b4e5c024	Formatting.	2021-09-20 21:31:19 +01:00
Seth Hillbrand	c67d560538	Remove unused and shadowed variables	2021-09-20 11:45:27 -07:00
jean-pierre charras	fada53d90c	Fix SCH_SCREENS::HasNoFullyDefinedLibIds(): incorrectly returned true if no symbol found. ... Fixes #9195 https://gitlab.com/kicad/code/kicad/issues/9195	2021-09-20 18:29:26 +02:00
Jeff Young	6e7ce09572	Use more descriptive terminology for preferred text editor. ... Also improves execution to allow the preferred editor to include parameters, such as "/usr/bin/open -e". Fixes https://gitlab.com/kicad/code/kicad/issues/9131	2021-09-19 15:17:26 +01:00
Marek Roszko	e7814915db	Call UpdateHierarchyNavigator on find jump in schematic in case we cross pages ... Fix #8971	2021-09-19 08:35:51 -04:00
Jeff Young	0400c0a775	Prevent crash with RTree modification invalidating iterator.	2021-09-19 11:34:43 +01:00
Jeff Young	a5c4bace60	Improve (and simplify) wire and pin hit-testing. ... 1) Expand the accuracy to at least the grid spacing 2) Move pin-selects-symbol logic to Selectable() 3) Recode pick-closest algorithm to handle exactHits and inexactHits separately 4) Remove pin target from bounding box in favour of expanding it to at least as wide as the pin decoration (this prevents the accuracy off the end of the pin from growing too large)	2021-09-19 11:34:43 +01:00
Jeff Young	a291cae2fd	Make sure intersheetRef bounding boxes get updated in RTree. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9177	2021-09-18 18:32:19 +01:00
Jeff Young	4779850c10	Add done messages to various plotters. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9172	2021-09-18 10:39:57 +01:00
Jeff Young	4b3490a2b9	Intercept rotate command when drawing wires. ... If unfolding from bus rotate the label; otherwise beep. Fixes https://gitlab.com/kicad/code/kicad/issues/9178	2021-09-17 22:01:17 +01:00
Jeff Young	5c07441e24	Remove Setup Dialog assignment of netclasses to buses. ... Also removes the message bar display of assigned netclass for buses and bus-to-bus entries. Also fixes a bug where assigning a netclass via the canvas only looked at the first level of bus members (and not any nested members). Also fixes a bug where the bus name validator tried to validate a vector bus first -- which doesn't work as a vector bus may be nested in a group bus. Also fixes a bug where we were failing to check for illegal chars in bus definitions which otherwise passed the bus parsers. See additional comments in the bug report. Fixes https://gitlab.com/kicad/code/kicad/issues/9160	2021-09-17 22:01:17 +01:00
Jeff Young	d32ca5b287	Fix bus validation. ... Bus groups must be checked first as they can contain vectors inside them.	2021-09-17 22:01:17 +01:00
jean-pierre charras	ca33ec05df	Eeschema: fix incorrect rotation (CW versus CCW) of some items. ... For some (not all) items and for blocks the rotation CCW was in fact a CW rot. Fixes #9176 https://gitlab.com/kicad/code/kicad/issues/	2021-09-17 18:30:23 +02:00
Jeff Young	cc14dfe3ca	Make canvas netclass assignment mirror Setup Dialog assignment. ... While it would make more sense to have them both use the old canvas algorithm (of only assigning to the members), I'd be *very* hesitant to change the Setup Dialog and underlying machinery this late in the 6.0 release. Fixes https://gitlab.com/kicad/code/kicad/issues/9160	2021-09-17 14:40:12 +01:00
Jeff Young	d7bfd1eb77	Restore use of floating point precision in pin name/number placement. ... It's actually required here to get the shadows centred directly under the text.	2021-09-17 12:37:53 +01:00
Jeff Young	b10f337299	Don't auto-zoom when page settings were cancelled. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8978	2021-09-17 12:37:53 +01:00
Wayne Stambaugh	d90094de39	Fix progress dialog main frame focus issue on Linux. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8718	2021-09-16 15:53:18 -04:00
Jeff Young	2479e1d7b1	Improve common settings property grouping. ... Also moves apply-icon-scaling-to-fonts to its own checkbox. (We used to try to infer when to do it, but that turns out to be a rathole.)	2021-09-16 18:31:44 +01:00
jean-pierre charras	8aa7e8d9f4	Fix compil warning (shadowed vars)	2021-09-16 18:21:07 +02:00
Wayne Stambaugh	4663da4709	Eeschema: don't escape document file alias names in legacy plugin. ... Escaping the document file (.dcm) alias names breaks the link between the document file and the library (.lib) file. This causes the information in the document file to be lost. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9130	2021-09-16 09:09:44 -04:00
Jeff Young	684d15895c	Box highlighting of selected text was never finished. ... In particular, pin numbers and names weren't done.	2021-09-15 21:17:18 +01:00
Jeff Young	e2ce2e6ca9	Correct slight misalignment in Library Link fields.	2021-09-15 21:17:18 +01:00
Seth Hillbrand	ca6e43d1e1	Fix segfault when discarding changes on open ... When opening new schematic, the undo/redo list is invalidated. CleanupSchematic uses it before presenting the new schematic to the user, so we need to make sure that old data are not preserved here past their pointer lifetimes	2021-09-14 16:41:25 -07:00
Jeff Young	b84d1456d5	KIFACE_I -> KIFACE_BASE.	2021-09-14 23:45:14 +01:00
Jeff Young	3aae3c6f65	Dark mode for a bunch of HTML dialogs. ... WX_HTML_REPORT_BOX WX_HTML_REPORT_PANEL HTML_MESSAGEBOX DIALOG_DISPLAY_HTML_TEXT Fixes https://gitlab.com/kicad/code/kicad/issues/9157 Fixes https://gitlab.com/kicad/code/kicad/issues/9156	2021-09-14 21:23:57 +01:00
Jeff Young	3b121359ae	Fix a couple of escape-string issues. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9167	2021-09-14 18:30:19 +01:00
Seth Hillbrand	4b436fb86d	Narrow down collector ... RTree keeps track of position as well. We can use this to reduce the amount of time spent in the collector routine	2021-09-13 20:24:07 -07:00
Seth Hillbrand	1c409ff90a	Fix typo in previous commit	2021-09-13 20:23:52 -07:00
Seth Hillbrand	2fdd805eda	Override SCH_GLOBALLABEL::HitTest ... Global labels can optionally have intersheet references. When enabled, they expand the bounding box of the label. Because they can be far away from the actual label, the bounding box is not a good approximation for the hittest	2021-09-13 19:55:48 -07:00
Seth Hillbrand	484eaa01b9	Try harder to avoid loop contention ... We have two cases where we might be requesting a disambiguation menu. In one case, we already have the event loop waiting and we need to run the selectionMenu through the action system. In the other case, the tool isn't on the stack and won't activate. Here we need to run directly and we are assured of not crashing because the tool isn't active. Fixes https://gitlab.com/kicad/code/kicad/issues/9154	2021-09-13 10:17:04 -07:00
Jeff Young	fdfecf5932	Don't push view control settings to the previous active tool. ... See further comments in bug report. Fixes https://gitlab.com/kicad/code/kicad/issues/9147	2021-09-13 13:28:05 +01:00
Jeff Young	efc9279a19	Fix unfortunate line-break.	2021-09-13 13:28:05 +01:00
Jeff Young	52f99e41e6	Fix merge screw up.	2021-09-12 22:57:25 +01:00
Jon Evans	558ba855a2	Copy default hotkey for Clear Highlight from pcbnew to eeschema	2021-09-12 17:38:02 -04:00
Jon Evans	ed342d0cc0	Do not clear highlighting on a cancel event ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9035	2021-09-12 17:35:44 -04:00
Jeff Young	a5247471f7	Expunge a bunch more fixed font specs from wxFormBuilder files. ... Also removes the -1 sizing of the status bar on GTK and MSW. Fixes https://gitlab.com/kicad/code/kicad/issues/8608	2021-09-12 13:53:12 +01:00
Jeff Young	9c78e4cf54	Mac needs different font size handling than MSW & GTK. ... Mac already uses diverse font sizes (for instance, smaller fonts for radio button groups), and the anti-aliasing is a lot better. The other platforms need a more limited range of sizes. Fixes https://gitlab.com/kicad/code/kicad/issues/8608	2021-09-11 23:40:31 +01:00
Roberto Fernandez Bautista	625e56676a	Add progress reporting to CADSTAR Schematic & PCB importers ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8685	2021-09-11 17:50:19 +01:00
Jeff Young	fbee62fc15	Tie font size scaling to when automatic icon scaling fails. ... It appears that SetSymbolicSize() and ConvertDialogToPixes() fail under the same circumstances.	2021-09-11 15:29:51 +01:00
Jeff Young	c736bd3fd0	Patch Altium import of oddly constructed line segments. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8974	2021-09-11 15:29:51 +01:00
Jeff Young	09ddcdbbca	Fix logic error setting bold text. ... (Reported on Forum.)	2021-09-11 12:01:41 +01:00
Jeff Young	7a822b55aa	Another round of changes to attempt to fix the GTK font size issue. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8608	2021-09-10 15:59:50 +01:00
Seth Hillbrand	29c2f3b7d4	Prevent jumping into disambiguation if moved ... Moving points should not be overrided by disambiguation menu, so we track where the disambiguation event started and only trigger the menu if the mouse hasn't moved a full unit in x/y Fixes https://gitlab.com/kicad/code/kicad/issues/9132	2021-09-09 16:24:18 -07:00
Wayne Stambaugh	451f8eefc0	Eeschema: fix broken project symbol rescue bug. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/9111	2021-09-09 10:21:09 -04:00
Jeff Young	5325dce862	Naming consistency with DRC reports. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9121	2021-09-09 13:37:57 +01:00
Sylwester Kocjan	fe608bfcef	eeschema, sim: clean signal list when last panel is closed ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9119	2021-09-09 01:11:47 +00:00
Mikolaj Wielgus	1c9e10f34e	Disable simulator notebook splitting ... Using this feature freezes the simulator.	2021-09-09 01:07:23 +00:00
Sylwester Kocjan	f9c5c97f74	eeschema, sim: fix wrong names of the signals ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9062	2021-09-08 23:15:29 +02:00
Jeff Young	f013dbc7c4	More uniform handling of status fonts. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8608	2021-09-08 21:34:22 +01:00
Seth Hillbrand	c8b2e69332	Check if selection is primary tool ... Previously, we were checking if the selection tool was the top of the stack but this ignored many other "secondary" tools that might be running such as the point editor. These still allow the selection tool to handle events such as clicks. This change allows the selection tool to handle clicks when it is the primary tool on the stack rather than the top Fixes https://gitlab.com/kicad/code/kicad/issues/9110	2021-09-07 10:42:01 -07:00
Wayne Stambaugh	4ee0b28ffc	Coverity issue fixes. ... Fix Coverity issues 338623, 338716, and 338717.	2021-09-07 13:38:56 -04:00
Wayne Stambaugh	41c7089417	Minor dialog layout improvements.	2021-09-07 08:06:02 -04:00
Jeff Young	9cf7c7800b	Use same text positioning algorithm in LibEdit and Eeschema. ... Also fixes some uninitialized variables in PCB painter. Fixes https://gitlab.com/kicad/code/kicad/issues/8947	2021-09-07 12:33:06 +01:00
Jeff Young	ad7275f0a3	Repair saving of default line styles. ... Note that the file format version was NOT bumped because we were correctly reading the default, just no writing it. Fixes https://gitlab.com/kicad/code/kicad/issues/9045	2021-09-07 00:14:18 +01:00
Seth Hillbrand	0f38a35531	Be sure to stop the timer when triggering d-click ... Some mice apparently trigger double-click without triggering a click, so stop the timer when we receive this event Fixes https://gitlab.com/kicad/code/kicad/issues/9106	2021-09-06 12:27:31 -07:00
jean-pierre charras	c1130535fb	PCM: make DIALOG_MANAGE_REPOSITORIES_BASE resizable.	2021-09-06 08:36:06 +02:00
Seth Hillbrand	240c3b75c4	Move selection disambiguation to long-click ... This standardizes selection tools in SELECTION_TOOL class to be able to handle a long-click as asking for a non-heuristic disambiguation menu. Fixes https://gitlab.com/kicad/code/kicad/issues/8490	2021-09-05 13:42:51 -07:00
Jeff Young	c58562aebf	Sigh. Values in the LibEdit are LIB_IDs; in Eeschema they are not. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9098	2021-09-05 21:23:55 +01:00
jean-pierre charras	07f0662ba9	Fix some issues in dialog_netlist.cpp , round 2 (work in progress) ... The netlist plugins added in dialog_netlist are now stored in eeschema config.	2021-09-05 16:13:52 +02:00
Marek Roszko	74b8f14ec3	Don't find when the dialog isn't open or the search is blank (which resulted in full highlighting) ... Fix #9056	2021-09-04 23:48:06 -04:00
Jeff Young	6818539f6d	Repair is-selected logic in various global editors. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9090	2021-09-04 18:10:25 +01:00
jean-pierre charras	1fe4aaa64f	fix some issues in dialog_netlist.cpp (work in progress)	2021-09-03 20:38:29 +02:00
Roberto Fernandez Bautista	a06f3f1d14	Don't update text items until modified explicitly ... Ensures that any complex formatting in text items created by importers or pasted S-expressions is preserved.	2021-09-03 19:25:53 +01:00
jean-pierre charras	7e2abf545b	Eeschema: add python script netlist_form_OrcadPcb2.py and netlist_form_pads-pcb-asc.py ... to replace netlist_form_OrcadPcb2.xsl and netlist_form_pads-pcb.asc.xsl	2021-09-02 17:15:49 +02:00
Jeff Young	bc8245ca7b	Attempt to untangle junction dot preferences.	2021-09-02 12:41:16 +01:00
Jeff Young	243631a095	Fix logic error in polyline hittesting. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9030	2021-09-01 21:38:32 +01:00
Jeff Young	651981b2a0	Remove atrophied property from appsettings.	2021-09-01 21:20:07 +01:00
Roberto Fernandez Bautista	8268c4ad17	CADSTAR Schematic: Ensure library ID is valid ... Previously the library created was invalid - opening it resulted in a parsing error due to invalid characters in the name.	2021-09-01 20:25:39 +01:00
Roberto Fernandez Bautista	be9ff7a7d5	CADSTAR Schematic: Load text sizes for pin names/numbers and net labels	2021-09-01 20:25:39 +01:00
Roberto Fernandez Bautista	0aa37d1173	Fix issues with new overbar syntax ... - Update sch text help (~~ no longer gets converted to single ~) - Update Eagle importer to correctly handle new overbar syntax - Update CADSTAR importer to correctly handle new overbar syntax	2021-09-01 20:25:39 +01:00
jean-pierre charras	130958e48e	Eeschema: add python script netlist_form_cadstar.py to replace netlist_form_cadstar.xsl	2021-09-01 21:06:00 +02:00
Seth Hillbrand	8a305eec32	Remove broken RefDesStringCompare ... This function attempted a poor-man's natural compare but it assumed specific structure of the string. This broke for strings with numberings that looked like decimals. Instead, we use our natural string comparison function and remove the references to this older function and its similar elements. Fixes https://gitlab.com/kicad/code/kicad/issues/9067	2021-09-01 11:48:01 -07:00
Seth Hillbrand	bc0302fafe	Replace RefDesCmp with better StrNumCmp	2021-09-01 11:48:01 -07:00
Jeff Young	d92d9898ad	Scale junction dots from wirewidth, not linewidth. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9040	2021-09-01 19:44:18 +01:00
Seth Hillbrand	b0ba8b01c4	Update RTree when rotating components ... Fixes https://gitlab.com/kicad/code/kicad/issues/9061	2021-08-31 16:36:38 -07:00
Jeff Young	2cdd3c9ebf	Work-around incorrect spacing (and order) of buttons on Mac.	2021-08-31 22:39:25 +01:00
Seth Hillbrand	345f506f0c	Ignore STARTPOINT/ENDPOINT in multiple item rot ... Rotating multiple items does not allow for individual end points to be selected. This can happen when we narrowSelection by hovering on end points.	2021-08-31 14:34:05 -07:00
Roberto Fernandez Bautista	3e32c2e5a7	eeschema: Make pasted text left aligned so that it is editable ... Previously it was pasted as centre aligned, which is not supported in the GUI.	2021-08-31 20:02:20 +01:00
Jeff Young	b5a3385ea9	Overhaul file locking system. ... See bug report for details. Fixes https://gitlab.com/kicad/code/kicad/issues/8919	2021-08-31 15:04:31 +01:00
Jeff Young	21365fff3e	Disambiguate JunctionDiameter from EffectiveJunctionDiameter. ... ADDED Junction Size and Color to Edit Text & Graphics properties. The added feature is only because it's the only way to recover from the buggy behaviour having changed all your junctions to overridden values. Also adds help texts to the Junction Dot Properties dialog to specify how to get schematic dot sizes and eeschema colors. Also fixes the terminology in the Line/Wire/Bus Properties dialog (the default widths come from the netclasses, not from eeschema). Fixes https://gitlab.com/kicad/code/kicad/issues/9040	2021-08-31 12:18:02 +01:00
Sylwester Kocjan	ddba9e2351	eeschema: fix of not updating spice primitive field ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8835	2021-08-31 06:27:36 +00:00
Wayne Stambaugh	897269f33f	Eeschema: schematic object context menu improvements. ... Don't show the clean up sheet pins context menu entry when the selected sheet doesn't have any pins to clean up. Remove sheet has no pins to clean up nag dialog now that the context menu entry isn't shown unless there are pins to clean up.	2021-08-30 11:52:40 -04:00
Jeff Young	6c16846b21	Remove unused lambda.	2021-08-30 13:44:28 +01:00
Jeff Young	9da8f04cb4	Cleanup sheet pins doesn't make any sense when drawing sheets. ... Fixes https://gitlab.com/kicad/code/kicad/issues/9044	2021-08-30 13:11:37 +01:00
Roberto Fernandez Bautista	0cd8a4d846	CADSTAR Schematic: Load line thickness in symbols	2021-08-29 19:55:47 +01:00
Seth Hillbrand	871bdbc952	Search sheets in hierarchy-order ... Also fixes an issue where multiple sub-sheets were skipped in certain cases Fixes https://gitlab.com/kicad/code/kicad/issues/8972	2021-08-27 13:03:18 -07:00
Mike Williams	d18d993eac	Eeschema: find next key shouldn't launch find dialog ... Adds some general cleanups of overridden find functions while I'm in there. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8967	2021-08-27 18:15:36 +00:00
Mike Williams	0b2e66d3b7	Infobar: Don't use animations on Windows/GTK ... Seems to cause issues on Windows where the animation locks the screen. Doesn't effect Linux, possibly because wxWidgets uses a native GTK infobar that doesn't animate anyway. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8987	2021-08-27 17:38:16 +00:00
Jeff Young	69fac89e86	Fix some issues with incorrectly scaled defaults given in mils.	2021-08-25 20:04:06 +01:00
jean-pierre charras	a5560bb5f9	Eeschema, Add new symbol to schematics: update Value and Footprint texts ... to be currently displayed. Fixes #9025 https://gitlab.com/kicad/code/kicad/issues/9025	2021-08-25 15:13:40 +02:00
Seth Hillbrand	17a17586a6	Don't use REALPATH to find shared/dynamic libraries ... We require API compatibility in the ngspice library because we dynamically load the library and assign function pointers to specific names/signatures. This should be consistent for all versions of the the library until the soversion changes. Fixes https://gitlab.com/kicad/code/kicad/issues/8878	2021-08-24 11:44:56 -07:00
Jon Evans	0463fc4c2b	Fix several bugs and refactor schematic saving ... Having the logic split between three different paths was a bit much, this should hopefully be a bit easier to maintain. All save logic now goes through SaveProject; individual file writing is now a private function. Also change Save As to Save Copy As in project manager mode, as we don't want to change projects from inside the editor in project manager mode. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9015	2021-08-23 23:01:08 -04:00
jean-pierre charras	4ac2aa675a	lib symbols: make fp filter tolerant to spaces in names. ... For historical reasons they are stored in a string using spaces as separators. So each fp filter is now escaped to remove spaces (replaced by {space}) Fixes #9009 https://gitlab.com/kicad/code/kicad/issues/9009	2021-08-23 18:01:31 +02:00
jean-pierre charras	9f22baf109	netlist xml exporter: fix incorrect keyword change (field was changed to f) ... Keywords cannot be changed without a very good reason. the keyword is now field. Fixes #9016 https://gitlab.com/kicad/code/kicad/issues/9016	2021-08-23 17:14:45 +02:00
Jeff Young	3bddadc03d	Fix a typo in reference clearing. ... Also fixes an unrelated bug where all values/footprints were getting reset rather than just the instance versions. Fixes https://gitlab.com/kicad/code/kicad/issues/8891	2021-08-22 19:55:20 +01:00
Jeff Young	7561715ffe	Unescape symbol fields going out to XML netlist. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8995	2021-08-21 22:03:24 +01:00
Jon Evans	0814219513	Clean up some handling of project files in standalone ... Add control of project creation to Eeschema; change defaults to enable project creation in both programs. Properly set project on newly-created schematics so "Save As" doesn't get triggered repeatedly. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9000	2021-08-21 12:09:21 -04:00
Jon Evans	4da0c897bc	Fix flagging power pin in ERC check ... IsPowerConnection() is too restrictive a check Fixes https://gitlab.com/kicad/code/kicad/-/issues/8881	2021-08-21 11:19:09 -04:00
Mikolaj Wielgus	44ea3a75f2	Simulator: Use last workbook path stored in .kicad_pro as initial path in dialogs ... Previously this was done using a static variable, which was not loaded from .kicad_pro on simulator launch, causing unexpected behavior Fixes https://gitlab.com/kicad/code/kicad/issues/8799	2021-08-20 23:23:23 +00:00
Wayne Stambaugh	1d8fd22cd8	Symbol editor: fix message panel units when selecting from combo box. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8991	2021-08-20 15:45:57 -04:00
Sylwester Kocjan	eefac5cc59	eeschema: fix in populating DC sim settings tab ... When filling drop-down list with sources, previous selection should be saved in local variable and restored if it is still available.	2021-08-20 19:23:13 +00:00
Sylwester Kocjan	691b53d125	eeschema: add missing virtual destructors	2021-08-20 19:23:13 +00:00
Seth Hillbrand	bee3d78d78	Limit Eeschema find/replace entries ... Standardize maximum find/replace entries to 10 Fixes https://gitlab.com/kicad/code/kicad/issues/9007	2021-08-20 11:48:02 -07:00
Seth Hillbrand	75e4fa9b75	Handle multiple annotation in search ... New schematic format needs to search client screen paths instead of maintaining multiple copies in a flat format.	2021-08-20 10:24:08 -07:00
Seth Hillbrand	6470be11c3	Add clarifying comments to EE_RTREE ordering	2021-08-20 08:49:43 -07:00
Seth Hillbrand	729ba1e301	Ensure deterministic Find/Replace ordering ... Sorts first by x and then by y when returning search order Fixes https://gitlab.com/kicad/code/kicad/issues/8972	2021-08-20 08:42:06 -07:00
Seth Hillbrand	09be1a8c78	Ensure sheets are deterministically sorted ... Even if a sheet exists at the same x/y coordinate as another, the sort needs to ensure a deterministic ordering	2021-08-20 08:31:01 -07:00
jean-pierre charras	13083c80c2	Eeschema, dialog Find: do not force a position on screen when reopen dlg. ... The last position will be used. Fixes #8969 https://gitlab.com/kicad/code/kicad/issues/8969	2021-08-19 15:40:38 +02:00
Jeff Young	dfacac5eb6	Repair label incrementer to handle formatting constructs. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8992	2021-08-19 00:08:37 +01:00
Jeff Young	9549a227ad	Fix typo. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8993	2021-08-18 23:38:11 +01:00
Jeff Young	8879b887df	Fix missing overbar notation conversions in legacy library parsing. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8981	2021-08-18 22:48:29 +01:00
Wayne Stambaugh	46b959c3e3	Move plotter headers into include folder.	2021-08-18 16:38:31 -04:00
Wayne Stambaugh	6427197962	Remove duplicate headers in plot and associated code.	2021-08-17 15:41:25 -04:00
Jeff Young	fc4d748bdc	Fix bugs in sheets. ... 1) Default_line_width is in mils, not IU. 2) Plot sheet fields. Fixes https://gitlab.com/kicad/code/kicad/issues/8984	2021-08-17 13:21:52 +01:00
jean-pierre charras	8c9b0bdba4	Eeschema: plot missing sheet fields. ... Fixes #8984 https://gitlab.com/kicad/code/kicad/issues/8984	2021-08-17 13:30:23 +02:00
Jeff Young	dd24502255	Clean up (yes, yet again) the default pen width handling. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8980	2021-08-17 11:59:50 +01:00
Jeff Young	41619ebbe2	Decouple PROGRESS_REPORTER interface from implementations.	2021-08-14 21:05:49 +01:00
Jeff Young	1818846cff	Minor improvements to some error messages.	2021-08-14 12:11:47 +01:00
Stefan	bed51a5fc1	altium schematic importer, replace record 211 with compile masks	2021-08-14 11:05:56 +00:00
jean-pierre charras	08d7899f7e	Rework on hint to user when pin scope control has no effect or unexpected result. ... A info banner is now shown (in synchronized mode) to inform an user when extra pins are added to other units when a new pin is added. A good info about the synchronized mode is not easy to create.	2021-08-14 10:21:25 +02:00
Jon Evans	766b67a8f1	Tune selection of wire endpoints near other objects ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8941	2021-08-12 22:04:24 -04:00
Jon Evans	7075aece3a	Hint to user when pin scope control has no effect ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8907	2021-08-12 21:19:27 -04:00
Jeff Young	fbb3f4b58d	Escape names when migrating legacy libraries. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8951	2021-08-12 22:07:57 +01:00
Wayne Stambaugh	04c6b79350	Eeschema: remove unused and unnecessary code. ... When swapping SCH_SYMBOL objects during undo, no special processing is required. The SCH_PIN objects are updated when the LIB_SYMBOL objects are swapped and the call to SCH_SCREEN::SwapSymbolLinks() didn't do anything.	2021-08-11 14:30:29 -04:00
Jeff Young	c536a4c4f2	Work around annoying wxWidgets assert.	2021-08-10 16:51:30 +01:00
Jeff Young	6eb59b9d9e	Dialog naming conventions.	2021-08-06 20:54:26 +01:00
jean-pierre charras	76bdb423d7	Minor changes: minor code cleanup and fix minor Coverity warning	2021-08-04 16:47:41 +02:00
Jeff Young	48e0f68c7e	Improve ease-of-use of color preferences.	2021-08-04 13:55:42 +01:00
Jeff Young	95b87ba29a	Freshen microwave polygon dialog and remove a bunch of dead code.	2021-08-03 01:11:11 +01:00
david-beinder	c34f45f646	Split global label size expansion from TextOffset setting ... Global label expansion ratio default is now 37.5% Wire text offset default is now 15%	2021-08-02 16:40:36 +00:00
david-beinder	bab13debcb	Improve overbar rendering in PCB and global labels ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8584 Moves the font slightly down in global labels Keeps font with overbar at the same size in PCB OpenGL renderer	2021-08-02 16:40:36 +00:00
Jeff Young	c51b1dad72	Generalize infobar MESSAGE_TYPE handling and use for DRC errors. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8782	2021-08-01 21:51:39 +01:00
Jeff Young	d40712d9d6	Formatting and message consistency.	2021-08-01 21:31:23 +01:00
Jeff Young	6ab45d0a6d	Fix double-escaping in Eagle importer. ... This has actually been there since dot, but the old escaping method just deleted chars it didn't like so you could run it as many times as you wanted. Fixes https://gitlab.com/kicad/code/kicad/issues/8694	2021-07-31 20:07:25 +01:00
Seth Hillbrand	6cd4d68d57	Add drop shadows to MacOS icons ... Apple UI guidelines ask for small drop shadows on the icons. We add these using ImageMagick when resizing	2021-07-30 20:55:34 -07:00
Seth Hillbrand	e7d8b1a975	Resize MacOS icons and script their creation ... Creates a script that will fomat the MacOS icons at 80% of the total size in line with Apple's guidelines. Script requires Inkscape 1.0 and png2icns (available on Linux boxen) Fixes https://gitlab.com/kicad/code/kicad/issues/7977	2021-07-30 20:28:14 -07:00
Seth Hillbrand	ad8acd328c	Expunge some remaining references to kicad-pcb	2021-07-30 20:27:45 -07:00
Wayne Stambaugh	f485ba9338	Fix netlist error when editing schematic symbols in place. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8798	2021-07-30 18:37:45 -04:00
Seth Hillbrand	d5abbd0d14	Allow overwriting existing symbols ... This allows the workflow: 1) Edit symbol in schematic 2) Save As to original library Also allows the user to quickly overwrite a symbol they don't want, either by importing over the existing symbol or creating a new one.	2021-07-30 10:36:08 -07:00
Jeff Young	c716548b29	Enable autoplace whenever sel contains at least 1 field owner. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8886	2021-07-29 20:23:56 +01:00
Jeff Young	539d14ce94	Fix hang-over from legacy canvas where we only looked at sel head. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8886	2021-07-29 16:52:22 +01:00
Jeff Young	6aaf4413b3	Fix kicad_string.h / string.cpp mismatch. ... They don't define a KiCad string class, so the header file name was somewhat misleading. But the fact that they didn't match definitely made coding more difficult.	2021-07-29 16:03:25 +01:00
Jeff Young	f221220fe2	Rename layer ids file. ... It hasn't had anything to do with colors or visibility for some time now.	2021-07-29 16:03:25 +01:00
Mike Williams	934b6e4cdc	Eeschema: fix symbol library link not showing ... In wxWidgets GTK, SetLabel() won't show anything. Seems like an old wxWidgets issue: https://forums.wxwidgets.org/viewtopic.php?t=20207	2021-07-29 01:19:51 +00:00
Jeff Young	46338403e7	Unwrap some std::library typedefs.	2021-07-28 22:16:38 +01:00
Jeff Young	87e4a1c672	Remove cover type; capitalize class name; make filename equal classname.	2021-07-28 22:16:38 +01:00
Jeff Young	293f207356	Hopefully the last of the symbol id escaping issues. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8694	2021-07-28 19:44:42 +01:00
Wayne Stambaugh	f233f4a0a9	Expunge EDA_FILE_SELECTOR. ... EDA_FILE_SELECTOR was just an obfuscation of wxFileSelector().	2021-07-28 14:12:51 -04:00
Jeff Young	6d4c454e8c	Fix some more missing escaping for symbol ids. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8694	2021-07-28 18:37:09 +01:00
Jeff Young	726f4d8016	Fix up some more cases of missing escaping for symbol names. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8694	2021-07-28 16:40:38 +01:00
Jeff Young	19de38bbae	Avoid Mac-standard Cmd+H as well. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8864	2021-07-27 22:26:13 +01:00
Mike Williams	2c766bdb2b	Eeschema: fix assigning netclass to buses ... Buses with at least one member can use assign netclass functionality to set all members to that netclass. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8743	2021-07-27 20:48:25 +00:00
Jeff Young	dd5676f4bc	Implement a safer (RAII) tool re-entrancy guard. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8873	2021-07-27 16:37:34 +01:00
Wayne Stambaugh	37b200cb3e	Pass wxString objects by reference instead of on the stack.	2021-07-27 08:41:27 -04:00
Wayne Stambaugh	78e5e98ea0	Pass VECTOR2I objects by reference instead of on the stack.	2021-07-27 08:41:27 -04:00
jean-pierre charras	8ff76de18e	DIALOG_EDIT_ONE_FIELD: fix a non resizable widgets and fix a compil warning. ... Fixes #8877 https://gitlab.com/kicad/code/kicad/issues/8877	2021-07-27 14:12:46 +02:00
david-beinder	8467fe5405	Altium schematic import: text positioning and arc fixes ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8844 (power port text positioning, only use 0, 90deg for text) Adjust text justification due to rotation on import Set field position through SCH_FIELD::SetPosition Honor hidden net names at power ports Calculate start/end points for imported arcs in symbols	2021-07-26 19:49:56 +00:00
Wayne Stambaugh	8fd83cbb95	Pass wxPoint objects by reference instead of on the stack.	2021-07-26 15:35:33 -04:00
Mike Williams	924d4563b7	Symbol Editor: Don't unselect library based on non-existent symbol ... FIXED: Previously, when the symbol editor frame gains focus it will unselect the library tree selection unconditionally. This is annoying when adding a new library and then new symbol to a freshly-opened symbol editor with no other symbol being edited. Anything that gives the editor focus will deselect your library before you can add a symbol to it.	2021-07-25 21:37:08 +00:00
Mike Williams	36b2ff262d	Symbol Editor: Auto select newly added/created library ... CHANGED: When creating a new library, the usual intention is to add a new symbol to it. Without this, the "No symbol library selected." message will appear if the user attempts to add a new symbol without manually selecting their new library.	2021-07-25 21:37:08 +00:00
Mike Williams	13a03f77d3	Eeschema: Fix for delete key in wire tool ... Delete key was not working for items selected with wire tool active. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8841	2021-07-25 15:17:49 -04:00
Jeff Young	010247bb7f	Add overbar conversion to the legacy SCH reader. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8855	2021-07-25 13:11:30 +01:00
jean-pierre charras	1aadf45947	DIALOG_SHIM: fix not working initial size when creating a dialog. ... The first time a DIALOG_SHIM was created, with a given size, this size was not taken in account. This this is now forced. (when recreated during a session, this is the last dialog size that is used)	2021-07-24 18:59:28 +02:00
jean-pierre charras	dbf17f83ed	Minor fixes (DIALOG_DISPLAY_HTML_TEXT_BASE: ensure min size is working).	2021-07-24 17:03:36 +02:00
Jeff Young	531f5480a7	Reduce line-breaks and increase SNR.	2021-07-24 14:25:59 +01:00
jean-pierre charras	9820e89268	EE_INSPECTION_TOOL::CheckSymbol(): fix incorrect test about pins on grid. ... (the minimal grid was 25 internal units instead of 25 mils) Also the coordinates in messages are now printed in current user units.	2021-07-23 18:23:25 +02:00
Jeff Young	29eece7409	Move update-wires-if-driver-changed logic. ... This prevents RecalculateConnections from getting called twice before we run the logic. In that case the driver would change on the first recalc, and then it would look like it didn't change on the second (which is where we were checking). Fixes https://gitlab.com/kicad/code/kicad/issues/8812	2021-07-23 16:45:26 +01:00
Jeff Young	fa93c1ec65	Don't include hidden fields in bounding box. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8809	2021-07-22 13:56:09 +01:00
Wayne Stambaugh	1a301d8eea	Stop using wxDialog::EndModal() from inside dialogs. ... Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.	2021-07-21 17:38:14 -04:00
jean-pierre charras	bff0307ac0	Edit pin number: fix a crash when a pin is common to all units (i.e. having a unit id = 0) ... Fixes #8824 https://gitlab.com/kicad/code/kicad/issues/8824	2021-07-20 16:49:53 +02:00
luz paz	8bacc9fccb	Fix python 'testing for equality' syntax ... 'Testing whether an object is 'None' using the == operator is inefficient and potentially incorrect.' Per https://lgtm.com/projects/g/KiCad/kicad-source-mirror/?mode=tree&ruleFocus=7900090	2021-07-19 15:42:30 +00:00
Jeff Young	4317848cfe	Only title-caps "our" field names. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8803	2021-07-19 14:43:57 +01:00
Jeff Young	f5aefb7ad9	User pointer compare, not object compare.	2021-07-19 13:17:12 +01:00
Wayne Stambaugh	cb72da294a	More NULL expunging.	2021-07-16 16:13:41 -04:00
Seth Hillbrand	d1c9572bcc	Allow editing symbols when added to schematic ... We do not allow editing symbols in Legacy libraries, but once they are added to the schematic, they become editable	2021-07-16 12:08:57 -07:00
Marek Roszko	c794a6ce7a	Add pdb install option for msvc	2021-07-14 23:42:45 -04:00
Mikolaj Wielgus	395602b12a	Use Bind() instead of Connect() for simulator events ... Also fixed "Settings..." menu item not starting settings. I don't know why it's called `m_boardAdapter`.	2021-07-13 11:52:09 +00:00
Mikolaj Wielgus	c6a4f25538	Use wx events to update simulator title, start tools and menu items grayed out	2021-07-13 11:52:09 +00:00
Mikolaj Wielgus	3bafe6d6c9	Gray out unavailable simulator menu items, use wxUpdateUIEvent	2021-07-13 11:52:09 +00:00
Mikolaj Wielgus	4f2856b345	Gray out unavailable tools in simulator toolbar ... Cures some of the dialogitis plaguing the simulator.	2021-07-13 11:52:09 +00:00
Mikolaj Wielgus	4f384085e2	Remove m_simulator null-check -- most of code already assumes it exists	2021-07-13 11:52:09 +00:00
luz paz	0446d35f0d	Fix source comment/doc typos (follow-up) ... Found via `codespell -q 3 -S *.po,./thirdparty -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,dout,einstance,modul,ot,overide,serie,te,,tesselate,tesselator,tht`	2021-07-13 10:48:17 +00:00
jean-pierre charras	4df3ba6a56	DIALOG_SPICE_MODEL: expand env var to open lib file selection dialog in the previous selected lib	2021-07-12 19:40:03 +02:00
Jeff Young	0b4bb9378b	Use consistent terminology. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8777	2021-07-12 11:59:07 +01:00
jean-pierre charras	ad7e563e24	Do not translate something similar to a proper noun	2021-07-12 09:02:04 +02:00
Marek Roszko	759f0e9a75	Be sure to stop the timer during widget destruction ... Also fix a comment elsewhere :D Fixes #8772	2021-07-11 19:17:34 -04:00
Jeff Young	5bd30232e8	Remove nag preventing setting shape to default line width. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8774	2021-07-11 13:04:55 +01:00
Jeff Young	01d3a88faa	Allow unnamed embedded step files in altium boards. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7898	2021-07-10 16:37:45 +01:00
Jeff Young	2fc4ee5c5f	Upgrade "project is missing" to a warning.	2021-07-10 09:47:49 +01:00
Jeff Young	a06b95bb1f	Even out spacing around various panels.	2021-07-09 23:42:45 +01:00
Wayne Stambaugh	dffe2661e6	Fix SPICE simulator plot bug. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/1944	2021-07-09 16:20:35 -04:00
jean-pierre charras	928c4e8ed7	DIALOG_SPICE_MODEL: expand environment vars in spice library path.	2021-07-09 18:22:59 +02:00
jean-pierre charras	f55f9a522b	Netlist exporter spice: expand env vars when used in include library name.	2021-07-09 14:22:31 +02:00
Jeff Young	46701c1195	Don't allow undo record to get pushed during an undo. ... When doing a schematic cleanup, for instance, we were breaking wires and pushing undo records on to the stack. Needless to say, this was pretty unexpected for the rest of the undo framework and caused all kinds of mayhem (including crashes in some cases). Fixes https://gitlab.com/kicad/code/kicad/issues/8704	2021-07-08 19:43:15 +01:00
Jeff Young	a4263ebce5	Clean up Altium special string handling ... 1) Fix a couple of bugs in case processing 2) Make case processing more explicit to prevent more (1) 3) Move label processing to AltiumSpecialStringsToKiCadVariables 4) Strip double-quotes from special strings (and add test cases) 5) Change PROJECTNAME to just filename, not full path 6) PROJECTREV and REVISION are two different things 7) Add support for Altium's Application_BuildNumber 8) Fix some issues in trimming spaces around special strings	2021-07-08 15:34:38 +01:00
Wayne Stambaugh	65c7958293	Coverity issue fixes. ... Issues #331869, #331875, #332203, #332159, #332171, #332180, and #332648.	2021-07-08 08:33:08 -04:00
Mikolaj Wielgus	1c28ea0577	Do not create selection with simulator probe tool	2021-07-08 03:15:15 +00:00
Jeff Young	3f165c70e1	Import more Alitum parameters. ... ADDED CURRENT_DATE titleblock token (to go with existing ISSUE_DATE) ADDED PROJECTNAME schematic token (to go with FILENAME and SHEETNAME) Converts other parameters to project text variables.	2021-07-08 00:19:31 +01:00
Jeff Young	c1db5dc0b1	Make the variable replacement table a little easier to read. ... Yes, this probably violates all our formatting conventions EXCEPT the one that says code should be easy to read/visually parse.	2021-07-07 22:06:35 +01:00
Jeff Young	9351a88091	Variable references are case insensitive in Altium.	2021-07-07 22:04:00 +01:00
Jeff Young	d51ac65349	Don't try to resolve variables before the schematic is set up. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8746	2021-07-07 22:04:00 +01:00
Jeff Young	5a57f6ba98	Clear NEW flags after import. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8750	2021-07-07 20:05:50 +01:00
Jeff Young	66eb2ddeb5	Remove auto when not needed for line length.	2021-07-07 20:05:50 +01:00
Jeff Young	db91908c18	Add sheetpath instances when importing sheets from Altium.	2021-07-07 20:05:50 +01:00
Jeff Young	a81c6b21b6	Formatting.	2021-07-07 20:05:50 +01:00
Thomas Pointhuber	5e9a8e3488	altium: Improve handling of footprint references ... Don't assume the implementation list index is always correct by order.	2021-07-07 21:03:21 +02:00
Jeff Young	a17862d646	Import Altium harness labels as text. ... One day we'll do better, but at least this way the user knows there's something they need to migrate manually. Fixes https://gitlab.com/kicad/code/kicad/issues/8748	2021-07-07 17:54:22 +01:00
Jeff Young	5ab56e5320	More Altium importer error reporting cleanup. ... 1) Use REPORTER instead of wxLog 2) Use consistent, non-techy strings 3) Use consistent severity levels Fixes https://gitlab.com/kicad/code/kicad/issues/8747	2021-07-07 12:43:33 +01:00
Jeff Young	3b288b1b1b	Pull textframe processing out from under note and allow both. ... Note that there's still a bunch of stuff we don't support regarding textframes such as wordwrap and background colours, but this at least keeps the text from getting lost. Fixes https://gitlab.com/kicad/code/kicad/issues/8741	2021-07-06 20:27:28 +01:00
Jeff Young	190b0ecdeb	Formatting.	2021-07-06 20:27:28 +01:00
Wayne Stambaugh	9d348d7e6d	Coverity issue fixes.	2021-07-06 13:32:34 -04:00
Jeff Young	0be91c5b7d	Import Altium footprint references into symbols. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7751	2021-07-06 14:40:29 +01:00
Jeff Young	3288971a7c	Allow titleblock vars to be resolved outside the titleblock. ... Also implements some variable resolving for Altium imports.	2021-07-06 13:30:17 +01:00
Mikolaj Wielgus	43cce8b0b5	Remove automatic simulation start on simulator launch ... Fixes https://gitlab.com/kicad/code/kicad/issues/8644	2021-07-06 10:08:19 +00:00
Mikolaj Wielgus	6dfd655a7f	Save simulator checkbox settings in project file ... Fixes https://gitlab.com/kicad/code/kicad/issues/8450	2021-07-06 10:06:51 +00:00
Jeff Young	b0c07a28b3	Add importing of Altium notes. ... Import is incomplete because KiCad doesn't support text boxes yet (so we can't do borders, word-wrap, background fills, etc.). Fixes https://gitlab.com/kicad/code/kicad/issues/8734	2021-07-05 23:59:43 +01:00
Jeff Young	f6aaaff81a	Smarten regex to include overbar, superscript and subscript. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8730	2021-07-05 20:26:05 +01:00
Jeff Young	ea6769b702	The REPORTER interface is inherently line-based. ... Also fixes a bunch of error messages that were similar but not identical (which just increases translation burden). Fixes https://gitlab.com/kicad/code/kicad/issues/8723	2021-07-05 13:41:06 +01:00
Jeff Young	26df39e71a	Naming conventions.	2021-07-05 11:05:46 +01:00
Jeff Young	6c161eec68	Autodetect plugin type when editing filename cell. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8687	2021-07-04 18:21:16 +01:00
Mikolaj Wielgus	8b2b3ca797	Define .wbk in wildcards_and_files.{cpp,h}, cosmetic code changes	2021-07-04 14:04:03 +00:00
Mikolaj Wielgus	df2d4966b1	Do not set dirty bit on simulator launch, remove dead code	2021-07-04 14:04:03 +00:00
Mikolaj Wielgus	9f1ecdd715	Give Spice simulator "Save As" option Shift+Ctrl+S shortcut key	2021-07-04 14:04:03 +00:00
Mikolaj Wielgus	87441e256c	Escape CR and LF in Spice simulation command when saved	2021-07-04 14:04:03 +00:00
Mikolaj Wielgus	bd1f3d85f4	Spice sim: Have more detailed error messages	2021-07-04 14:04:03 +00:00
Mikolaj Wielgus	86c7db46b9	If there is no project name, default workbook name shall be "noname.wbk"	2021-07-04 14:04:03 +00:00
Mikolaj Wielgus	28531a982d	Simulator: Use SIM_WORKBOOK in place of wxAuiNotebook ... SIM_WORKBOOK is now a subclass of wxAuiNotebook, removing the problem of having to maintain two separate workbook states.	2021-07-04 14:04:03 +00:00
Mikolaj Wielgus	cd0c8a5676	Make panel sim command only accessible from outside through workbook object	2021-07-04 14:04:03 +00:00
Jeff Young	c11ee69499	Save 3D prefs after editing, and load some of them into FP Props. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8712	2021-07-04 13:20:55 +01:00
Jeff Young	aa5902bd99	Process Altium pin name and number hidden flags. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7853	2021-07-04 00:18:42 +01:00
david-beinder	a5308e5f5c	Fix python console toggle to work across pcbnew/eeschema	2021-07-03 22:48:46 +00:00
Jon Evans	fc96cb90f1	Fix validation of net names in eeschema ... The SCH_NETNAME_VALIDATOR wasn't even being used because C++ is great Fixes https://gitlab.com/kicad/code/kicad/-/issues/1821	2021-07-03 17:25:29 -04:00
Jeff Young	f46486bc3e	Naming conventions.	2021-07-03 21:43:57 +01:00
Jon Evans	3aab37bd2a	Fix determinism issue when comparing a local and hierarchical label ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8406	2021-07-03 16:43:00 -04:00
Jon Evans	8cbd754362	Preserve highlighted connection through a recalculation	2021-07-03 16:43:00 -04:00
Jeff Young	5507230b9b	Minor dialog spacing issue.	2021-07-03 15:24:54 +01:00
Wayne Stambaugh	3f6811f413	Minor dialog layout improvements.	2021-07-02 11:36:06 -04:00
jean-pierre charras	eedd32177e	Fix a minor compil warning	2021-07-02 16:11:26 +02:00
Marek Roszko	eff75b630f	Get rid of anonymous struct typedefs ... We are using C++14 where there is no reason for this and is banned in C++20 under P1766R1. MSVC generates a warning under C++14 as a reminder.	2021-07-01 18:28:41 -04:00
Jeff Young	d7271c9281	Unescape strings for display in symbol browser. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8694	2021-07-01 22:01:13 +01:00
Jeff Young	04764c9224	Allow dragging of fields in symbol aliases. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8698	2021-07-01 21:03:53 +01:00
Jeff Young	f8a34d98b3	Support for overbar syntax in Altium importer. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7979	2021-07-01 21:03:53 +01:00
Jeff Young	dacb5f58e8	Default bus entries to default (0 width and transparent color). ... Also adds some help text to the dialog so it's easier to figure out what's going on. Fixes https://gitlab.com/kicad/code/kicad/issues/8607	2021-07-01 15:43:19 +01:00
Jeff Young	24e54178db	Make sure pin hittest regions don't get too hard to hit. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8616	2021-07-01 15:43:19 +01:00
Jeff Young	201c34345f	Fix sheet filename if it's missing extension. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8619	2021-07-01 15:43:19 +01:00
Wayne Stambaugh	175b474c3e	Coverity issue fixes. ... Fixes issues #280412, #314755, #329615, #332459, #332157, #332167,	2021-06-30 18:08:49 -04:00
Jeff Young	00504368d6	Better label for fieldname filter, and single undo for all sheets. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8704	2021-06-30 18:45:18 +01:00
Jeff Young	6810912f09	Refuse to load schematics from the future. ... Also fixes a bug where an empty window would get left when loading a file from the KiCad manager window errored out. Also fixes a bug where we were getting the wrong exception because we were rethrowing the type-casted one (rather than just calling throw). Fixes https://gitlab.com/kicad/code/kicad/issues/8604	2021-06-30 18:32:07 +01:00
Jeff Young	e695c580fd	Resolve textvar cross-references even if the field doesn't exist. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8701	2021-06-30 13:12:57 +01:00
Jeff Young	2aa2493472	Resolve un-set template fieldnames to empty string. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8699	2021-06-30 13:12:57 +01:00
Jeff Young	5cac8afe1d	Remove long-dead revision support for LIB_IDs.	2021-06-30 13:12:57 +01:00
Jeff Young	b1b4caee6a	Escape "naughty" characters in symbol names. ... It's tempting to say that we don't need to exclude filename chars from symbols, but we might regret that decision down the road. Better to just escape them. Fixes https://gitlab.com/kicad/code/kicad/issues/8694	2021-06-30 13:12:57 +01:00
Jeff Young	c07367821e	Fix compile error, and use more robust method of setting fonts.	2021-06-29 19:36:06 +01:00
Jeff Young	0c2ac9a711	Move GUI font code to common. ... This also allows the Mac fixes for font facenames to be more compartmentalized. Fixes https://gitlab.com/kicad/code/kicad/issues/8657	2021-06-29 18:27:58 +01:00
Jeff Young	64f07ea9c6	Update text variables after changes. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8697	2021-06-29 13:55:06 +01:00
Jeff Young	6c67dfa032	Improve eeschema colour preview zoom-to-fit a bit.	2021-06-29 01:08:26 +01:00
Jeff Young	a1dfc36233	More error message regularization.	2021-06-29 01:08:26 +01:00
Jeff Young	e2a2c3282a	Update fields list when source or target lib IDs change. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8263	2021-06-28 20:38:19 +01:00
Jeff Young	d296bec5b8	Differentiate aSingleLine mode for SCINTILLA_TRICKS ... This allows us to avoid the monospaced font (along with the tab-stop handling), and process a <return> as an OK rather than just <shift> + <return>. Fixes https://gitlab.com/kicad/code/kicad/issues/8425	2021-06-28 11:20:12 +01:00
Jeff Young	062c4fda62	More error message regularization (and translatability improvements).	2021-06-28 00:45:24 +01:00
Jeff Young	4aa8318dc2	More error message regularization.	2021-06-27 14:24:02 +01:00
Jeff Young	0dfb5fcaf9	Error message cleanup. ... wxString::Format is redundant in a wxLogXXX call. Error messages should generally be translatable. Error messages should use generally consistent sentence forms.	2021-06-26 22:53:24 +01:00
Jeff Young	4c5df22eb0	Don't show busy cursor when dialogs (including progress) are in use. ... Also removes a stale comment. Also moves the progress reporters earlier to lessen need for busy cursor. Also cleans up some error strings and makes other more easily translatable.	2021-06-26 22:53:24 +01:00
Jeff Young	5c21f93803	Consistency in progress and error messages.	2021-06-26 13:23:43 +01:00
Jeff Young	173c9a974c	Formatting.	2021-06-25 20:49:38 +01:00
Jeff Young	27804e40e2	Go back to using space-width for tabs (instead of max-char-width). ... The max-char-width impl was buggy and never applied to PCBNew anyway. Plus the stroke font has a max-char-width of 2.8 time the space width, so it made for really wide tab spacing. Also fixes a bug where the Scintilla editors weren't getting a monospace font on Mac. (This bug may also exist on the other platforms, but each would need its own fix.) Also moves more of the Scintalla customizations to SCINTILLA_TRICKS where they can be shared. Fixes https://gitlab.com/kicad/code/kicad/issues/8666	2021-06-24 23:53:27 +01:00
Jeff Young	8502fd6877	Divide-by-zero safety.	2021-06-24 12:18:22 +01:00
Jeff Young	5fa5a73c6d	File open/import progress dialogs. ... Fixes https://gitlab.com/kicad/code/kicad/issues/6864 Fixes https://gitlab.com/kicad/code/kicad/issues/2166	2021-06-23 23:55:54 +01:00
Roberto Fernandez Bautista	466536d509	Make sure hierarchy is up to date before checking duplicate sheet names ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8654	2021-06-22 21:41:50 +01:00
RigoLigoRLC	a495a57602	Change syntax help for overbars to match syntax changes	2021-06-22 08:06:08 +00:00
Jeff Young	6d223931fb	Convert overbar syntax in bus aliases. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8647	2021-06-21 20:13:21 +01:00
PJM	15d36456a9	Eeschema: Save annotation starting value in project settings ... CHANGED: Added support for saving the starting value for annotation Fixes https://gitlab.com/kicad/code/kicad/issues/8364	2021-06-21 10:19:09 +00:00
Jeff Young	685ee31c35	Workaround a few more OSX printf problems. ... Also regularizes the frame title processing. Also fixes a type where the library name wasn't processed for variable expansion. Fixes https://gitlab.com/kicad/code/kicad/issues/7742	2021-06-20 22:48:19 +01:00
Jeff Young	b72545a432	Implement more aggressive re-entrancy blocking for drawing tools. ... A similar strategy was already implemented in Eeschema. Also adds some safety around clearing of autopan and mouse capture. Fixes https://gitlab.com/kicad/code/kicad/issues/6909	2021-06-20 11:09:55 +01:00
Mikolaj Wielgus	19f76ae77c	Convert pin names to new overbar format ... Fixes bug 6 of https://gitlab.com/kicad/code/kicad/issues/8591, thereby closing the issue: Fixes https://gitlab.com/kicad/code/kicad/issues/8591	2021-06-20 09:00:16 +00:00
Jakob Haufe	430b8358ab	Fix comment	2021-06-19 14:32:55 +00:00
Jeff Young	96e4b19444	Append Schematic Content -> Insert Schematic Content ... Fixes https://gitlab.com/kicad/code/kicad/issues/7905	2021-06-18 21:23:49 +01:00
Jeff Young	d811ae0aa3	Improved ASCII art.	2021-06-18 12:01:16 +01:00
jean-pierre charras	c35cceca62	fix compil warnings ( "multi-line comment" ) and missing override	2021-06-18 09:38:19 +02:00
Jeff Young	e540752640	Allow all selected footprints/symbols to be changed. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7389	2021-06-17 23:34:56 +01:00
Jeff Young	389287e942	A bit more Part -> Symbol.	2021-06-17 22:24:41 +01:00
Jeff Young	c0ad498c4a	Report all lib symbol issues. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7725	2021-06-17 22:24:41 +01:00
Jeff Young	bdeeace2ab	More Eagle importer fixes. ... 1) Don't process wires more than once when looking for bus entries. 2) Don't allow processing a wire to mess up iteration over the RTree.	2021-06-17 18:16:38 +01:00
Jeff Young	0484ca5564	Separate LIB_PIN and SCH_PIN GetShownName/Number processing. ... SCH_PIN wasn't handling the legacy empty string token (~), but more importantly this will allow text variable resolution specific to the schematic. Fixes https://gitlab.com/kicad/code/kicad/issues/8625	2021-06-17 10:52:46 +01:00
Jeff Young	b10f156dd0	Don't convert overbar syntax in most fields. ... You probably do want it in VALUE, but not REFERENCE, and certainly not FOOTPRINT or DATASHEET. User fields are more likely to be part numbers, etc. (and don't want conversion). Fixes https://gitlab.com/kicad/code/kicad/issues/8617	2021-06-17 00:05:17 +01:00
Jeff Young	1722bc03b0	Consistent terminology and punctuation.	2021-06-17 00:05:17 +01:00
Jeff Young	c23c5b7f18	Allow import of Eagle schematics without libraries.	2021-06-16 22:02:50 +01:00
Jeff Young	4b28bac89a	Fixes for Eagle importer. ... 1) Make sure we set an absolute path on the sheet. 2) Don't mix RTree iterators; wires get skipped between buses. 3) Implement a real ERC error so we don't assert. Fixes https://gitlab.com/kicad/code/kicad/issues/7042	2021-06-16 21:44:18 +01:00
Jeff Young	decfe89091	Refresh after import; don't wait for user to move mouse.	2021-06-16 21:44:18 +01:00
Seth Hillbrand	7953a5c62b	Work around MacOS printf/format issues ... MacOS wxWidgets implementation of wxPrintf/Format suffers from some issues when mixing string types. We avoid this by manually formatting the string ourselves. Fixes https://gitlab.com/kicad/code/kicad/issues/8404	2021-06-16 11:54:55 -07:00
Jon Evans	27932883d9	Pass configured Python interpreter in to use for BOM plugins ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8594	2021-06-15 22:52:16 -04:00
Jeff Young	21b869bd1f	Fix a few cases missed in the last merge. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7042	2021-06-16 00:01:28 +01:00
Jeff Young	3a84ee27fd	First take at repairing Eagle import of bus entries. ... Simplify logic by adding quadrant-based BUS_ENTRY ctor. Fix issue with bus entry size having been in mils rather than IU. Fix issues with logic. Fixes https://gitlab.com/kicad/code/kicad/issues/7042	2021-06-15 23:23:47 +01:00
Michal Schulz	a895dc15f9	eeschema label edit dialog replaces '\r' occurances with '\n'.	2021-06-15 14:59:04 +00:00
Wayne Stambaugh	ff099453c8	Rename class_library.[h|cpp] to symbol_library.[h|cpp].	2021-06-15 09:24:55 -04:00
Wayne Stambaugh	ee3eac325d	Expunge the use of the word part from Eeschema code.	2021-06-15 08:32:11 -04:00
Jeff Young	4418707e5e	Add a few more overbar syntax conversion calls. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8606	2021-06-15 13:09:18 +01:00
Wayne Stambaugh	fb46cd8bc5	Expunge the use of the word component from Eeschema code. ... The only exception to this is the SPICE simulator's use of component when referring to physical component (R, L, C, etc.) values.	2021-06-14 14:00:21 -04:00
Wayne Stambaugh	71c183d7bb	Rename LIB_PART to LIB_SYMBOL.	2021-06-14 07:11:17 -04:00
Jeff Young	3763aca52c	Use getLineWidth() when drawing bus entries. ... (Otherwise inheriting from the netclass or schematic doesn't work.) Also fixes precedence order in GetPenWidth() for the two BUS_ENTRY classes. Fixes https://gitlab.com/kicad/code/kicad/issues/8601	2021-06-13 20:52:03 +01:00
Jeff Young	a386d44134	Fix typo fetching stroke width. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8600	2021-06-13 20:31:53 +01:00
Jeff Young	a1a48a4c42	Don't allow rotation/mirroring while dragging. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8523	2021-06-13 20:22:25 +01:00
Jeff Young	d9cb5a3015	Make sure text gets rotated, not just position. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7964	2021-06-13 20:22:25 +01:00
Jeff Young	08d56f897c	Update Hierarchy Navigator after performing file actions. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8498	2021-06-13 17:15:43 +01:00
Jeff Young	bcdec0dea7	Move '~' pin name processing to LIB_PIN and SCH_PIN. ... This will also allow us to do variable processing in the future if desired.	2021-06-12 19:54:34 +01:00
Jeff Young	ceb23c3aac	Don't display legacy placeholder for empty string ("~").	2021-06-12 18:58:15 +01:00
jean-pierre charras	a297e8f202	Gerbview, export to pcbnew: use gr_circle instead of polygon for flashed round shapes	2021-06-12 09:26:36 +02:00
Mikolaj Wielgus	ade38f48bc	Add conversion from old `~...~` to new `~{...}` notation	2021-06-11 18:40:57 +00:00
Mikolaj Wielgus	3d520ebe1e	Replace `~...~` overbar syntax with `~{...}` ... Fixes https://gitlab.com/kicad/code/kicad/issues/8134 Fixes https://gitlab.com/kicad/code/kicad/issues/4227	2021-06-11 18:40:57 +00:00
Wayne Stambaugh	fbc135e69f	Rename SCH_COMPONENT to SCH_SYMBOL.	2021-06-10 10:34:49 -04:00
jean-pierre charras	1c3df973d6	Coverity warnings fixes.	2021-06-10 13:45:02 +02:00
luz paz	5f1e9bc8a7	Fix typos in source code	2021-06-10 01:24:15 +00:00
luz paz	f968fc8719	Fix source comment / documentation typos	2021-06-09 19:32:58 +00:00
Jeff Young	de95edb5ad	UI improvements for Manage Symbol Libraries. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8466	2021-06-09 19:20:51 +01:00
Wayne Stambaugh	2c19fbd752	Remove a few unnecessary headers.	2021-06-09 12:28:03 -04:00
Marek Roszko	d946d6e68f	Cleanup some pgm_base.h includes	2021-06-08 21:56:00 -04:00
Marek Roszko	6e01ce84b9	Break out eda_item_flags.h, fix the typedef to std::uint32_t, fix some signed vars	2021-06-08 19:12:30 -04:00
Marek Roszko	c854811ac4	Parent frame already includes undo_redo_container.h	2021-06-08 19:12:30 -04:00
Jeff Young	ed0e0a00c0	Clear selection before importing schematic. ... Also moves some error messages to use consistent terminology. Fixes https://gitlab.com/kicad/code/kicad/issues/8421	2021-06-08 16:08:22 +01:00
Wayne Stambaugh	9ebabb222c	Pass objects by reference instead of on the stack.	2021-06-08 10:09:38 -04:00
Marek Roszko	3a129a623a	Kick wx.h out of eeschema	2021-06-07 18:38:51 -04:00
Marek Roszko	8f2819cfa4	Kill the last of wx/wx.h in headers	2021-06-07 17:59:20 -04:00
Johannes Maibaum	022dd6072c	Add utility method to resolve symlinks ... The same logic block to resolve possible symlinks exists in 5 different places now. This change moves this duplicated code to a static member function of WX_FILENAME instead.	2021-06-07 20:59:59 +00:00
Johannes Maibaum	542c02046b	Write through symlinks for schematics and PCBs	2021-06-07 20:59:59 +00:00
Sylwester Kocjan	b0e6bbb39c	eeschema: remove m_simCommand from SIM_WORKBOOK	2021-06-07 20:00:48 +00:00
Sylwester Kocjan	917e329bdf	eeschema: remove TRACE_DESC from SIM_WORKBOOK	2021-06-07 20:00:48 +00:00
Jeff Young	3ff670d2a4	Disable ACTIONS::openPreferences for now. ... wxWidgets needs to move the item to the KiCad menu on Mac, and it can only find it if it has the id wxID_PREFERENCES.	2021-06-07 20:51:45 +01:00
Jeff Young	e91721cb62	Minor cleanup.	2021-06-07 20:51:45 +01:00
jean-pierre charras	6cfc2755ed	Remove a useless "#include wx/wx.h" from wx_html_report_panel.h	2021-06-07 09:26:13 +02:00
Marek Roszko	33bbf85a3e	Use the parent frame GetSettings helper rather than including for Pgm()	2021-06-06 19:05:12 -04:00
Jeff Young	f02d7ee593	Fix some (unexplained) issues with wxString::Printf on my build.	2021-06-06 19:01:23 +01:00
Ian McInerney	dc27079b71	cleanup tool event and tool action includes	2021-06-06 18:26:26 +01:00
Marek Roszko	fcb21038cb	Reduce some eda_item.h usage in headers	2021-06-06 11:09:06 -04:00
Marek Roszko	ad111a513d	Remove eda_itemf rom sch_view.h	2021-06-06 11:09:06 -04:00
Marek Roszko	c337f747b8	DIALOG_PIN_PROPERTIES does not need wx/msgdlg	2021-06-06 09:36:04 -04:00
Marek Roszko	fc3cea2cca	Remove wx/xml/xml.h from sch_eagle_plugin.h	2021-06-06 09:34:57 -04:00
Marek Roszko	7fa6e13c48	Remove xnode.h from netlist_exporter_xml.h	2021-06-06 09:32:36 -04:00
Jon Evans	c9a660a80c	Rework JSON integration to speed up build	2021-06-05 17:08:38 -04:00
Johannes Maibaum	06e967354f	Fix symlink read-/write-through code ... Use `realpath(3)` instead of `readlink(3)`, which offers support for relative and absolute symlinks alike, since all symbolic links will be resolved to the absolute path of the linked-to file. Fixes #8082	2021-06-05 14:22:50 +00:00
Jon Evans	9ffa2955b7	Fix drag of bus wire creating net wires	2021-06-03 22:29:04 -04:00
Marek Roszko	b1c9083743	Remove the wx/docview.h include	2021-06-03 18:42:08 -04:00
Marek Roszko	4e94b1fe86	Remove the universal sockets include	2021-06-03 17:59:46 -04:00
Wayne Stambaugh	7c14e4e967	Common widget header housekeeping.	2021-06-03 12:02:45 -04:00
Marek Roszko	4df3cb912d	Remove another leaky wx/log.h header	2021-06-03 08:11:15 -04:00
Marek Roszko	7faee5eda5	Stop salt the eart with wxhtml.h	2021-06-03 07:49:49 -04:00
Marek Roszko	b5b76eedf7	Avoid sharing gdicmn for just bitmaps	2021-06-03 01:46:04 -04:00
Ian McInerney	3ab69939f9	Remove wx.h from many files	2021-06-03 02:19:20 +01:00
Marek Roszko	af2707929d	Don't leak a wx header via eda_item.h ... Turns out this provided the translation header globally :D	2021-06-02 19:18:48 -04:00
jean-pierre charras	6919d12c70	Eeschema, Spice simulator: use Ctrl+letter as accelerator keys. ... Using only a letter can conflict with widgets accepting letters to enter data. Fixes #8537 https://gitlab.com/kicad/code/kicad/issues/8537	2021-06-02 19:45:30 +02:00
Ian McInerney	f03ca3259e	Remove unused Boost code/includes	2021-06-02 18:39:43 +01:00
Marek Roszko	eeb405c196	Cleanup some more excess math/util includes	2021-06-02 00:50:46 -04:00
Marek Roszko	5f581aa6ad	Move some LABEL_SPIN_STYLE to the cpp to add back warnings	2021-06-02 00:26:16 -04:00
Jon Evans	9effeb1fcb	Don't crash if an invalid bus connection is made ... Certain situations can trigger the stale cleanup being run on a bus that doesn't actually contain the stated member. In this case we should just keep calm and carry on -- who knows what netlist will be generated, but we shouldn't crash. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8530	2021-06-01 21:49:25 -04:00
Marek Roszko	cf2bb5692a	Remove the wxLog calls from math/util.h for now ... This was leaking windows headers and partial wx headers to 1084 compilation units...... This also means math/util.h is leaking to 1084 compilation units which seems a bit high too.	2021-06-01 18:44:22 -04:00
Seth Hillbrand	c7d188a8d0	Centralizing SCRIPTING class	2021-06-01 20:18:24 +00:00
Seth Hillbrand	f274a00c08	Remove PYTHON_* compile options	2021-06-01 20:18:24 +00:00
Mikolaj Wielgus	33c0bb78fd	Use file absolute path when determining title bar indicators ... Fixes https://gitlab.com/kicad/code/kicad/issues/8449	2021-06-01 17:03:20 +00:00
Giulio Girardi	cc5b3f1a2f	Always check simulator netlist options ... Before the simulation netlist checkboxes were considered only when changing the simulation type	2021-06-01 12:42:45 +00:00
jean-pierre charras	d84fcd89f1	bom html python scripts: enhancements	2021-05-31 18:54:36 +02:00
jean-pierre charras	54fbcbac36	BOM python plugins: restrict changes made in commit 35f9cd26 to Windows.	2021-05-31 17:06:23 +02:00
Jeff Young	c4cabb38d5	More worksheet -> drawing sheet cleanup. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8516	2021-05-31 12:26:44 +01:00
Jeff Young	0598c82972	Terminology (use present tense for flags).	2021-05-31 12:26:44 +01:00
Jeff Young	1be2c8cc40	More trouble with the IS_MOVED flag. ... We moved it earlier because AddItemToScreenAndUndoList() was clearing it, but it needs to be set for AddItemToScreenAndUndoList() too. Fixes https://gitlab.com/kicad/code/kicad/issues/8289	2021-05-31 12:26:44 +01:00
jean-pierre charras	35f9cd2634	BOM python plugins: fix some issues related to python2/3 and utf-8 chars.	2021-05-31 10:03:53 +02:00
Marek Roszko	1b94534451	Revert "Use lambdas to fix paste conditions" ... This reverts commit 65c7c77c3d.	2021-05-30 21:25:42 -04:00
Marek Roszko	3ac5aa5369	enum class SHEET_SIDE	2021-05-30 21:23:46 -04:00
Marek Roszko	65c7c77c3d	Use lambdas to fix paste conditions ... `SELECTION_CONDITIONS::Idle && ` was evaluating as always true because this was referencing the function pointer	2021-05-30 20:37:16 -04:00
Marek Roszko	382dca4e6f	Fix uninitialized member warnings ... Based on PVS Studio report	2021-05-30 20:01:01 -04:00
jean-pierre charras	a60183ec32	netlist xml: fix missing space between UUIDs for multi-units symbols (trial 2). ... Fixes #8509 https://gitlab.com/kicad/code/kicad/issues/8509	2021-05-30 11:23:14 +02:00
jean-pierre charras	71f40bd67c	Revert a change made in commit acb024f6, because it breaks the .net netlist format.	2021-05-30 08:37:13 +02:00
jean-pierre charras	acb024f622	netlist exporter xml: fix missing space between UUIDs for multi-units symbols. ... (similar to the .net netlist) kicad_netlist_reader.py: fix compatibility with V6 xml netlist : "tstamp" keyword is now "tstamps" keyword. Fixes #8509 https://gitlab.com/kicad/code/kicad/issues/8509	2021-05-29 18:29:02 +02:00
jean-pierre charras	81c7fb61f8	Sub-menu "Preferences..." in main menu "Preferences": fix not working accelerator key. ... Accelerator keys are disable in our WX_MENUBAR. A common ACTION_MENU is used and "Preferences..." is now shown in Hotkeys list.	2021-05-29 18:09:49 +02:00
jean-pierre charras	37c31196f4	Eeschema, importFile: build the HTML report messages before displaying the dialog. ... Fixes #8507 https://gitlab.com/kicad/code/kicad/issues/8507	2021-05-29 10:23:11 +02:00
Seth Hillbrand	be5b281501	Cleanup RAD2DEG and unused vars	2021-05-28 12:37:57 -07:00
Seth Hillbrand	f47784cd14	Fixup Junctions should call common tool	2021-05-28 12:35:38 -07:00
Roberto Fernandez Bautista	3fa8795f26	Fix crash in LIBEDIT when editing pins ... Units in library items start at 1. 0 is reserved for "all units". Previous code was requesting an out of range index due to an assumption that units start at 0.	2021-05-28 20:13:11 +01:00
Roberto Fernandez Bautista	9a9c9d38e8	CADSTAR Schematic: Cleanup pins in symbols ... In CADSTAR pins are single points. We can replicate the original look of the schematic in most cases by searching the symbol for straight segments that are coincident with the pin and use those to calculate a suitable pin length and angle.	2021-05-28 20:13:11 +01:00
Roberto Fernandez Bautista	29d1b84939	CADSTAR Schematic: Fix positioning of symbol attributes ... Symbol attributes were being placed at the wrong location due to incorrect relative angle calculation	2021-05-28 20:13:10 +01:00
Roberto Fernandez Bautista	8d788b7a09	CADSTAR Schematic: Fix assert regarding sheet absolute path	2021-05-28 20:13:10 +01:00
Roberto Fernandez Bautista	63f56640db	CADSTAR Schematic: Add needed junctions on load ... Fixes a bug that was causing junctions to disappear when they were not perfectly positioned in the original CADSTAR design.	2021-05-28 20:13:10 +01:00
Roberto Fernandez Bautista	b985c4d2e9	CADSTAR Schematic: Handle scaled symbols ... Create a new LIB_PART for scaled symbols. These will be then embedded into the schematic file. However when "update from library" is done, it will revert to the unscaled symbol. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8494	2021-05-28 20:13:10 +01:00
Seth Hillbrand	752ae4d519	Rename modification flag routines ... Differentiates better between the EDA_ITEM IsModified(), referring to items themselves changing and the EDA_SCREEN IsContentModified(), referring to whether we have made any unsaved changes.	2021-05-28 12:07:04 -07:00
Seth Hillbrand	d7f219e98f	Unify IsSave and IsModify ... The flags and calls were used identically, leading to potential confusion/bugs. Testing for modification should go through IsContentModified()	2021-05-28 11:51:54 -07:00
jean-pierre charras	40b96c8388	Netlisters: do not remove unconnected pins from netlists needing all pins. ... Fixes #8499 https://gitlab.com/kicad/code/kicad/issues/8499	2021-05-28 10:09:33 +02:00
Wayne Stambaugh	fdcc49d3ee	Eeschema: fix saving hierarchical sheets in stand alone mode. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8209	2021-05-27 16:01:36 -04:00
Wayne Stambaugh	9fcd847238	Eeschema: allow sheet file paths outside the project to be relative.	2021-05-27 14:48:22 -04:00
jean-pierre charras	bd72f7a054	DIALOG_PIN_PROPERTIES: shows the pin connect point, like in symbol editor. ... (See commit 2817c)	2021-05-27 20:45:45 +02:00
Wayne Stambaugh	b1572dd56b	Eeschema: fix broken sheet paths when adding existing schematic. ... All existing sheet schematic file paths were completely trashed when adding a new sheet from an existing file outside of the project path.	2021-05-27 14:04:56 -04:00
Jeff Young	2817c3b3de	Always show pin dangling symbols in Symbol Editor. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8493	2021-05-27 17:50:21 +01:00
Jeff Young	42eae27551	Rebuild selection after heavy lifting. ... Undo does some fairly major redraws (including setting the current screen), all of which drop the selection and cancel interactive tools. Make sure the selection is re-built *after* all those run. Fixes https://gitlab.com/kicad/code/kicad/issues/8492	2021-05-27 14:25:37 +01:00
david-beinder	64cd401bdb	Delete Tool: Fix missing "Item Locked" popup ... Fixes problem identified in https://gitlab.com/kicad/code/kicad/-/issues/8392 Removes same popup from schematic tool because SCH_ITEM can not be locked	2021-05-27 05:38:51 +00:00
Wayne Stambaugh	71b3ab432c	Eeschema: fix broken sheet name edit control validator.	2021-05-26 15:26:48 -04:00
Jeff Young	3d0fe8e2c6	Only initialize VALIDATOR if we're using it. ... It appears to get called by the wxWidgets framework sometimes even when invisible/unenabled. Fixes https://gitlab.com/kicad/code/kicad/issues/8483	2021-05-26 12:39:33 +01:00
Wayne Stambaugh	db900fe526	Eeschema: fix broken schematic edit control validators. ... Sheet file names can have ':', '\', and '/' characters depending on the platform so don't exclude them. Warn the user when any platform specific paths are used about the platform capability issues rather than outright prevent them from being used which prevents absolute paths from being used even when they are desired by the user. Fix broken validator behavior when excluded characters are not white space characters only.	2021-05-25 14:10:29 -04:00
Jeff Young	45ba067642	Update SCH_SCREENs RTree after placing new symbol. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8451	2021-05-25 15:10:10 +01:00
Roberto Fernandez Bautista	be436ec977	Remove whitespace from page numbers on load and use # if page is empty ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8350	2021-05-21 22:52:47 +01:00
Roberto Fernandez Bautista	6b764f893a	Assign a page number to all sheet instances when adding a sheet ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8208	2021-05-21 22:52:40 +01:00
Roberto Fernandez Bautista	5cf3e6d31a	eeschema: Duplicate() is a Copy() followed by a Paste() ... The only subtle difference is that Duplicate() does not modify the clipboard contents so we need to keep a local variable in which to store the result of a Copy()	2021-05-21 22:52:34 +01:00
Giulio Girardi	78a475d75b	Enable "Spice settings" button on derived symbols	2021-05-20 14:53:23 +00:00
Wayne Stambaugh	11785b08fe	Eeschema: fix plot path in stand alone mode with no project loaded. ... Fixes https://gitlab.com/kicad/code/kicad/8308	2021-05-18 13:59:27 -04:00
Wayne Stambaugh	57d4347f00	Eeschema: move schematic plot dialog code into dialog_plog_schematic.cpp. ... This makes it easier to find all of the dialog code, has less files to compile, and makes it easier to see the redundant code that could be refactored.	2021-05-17 17:00:30 -04:00
jean-pierre charras	cda9650380	Eeschema: ensure the actual canvas type is saved in config. ... The saved type was not updated after switching the canvas type from Preferences.	2021-05-17 11:48:37 +02:00
Mikolaj Wielgus	33c6bdd121	Preserve plot panel order in simulator notebook	2021-05-15 12:26:50 +00:00
Mikolaj Wielgus	afc6d29fde	Fix relative path used where absolute path should be	2021-05-15 12:26:50 +00:00
Mikolaj Wielgus	b9fd18d150	Minor UI changes, display workbook in title and some fixes	2021-05-15 12:26:50 +00:00
Mikolaj Wielgus	5410510bd4	Spice sim: remember last simulation, remove welcome page ... Fixes https://gitlab.com/kicad/code/kicad/issues/8019	2021-05-15 12:26:50 +00:00
Wayne Stambaugh	ebd53cd45c	Eeschema: fix text justification terminology. ... Use justification instead of orientation relative to the anchor point when describing text direction and alignment. This seems to be the preferred method by most users so hopefully this will eliminate some confusion. Fix a bug in the s-expression schematic parser that failed to take into account how graphical text alignment is defined for graphic text objects compared to label text objects. Fixes https://gitlab.com/kicad/code/kicad/issues/6489	2021-05-14 13:44:17 -04:00
Wayne Stambaugh	e4ac0fb5a1	Eeschema: fix minor editing options panel lay out issues.	2021-05-12 18:04:23 -04:00
jean-pierre charras	64afa3a42e	EEschema, minor fix: avoid modifying frame title after an autosave. ... Fixes #8411 https://gitlab.com/kicad/code/kicad/issues/8411	2021-05-12 09:45:23 +02:00
Jeff Young	2a856890e6	Allow connections between sheet (pins) and symbols. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8305	2021-05-12 00:07:17 +01:00
Jon Evans	55c1d814f9	Fix hierarchical propagation for designs with unmatched hier ports ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8397	2021-05-10 17:54:09 -04:00
Jeff Young	7356f9568d	Move grid disable modifier from ALT to CTRL. ... Also had to move the H/V/45 disable modifier from CTRL to SHIFT. Fixes https://gitlab.com/kicad/code/kicad/issues/8124	2021-05-09 20:17:40 +01:00
Jeff Young	7c66a0a594	Selection routines should never be snapped.	2021-05-09 18:14:41 +01:00
Jeff Young	f03152a548	Add some more tools to the "don't allow tool loop interruption" set. ... See also b78ba12739. Fixes https://gitlab.com/kicad/code/kicad/issues/8071	2021-05-09 17:30:32 +01:00
Jeff Young	693fbf9073	Ask user before overwriting a file when migrating symbol libs. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8299	2021-05-08 23:09:51 +01:00
Jeff Young	b78ba12739	Don't allow activation of other tools in the middle of a move. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8116	2021-05-08 20:49:51 +01:00
Wayne Stambaugh	6e017b475d	Warn user before removing invalid rows from library table entries. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8080	2021-05-08 08:58:54 -04:00
david-beinder	063f26531c	Make LIB_PART::GetPins() return data for derived symbols ... https://gitlab.com/kicad/code/kicad/-/issues/8212	2021-05-06 22:00:06 +00:00
Ian McInerney	5378cacee3	Don't make a copy when looping	2021-05-06 21:56:21 +01:00
Wayne Stambaugh	5da8e700ce	Eeschema: fix BOM path bug in stand alone mode. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8180	2021-05-06 15:42:38 -04:00
Wayne Stambaugh	68085820ff	Eeschema: fix value and footprint field update bug. ... Don't assume all identical references should have the same value. Filter by checking that only symbol units having the same reference also have the same library identifier before updating the value and footprint fields. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8313	2021-05-06 07:13:26 -04:00
Jeff Young	2e3860de6f	Naming conventions.	2021-05-05 22:58:40 +01:00
jean-pierre charras	d4e5861c62	Fix a few issue in simulation (noticeable only when the calculation time is high): ... - Wait for end of simulation before return from "C" locale to current locale (to avoid data files created by ngspice using curr locale instead of "C" locale) - Do not allow changing signal list to plot during simulation calculation (avoid crashes)	2021-05-05 20:28:46 +02:00
Seth Hillbrand	61289ab39a	Cleanup ngspice calling signatures	2021-05-05 10:49:40 -07:00
Seth Hillbrand	36975c9cd0	Conditionally handle the SPICE signatures ... ngspice updated their function signatures, requiring us to test. They also don't provide an indicator that the signature is changed, so we need to test based on the existence of a new version define. Fixes https://gitlab.com/kicad/code/kicad/issues/8358	2021-05-05 10:19:01 -07:00
Jonatan Liljedahl	a8672dd2f9	Simulator: populate DC sources list.	2021-05-04 22:54:42 +02:00
Jonatan Liljedahl	d46e106564	Simulator: Fix sim settings layout for DC sweep page. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8261	2021-05-04 15:14:10 +00:00
Fabien Corona	065f85b504	check on exit	2021-05-04 13:57:45 +00:00
Fabien Corona	0555da2aaa	Eeschema page: if empty, don't check export	2021-05-04 13:57:45 +00:00
Wayne Stambaugh	16bb45208a	Fix save accelerator key handling when library tree has focus. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8247	2021-05-03 19:41:07 -04:00
Marek Roszko	c7345096f8	Use wxFFileInputStream explicitly when loading xml documents ... wxFFile (FILE, buffered) is better than wxFile (syscalls)	2021-05-03 19:39:56 -04:00
Marek Roszko	8c2f07be2a	Write xml netlists explicitly via wxFFileOutputStream for performance ... Fix #6944	2021-05-03 19:10:21 -04:00
Wayne Stambaugh	d2a7f81b10	Debugging improvements and clean up. ... * Remove unused wxLogDebug calls. * Add add application level character tracing to detect unhandled key events. * Catch unhandled exceptions in KiCad main event loop like single top applications.	2021-05-03 18:08:15 -04:00
Roberto Fernandez Bautista	f2677340f2	Access the new paste behaviour via a new Paste Special... dialog ... ADDED Paste Special... action in pcbnew CHANGED Additional options for Paste Special... in eeschema, including "Assign unique reference designators to pasted instance"	2021-05-03 19:38:32 +01:00
Roberto Fernandez Bautista	98c8f43320	eeschema and pcbnew paste: consistent paste behaviour ... Duplicates are reannotated on paste in the same way in pcbnew and eeschema such that when copying and pasting the same block in the pcb and schematic, the reference designators will match.	2021-05-03 19:38:32 +01:00
Roberto Fernandez Bautista	cf2dc06add	Fix latent bugs in SCHEMATIC and SCH_SEXPR_PLUGIN ... Noticed after writing the qa test: when loading a file immediately after having loaded a previous one, it was resulting in a nullptr exception.	2021-05-03 19:38:31 +01:00
Roberto Fernandez Bautista	ae009e0758	Ensure clipboard data is available after KiCad closes ... Always Flush() after SetData()	2021-05-03 19:38:31 +01:00
Roberto Fernandez Bautista	5822cd85c4	Fix eeschema copy/paste: save and load sheet and symbol instances ... Save sheet and symbol instance information to the clipboard on copy Load sheet and symbol instance information from the clipboard on paste and renumber page numbers after loading. Correctly handle pasting in a multiple hierarchy by ensuring symbol and sheet instances are updated for all instances of the destination sheet. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8207	2021-05-03 19:38:31 +01:00
Roberto Fernandez Bautista	91fd28c4be	Refactor saving sheet and symbol instances in SCH_SEXPR_PLUGIN::Format ... Avoid code duplication by moving all common code to a new function SCH_SEXPR_PLUGIN::saveInstances Also fixes a bug that was resulting in footprint and value information not being saved for subsheets that were root sheets in a different project.	2021-05-03 16:54:42 +01:00
Roberto Fernandez Bautista	2c75911669	Fix SortByPageNumbers: use Sheet Name when page numbers are equal	2021-05-03 16:54:42 +01:00
jean-pierre charras	aee1593678	Fix wxWidgets alerts ... Fixes #8346 https://gitlab.com/kicad/code/kicad/issues/8346	2021-05-02 16:02:33 +02:00
Jeff Young	c30102cd4f	Don't crash when trying to save sim settings during shutdown. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8327	2021-05-01 21:49:40 +01:00
Marek Roszko	9dc611f704	Delay loading eeschema "project settings" to after the ui is ready	2021-05-01 16:13:48 -04:00
Marek Roszko	d4bb1cbc63	Make drawing sheet loading slightly smarter	2021-05-01 14:11:31 -04:00
jean-pierre charras	f6f2284851	Fix missing includes on Linux after commit 0427bda7	2021-05-01 20:05:01 +02:00
jean-pierre charras	0427bda768	Remove useless wx/wx.h include, that create sometimes compil warnings on msys. ... wx/wx.h includes all wxWidgets .h files, and sometimes creates collision names in #define between kicad and windows headers Moreover, blindly including a lot of useless files is compil time consuming	2021-05-01 19:32:15 +02:00
Marek Roszko	18ff8ea4a0	Try to catch memory allocation errors in pcbnew and eeschema	2021-05-01 13:11:10 -04:00
Marek Roszko	e20562b09b	Some cleanup	2021-05-01 10:37:20 -04:00
Marek Roszko	6e9f833739	Disable two prof_counters if not ifdefed	2021-05-01 10:08:21 -04:00
Jeff Young	1ed54d2314	Make sure find/replace respects different values in the hierarchy. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8328	2021-04-30 18:39:21 +01:00
Roberto Fernandez Bautista	9b35757e18	Refactor AppendSymbol and AppendMultiUnitSymbol	2021-04-30 11:03:21 +00:00
Roberto Fernandez Bautista	0f85f61e5f	CHANGED: Reannotation in eeschema now always keeps symbol units ... Ensures that symbol units are never modified after re-annotation.	2021-04-30 11:03:21 +00:00
Roberto Fernandez Bautista	0c91bea751	Fix eeschema reannotation: ensure no duplicate references are created ... Also implements reannotation of a selection ADDED: Ability to reannotate a selection in eeschema Fixes https://gitlab.com/kicad/code/kicad/-/issues/2209	2021-04-30 11:03:21 +00:00
Jeff Young	50fd94d35d	Remove stale comment. (Thanks Jonathan!)	2021-04-26 20:01:30 +01:00
Jeff Young	e06a3cf3b4	Add Annotate Selection in prep for Roberto's fixes.	2021-04-26 17:33:49 +01:00
Jeff Young	de2f60fe4c	Save annotation settings in preferences. ... See comments in issue. Fixes https://gitlab.com/kicad/code/kicad/issues/8277	2021-04-26 16:05:22 +01:00
Marek Roszko	8a8475630e	Check wxHAS_NATIVE_TABART before using the simple tab art	2021-04-22 22:24:55 -04:00
Seth Hillbrand	d934dae21a	null check for non-schematic symbol ... Fixes https://gitlab.com/kicad/code/kicad/issues/8279	2021-04-22 17:53:45 -07:00
Seth Hillbrand	2c2ac39990	Replace default aui art provide in sim ... The default art provider was a gradient tab. This does not match the system elsewhere and is particularly bad for dark themes. The simple art provide matches the background colors correctly. Although the tab background is still white, this is quite a bit better than before. Fixes https://gitlab.com/kicad/code/kicad/issues/8280	2021-04-22 17:35:54 -07:00
Ian McInerney	ecd9bf696e	Be consistent about using nullptr instead of 0 ... 0 can be too easily overloaded into an int, so ensure we use nullptr when we mean pointers.	2021-04-22 22:20:34 +01:00
Wayne Stambaugh	54e18f6b1f	Pcbnew: remove update schematic option for geographical annotation dialog. ... REMOVED: Update schematic option from geographical annotation dialog due to potential issues with incomplete and/or broken updates. Use "Update Schematic from PCB" tool to update reference designation changes. Forcing the footprint reference designator changes back to the schematic without checking any other board changes in the schematic could leave the schematic in a undefined state. The update schematic from board tool is the correct method to sync any changes from the board. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8042	2021-04-22 12:45:59 -04:00
Jeff Young	ecb2e0e031	Formatting.	2021-04-22 12:38:29 +01:00
Jeff Young	87ca59f52e	One (correct) error message is sufficient. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8225	2021-04-22 12:38:29 +01:00
Jon Evans	511f4cd03c	Simulator: don't try to access an invalid map entry ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8273	2021-04-21 22:09:40 -04:00
Jeff Young	620aa315f6	Show infobar error when asking for empty datasheet. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8260	2021-04-21 15:40:59 +01:00
Adam Wolf	d91293eea5	Remove ngspice scripts from macOS bundle ... Apple won't notarize the bundle with those scripts in that area of the bundle. It appears that we don't use these scripts in KiCad.	2021-04-21 12:50:31 +00:00
Jon Evans	afe0c79a1e	Sheet pins need new UUIDs, too	2021-04-18 22:14:15 -04:00
Jon Evans	1e52f0a180	Make sure pasted symbols get new pin UUIDs ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8218	2021-04-18 21:53:38 -04:00
Ian McInerney	ae91042544	Implement thread safety for symbol loading routines ... These functions can be called from any thread of the library loader, so we need to ensure we have some thread safety with them.	2021-04-18 18:39:46 +01:00
Jeff Young	f30c67a478	Symbols need to be unannotated when updating their references. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8223	2021-04-18 16:26:36 +01:00
jean-pierre charras	8967e7eb3e	Eeschema: remove a strange test that modified the reference position. ... For some reason, when the reference was empty, the position was changed without a good reason. (It happens in the SCH_COMPONENT ctor). Fixes #8230 https://gitlab.com/kicad/code/kicad/issues/8230	2021-04-18 11:27:05 +02:00
Jeff Young	13473420e5	Remove duplicated routine and fix bug in UTIL version.	2021-04-17 15:10:59 +01:00
Jeff Young	f7ae819430	Don't confuse annotation prefix *letters* with root annotation. ... Given a symbol U12A, some parts of the code were assuming the prefix was 'U' while others were assuming 'U12'. Further complication arose when there were '?' in the library version. Fixes https://gitlab.com/kicad/code/kicad/issues/8223	2021-04-17 12:30:40 +01:00
Jeff Young	9846076676	Don't change must match between FormBuilder and C++ code.	2021-04-16 18:20:55 +01:00
Jeff Young	76ba11bd86	AppendUndo needs to be set after the first undo... ... ... not after the first change. Fixes https://gitlab.com/kicad/code/kicad/issues/8148	2021-04-16 18:20:55 +01:00
jean-pierre charras	31e9895a1a	Fix a minor compil warning	2021-04-15 19:49:41 +02:00
Wayne Stambaugh	1fc1286180	Minor code cleaning.	2021-04-15 12:59:15 -04:00
jean-pierre charras	e5dd54e05a	Eeschema, spice sim: fix a crash when no value is available. ... onSimFinished() try to analyse the list of plots, but did not test if there is available data before using it. Fixes #8169 https://gitlab.com/kicad/code/kicad/issues/8169	2021-04-14 21:01:39 +02:00
jean-pierre charras	5bfda7f1f0	spice netlist generation: use utf8 format. ... Using basic conversion from unicode to 8bits strings can break non ASCII7 strings Fixes #8192 https://gitlab.com/kicad/code/kicad/issues/8192	2021-04-14 09:54:29 +02:00
Jon Evans	6129f978ab	Fix symbol editor not pulling the right settings object ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7916	2021-04-12 22:03:25 -04:00
Roberto Fernandez Bautista	45409ec314	CADSTAR Schematic: Fix orientation of symbol fields	2021-04-12 20:25:04 +01:00
Roberto Fernandez Bautista	9148542219	CADSTAR Schematic: Fix Text Positioning within Symbols	2021-04-12 20:25:03 +01:00
Jonathan Haas	0593f3b0c3	Fill gc with background color before copying to clipboard ... Fixes https://gitlab.com/kicad/code/kicad/issues/7995	2021-04-12 17:05:50 +00:00
jean-pierre charras	929e535f0c	SCH_EDIT_FRAME::DrawCurrentSheetToClipboard(): fix missing init of worksheet color.	2021-04-12 18:15:30 +02:00
Jeff Young	a4c08e2af6	Apply Eeschema cursor updating architecture to PCBNew. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8135	2021-04-12 11:11:11 +01:00
jean-pierre charras	15353e3c33	Eeschema: when placing a new symbol or image, avoid starting the autopan. ... When activate the new symbol placement, the mouse cursor is outside the canvas. Therefore a autopan was started and not so easy to stop. Now the mouse cursor (and the graphic cursor) are moved to a better location inside the canvas. Fixes #8156 https://gitlab.com/kicad/code/kicad/issues/8156	2021-04-11 18:01:25 +02:00
Jeff Young	cc956695ae	Hit test for worksheet before adding Properties to menu. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8171	2021-04-11 14:18:35 +01:00
Thomas Pointhuber	f13eb13b9a	altium: import images from SchDoc	2021-04-10 21:52:37 +02:00
Jonathan Haas	846e4aed42	Fix selection filter in Edit Text and Graphics dialog ... Fixes https://gitlab.com/kicad/code/kicad/issues/7966 Fixes https://gitlab.com/kicad/code/kicad/issues/8149	2021-04-10 15:49:23 +00:00
Jonathan Haas	0589792a14	Set combobox defaults in "Edit Text and Graphics" dialog ... Fixes https://gitlab.com/kicad/code/kicad/issues/8167	2021-04-10 09:25:06 +02:00
Jeff Young	df5f010514	Bug fixes for fields when editing a symbol from the schematic. ... 1) Don't reset value when name changes 2) Don't fire events when initialising dialog 3) Make sure when symbol is saved back to schematic that only current instance has its ref updated, but that all instances have their other fields updated. 4) When saving symbol back to board always use the fields from the editor and not the (alias-specific) ones from the library. Fixes https://gitlab.com/kicad/code/kicad/issues/8159	2021-04-09 17:14:53 +01:00
Jon Evans	7dd6a182f2	Unhide the Altium schematic importer ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/8069	2021-04-08 22:22:03 -04:00
jean-pierre charras	677d7b0a60	Eeschema, cross-probing: fix incorrect unit selection when highlight a pin. ... Highlight a pin of a multi-unit symbol from Pcbnew did not always select the right part. Fixes #8087 https://gitlab.com/kicad/code/kicad/issues/8087	2021-04-07 19:48:02 +02:00
Ian McInerney	1a727558b0	Switch update event handlers to use the event instead of pointers ... It is safer to use the event to pass the enable/string instead of pointers, since using the pointers could trigger other UI events.	2021-04-07 17:39:48 +01:00
Jeff Young	21d4197eab	Apply SPECIAL_CASE_LABEL_INFO architecture to one-ended-drag. ... We've been doing this for some time to wires that are attached to the moving block (and therefore have the other end anchored). However we also need to apply it when dragging a single end of a wire. Fixes https://gitlab.com/kicad/code/kicad/issues/7807	2021-04-07 14:40:07 +01:00
Jeff Young	30a073c2bb	Cleanup.	2021-04-07 14:40:07 +01:00
Jeff Young	895f3de455	Formatting.	2021-04-07 14:40:07 +01:00
Wayne Stambaugh	2b86b34124	Eeschema: split out SCH_SHEET_PIN declarations into separate header.	2021-04-06 17:15:49 -04:00
Wayne Stambaugh	866c58a6d6	Eeschema: do not change schematic UUID on file overwrite.	2021-04-06 15:42:22 -04:00
Wayne Stambaugh	df186a2049	Eeschema: fix root sheet UUID changing in project file. ... This change is a bit more invasive than the description above would suggest. UUIDs have been added to all schematics. For now, it's only useful to the root schematic so that the UUID in the project file does not change every time the project file is save. In the future, it may be useful to store and check the schematic UUIDs against the one's saved in the project file. Fixes https://gitlab.com/kicad/code/kicad/issues/7763	2021-04-06 14:28:01 -04:00
Jeff Young	daaf738c7f	Add save-as files to file history. ... Also fixes where lock wasn't getting reset on a Save As. Fixes https://gitlab.com/kicad/code/kicad/issues/8111	2021-04-06 13:35:26 +01:00
Roberto Fernandez Bautista	d041578150	CADSTAR Schematic: Fix import of text alignment ... Ensure that the text alignment applied to text objects corresponds to valid text alignments that can be set within eeschema Fixes https://gitlab.com/kicad/code/kicad/-/issues/8090	2021-04-05 20:15:08 +01:00
Roberto Fernandez Bautista	7d9ee76f64	Don't iterate through m_selection if deleting items from it ... Use the copied container saved_selection instead Fixes https://gitlab.com/kicad/code/kicad/-/issues/8126	2021-04-05 18:40:40 +00:00
Jonathan Haas	baca70e748	Fix description: FETs have a gate, not a grid	2021-04-05 16:15:25 +02:00
Ian McInerney	e08387ce3d	Make the GAL responsible for the native cursor management ... The native cursor must be set on the GAL canvas wx object, not its frame (otherwise on GTK the cursor is only set when we get a request for it from the WM and not immediately). Fixes https://gitlab.com/kicad/code/kicad/issues/6421	2021-04-05 02:36:12 +01:00
Marcus A. Romer	1632707d9b	Replace tabs with spaces	2021-04-05 01:13:39 +00:00
Jeff Young	329577cc5c	Add new text items/labels to the selection so rotate/mirror/etc. work. ... Also clears the selection after finding the sheet in the sheet pin case so that the sheet itself doesn't get rotated/mirrored/etc. Fixes https://gitlab.com/kicad/code/kicad/issues/8108	2021-04-03 19:41:24 +01:00
jean-pierre charras	2b89511887	DIALOG_LIB_EDIT_TEXT: Remove useless code creating a wxWidgets alert. Fixes #8093 https://gitlab.com/kicad/code/kicad/issues/8093	2021-04-03 17:58:11 +02:00
Carsten Schoenert	cb17c9f3dd	Typo fix: Correct various misspelled words ... agressive -> aggressive decription -> description miscellanous-> miscellaneous rectange -> rectangle Unkown -> Unknown	2021-04-03 13:39:50 +00:00
Jeff Young	32e8a17cc0	Fix nullptr error. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8102	2021-04-03 11:15:11 +01:00
Jon Evans	358f01ba66	Use HTML report window for symbol loading issues	2021-04-02 19:50:50 -04:00
Jon Evans	c1573744be	Lock project files when opening; open locked projects read-only ... Also clean up an include-what-you-use problem Fixes https://gitlab.com/kicad/code/kicad/-/issues/8037	2021-04-02 19:29:56 -04:00
Ian McInerney	bb95761642	Remove unused variable ... item is already an SCH_ITEM, so the static cast is pointless.	2021-04-02 19:26:22 +01:00
Jeff Young	ebfbe14185	Persist fields_autoplaced information. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8086	2021-04-02 17:08:58 +01:00
Jeff Young	c7d689a022	Show field children when creating new labels. ... And in particular, show reasonable intersheet reference facsimiles.	2021-04-02 15:15:07 +01:00
Jeff Young	04f7fbfa4a	Don't draw selection in hyperlink colour.	2021-04-02 11:18:18 +01:00
jean-pierre charras	dce351791c	Eeschema, DIALOG_SYMBOL_PROPERTIES_BASE: very minor fix: make lib link copiable. ... Fixes #8080 https://gitlab.com/kicad/code/kicad/issues/8080	2021-04-01 13:54:32 +02:00
Jeff Young	0c4184f1a4	Split lib tree initialization into a two-pass affair. ... This is under the supposition that we can't set the column widths on some Mac instances because the host controls haven't yet been created. This is primarily conjecture based on looking at things that have the *possibility* of going wrong. Why this only happens in some installs is beyond me. Fixes https://gitlab.com/kicad/code/kicad/issues/5479	2021-04-01 10:51:29 +01:00
jean-pierre charras	655a696589	fix compil issue	2021-04-01 11:36:30 +02:00
jean-pierre charras	6499b5f296	Eeschema: protect lib symbols against duplicate field names. ... If a field name is already in use, try to rename the new field name (adding the suffix "_1" or "_2" or ... ) This is especially critical when a non mandatory field has the same name as a mandatory field (was crashing before) Fixes #8081 https://gitlab.com/kicad/code/kicad/issues/8081	2021-04-01 11:27:14 +02:00
Jeff Young	2ad69fc56b	Move importers from wxLog to REPORTER. ... Fixes https://gitlab.com/kicad/code/kicad/issues/6389	2021-03-31 22:54:30 +01:00
Ian McInerney	0a0935e0f3	Remove ACTIONS::TranslateLegacyId and TOOL_DISPATCHER::DispatchWxCommand ... After commit 9535153f9e there were no more IDs inside the legacy ID system. Therefore the entire system for dispatching and looking up the legacy ideas and handling those events can now be removed and the tool dispatcher simplified (it no longer needs to know about the ACTIONS class).	2021-03-30 23:20:22 +00:00
Roberto Fernandez Bautista	de1191f971	Only FixupJunctions for Legacy designs ... The new s-expression format embeds the library within the file so there should be no connectivity issues (unless they were present in the original design). This fixes a potential issue with EAGLE imported schematics.	2021-03-30 13:03:56 +00:00
Roberto Fernandez Bautista	c5e4220b5b	CADSTAR Schematic: Fix duplicate pins ... Fixes a bug that was causing duplicate pins to be loaded (one on top of the other) for all symbols.	2021-03-30 13:03:56 +00:00
Roberto Fernandez Bautista	767aab7294	CADSTAR Schematic: Fix up junctions after load	2021-03-30 13:03:56 +00:00
Roberto Fernandez Bautista	1629b038e1	CADSTAR Schematic: Fix loading of symbol instances differing from part ... The previous assumption was that a part definition would always hold the information about the symbol. However some designs have symbol instances that refer to a different symbol definition than that specified in the part. Fixes https://gitlab.com/kicad/code/kicad/-/issues/7808	2021-03-30 13:03:56 +00:00
Roberto Fernandez Bautista	e6c7ddc271	CADSTAR Schematic: Fix loading of symbol attributes ... Fixes an issue that resulted in incorrect field values being loaded	2021-03-30 13:03:56 +00:00
Roberto Fernandez Bautista	51db9cfcef	CADSTAR Schematic: Text Loading improvements	2021-03-30 13:03:56 +00:00
Jeff Young	2fc34de1be	Don't nag the user about file extensions. Just fix it. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8067	2021-03-29 22:11:35 +01:00
Jeff Young	f2e68e68d0	Add "Hide Tree" context menu options when tree has no selection. ... Also cleans up some other code to be more consistent between symbol editor and footprint editor. Fixes https://gitlab.com/kicad/code/kicad/issues/8052	2021-03-29 12:02:00 +01:00
Jeff Young	14e73d24dc	Naming conventions.	2021-03-29 11:46:05 +01:00
Jeff Young	455e7dc3a8	Reorder for better readability and consistency.	2021-03-29 11:04:06 +01:00
Jeff Young	1b163c5dd3	Don't eat delete event when there's no item being drawn. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8061	2021-03-29 10:59:45 +01:00
Jeff Young	0561ce903e	Don't remove IS_MOVED flag too early. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8056	2021-03-28 20:05:41 +01:00
Jeff Young	c32932a311	Naming conventions.	2021-03-28 20:05:41 +01:00
jean-pierre charras	cc43436df8	Eeschema: Fix a few issues in dialog edit fields ... Partial fix of #8057	2021-03-28 18:23:35 +02:00
Ian McInerney	42c6af4bd8	Cleanup ACTION_MENU creation in some places ... The ACTION_MENU constructor now takes the tool as an argument, so the call to SetTool() immediately following it can be removed and the tool just passed into the constructor.	2021-03-27 19:16:58 +00:00
Ian McInerney	7bfa8575fa	Remove redundant information from import/export menu item labels ... Saying "Import/Export" on the labels when the submenu has "Import" or "Export" in it is redundant. Note that we can't just update the action text with the new name, because that is used in the hotkey list and would become too confusing without the "Import"/"Export" text.	2021-03-27 18:50:35 +00:00
Jeff Young	15e640b5fe	Reset field ids after re-ordering. ... We use the id for sorting the multivector. Fixes https://gitlab.com/kicad/code/kicad/issues/8031	2021-03-26 23:26:10 +00:00
Jeff Young	a0a5e93782	Remove m_props from symbol library plugins. It's not thread-safe. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8035	2021-03-26 21:57:32 +00:00
Jeff Young	3d6c05b210	Apply symbol field id fixup logic to lib parts. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7903	2021-03-26 21:57:32 +00:00
Wayne Stambaugh	925b6d9387	Eeschema header housekeeping round 2.	2021-03-25 17:55:16 -04:00
Roberto Fernandez Bautista	e0d2724f68	CADSTAR Schematic: Increase "tiny" bus labels to 0.4mm text size ... Also fix incorrect label orientation	2021-03-25 19:10:49 +00:00
Roberto Fernandez Bautista	6494e0bf25	CADSTAR Schematic: Fix orientation of net labels and sheet pins	2021-03-25 17:50:33 +00:00
Roberto Fernandez Bautista	5a74fb9bb1	CADSTAR Schematic: Ensure connectivity with tiny labels at Bus Entries ... Always add a label at bus terminals to ensure connectivity. The original design might already have a bus terminal with a given location. If the original design does not have a label, just make it very small to keep connectivity but make the design look visually similar to the original.	2021-03-25 17:50:33 +00:00
Wayne Stambaugh	a85898f904	Eeschema header housekeeping round 1.	2021-03-25 10:08:06 -04:00
jean-pierre charras	faa5ed3e37	typo	2021-03-25 11:47:13 +01:00
Jeff Young	040cdd64f2	Fix typo in Eeschema titlebar. ... Fixes https://gitlab.com/kicad/code/kicad/issues/8016	2021-03-25 10:28:03 +00:00
jean-pierre charras	bbd7b4ca8c	Eeschema, selection tool: uniformize the cursor shape and the actual modifiers. ... SHIFT, CTRL, ALT modifier keys were handled in 2 different codes, one for the selection tool and another to modify the mouse cursor shape, with 2 different configs. Now the modifiers are managed from only one function. Pcbnew: group also SHIFT, CTRL, ALT modifier keys management to a specific function. Fixes #8021 https://gitlab.com/kicad/code/kicad/issues/8021	2021-03-25 10:28:20 +01:00
Wayne Stambaugh	b37b7d53b4	Fix geographic annotation bug when back annotating to schematic. ... For some reason, the footprint UUID was being prefixed to the sheet path which caused the symbol look up by sheet path to fail. An option was added to not do this when the geographical back annotation to the schematic is performed.	2021-03-24 09:57:36 -04:00
Jon Evans	4dbeb15024	Use a worker thread to send socket commands ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/6503	2021-03-23 03:20:40 +00:00
Roberto Fernandez Bautista	be51be22a7	Update Page Number when Duplicating or Pasting sheets ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7872 Also, update hierarchy before renaming pasted sheets Avoids duplicate sheet names when pasting multiple sheets	2021-03-23 02:48:07 +00:00
Wayne Stambaugh	c7d2440699	Eeschema: fix build issue when spice simulator build is disabled. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7996	2021-03-22 17:45:49 -04:00
Jeff Young	29b215d7f5	Move spice compatibility mode out of analysis type notebook. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7988	2021-03-22 13:51:10 +00:00
Jeff Young	cf4cbea8a1	Use a more robust storage of items added to drag. ... We kept having various issues of the pointer list going stale. This will prevent all permutations of that. Also while I was in there I fixed the double-move thing (see bug number). Fixes https://gitlab.com/kicad/code/kicad/issues/7910	2021-03-22 13:51:10 +00:00
Wayne Stambaugh	cfaca0e4bb	Revert "Eeschema: remove all legacy schematic and symbol library save code." ... This reverts commit 9c19c2306e. Unfortunately writing legacy symbols libraries can never be removed because of the symbol rescue feature. :( Fixes https://gitlab.com/kicad/code/kicad/issues/7986	2021-03-22 08:19:47 -04:00
Wayne Stambaugh	664b0c597a	Schematic netlist exporter header housekeeping.	2021-03-22 07:59:54 -04:00
Jon Evans	c5c348538e	Fix some STL asserts in EE_SELECTION_TOOL	2021-03-21 22:01:45 -04:00
Jon Evans	f7c20c6bef	Only consider pins on this unit as clickable anchors ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7987	2021-03-21 19:18:13 -04:00
Roberto Fernandez Bautista	8efc2f12d8	Non-KiCad Schematic Importers: Do not save project ... Prevents creating unnecessary project files when importing Non KiCad schematics. Also clarified that empty.kicad_wks is required for all importers (not just EAGLE).	2021-03-21 20:13:20 +00:00
Roberto Fernandez Bautista	6c29f54988	Non-KiCad Schematic Importers: New project when running standalone ... Create a new project when running eeschema standalone and importing a non-KiCad Project. If we have the project manager open, then we instead use the existing project and load everything there.	2021-03-21 20:13:20 +00:00
Roberto Fernandez Bautista	a0889705e7	EAGLE and Altium SCH importers: UpdateSymbolLinks after import ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7687	2021-03-21 20:13:20 +00:00
Wayne Stambaugh	6997fec14f	Schematic editor dialog source code housekeeping.	2021-03-21 13:31:23 -04:00
Jon Evans	9b0d7b7d37	Maybe make Coverity happy	2021-03-21 09:19:18 -04:00
Thomas Pointhuber	d9229697d8	altium: special string override map should be case-insensitive ... This only fixes overrides where we explicitly map an override. Wrongly written variables pointing to fields are not corrected by this. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6256	2021-03-20 20:42:25 +01:00
Wayne Stambaugh	9c19c2306e	Eeschema: remove all legacy schematic and symbol library save code. ... Legacy schematic and symbol library saving is officially deprecated.	2021-03-20 13:29:44 -04:00
Jon Evans	c04e19f9ac	Include optimization: move some things from common.h to point-of-use	2021-03-20 12:09:18 -04:00
Wayne Stambaugh	80cb1db2e6	Spice simulator settings dialog improvements. ... The dialog can now be closed even if it is not on a simulation type tab which is an improvement but it still doesn't flow very well. Maybe a drop down list control to select the desired simulation type would make for a better user experience.	2021-03-20 11:19:40 -04:00
Jon Evans	ba67acf348	Fix wx3.0 build	2021-03-19 22:11:54 -04:00
Jeff Young	f0e6f812ff	Edit One Field improvements. ... 1) Accept <enter> as OK if the multiline textbox isn't shown. 2) Focus and select all in first control if multiline textbox isn't shown. 3) Make title be title caps ("Edit Sheet name Field" looked dorky). Fixes https://gitlab.com/kicad/code/kicad/issues/7940	2021-03-20 00:41:09 +00:00
Jon Evans	82a4cacb4f	Add threaded library load to symbol editor	2021-03-19 20:23:54 -04:00
Jeff Young	2e129d9b47	Naming conventions and other cleanup.	2021-03-19 23:06:19 +00:00
Jeff Young	7a13ad7b17	Consistent naming.	2021-03-19 23:06:19 +00:00
Jon Evans	4b46c0c954	Make sure nested settings get released in dtor ... Also fix a crash if sim window can't be created because ngspice shared library could not be found Fixes https://gitlab.com/kicad/code/kicad/-/issues/7969	2021-03-19 19:04:27 -04:00
Ian McInerney	6c3cf33170	Cleanup some compiler warnings	2021-03-19 21:18:45 +00:00
Jeff Young	30ac8de734	Honour component transforms when rotating fields. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7964	2021-03-19 19:33:36 +00:00
Jeff Young	e560de496c	Intersheet refs don't go in the view themselves. ... (Their parents draw them.) Also simplifies a couple of loops by using OfType(). Fixes https://gitlab.com/kicad/code/kicad/issues/7805	2021-03-19 16:14:34 +00:00
Wayne Stambaugh	dbb0a125ac	Fix build error when spice simulator build option is disabled.	2021-03-19 09:04:28 -04:00
Jon Evans	472d0e03fc	Remove unused color layer	2021-03-18 22:30:24 -04:00
Jon Evans	93c991926f	Use threading for loading symbol libraries	2021-03-19 00:56:26 +00:00
Jeff Young	9c02e3ea63	Don't consider 0-length-lines when checking for junctions. ... Also don't put junctions on labels in the middle of a wire. Fixes https://gitlab.com/kicad/code/kicad/issues/7951	2021-03-18 23:50:04 +00:00
Wayne Stambaugh	acec6ad7fc	Spice simulator: add Ngspce model behavior mode settings. ... ADDED: Ngspice simulator model behavior mode settings for PSpice, LTSpice, PSpice and LTSpice, and HSpice. Fixes https://gitlab.com/kicad/code/kicad/issues/5810	2021-03-18 15:31:02 -04:00
Jeff Young	1641d6da79	Go back to separate junction logic for wires and buses. ... Also makes sure we don't add wire width in to hit-test calculations. Fixes https://gitlab.com/kicad/code/kicad/issues/7951	2021-03-18 18:32:01 +00:00
Jeff Young	999477e0ed	Vastly simplify the needs-junction logic to try and make it less buggy. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7951	2021-03-18 16:38:48 +00:00
Jeff Young	e206a9d39a	Naming conventions.	2021-03-18 12:28:24 +00:00
Jeff Young	cc70a9fa98	New components must be added to the screen. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7952	2021-03-18 12:28:24 +00:00
Jeff Young	35d17929ff	Add specific warning for no symbol library selected. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7954	2021-03-18 12:28:24 +00:00
Jeff Young	36259b1f6b	Refresh lib trees after editing library tables. ... Also make sure that we grab the library item descriptions from their source rather than just the cached tree copy. Fixes https://gitlab.com/kicad/code/kicad/issues/7875	2021-03-17 14:54:18 +00:00
Jon Evans	6d502cb2a5	Don't generate real random UUIDs while loading libraries ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7921	2021-03-17 00:43:13 +00:00
Jeff Young	7e682e9948	Don't allow pins on corners. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7917	2021-03-16 22:03:08 +00:00
Jeff Young	30fdba4cbb	Finish grid-snapping impl.	2021-03-16 22:03:08 +00:00
Mario Luzeiro	4e63aefaab	Call Layout OnSizeGrid ... Fixes https://gitlab.com/kicad/code/kicad/issues/5690	2021-03-16 21:59:44 +00:00
Mikolaj Wielgus	ee4bc8b1d0	Fix default line width for symbol editor graphic items, add validation ... There was a mils to iu conversion missing for line width (the default values are in mils). Fixes https://gitlab.com/kicad/code/kicad/issues/7813	2021-03-16 13:50:41 +00:00
Jeff Young	2bafc1af00	Give up on using preview layer for PlaceComponent. ... 1) Cloning the component fails to select all its pins. 2) Something about the layer compositing causes light selection shadows to get even lighter. The default pretty much disappears. Fixes https://gitlab.com/kicad/code/kicad/issues/7908	2021-03-15 19:04:59 +00:00
Jeff Young	82af98b08e	Now that user can specify alpha we don't need to add in more.	2021-03-15 19:04:59 +00:00
Julian Fellinger	de12ebf16f	Check if symbol is disabled first ... By checking for disabledness of the symbol first we skip potentially unnecessary validation that in turn would throw an unnecessary warning Fixes https://gitlab.com/kicad/code/kicad/issues/7338	2021-03-15 08:39:46 -07:00
Jeff Young	573dd36515	Handle <delete> in move and drawing tools. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7924	2021-03-15 14:23:54 +00:00
Jeff Young	afab60ae06	Fixes for autoplace fields. ... 1) Don't factor in pin names when computing symbol body boundingbox. 2) Grid-snap only in the axis corresponding to the layout side. 3) We only need interline spacing *between* lines, not for each line. 4) Also cleans up the unit checking logic as the unit can't be more than 0 unless it's a multi-unit symbol. Fixes https://gitlab.com/kicad/code/kicad/issues/7907	2021-03-15 02:23:29 +00:00
Jeff Young	7415bf0c62	Don't hide (or disable) options if it's not obvious why. ... It deprives us of the opportunity to inform the user what the conditions are.	2021-03-15 02:23:29 +00:00
Thomas Pointhuber	4482b3baba	altium: Handle special strings and convert them into KiCad variables. Use Comment for VALUE. ... Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6256 Fixes: https://gitlab.com/kicad/code/kicad/-/issues/7736	2021-03-14 16:40:36 +01:00
Jeff Young	e34734c230	Make sure pasted sheet instances get added. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7872	2021-03-13 16:34:30 +00:00
Wayne Stambaugh	a79974fb92	Symbol editor: fix segfault when saving library with renamed symbol. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7866	2021-03-13 08:28:52 -05:00
Jeff Young	b71ab01de4	More wxWidgets 3.1 layout adjustments.	2021-03-13 00:00:38 +00:00
Jeff Young	3e947553f5	Adjust pin conflicts table for wxWidgets 3.1.	2021-03-13 00:00:38 +00:00
Jeff Young	faf9cca938	Fix many cases of old mils flag getting interpreted as allowEval flag. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7883	2021-03-12 15:15:50 +00:00
Jon Evans	b20f18e6c5	Properly handle mixed-up group buses ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7870	2021-03-11 18:24:39 -05:00
Jon Evans	44f88f840c	Bitmaps: a few improvements from review	2021-03-11 08:37:35 -05:00
Jon Evans	18037e2f65	Rework bitmap system to load from archived PNGs ... Bitmaps are now identified by an enum class instead of by pointers. Bitmap loading and caching is now handled by a class in common, and we no longer compile most bitmaps into the binary, so there is no longer a bitmaps static library. Instead, bitmaps are archived to a .tar.gz file which is installed in ${KICAD_DATA}/resources/images.tar.gz The source PNGs are checked in to Git as the original CPP files were, so that people can build without the required dependencies to convert SVGs to PNGs. Initial support is also added for dark theme icons, although this is not yet exposed in the GUI. Stubs are present for multi-resolution image resources, but this is not fully-baked yet and could use some refinement.	2021-03-11 08:37:35 -05:00
jean-pierre charras	2bc22de1a5	Eeschema: fix crash when opening preferences, due to null pointer. ... In panel preview, Schematic() returns a null pointer. Fixes #7869 https://gitlab.com/kicad/code/kicad/issues/7869	2021-03-11 08:20:27 +01:00
jean-pierre charras	33f465f754	SCH_GLOBALLABEL::GetBoundingBox(): do not include IREF when not shown.	2021-03-10 18:38:38 +01:00
jean-pierre charras	d295b5d6de	SCH_GLOBALLABEL: fix broken position of IREF, creating a broken bounding box. ... Note also the bounding box is too large when the IREF is not shown, because IREF is always included, even if not shown. Fixes #7864 https://gitlab.com/kicad/code/kicad/issues/7864	2021-03-10 17:58:44 +01:00
Jeff Young	068e85c567	Reset moved flag after completing move. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7818	2021-03-10 16:00:28 +00:00
Jeff Young	861ad0b6ec	Don't bloat layout.	2021-03-10 16:00:28 +00:00
Wayne Stambaugh	fb29b4f946	Eeschema: add missing symbol cache library file warning. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7346	2021-03-10 09:52:53 -05:00
Jeff Young	e48f86bfd6	Move default assignment on Mac. ... CHANGED: add corner and repeat last command now default to 'I' instead of '<insert>' on Mac. 1) wxWidgets doesn't currently display the correct graphic in the menu for the insert key 2) Mac laptops don't have an instert key Fixes https://gitlab.com/kicad/code/kicad/issues/5016	2021-03-10 13:35:04 +00:00
Marek Roszko	3d4ac9af03	Relocate win32 resource files to the central folder for further consolidation	2021-03-09 21:48:14 -05:00
Jeff Young	8be3ff5a0a	Perform a slightly more aggressive cleanup. ... Also removes the functionality that selects the newly-added item as we don't do that with any of the other drawing tools. Fixes https://gitlab.com/kicad/code/kicad/issues/7833	2021-03-09 21:42:35 +00:00
Jonathan Haas	14f00271a4	Fix typo in the schematics help text. Align bottom example properly, as the subscript letters are smaller.	2021-03-09 16:23:12 +00:00
Jeff Young	2a9186d9e9	Don't re-use FieldIDs when assigning ids on save. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7849	2021-03-09 15:09:31 +00:00
Jeff Young	e4590e4762	Make sure SCH_GLOBALLABEL's bounding box includes its intersheet ref. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7819	2021-03-09 12:08:33 +00:00
Jeff Young	3c8e35249c	Mac doesn't like menus that start with ID 0. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7845	2021-03-09 12:08:33 +00:00
jean-pierre charras	ae15098a5d	Make a menuitem name translatable and understandable.	2021-03-09 12:53:44 +01:00
Dominik Wernberger	e2aa7be4b3	Added a lot of consts and refactored a few lines	2021-03-08 12:49:48 -08:00
Franck Jullien	c16199c3f9	eeschema: add a setting to allow intersheets to not list their own page ... Also disable inter-sheet options when "Show inter-sheet references" is not checked.	2021-03-08 20:40:37 +00:00
jean-pierre charras	14b1d36b38	Simulator: Fix a ugly bug that happens is some simulations ... TRhe initial code was broken.	2021-03-08 20:01:36 +01:00
jean-pierre charras	638a9b693d	SIM_PLOT_FRAME_BASE: minor cosmetic enhancements and fix a incorrect wxmenu ... name in the .fbp file that prevent to rebuild working .cpp and .h files.	2021-03-08 16:33:08 +01:00
Jeff Young	6fd247a152	Check for active tool as well as items. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7821	2021-03-08 14:09:43 +00:00
jean-pierre charras	c1003e2ddd	Fix missing call to Layout() in SIM_PLOT_FRAME after adding widgets. ... Fix a minor wxWidgets warning.	2021-03-08 13:49:45 +01:00
jean-pierre charras	8285f2a223	Fix a compil error.	2021-03-08 12:45:00 +01:00
Jeff Young	ed61440d2a	Improve clarity.	2021-03-08 11:07:35 +00:00
Jonatan Liljedahl	5b70508624	dialog_sim_settings: don't try to read current wxChoice selection if no choices. ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7823	2021-03-08 09:36:15 +00:00
Jon Evans	720147d272	Remove transitive inclusion of bitmaps.h	2021-03-07 16:08:57 -05:00
jean-pierre charras	7f9890adaa	Fix a install issue after changing a plugin filename (by commit a0f57d6)	2021-03-07 20:57:09 +01:00
Graham Keeth	a0f57d6846	Cleanup BOM script descriptions ... - make descriptions consistent - fix inaccuracies - describe what scripts do more precisely	2021-03-07 16:33:59 +00:00
Jeff Young	22b4a74bfa	Don't forget intersheet refs when collecting non-view items. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7819	2021-03-07 15:04:01 +00:00
Jeff Young	3ab1ef7b83	Formatting.	2021-03-07 15:04:01 +00:00
Jeff Young	b691c18bfc	Allow netclass assignents to unnamed nets. ... Most of the code had already moved over to this, but there were a few hold-outs. Fixes https://gitlab.com/kicad/code/kicad/issues/7802	2021-03-05 19:16:09 +00:00
PJM	0fc8a9d89a	Eeschema: Fix ctrl-MMB double click to perform 'Zoom to Objects' ... CHANGED: Ctrl-middle mouse button double click should perform 'Zoom to Objects' in Eeschema, but a change in modifier key handling broke it. This MR restores the functionality. Fixes https://gitlab.com/kicad/code/kicad/issues/7803	2021-03-04 22:43:03 -08:00
Jon Evans	5ca7a2c457	Fix some issues with group bus prefix handling ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7196	2021-03-04 23:37:46 -05:00
Jon Evans	4ddb942ec0	Do not allow drag selection or drag move when already moving something ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7800	2021-03-04 19:01:31 -05:00
Wayne Stambaugh	6cdc3664ba	Symbol editor: fix crash whe changing symbol name. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7791	2021-03-04 18:21:41 -05:00
Wayne Stambaugh	7a00e01b3e	Eeschema: fix false positive library symbol changed ERC errors. ... This fix required sorting all of the LIB_PART draw items to ensure accurate comparison between the symbols stored in the schematic and the original library symbols. This has a noticeable impact on symbol library load performance. It may also cause significant changes the next time the library is saved due to changes in the draw item sorting. Hashing may be a better solution here but this addressed the immediate problem. A skeleton method SCH_SCREEN::SwapSymbolLinks() was added because there is most likely an issue with orphaned symbols in the schematic library symbol cache during undo/redo operations. More testing is required to verify this. Fixes https://gitlab.com/kicad/code/kicad/-/issues/7263	2021-03-04 17:59:24 -05:00
WhiteChairFromIkea	ff23f4324a	Do not hardcode altium file extension length	2021-03-04 12:20:40 +00:00
Marek Roszko	8831c5567c	Add win32 version manifest block	2021-03-04 00:34:48 -05:00
Jon Evans	1fc399fa31	Fix a few more cases of picking up wrong mouse positions ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7745	2021-03-03 20:09:24 -05:00
Jeff Young	b9d26a55f2	Show variable references of text in status bar. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7790	2021-03-03 18:58:04 +00:00
Ian McInerney	908de37e7c	Don't hardcode the file extensions where possible	2021-03-03 01:13:59 +00:00
Ian McInerney	69e310918e	Update singletop eeschema to append the new schematic extension ... This is used when launching a single top instance and no extension is supplied to the filename given.	2021-03-03 01:13:59 +00:00
Wayne Stambaugh	0ce8bce753	Symbol editor: fix symbol renaming bug. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7616	2021-03-02 19:19:08 -05:00
WhiteChairFromIkea	2c289b3f35	Check for ".SchDoc" before replacing to ".kicad_sch" for subsheet	2021-03-02 22:30:08 +00:00
WhiteChairFromIkea	f83b9236ac	Formatting	2021-03-02 22:30:08 +00:00
WhiteChairFromIkea	b98602583c	Remove "SchDoc" and use "kicad_sch" instead for subsheet names	2021-03-02 22:30:08 +00:00
WhiteChairFromIkea	042ea9761c	Revert "Import footprint to symbols. Subsheet is name is prepended to footprint name,..." ... This reverts commit 8aa4faa4ce24adc6310223952e8b5773ce245778	2021-03-02 22:30:08 +00:00
WhiteChairFromIkea	292aff48fd	Import footprint to symbols. Subsheet is name is prepended to footprint name, which is probably NOT OK when syncing with PCB.	2021-03-02 22:30:08 +00:00
Jonathan Haas	f90164f7cf	Fix some typos and improve wording	2021-03-02 19:13:49 +01:00
Jon Evans	f6064523a3	Use valid diff pair suffixes in label help example	2021-03-01 21:47:29 -05:00
Jeff Young	7760570d76	Treat action buttons in Symbol/Footprint Properties as OK, not Cancel. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7001	2021-03-01 20:37:04 +00:00
Jeff Young	57e948ff08	Make sure axesEnabled is set before saving config. ... We don't actually allow the user to change this at present, so one could argue that we should remove it from what is saved out of the config. But this is a smaller, safer change. Fixes https://gitlab.com/kicad/code/kicad/issues/7666	2021-03-01 20:37:04 +00:00
Sylwester Kocjan	959ae73a01	Eeschema,sim: extract plot colors to new class	2021-03-01 18:50:37 +00:00
Jon Evans	375cd12258	Eeschema: never replace event position in wire drawing tool ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7745	2021-03-01 12:17:18 -05:00
Jeff Young	5bc2285aef	Fix another failure of dynamic_cast<>. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7767	2021-03-01 14:46:27 +00:00
Jeff Young	8a33542bcd	SCH_COMPONENT::GetField() expects a vector index, not a field id. ... Check this at compile time. Callers wanting to use an index now must use SCH_COMPONENT::GetFields()[i] instead. Fixes https://gitlab.com/kicad/code/kicad/issues/7757	2021-02-28 15:10:37 +00:00
jean-pierre charras	13bcfc79a1	Eeschema, DIALOG_ERC: fix minor issues: ... - avoid printing twice the messages when running tests (Report() was called twice). - when saving the report open the project directory by default.	2021-02-28 15:52:14 +01:00
Jeff Young	8ab1f957a2	Update title after a Save All. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7752	2021-02-27 23:17:48 +00:00
Jeff Young	790e97a398	Only report "done" once, and be a (bit) more descriptive about it. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7743	2021-02-27 20:28:06 +00:00
PJM	d8089ed54a	Eeschema: Adds wire when dragging directly connected labels ... CHANGED: KiCAD allows connecting components directly together in schematics. If the user drags one of the components, KiCAD adds a wire to keep the conection intact. It should do the same for net and global labels but it doesn't. This MR adds net and global labels to the list of items that can connect to other items. Fixes https://gitlab.com/kicad/code/kicad/issues/7713	2021-02-26 22:56:28 -08:00
Roberto Fernandez Bautista	76ef98339d	CADSTAR PCB Archive Importer: Re-write loading of power symbols ... Ensure all each power symbol is unique for each net name even if it uses the same graphical symbol. Fixes https://gitlab.com/kicad/code/kicad/-/issues/7722	2021-02-26 19:32:44 +00:00
Jon Evans	7fda7438f9	BOM dialog: explain when we can't find scripts ... Also default to the user plugin dir when adding a new plugin, and don't convert filenames to full path on save. Fixes https://gitlab.com/kicad/code/kicad/-/issues/7719	2021-02-25 22:41:12 -05:00
Jeff Young	808ab92834	Simplify default format for exporting netlist. ... It's now just remembers the last-shown tab. Fixes https://gitlab.com/kicad/code/kicad/issues/7618	2021-02-26 00:36:39 +00:00
Seth Hillbrand	f73039cb18	Fix wire endings both too small and too large ... Junctions should only be wire endings when ending directly on the wire. This is the requirement for netlisting, so we need to follow it in the auto-end as well. SCH_LABEL needs to allow ending because any wire that touches the label will be connected, so there's a use case for this. However, the bounding box for local labels did not include their connection point, so we increase that box a bit. Note that this might have the opposite effect to https://gitlab.com/kicad/code/kicad/-/issues/7689 Fixes https://gitlab.com/kicad/code/kicad/issues/7714	2021-02-25 16:27:05 -08:00
Jeff Young	b8c95345d0	Make sure reporters have a better default path than /bin.	2021-02-25 15:05:26 +00:00
jean-pierre charras	1ac81c04e5	Bugfix for "Edit text and graphic properties" dialog: vertical alignment code ... erroneously checked against change in horizontal alignment UI item	2021-02-25 12:52:04 +01:00
jean-pierre charras	cfa3f3afeb	Fix compil issue.	2021-02-25 10:44:14 +01:00
jean-pierre charras	9797bc5f25	Left Mouse Button: use same modifiers for Pcbnew, Eeschema and pleditor for selection. ... It also means the "force disambiguation menu" uses now Ctrl in Eeschema and pleditor.	2021-02-25 08:22:35 +01:00
Jon Evans	8d62c73b86	Eeschema: overhaul storage of BOM plugin settings ... CHANGED: BOM generator plugins are no longer loaded by searching all plugin directories; instead a fixed default set of plugins is provided. Also: - Move from sexpr to JSON - Support both full-path and no-path specifications of plugins - Add a Reset to Defaults button to reset the list Fixes https://gitlab.com/kicad/code/kicad/-/issues/7633	2021-02-24 22:45:42 -05:00
Wayne Stambaugh	9f42b5e8c7	Attempt to fix Coverity issue 316502.	2021-02-24 17:36:11 -05:00
Jon Evans	92cc88f87c	Tighten up schematic label bounding boxes ... Margins were being added in more places than necessary Fixes https://gitlab.com/kicad/code/kicad/-/issues/7689	2021-02-24 17:15:35 -05:00
Seth Hillbrand	0bab025832	Fixup toolchaining for immediate mode ... The move tool can stack on others, so when we re-enter the previous tool this caused another immediate action. We flag re-entry in the tool stack to check for this and avoid unexpected tool starts	2021-02-24 10:44:54 -08:00
Jeff Young	2fd5f25c3c	Allow expand selection to work (even if you probably can't get there). ... I think the guessSelectionCandidates narrows down to a single item in 99.9% of cases, so we can probably remove this entirely. But for now it's safer just to fix it.	2021-02-24 14:12:32 +00:00
Wayne Stambaugh	1786ae8773	Eeschema: use symbol nomenclature for object file naming.	2021-02-24 08:48:02 -05:00
James Jackson	eee04f4482	Fix Bus Management UI flow on macOS ... Fixes https://gitlab.com/kicad/code/kicad/issues/7510	2021-02-24 01:32:29 +00:00
Seth Hillbrand	0518d9c546	Add more force-immediate tools	2021-02-23 17:05:03 -08:00
Seth Hillbrand	005622027f	Add component/footprint is always immediate ... When a user clicks on the "Add Component", "Add Power" or "Add Footprint" icon, they want to add the item. Requiring an extra click on the screen before selecting the component/footprint is not needed.	2021-02-23 16:15:31 -08:00
Jeff Young	7318417ca4	Fix typo in expand-selection-disambiguation menu logic. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7654	2021-02-23 22:09:00 +00:00
Jeff Young	7e2b0e63f1	Fix junction logic when splitting two wires.	2021-02-23 21:43:41 +00:00
Jeff Young	c0487e5c87	Don't leave the cursor position forced. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7665	2021-02-23 21:43:41 +00:00
jean-pierre charras	94bc373f30	PANEL_EESCHEMA_EDITING_OPTIONS: add info about left mouse click and modifiers. ... Similar to the existing info in Pcbnew editing options panel.	2021-02-23 20:40:22 +01:00
Jeff Young	8755f55956	Fix copy-paste error. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7674	2021-02-23 17:50:11 +00:00
Jeff Young	a9ea617069	Add some defensive code for double-moves. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7665 Fixes https://gitlab.com/kicad/code/kicad/issues/7502	2021-02-23 16:38:18 +00:00
Jeff Young	9eb2113a50	Make TwoClickPlace cursor handling match SingleClickPlace.	2021-02-23 15:28:45 +00:00
Jeff Young	e251cf067a	Formatting.	2021-02-23 14:34:06 +00:00
Jeff Young	d7b6d4a541	Warn user when placing a junction is just going to remove it again. ... Also removes a duplicate call to SaveCopyForRepeatItem (which has already been done in AddItemToScreenAndUndoList). Fixes https://gitlab.com/kicad/code/kicad/issues/7651	2021-02-23 12:51:15 +00:00
Jeff Young	b938df0e46	Coding policy.	2021-02-23 12:49:02 +00:00
Jeff Young	a3b9e8ddb4	Round 2 of Worksheet -> Drawing Sheet.	2021-02-23 11:57:44 +00:00
Seth Hillbrand	b484c0787b	Disable commands in SingleTop ... We cannot do forward/reverse annotation in Single Top mode because we depend on shared memory access. This disables the menu options in this case and replaces the toolbar update pcb icon with the import netlist, which is more appropriate for single top mode Fixes https://gitlab.com/kicad/code/kicad/issues/7637	2021-02-22 14:49:13 -08:00
Jeff Young	cad5198ab7	Worksheet -> (industry standard) Drawing Sheet.	2021-02-22 17:35:46 +00:00
Roberto Fernandez Bautista	ccbc0f73cc	CADSTAR Schematic Archive Importer: Fix Coordinate Rounding error ... Rewrite of the calculation to convert CADSTAR to KiCad coordinates, rounding half way cases away from zero. Use integer division instead of double, to ensure precision.	2021-02-22 13:24:00 +00:00
Roberto Fernandez Bautista	842a930ced	CADSTAR Schematic Archive Importer: Autoplace fields when adding sheet ... Makes the sheets look a little bit better when there is no block name in the original CADSTAR design.	2021-02-22 13:24:00 +00:00
Roberto Fernandez Bautista	7b5cf955af	CADSTAR Schematic Archive Importer: Visible fields to calculate BBOX ... - Ensures page size is calculated correctly	2021-02-22 13:24:00 +00:00
Roberto Fernandez Bautista	5acdf1ddb1	CADSTAR Schematic Archive Importer: Align to original grid ... Previous assumption of 100mil grid in CADSTAR schematic designs has been proven to be incorrect. Let's use the "working grid" in the original design instead.	2021-02-22 13:24:00 +00:00
Roberto Fernandez Bautista	c98106ebcf	CADSTAR Schematic Archive Importer: Parse TESTPOINT ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7574	2021-02-22 13:24:00 +00:00
Roberto Fernandez Bautista	09ebfcd650	CADSTAR Importer: Fix Code Style ... - Rename member variable names to use the 'm_' prefix - Rename a few object types that clashed with KiCad object names, such as BOARD and SCHEMATIC, to avoid the use of '::' to access the KiCad objects. - Remove some unused code.	2021-02-22 13:24:00 +00:00
Jeff Young	09d3667bce	Fix bone-headed mess up of two-click-place. ... Original architecture was to pass KICAD_T in to specify what kind of object you wanted. That didn't work well with things like cursor shape so it was moved to setting booleans based on the ACTION. When I cleared out the old KICAD_T stuff I missed one case where it was still used. That is now corrected as well. Fixes https://gitlab.com/kicad/code/kicad/issues/7651	2021-02-22 11:54:03 +00:00
Jon Evans	f1039dfb94	Disable project saving outside explicit save actions ... Fixes https://gitlab.com/kicad/code/kicad/-/issues/7589	2021-02-21 21:31:45 -05:00
Jeff Young	781d293b60	Add option for text updating to Update Symbol. ... Fixes https://gitlab.com/kicad/code/kicad/issues/6420	2021-02-22 00:36:40 +00:00
Jeff Young	afb4bbde47	Bug fixes to Eeschema context menu. ... 1) Fix typo in SingleSymbolOrPower 2) Remove Edit reference/value/footprint items for power symbols	2021-02-21 23:45:32 +00:00
Jeff Young	34d3218f73	Translation cleanup. ... Fixes https://gitlab.com/kicad/code/kicad/issues/6078	2021-02-21 23:13:13 +00:00
Jeff Young	2d28ed8eda	Move canvas backend selection to Preferences. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7630	2021-02-21 20:12:43 +00:00
Mikolaj Wielgus	f9c42585fb	Force immediate action for auto start wire feature ... Fixes https://gitlab.com/kicad/code/kicad/issues/7503	2021-02-21 18:43:34 +00:00
Jeff Young	18d4d517b0	Implement RMB Import Sheet Pin as a single-shot. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7638	2021-02-21 15:46:53 +00:00
Seth Hillbrand	8a12aa4e3a	Handle unit changes in the netlist ... Each symbol unit in eeschema has a unique identifier. But we don't have a unique identifier for the entire symbol. So changing which symbol instance was unit A (our default base for matching), changed the UUID that we were using to match the footprints. This commit adds all UUIDs to the netlist, allowing us to match symbol to footprint without worrying about which unit is referenced. This still does not handle changing different units on different sheets. Fixes https://gitlab.com/kicad/code/kicad/issues/7604	2021-02-20 20:11:49 -08:00
Marek Roszko	907e282347	Silence some msvc warnings ... - exception variables that were unused - RAYSEG2D improperly foward declared with class instead of struct - unused vars	2021-02-20 11:58:55 -05:00
Jeff Young	91e876ce0d	Make sure the title is updated when file is saved/reverted/etc. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7626	2021-02-20 15:09:47 +00:00
Jeff Young	881cb3182b	Move writable dir checking lower down. ... (Well, it was already lower down, this really just removes the higher up calls that were getting in the way.) Fixes https://gitlab.com/kicad/code/kicad/issues/5937	2021-02-19 22:24:08 +00:00
Jeff Young	5994ce3711	Be more aggressive about updating title to show dirty status. ... Fixes https://gitlab.com/kicad/code/kicad/issues/7613	2021-02-19 21:58:49 +00:00
Jeff Young	1a36971583	Remove higher-level write-protected check. It's now done lower down. ... Fixes https://gitlab.com/kicad/code/kicad/issues/5937	2021-02-19 21:46:06 +00:00
Jeff Young	26cb05051b	fixup! Whittle down library tree context menus to be more contextual.	2021-02-19 19:07:45 +00:00
Jeff Young	57e043e0e6	Don't allow moving markers. Do allow excluding them.	2021-02-19 19:07:45 +00:00
Jeff Young	c2f68ca4da	Whittle down library tree context menus to be more contextual. ... (From discussion on Zulip.)	2021-02-19 19:07:45 +00:00
James Jackson	48853d0c88	Eeschema: Allow auto-wiring / drawing from unconnected bus and graphic line endpoints ... Fixes https://gitlab.com/kicad/code/kicad/issues/7537	2021-02-19 17:15:27 +00:00
jean-pierre charras	9cc2781d55	typo	2021-02-19 10:35:25 +01:00
jean-pierre charras	d0ca01be22	DIALOG_EDIT_COMPONENTS_LIBID: do not replace fields by default. ... Values entered by the user will be lost and the schematic can be broken. This is especially true for generic components. Add also a tool tip for this option.	2021-02-19 09:37:53 +01:00
Seth Hillbrand	05b559c9dc	Quiet gcc warnings	2021-02-18 11:20:27 -08:00
Jeff Young	b43db7cd7d	Fix assert in Symbol Editor. ... Also allows some symbol lib operations when we know the context even if the library itself isn't selected. (For instance, select a symbol, copy, paste.)	2021-02-18 18:08:37 +00:00
Zoltan Gyarmati	0df1558e10	eeschema: update symbol fields when editing Symbol Library links ... Also making this behavior optional via a adding checkbox to the Edit Symbol Library Links dialog. Fixes: https://gitlab.com/kicad/code/kicad/issues/7010	2021-02-18 18:06:11 +00:00