haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
26,985 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

11619 Commits

Author SHA1 Message Date
Jeff Young b165ae6519 Fix note formatting issues. 
Also removes the "tip" icon which doesn't work on OSX and isn't as
important as the graphics which actually convey information.  Replaced
with the more generic "Note: " string.

Fixes https://gitlab.com/kicad/code/kicad/issues/7281
 2021-01-26 11:29:30 +00:00
Jeff Young 7d6c1c5ee6 Improve comments. 2021-01-26 10:56:19 +00:00
Jeff Young dca7e44455 Fix a missed Module -> Footprint. 2021-01-26 10:56:19 +00:00
Jon Evans b96bcc86b1 Don't restrict start item to same layer if snapping is enabled 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7276
 2021-01-25 21:19:26 -05:00
jean-pierre charras 96af236493 Code cleanup: remove include wx.h from pcb_plot_params.h. 
including wx.h is useless for this file, and include wx.h in a lot of other files.
Include wx.h must be made only when needed in a given file, because on Windows
it include some headers that frequently create collision with kicad declarations
 2021-01-25 16:18:46 +01:00
Michael Kavanagh d933a0a863 Use the pencil for Properties in Pcbnew 2021-01-25 14:21:23 +00:00
Michael Kavanagh eba09a59e9 Remove inappropriate icon 2021-01-25 14:21:22 +00:00
Jeff Young 09eb4b35c6 Make sure footprint edges get checked. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7267
 2021-01-25 13:20:16 +00:00
Jeff Young d40fe127aa Update pad locked status when adding footprints from schematic. 
Also fixes some latent bugs with not updating the local ratsnest
visibility in other places, and the netcode in update PCB from schematic.

Fixes https://gitlab.com/kicad/code/kicad/issues/7202
 2021-01-25 01:20:36 +00:00
Seth Hillbrand 5a9c0a9b5a Quiet a few coverity warnings 2021-01-24 14:53:18 -08:00
Seth Hillbrand 47d5900600 Fix build warnings 2021-01-24 11:37:48 -08:00
Mikolaj Wielgus 04cc64c008 Restore the old reference after rotation or flip instead of clearing 
After a rotation or flip the reference point has to be restored to the
previous value to prevent the dragged item from warping to the cursor.
Before this change, the reference point was only cleared, causing odd
behavior when a rotation or flip was performed.

Fixes https://gitlab.com/kicad/code/kicad/issues/7112
 2021-01-24 18:56:46 +00:00
Roberto Fernandez Bautista f353fc448b Fix edge cases in EDIT_TOOL::DragArcTrack 2021-01-24 16:41:11 +00:00
Roberto Fernandez Bautista 99d203feae Clarify CIRCLE::ConstructFromTanTanPt 
Remove unused bool aAlternateSolution and add doxygen comments
 2021-01-24 16:41:11 +00:00
Roberto Fernandez Bautista 48823c0723 Formatting fixes and fix qa_kimath following rebase 2021-01-24 16:41:10 +00:00
Roberto Fernandez Bautista 6e7ae93cc8 EDIT_TOOL::DragArcTrack Fix incorrect undo history when items are deleted 
Need to make sure we only apply one COMMIT operation per object before calling COMMIT::Push() or COMMIT::Revert()
 2021-01-24 16:41:10 +00:00
Roberto Fernandez Bautista 2b5c1bae97 CHANGED: Dragging a curved track starts an interactive resizing of it, keeping start an end points tangent 2021-01-24 16:41:10 +00:00
Jeff Young 25956152c6 Scan actual nets; not assumed nets. 
Specctra exporter should not assume that PCB nets are numbered
sequentially without any holes.

Fixes https://gitlab.com/kicad/code/kicad/issues/7249
 2021-01-23 22:55:03 +00:00
Jeff Young d5d9372839 Don't cancel dialog when esc-ing out of autocomplete. 2021-01-23 22:55:03 +00:00
jean-pierre charras 15cc368918 Gerber plotter: prepare optimization of aperture macros type free polygons. 
They are used for chamfered round rect pads, and can be used for custom shaped pads.
No actual change currently, but the shape rotation of custom pads and chamfered rr pads
can be now used in gerber plots.
 2021-01-23 21:15:27 +01:00
Jeff Young d8c7c8f700 Evaluate rules when fetching zone edge clearance. 2021-01-23 17:04:44 +00:00
Jeff Young 2d8cac658e Allow negative clearances to signal supression of DRC test. 2021-01-23 00:10:01 +00:00
Jeff Young 0ba0160da9 Add a PT_NIC pin electrical type and a netlist token for SCH_NO_CONNECT. 
ADDED a new pin electrical type "free" for internally unconnected pins.

CHANGED the "unconnected" pin electrical type is now represented by
"no_connect" in files and netlists.  (The legacy syntax is also accepted
in files.)
 2021-01-23 00:10:01 +00:00
Jeff Young f5e35af1a5 Transmit pin electrical types through to pads. 2021-01-23 00:10:01 +00:00
Jeff Young 9ac807bdd2 Freeze implicit footprint file version at last before explicit. 
We have been writing footprint versions for a while now, but we were
still interpreting the lack of a version as "current".  This changes
lack of a version to mean "last format before we started writing out
versions".

Fixes https://gitlab.com/kicad/code/kicad/issues/7143
 2021-01-23 00:10:01 +00:00
jean-pierre charras cbff706916 Update the .fpb file to be able to open it with wxFormBuilder 3.9, used by Kicad 2021-01-21 20:28:05 +01:00
Jeff Young 3fcd0860c1 Make 'E' go straight to Custom Track Width dialog. 
Also fixes some mouse capture issues.

Fixes https://gitlab.com/kicad/code/kicad/issues/7198
 2021-01-20 18:19:55 +00:00
qu1ck 07d4a28024 Improvements to pcbnew action plugins settings panel 
1. Add open plugins directory button (same as in tools menu)
2. Add show plugin errors button to help debug issues
 2021-01-20 09:09:53 +00:00
Roberto Fernandez Bautista 74aa081b8a Don't add board-only footprints to the netlist (fixes back-annotation issue) 2021-01-20 00:37:38 +00:00
Jeff Young 360953ba98 "comp" -> "symbol". 2021-01-19 23:50:40 +00:00
Jeff Young 0ded846130 Go back to previous arc midpoint editing routine. 
It avoids erratic behaviour near the chord or end-points.

Fixes https://gitlab.com/kicad/code/kicad/issues/7135
 2021-01-19 23:50:40 +00:00
Michael Kavanagh 80dbc24326 Icons: remove superfluous icon 
Remove icons where menu text gives context
 2021-01-19 22:57:25 +00:00
Michael Kavanagh ef2aa8a730 FP Editor: remember to update appearance manager 
Fixes https://gitlab.com/kicad/code/kicad/issues/6926
 2021-01-19 20:24:16 +00:00
Seth Hillbrand 060635b14c fabmaster: Fix graphic handling in geometry section 2021-01-19 12:16:40 -08:00
Jeff Young 35978adef9 Don't run dimension updates while parsing files. 
They mess up the geometry when only partial values are provided.

Fixes https://gitlab.com/kicad/code/kicad/issues/7177
 2021-01-19 16:09:44 +00:00
Jeff Young 25ff0fa662 Fix typo in unit label assignment and some minor layout improvements. 2021-01-19 16:09:44 +00:00
Jeff Young e9dc1824d6 Minor improvements to layout. 2021-01-19 16:09:44 +00:00
Jeff Young 06dec36625 Improve layout and terminology in PCBNew/FPEditor edit settings. 2021-01-19 13:16:26 +00:00
Jeff Young 1ac47c2ac6 Fix misleading tooltip. 2021-01-19 11:05:25 +00:00
Jeff Young 0a2a3c9903 Fix Coverity-discovered typo. 2021-01-19 10:57:07 +00:00
Jon Evans 330d717c69 Fix typo 2021-01-18 21:50:26 -05:00
Michael Kavanagh 7461b96dea Hide the selection tool submenu in the FP Editor 
Fixes https://gitlab.com/kicad/code/kicad/issues/7164
 2021-01-19 00:30:44 +00:00
Jeff Young 12fe44d4b3 Snap arc center *by* the grid, not *to* the grid. 
Also fixes a bug with editing an arc endpoint because the cursor pos
was being forced before the arc constraints stuff had been run (in
updateItem()).
 2021-01-19 00:26:31 +00:00
Seth Hillbrand b8dfcb34c4 Revert "Use less-sophisticated arc editing math." 
This reverts commit 3b424d3868.  And fixes
issue with rouding causing arc errors
 2021-01-18 12:44:27 -08:00
Ian McInerney 44655b98de Initialize variables properly 2021-01-18 18:35:10 +00:00
Ian McInerney d030d1667b Fix improper string creation in fabmaster importer 2021-01-18 18:35:10 +00:00
Jon Evans 1e33928b96 Fix issues with zone filling connectivity locking 
Two issues found with the locking system used to prevent access to
stale connectivity data during the zone fill process:

1) a std::mutex has undefined behavior if you try to use it to guard
against access from the same thread.  Because of the use of wx event
loops (and coroutines) it is entirely possible, and in some situations
inevitable, that the same thread will try to redraw the ratsnest in the
middle of zone refilling.

2) The mutex was only guarding the ZONE_FILLER::Fill method, but the callers
of that method also do connectivity updates as part of the COMMIT::Push.
Redrawing the ratsnest after the Fill but before the Push will result in
stale connectivity pointers to zone filled areas.

Fixed (1) by switching to a trivial spinlock implementation.  Spinlocks would
generally not be desirable if the contention for the connectivity data crossed
thread boundaries, but at the moment I believe it's guaranteed that the reads
and writes to connectivity that are guarded by this lock happen from the main
UI thread.  The writes are also quite rare compared to reads, and reads are
generally fast, so I'm not really worried about the UI thread spinning for any
real amount of time.

Fixed (2) by moving the locking location up to the call sites of
ZONE_FILLER::Fill.

This issue was quite difficult to reproduce, but I found a fairly reliable way:
It only happens (for me) on Windows, MSYS2 build, with wxWidgets 3.0
It also only happens if I restrict PcbNew to use 2 CPU cores.
With those conditions, I can reproduce the issue described in #6471 by
repeatedly editing a zone properties and changing its net.  The crash is
especially easy to trigger if you press some keys (such as 'e' for edit)
while the progress dialog is displayed.  It's easiest to do this in a debug
build as the slower KiCad is running, the bigger the window is to trigger this
bug.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6471
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7048
 2021-01-18 13:22:12 -05:00
Jeff Young 26bc29808a Clean up Text Properties dialog. 
It's no longer used for dimensions so doesn't need the line thickness
controls.

The spacing was a bit wonky.

Changed to disabling rather than hiding visibility checkbox.  The less
the GUI moves around the better.
 2021-01-18 15:20:15 +00:00
Jeff Young 4f399d4304 One more attempt to fix flipping geometry. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4480
 2021-01-18 15:20:15 +00:00
Michael Kavanagh 479487ceb1 Tidy up context menus a bit 
Try and put the common actions in the same places
 2021-01-17 22:42:03 +00:00
Jon Evans 6bb9aeab4b Position relative: store discarded pad for use as the selection anchor 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6996
 2021-01-17 14:25:52 -05:00
Jeff Young f1221a9ca3 Resolve text variables in title blocks for outputing to netlist. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7153
 2021-01-17 16:24:22 +00:00
Jon Evans 1754504234 Fabmaster: fix MSVC build 
std::map is not move-constructable on MSVC because
it is not declared noexcept (and is not required to be
by the standard)

This means that a struct containing graphic_element
cannot be inserted into a vector with move semantics without
compile errors.  However, wrapping it in a unique_ptr
works.
 2021-01-17 10:23:31 -05:00
Jeff Young 68efdb2fff Push shared parts of GRID_HELPERs into common. 2021-01-16 23:18:10 +00:00
Seth Hillbrand 950db6ff9c pcbnew: Add Fabmaster import 
Allows importing ASCII design output from OrCAD designs
 2021-01-16 14:28:33 -08:00
Jeff Young 3b424d3868 Use less-sophisticated arc editing math. 
While it doesn't do the tangent retention that the old version did,
this one I can at least make work.

Fixes https://gitlab.com/kicad/code/kicad/issues/7135
 2021-01-16 20:46:14 +00:00
Roberto Fernandez Bautista 00918c68f5 Don't do clever snapping logic when drawing a circle 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7131
 2021-01-16 08:39:20 +00:00
Jon Evans 38455c25ef Bring back consideration of world scale to PcbNew snapping 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7125
 2021-01-15 12:29:47 -05:00
Jeff Young 08d595c9bf Move title block fields to global availability in PCBNew. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7118
 2021-01-15 15:41:18 +00:00
Jeff Young 7dc2ca93cd Make sure we mark board-only-footprint nets as current. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6871
 2021-01-15 12:46:48 +00:00
Jon Evans 6cc39d8011 Don't allow moving locked pads with Position Relative dialog 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6996
 2021-01-14 22:14:00 -05:00
Jon Evans 0b7fc0e2d9 Update local ratsnest state when toggling appearance control 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7035
 2021-01-14 22:03:23 -05:00
Jeff Young 36508807e7 Give the pad placement tool a context menu. 
ADDED: allow pad properties to be edited while placing pads.

Fixes https://gitlab.com/kicad/code/kicad/issues/6953
 2021-01-15 00:52:03 +00:00
Jeff Young 965482bd7f Improve some tooltips. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7116
 2021-01-14 22:35:32 +00:00
Thomas Pointhuber 9f24ea0bb7 altium: fix non-copper pads. Roundrect pads were not filled and SetLocalCoord() does not transform polygons into the local coordinates, which is unexpected. 2021-01-14 22:21:05 +01:00
jean-pierre charras 54cf67dad2 Pcbnew, drill map: fix incorrect position of texts for small boards. 
Fixes #7111
https://gitlab.com/kicad/code/kicad/issues/7111
 2021-01-14 18:52:04 +01:00
Mikolaj Wielgus 0129c7ae52 Notify appearance panel when net is (un)hidden by board inspection tool 
Fixes https://gitlab.com/kicad/code/kicad/issues/7039
 2021-01-14 17:22:41 +00:00
Jeff Young 02ccd5fbdb Make sure properties commands don't go to other tools during routing. 
Brings up the track widths (or diff pairs) context menu instead,
which seems to be the closest parallel.

Fixes https://gitlab.com/kicad/code/kicad/issues/7099
 2021-01-14 15:19:09 +00:00
Jeff Young 3e920c665f Special case via area generation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7105
 2021-01-14 12:48:44 +00:00
Mikolaj Wielgus f0b11896da Clip the first segment in leaders 
Fixes https://gitlab.com/kicad/code/kicad/issues/6548
 2021-01-14 00:10:41 +00:00
Seth Hillbrand 13a4717aed Add center handles to rectangle edits 
Allows changing a single dimension at a time.  Matching the polygon edit
tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/7085
 2021-01-13 14:04:21 -08:00
Jeff Young ffdff21f45 Use a sloppier hittest for the collector as well as the actual hittest. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7079
 2021-01-13 21:22:24 +00:00
Seth Hillbrand e3e9bfc1b8 Fix compile error 2021-01-13 13:21:27 -08:00
Seth Hillbrand 605dcfbedf Fix Windows script location 
Windows has arbitrary installation locations, so reference relative to
the executable
 2021-01-13 13:11:26 -08:00
Seth Hillbrand b57ad4b2f9 Correct SWIG path 
Don't offset from executable, this is an absolute path

Fixes https://gitlab.com/kicad/code/kicad/issues/7089
 2021-01-13 12:34:04 -08:00
Jeff Young da4b269783 Make sure pad local clearances get in to m_worstClearance. 2021-01-13 12:37:20 +00:00
Jeff Young 0bce280424 Make sure design rules get recompiled after netclass changes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7082
 2021-01-13 12:37:20 +00:00
Jon Evans d2d4ffe6d0 Dismiss infobar if it's dismissable on board save 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7071
 2021-01-12 23:24:13 -05:00
Barabas Raffai 5931a39c0f Fix layer preset overwriting ratsnest settings 
Fixes https://gitlab.com/kicad/code/kicad/issues/6975
 2021-01-13 01:22:30 +00:00
Seth Hillbrand 6ed2a831d8 Don't override the router tool with drag actions 
Before processing the select tool actions, we check if the router is
currently active and if it is, pass the event for processing in other
tools

Fixes https://gitlab.com/kicad/code/kicad/issues/7021
 2021-01-12 15:44:20 -08:00
Dominik Wernberger ad97fabfd3 Add missing const to Matches 2021-01-12 20:51:32 +00:00
Dominik Wernberger dc02ec9758 Remove a few const_cast 2021-01-12 20:51:31 +00:00
Dominik Wernberger 07635d2fc7 Minor adjustments 2021-01-12 20:51:31 +00:00
Dominik Wernberger ac94d72d2d Add more const specifiers 2021-01-12 20:51:31 +00:00
Dominik Wernberger ec0af24f13 Make wxFindReplaceData argument const 2021-01-12 20:51:31 +00:00
jean-pierre charras 76cc7b98a7 Fp editor, DIALOG_PAD_PROPERTIES: do not disable posX and posY settings. 
When a pad is locked,  posX and posY settings in DIALOG_PAD_PROPERTIES must
be locked only for the board editor, not in the fp editor.
 2021-01-12 20:33:52 +01:00
Seth Hillbrand 2cb8dff650 Use KICAD_DATA for data path lookup in scripting 
Fixes https://gitlab.com/kicad/code/kicad/issues/7036
 2021-01-12 08:22:17 -08:00
Konstantin Baranovskiy cd2c46e5c9 Make "... file is read only." warnings translatable. 2021-01-12 14:33:35 +00:00
Jeff Young beab68db13 Fix bone-headed error in rules optimization. 2021-01-12 12:46:51 +00:00
jean-pierre charras d4c36230d2 Pcbnew, Graphic items: show the locked status in msg panel and dialog properties. 2021-01-12 10:00:21 +01:00
Jon Evans 01181ccb2f Make sure project is unlinked before deleting it 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7038
 2021-01-11 22:17:13 -05:00
Michael Kavanagh a00b9cc821 Icons: general tweaks and pixel alignment 
+ minor rename
+ fix missing bitmap in DRC panel
 2021-01-11 23:31:25 +00:00
Michael Kavanagh dc83cb7a41 Icons: general tweaks and pixel alignment 
+ remove some unused icons
 2021-01-11 23:31:25 +00:00
Michael Kavanagh 32f7f30958 Icons: remove where they don't make sense 
Also avoid icon reuse
 2021-01-11 23:31:25 +00:00
Michael Kavanagh 8fba0c257b Icons: remove more inconsistencies around Select 
Missed from 5d9b2d3fea
 2021-01-11 23:31:24 +00:00
Seth Hillbrand 740df93808 Don't dereference board groups in fp editor 
The Footprint editor group resolution should stop at the footprint level
to avoid breaking into groups that cannot be accessed.

Fixes https://gitlab.com/kicad/code/kicad/issues/7049
 2021-01-11 14:58:33 -08:00
Jeff Young 63e2046eb0 Performance improvements for DRC rules. 2021-01-11 22:09:36 +00:00
Jeff Young 50889a9ed6 Promote mouse drag settings to full enums. 2021-01-11 22:09:36 +00:00
Seth Hillbrand c09dc5abdd Prevent locking items in footprint editor 
Adding footprints to the board now has a preference for whether we want
pads locked or unlocked by default
 2021-01-11 11:23:26 -08:00
jean-pierre charras 1b755bbc37 Fix issues in ConvertOutlineToPolygon() related to S_POLYGON PCV_SHAPE 
Fixes #7046
https://gitlab.com/kicad/code/kicad/issues/7046
 2021-01-11 17:05:44 +01:00
Jeff Young a4d417f5c0 Get rid of "drill" terminology when talking about finish hole size. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7044
 2021-01-11 13:49:43 +00:00
RigoLigoRLC 493a784b62 Fix Pcbnew search "not found" prompt not displayed 
Before this, "Searching..." prompt will not go away if nothing was found
in a search session. A bug I noticed while working on !611. After this
fix, "foo not found" will be displayed when Pcbnew cannot find the
given text.
 2021-01-11 13:48:20 +00:00
RigoLigoRLC dd328d230b Make Pcbnew search about zone names, fixes #6951 
I put zones in "other text items" category of searching as I thought it
would be the appropriate one.

Fixes https://gitlab.com/kicad/code/kicad/issues/6951
 2021-01-11 13:48:20 +00:00
Wayne Stambaugh 1eee72ec65 Fix library tree behavior when duplicate project table entry is disabled. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5438
 2021-01-11 07:46:07 -05:00
Jeff Young 6c648df4c6 Support 3 drag vs. select options, and unifiy with other drag prefs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5493
 2021-01-11 11:50:14 +00:00
Jeff Young 7134ff2da6 Try a different arrangement of Board Setup pages. 2021-01-11 11:50:14 +00:00
Jeff Young 9ce6c2be80 Group global editors under tools menu. 
Also improves some terminology in Remove Unused Pads.
 2021-01-11 11:50:14 +00:00
Seth Hillbrand 8ee324b1a9 Add bezier output to VRML 2021-01-10 11:28:15 -08:00
jean-pierre charras 067b94c410 DRC: Fix a incorrect message and marker position when testing dangling vias. 
Commit 6ffb721 detects vias connected on only one layer.
But the DRC diag (marker position and error message) were not correctly initialized
for this new test.
 2021-01-10 10:21:24 +01:00
Marek Roszko 828ecb76aa Remove polyline 3d check added by previous fixes 
Fix #7030
 2021-01-09 18:56:35 -05:00
Seth Hillbrand 4f6134b60d Check for CCW polys 
Use rectangles for 4-sided polygons that are rectangular regardless if
they are CW or CCW oriented
 2021-01-09 13:05:58 -08:00
Seth Hillbrand 8036303f8f Add margin to both sides to avoid drawing 0-poly 
We cannot draw degenerate polygons, so we need to test for 0-size shapes
especially after scaling the mask.  The mask adjustment is from both
sides however, so it needs to be doubled.

Fixes https://gitlab.com/kicad/code/kicad/issues/7020
 2021-01-09 13:05:58 -08:00
Jeff Young ed7b3373d1 Disentangle copper- and board-edge-clearances in Clearance Resolution... 
Fixes https://gitlab.com/kicad/code/kicad/issues/6983
 2021-01-09 16:44:03 +00:00
jean-pierre charras 08b93bd5ba FOOTPRINT::GetBoundingHull(): avoid returning a empty hull SHAPE_POLY_SET, 
when a footprint contains only texts.
empty SHAPE_POLY_SET creates most of time issues (crashes for instance) when
containing no data.
Ensure the returned SHAPE_POLY_SET contains a minimal hull (a 0.04 mm square)
Fixes #7026
https://gitlab.com/kicad/code/kicad/issues/7026
 2021-01-09 16:53:32 +01:00
jean-pierre charras daae68a6b8 French translation update. 
Fix also a typo in 2 I18n strings.
 2021-01-09 14:54:43 +01:00
Jeff Young 5ae6f93af8 A groups children may also have children. 
For instance, it could be a nested group or a footprint.

Fixes https://gitlab.com/kicad/code/kicad/issues/7025
 2021-01-09 13:47:24 +00:00
Jeff Young 78dcfb2392 Honour locks inside groups. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6841
 2021-01-09 13:47:24 +00:00
Jeff Young 7716f20a5b Disentagle board edges from graphics in global delete. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7024
 2021-01-09 13:47:24 +00:00
Jeff Young e4f29d358c Formatting. 2021-01-09 13:47:24 +00:00
Seth Hillbrand cf2dd0bd38 Fix edit_tool pad handling 
Check for footprint editor
Promote pad edits to footprint edits iff
 - Pad is locked
 - Footprint is not

Otherwise, handle the pad normally and prompt for locked items if found
 2021-01-08 19:46:14 -08:00
Seth Hillbrand 1c9d8a9f4c Don't warn on locked conversion 2021-01-08 16:49:47 -08:00
Seth Hillbrand 51f02ecc51 Fix alignment tool with locked footprints 2021-01-08 13:58:26 -08:00
Seth Hillbrand 721155165d Don't move locked footprint if pads are locked 2021-01-08 13:58:26 -08:00
Jon Evans d6448ce6b4 Expose settings manager to python 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6989
 2021-01-08 16:47:20 -05:00
Jeff Young d0af4e9f9d Save a cancel value when asked if it's not being used to cancel. 
Many, many KIDIALOGs use OK/Cancel and then rename both buttons to
confirm or deny some action.  In those cases we *do* want to store
the deny actions if they check "Do Not Show Again".

Fixes https://gitlab.com/kicad/code/kicad/issues/6979
 2021-01-08 21:32:19 +00:00
Jeff Young 8fffb75347 Allow custom pads with 0-sized anchor pads. 
(Surprisingly we used to in 5.1, so this is a regression.)

Also had to go back to the nag dialog as on a small screen the infobar
comes up behind the dialog.  A lot of the errors have also been turned
into warnings, so the overall effect should still be to reduce nagging.

Fixes https://gitlab.com/kicad/code/kicad/issues/6992
 2021-01-08 20:43:02 +00:00
Jeff Young 3467e643e5 Move pad locking from footprint to pads. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6997
 2021-01-08 20:43:02 +00:00
Seth Hillbrand 6ffb72159a Remove vias if they only connect to single layer 
A via takes up zone space on additional layers, so if we are not
connecting to those layers, then we should remove it.

Fixes https://gitlab.com/kicad/code/kicad/issues/7004
 2021-01-08 09:39:43 -08:00
Seth Hillbrand 1e96374715 Consider tracks and vias together 
Dangling tracks and vias affect each other and need to be considered at
the same time in order to fully remove the dangling segments
 2021-01-08 09:35:58 -08:00
jean-pierre charras 93d203aef7 Fix a I18n issue: a string flagged as translatable cannot be empty. 2021-01-08 18:16:00 +01:00
Seth Hillbrand 9424d66d22 Move footprint when selecting locked pad 
Prompting to unlock is obtrusive and blocks the common action of
dragging from a pad to align footprints.  The less common action of
editing pads in layout can be accomplished after unlocking the pads

Fixes https://gitlab.com/kicad/code/kicad/issues/6997
 2021-01-07 19:46:06 -08:00
Jon Evans 24435df6b0 Don't update 3D view on cursor movement 
Our rendering pipeline is not set up for this kind of speed,
and this is a blocking operation at the moment.

Note that we will get an update at the end of the move
because OnModify does it.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6819
 2021-01-07 20:43:14 -05:00
Jon Evans 61bddd0928 LAYER_PADS_TH is not a dependent layer 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6999
 2021-01-07 20:12:31 -05:00
Jon Evans 111fa99f9f PNS: Use last-segment posture optimization always 
Also when auto-posture is enabled, don't flutter
until area threshold has been met.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6935
 2021-01-07 20:12:31 -05:00
Jeff Young 3fd128a75b Performance enhancements. 2021-01-08 00:46:55 +00:00
Jon Evans 5c22ffe422 Don't try to load a nonexistent layer setting 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6998
 2021-01-07 19:09:54 -05:00
jean-pierre charras bf332b3189 Fix minor compil warnings 2021-01-07 20:55:24 +01:00
Jeff Young 01fe3b91e9 Implement locking for graphic shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6972
 2021-01-07 17:39:18 +00:00
hoijui 6ca9a42251 Removes 3 other instances of a potential encoding problem 
Signed-off-by: hoijui <hoijui.quaero@gmail.com>
 2021-01-07 17:36:49 +00:00
Jeff Young 8c8516b7b1 Remove formbuild URL from hypertext links. 
Also adds a tooltip.

Fixes https://gitlab.com/kicad/code/kicad/issues/6982
 2021-01-07 15:12:19 +00:00
Jeff Young e41c06304b Don't show a leading ratline to a NPTH. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6960
 2021-01-07 12:25:04 +00:00
Jeff Young f702b64b8d Minor improvements to formatting & SNR. 2021-01-07 12:25:04 +00:00
Marek Roszko 84dd78e01d Fix the install location for vcpkg built python modules 2021-01-07 00:08:11 -05:00
Seth Hillbrand 52f822dedb Remember autotrack width setting 
Fixes https://gitlab.com/kicad/code/kicad/issues/6971
 2021-01-06 20:11:32 -08:00
Jon Evans 0234b7278a PNS: Make DIRECTION_45 North be up everywhere 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6935
 2021-01-06 21:47:06 -05:00
Jeff Young ad8136541b Improve layout and terminology of Remove Unused Pads. 
Also removes the limitation of removing outside layers for pads.
It's already supported in Pad Properties so it's odd to not support
it here.
 2021-01-07 01:27:12 +00:00
Jeff Young f372c8025b Better sizing for some conditional dialogs. 
These dialogs don't have growable features but do have conditional
features, so the size is better adjusted automatically by the code
then by the user.
 2021-01-07 01:27:12 +00:00
Seth Hillbrand 43e7b1ab6e Set icons for front/back assembly layers 2021-01-06 13:49:00 -08:00
Seth Hillbrand c0f940438a Clarify Flip action 
Fixes https://gitlab.com/kicad/code/kicad/issues/6954
 2021-01-06 13:02:44 -08:00
Jeff Young 2a088e5c7b Add conversion of circles to zones and enable in footprint editor. 
Also rule areas, of course.

Fixes https://gitlab.com/kicad/code/kicad/issues/6966
 2021-01-06 17:21:49 +00:00
Jeff Young 70967bfebd Hierarchical menu parents don't get ...'s. 
Also moves the Convert menu up a level.  Nested hierarchical menus
should be avoided whenever possible.
 2021-01-06 17:21:49 +00:00
Jeff Young 8aeaaf99ef Disable net selector for non-free vias. 
Also moves the checkbox up so this relationship is clearer.

Fixes https://gitlab.com/kicad/code/kicad/issues/6967
 2021-01-06 15:49:12 +00:00
Jeff Young 366c7096b3 More double- and triple-pointer erradication. 2021-01-06 14:37:38 +00:00
Jeff Young 426536c381 Don't show empty-net synthetic net in Net Inspector. 
Also fixes an assert when deleting a net inspector row with no
parent row.

Fixes https://gitlab.com/kicad/code/kicad/issues/6962
 2021-01-06 14:27:02 +00:00
Jon Evans 46c4727783 Make MSVC happy again 2021-01-05 20:56:37 -05:00
Michael Kavanagh 2a24886d47 Icons: remove more duplicates 2021-01-06 00:35:20 +00:00
Michael Kavanagh 6fd718fbd8 Icons: replace old with new 2021-01-06 00:35:20 +00:00
Michael Kavanagh 5d9b2d3fea Icons: new filter icon 
+ remove icons where they don't make sense.
 2021-01-06 00:35:20 +00:00
Michael Kavanagh 54724096ea Icons: consistency between Eeschema and Pcbnew 2021-01-06 00:35:20 +00:00
Seth Hillbrand fd04a176a4 Remove full path from drill report 
Leaves just file name in place.  Full paths are considered a security
risk for some

Fixes https://gitlab.com/kicad/code/kicad/issues/6949
 2021-01-05 16:22:08 -08:00
Seth Hillbrand 71a93c71f7 Prevent footprint editor snapping to footprint 
Inside the footprint editor, we only want snap points from the base
elements

Fixes https://gitlab.com/kicad/code/kicad/issues/6948
 2021-01-05 16:08:30 -08:00
Jon Evans e7b047660c PNS: Correctly assemble lines with reversed arcs 2021-01-05 17:57:21 -05:00
Jon Evans feda03f69b PNS: Fix arc orientation when assembling lines with backwards arcs 2021-01-05 17:57:21 -05:00
Jon Evans 7431d5c985 PNS: First pass at updating meander placers for arcs 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6464
 2021-01-05 17:57:21 -05:00
Jon Evans 8619086cf2 PNS: re-enable optimization of colinear segs in lines with arcs 2021-01-05 17:57:21 -05:00
Jon Evans 8901e71fc8 PNS: Fix loop removal, make walkaround less broken for arcs 2021-01-05 17:57:21 -05:00
Zoltan Gyarmati 5676117d0b Make small drill marks size configurable via advanced config for both printing and plotting 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1972
 2021-01-05 22:37:34 +00:00
Jeff Young 81aa91ce2a Run insideCouryard on all matching footprints, not just the first. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6945
 2021-01-05 22:22:25 +00:00
Seth Hillbrand 4710b709d9 Only darken, don't hide vias unless requested 
Fixes https://gitlab.com/kicad/code/kicad/issues/6912
 2021-01-05 14:00:15 -08:00
Jeff Young a9d4d9d7f0 Modify insideArea() to return true for zones only when fully inside. 
Intersections is enough for other objects.
This is also a bit of a DRC performance improvement.

Fixes https://gitlab.com/kicad/code/kicad/issues/6934
 2021-01-05 21:43:04 +00:00
Jeff Young 02cd8c99cd Better error messages when routing can't be started. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6541
 2021-01-05 18:47:58 +00:00
Seth Hillbrand b19ccd819e Quiet compile warning 2021-01-05 09:16:38 -08:00
Jeff Young 88d42724e6 Remove diff-pair-gap handling from single-line-router. 
We can't really support it until we do min/max/opt shoving and
dragging.

Fixes https://gitlab.com/kicad/code/kicad/issues/6932
 2021-01-05 16:54:52 +00:00
Jeff Young d975f2f6aa Commenting and naming for clarity. 2021-01-05 16:54:52 +00:00
Jeff Young a48f0d21f7 More consistency in clearance resolution messages. 2021-01-05 16:54:52 +00:00
Jeff Young f7b20611c1 Enforce hole-to-hole min when placing diffpair vias. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6931
 2021-01-05 00:26:49 +00:00
Jeff Young 93bd2171ab Formatting. 2021-01-05 00:26:49 +00:00
Michael Kavanagh b40e3a39f5 Minor cleanup. 2021-01-04 23:59:36 +00:00
Jeff Young d24b034cbc Cleanup (and a minor performance improvement). 2021-01-04 22:32:29 +00:00
Jeff Glass 597a74af9a Corrects text of orthogonal dimensions 
The 'outisde' position is now 'outside' in all orientations

Fixes https://gitlab.com/kicad/code/kicad/-/issues/5821
 2021-01-04 19:53:39 +00:00
Jeff Young 2ea6bc5529 Formatting. 2021-01-04 19:19:55 +00:00
Jeff Young 648c42f643 Show collisions preventing routing from starting. 
Also introduces a callback to the infobar so that the view can be
cleaned up when the timer expires.

Fixes https://gitlab.com/kicad/code/kicad/issues/6930
 2021-01-04 19:19:55 +00:00
Jeff Young 354d9b4e63 Simplify layer pair indicator icon. 
It now just has top layer / bottom layer from the router's layer
pair.  The current layer is visible in the drop-down just to the
left, and the via stuff was confusing anyway.
 2021-01-04 19:19:55 +00:00
Jon Evans 5c8927678a Don't link a project to a board more than once 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6929
 2021-01-04 13:23:19 -05:00
Michael Kavanagh 76cfd19621 Icons: fix incorrect icon in footprint browser 2021-01-04 01:44:02 +00:00
Jeff Young c09d3b765a Slight improvement to error text for when drill is same size as pad. 2021-01-04 00:03:21 +00:00
Jeff Young 33aa6edb01 Don't run clearance tests on unflashed NPTH pad layers. 2021-01-04 00:03:21 +00:00
Jeff Young d0b82ea26e Show better descriptions of through-hole pads. 2021-01-04 00:03:21 +00:00
Jeff Young 7378c2c3b3 Implement max hole size DRC checks. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6893
 2021-01-04 00:03:21 +00:00
Jeff Young 71215bcab3 Make sure TH pads get collision layer highlighted. 
Also cleans it up to centralise all the decision-making.

Fixes https://gitlab.com/kicad/code/kicad/issues/6925
 2021-01-03 21:16:09 +00:00
Jeff Young 491fc2c8f2 Save DXF plot params to file and remove some dead code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6720
 2021-01-03 14:22:25 +00:00
jean-pierre charras a1d7a959f7 more fixes and enhancements in DIALOG_EXPORT_STEP. 2021-01-03 11:38:09 +01:00
jean-pierre charras 5db75805bd Step exporter: better values for min distance between 2 points to merge them. 
- The default value is 0.01 mm (according to comments and similar to the 3D viewer
 settings that uses 0.02 mm)
- The export dialog  has now 3 values 1 micron, 0.01mm (default) and 0.1 mm
The 0.1 micron option is removed: it makes no sense for a mechanical tolerance.
 2021-01-03 11:01:03 +01:00
Jon Evans f01297fedd Convert an annoying message box to an infobar 2021-01-02 22:14:10 -05:00
Michael Kavanagh 154e19b6e7 Icons: use common prefix for small 16x16 2021-01-02 23:16:33 +00:00
Michael Kavanagh 5a3f4f52df Icons: add new icon for Pcbnew 'Special Tools...' 2021-01-02 23:16:33 +00:00
Michael Kavanagh 6d3c1c7716 Icons: remove unused sources/duplicates + rename 2021-01-02 23:16:33 +00:00
Carlo Bramini a06387fafd Fix warning at compile time 2021-01-02 22:42:16 +00:00
Jeff Young f691828c8f Nullptr safety. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6862
 2021-01-02 22:26:12 +00:00
Jon Evans 7e58f1aa9f Fix display of pads in high contrast mode 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6912
 2021-01-02 14:16:17 -05:00
Jeff Young 8b849b1c49 Fix several bugs in hull push-back with vias. 
1) take hole plating thickness into account
2) build hulls specifically for via so pushing back to the hull doesn't
have to try and figure out how much extra to push back for the via
and/or hole
3) clear MK_HOLE flags when colliding with the pad itself so that we
don't get stuck in HOLE mode
4) move flag setting/clearing to updateNearest() so that it will keep
track of the state of the nearest collision

Fixes https://gitlab.com/kicad/code/kicad/issues/6913
 2021-01-02 19:14:44 +00:00
Jeff Young 13094fdc28 Formatting. 2021-01-02 18:38:17 +00:00
Jeff Young 85e42890c4 Distinction between via and via hole probably not useful. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6913
 2021-01-02 16:41:09 +00:00
Jeff Young 068af7d328 When routing don't give NPTH holes a copper clearance. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6903
 2021-01-02 16:33:51 +00:00
Jeff Young b5e7611696 Don't cross-pollute CONSTRAINTs. 
If you want the HOLE_CLEARANCE, then ask for it.
 2021-01-02 16:33:51 +00:00
Jon Evans eba7cb222c PNS: Fix initial posture guess for pads 2021-01-02 10:32:15 -05:00
Jeff Young 6b6694f55f Fix typo. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6913
 2021-01-02 15:04:30 +00:00
Jeff Young 42c114f6ed Record status of via dragging in Walkaround mode. 
Fixes https://gitlab.com/kicad/code/kicad/issues/3967
 2021-01-02 00:31:02 +00:00
Jeff Young 419d8dcd6f Minor cleanup. 2021-01-01 23:42:44 +00:00
Jeff Young 8a049cf290 Make sure bounding boxes get cached on rule areas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6898
 2021-01-01 23:17:49 +00:00
Jeff Young 018c17399d SNR. 2021-01-01 23:17:49 +00:00
Jeff Young 8ee72853fb Be more targetted on when we load DRC Rules for better performance. 2021-01-01 23:17:49 +00:00
Seth Hillbrand a69a4be853 Fix build error with icon names 2021-01-01 13:13:33 -08:00
Seth Hillbrand 72c27b2e33 Make expand selection stop at vias 
During the first expansion, we are supposed to stop at vias and branches
(where three track ends connect).  This needs to account for the number
of vias and tracks not just tracks
 2021-01-01 09:31:44 -08:00
Jeff Young fc1b0ec11f Improve feedback when routing in highlight collisions mode. 
In particular, when Allow DRC violations is NOT turned on and we
bump in to an obstacle.
 2021-01-01 17:25:37 +00:00
Seth Hillbrand 8de9cff4e0 Change environmental variables to human-readable 
Versions specific variables that may point to objects that change
through versions, allowing multiple KiCad versions to operate correctly
(even on MSW) on the same machine.
 2021-01-01 16:20:35 +00:00
jean-pierre charras 6a81113c2d Better comments in files related to my previous commit. 2021-01-01 17:09:32 +01:00
jean-pierre charras 93e186f53e SelectFootprintFromLibTree(): fix a issue similar to commit 27d47743. 
Force immediate deletion of the APP_PROGRESS_DIALOG (do not use Destroy() )
because on Windows, APP_PROGRESS_DIALOG has some side effects on the event loop
manager. A side effect is the call of ShowModal() or ShowQuasiModal of a dialog
following the use of a APP_PROGRESS_DIALOG (if not deleted) has a broken behavior
(incorrect modal/quasi modal behavior).
 2021-01-01 15:59:15 +01:00
Seth Hillbrand f8f34982c0 Escape PCB text 
Also keep a fail-safe for unescaping strings that are not previously
escaped

Fixes https://gitlab.com/kicad/code/kicad/issues/6901
 2020-12-31 17:17:27 -08:00
Jeff Young 3ba17e0a16 Formatting. 2021-01-01 01:02:06 +00:00
Jeff Young ecc0e861d3 Implement hole clearance and hole-to-hole clearance in router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6882
 2021-01-01 00:31:36 +00:00
Jeff Young 5d8e6020d1 Improve clarity. 2021-01-01 00:31:36 +00:00
Jeff Young 0e3c9de684 Formatting. 2021-01-01 00:31:36 +00:00
Jeff Young e060ee2a53 Factor in all clearance types when asking for worst clearance. 2021-01-01 00:31:36 +00:00
Jeff Young 1b93663627 Formatting. 2021-01-01 00:31:36 +00:00
Jon Evans 9a0f685a75 PNS: Consider arcs when searching for lines between joints 2020-12-31 13:05:43 -05:00
Jon Evans 73248ab219 PNS: correct initial segment direction for posture solver 2020-12-31 13:05:43 -05:00
jean-pierre charras 381aabdd2a PCB_TARGET: add missing GetMsgPanelInfo() virtual function. 2020-12-31 15:46:58 +01:00
jean-pierre charras a6a2dae480 Footprint editor: ensure the pad editor is closed before load a new footprint. 
When editing a new footprint from the board editor, if the Footprint editor has the pad editor
open, there is a risk of crash when replacing the footprint in edit.

Fixes #6892
https://gitlab.com/kicad/code/kicad/issues/6892
 2020-12-31 10:53:14 +01:00
Seth Hillbrand 82e728dbf6 Remove drawing of annular rings in high contrast 
High contrast should not show the annular rings from other layers.  Once
the ring is removed, we hide the annular when not focused on a flashed
layer

Fixes https://gitlab.com/kicad/code/kicad/issues/6896
 2020-12-30 17:38:30 -08:00
Jon Evans 60fd7fdbb2 Fix comment 2020-12-30 18:52:56 -05:00
Jon Evans 510db66f0e PNS: Fix rollback for arc traces 
PNS: Update posture solver after rollback
 2020-12-30 18:23:24 -05:00
Jon Evans 6105ac50da ADDED: Default hotkey of CTRL+/ for switch corner rounding 2020-12-30 18:23:24 -05:00
Jon Evans b5b64a55ad PNS: Only run optimization if lastNode is valid 2020-12-30 18:23:24 -05:00
Jon Evans 79502a0d88 PNS: A new approach to arc placement 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6334
 2020-12-30 18:23:24 -05:00
Allan Nordhøy 8d81abb57a Consistent use of spaces in strings. 2020-12-30 22:57:50 +00:00
Seth Hillbrand 5a3e5781bf Allow polygon drawing on edge cuts and courtyard 
Prevents line splitting behavior needed in v5 when drawing polygons on
courtyards. Also provide property dialog with some smarts to handle
special layers

Fixes https://gitlab.com/kicad/code/kicad/issues/6900
 2020-12-30 14:10:30 -08:00
Roberto Fernandez Bautista b168b74919 CADSTAR Archive Importer: Fix position of multiline text with NO_ALIGNMENT in CADSTAR 2020-12-30 18:53:43 +00:00
Roberto Fernandez Bautista ffee24be63 CADSTAR PCB Archive Importer: Rewrite loadBoardStackup routine 
Uses BOARD_STACKUP::BuildDefaultStackupList instead of trying to build the stackup from scratch
Fixes several asserts / incorrect stackups in some older boards
 2020-12-30 18:53:43 +00:00
Roberto Fernandez Bautista a2cbbb963e CADSTAR PCB Archive Loader: Correctly handle Dimension text 
Do not parse fields in dimension text to allow splitting it into prefix and suffix
 2020-12-30 18:53:43 +00:00
Roberto Fernandez Bautista f74a86b7e1 Add missing dimension objects to BOARD::Move collector 
Fixes import of orthogonal dimensions
 2020-12-30 18:53:43 +00:00
Roberto Fernandez Bautista 45b621a3d1 CADSTAR PCB Archive Importer: Fix Import of Linear Dimensions (Angular dimensions not supported) 2020-12-30 18:53:43 +00:00
Roberto Fernandez Bautista fbac766254 CADSTAR PCB Archive Importer: Refactor layer mapping and fix assert 
An assert was being fired to due to incorrect BOARD_STACKUP_ITEM_TYPE on some boards
 2020-12-30 18:53:43 +00:00
Roberto Fernandez Bautista 0a1045300b CADSTAR PCB Archive Importer: Fix loading of net class settings 2020-12-30 18:53:43 +00:00
Roberto Fernandez Bautista cde433c82e CADSTAR PCB Archive Importer: Transfer Project to allow importing of Text Variables 2020-12-30 18:53:43 +00:00
Roberto Fernandez Bautista 03a23db4f7 CADSTAR PCB Archive Importer: Load PCB Text Variables to KiCad project 2020-12-30 18:53:42 +00:00
Roberto Fernandez Bautista 9ed4780fec CADSTAR Archive Importer: Change architecture to Parse CADSTAR fields and store them in a static map 
Architecture of the parser changed to have a shared PARSER_CONTEXT between all the individual parsers.
Parses CADSTAR fields such as <@DESIGN_TITLE@> or <@SHEET_NUMBER@> and replaces with an equivalent KiCad Text Variable.
 2020-12-30 18:53:42 +00:00
Jon Evans bf9501e1d4 PNS: Fix auto-posture when placing via 2020-12-29 21:14:36 -05:00
Jon Evans 689da3794d PNS: Merge co-linear segments during placement 2020-12-29 21:14:36 -05:00
Jon Evans 4c0aa6db1a PNS: Disable smart pads optimization for vias 
There is not much point with the current algorithm and it
breaks auto-posture.
 2020-12-29 21:14:36 -05:00
PJM 94bf88d820 Pcbnew: Prevent selections jumping when dragged after flip or rotate 
CHANGED: If you flip or rotate an item or selection of items, move
the mouse, press 'M' and start moving the mouse, the selection jumps
to where the mouse is.  This MR fixes that so it doesn't happen.

This bug was reported against the 5.1.x branch but also affects the
5.99 branch.  This MR is for the 5.99 branch.

Fixes https://gitlab.com/kicad/code/kicad/issues/4069
 2020-12-30 01:02:04 +00:00
Jon Evans 0b0af2f545 Fix layer ordering of pad net names 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6881
 2020-12-29 18:31:44 -05:00
Jon Evans a637f310d0 Store zone display mode in project local settings 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6886
 2020-12-29 17:19:01 -05:00
Jon Evans 23f81412c3 Ensure connectivity is updated before filling zones 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6844
(maybe)
 2020-12-29 14:58:45 -05:00
Jon Evans 241823647b DRC: Fix a minor memory leak 2020-12-29 14:58:45 -05:00
Jon Evans bc712a7383 Remove some stray printfs 2020-12-29 14:58:45 -05:00
Jon Evans 76e8c62269 PCB_VIEW: Fix a few ASAN issues 2020-12-29 14:58:45 -05:00
Jeff Young 35a5781f68 Don't look at project layer visibilities for footprint editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6873
 2020-12-29 17:03:43 +00:00
Jeff Young 97a99beef5 Fix missing ENUM_TO_WXANY decl. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6879
 2020-12-29 14:37:03 +00:00
Jeff Young efd16dca66 Fix a bunch of issues with group selection and highlighting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6686
 2020-12-29 12:41:24 +00:00
Jeff Young f7a6dc26e9 Give GROUP_PROPERTIES_DIALOG its own files. 2020-12-29 12:41:24 +00:00
Jon Evans 81d4e06f00 PNS: Consider pad orientation when routing 
PNS: Skip smart pads when posture was manually forced

This allows a more-correct pad breakout to be chosen when
smart pads is off.
 2020-12-29 01:06:46 -05:00
Jon Evans 96d49d1473 PNS: Improved auto-posture when starting from a segment 
The previous auto-posture algorithm worked great for pads
but not so great when starting routing from a segment.

Now we can optimize the posture based on the starting
segment if one exists, to maximize the "obtuseness" of the
posture.
 2020-12-28 23:51:13 -05:00
Jon Evans 3adff647a7 PNS: Preserve nearest vertex when dragging in shove mode 2020-12-28 19:44:39 -05:00
Jon Evans 55394f343d Don't use snapping for a selection interaction 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6856
 2020-12-28 17:26:39 -05:00
Jon Evans be294dabce PNS: Snap back to last valid point when committing a drag 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6651
 2020-12-28 16:36:42 -05:00
Jon Evans e5b7e7d2b2 Add missing header needed for gcc builds 2020-12-28 16:02:06 -05:00
Jeff Young 3e2aa8df3a Thread safety for pad effective shape building. 2020-12-28 20:44:46 +00:00
Jeff Young cfb4e34b07 Cleanup. 2020-12-28 20:44:46 +00:00
Jan Mrázek 93466fa165
Fix crash when adding 3D Models via Python 2020-12-28 20:03:54 +01:00
Jon Evans 17cf2466aa Fix overlapping definitions warning 2020-12-27 19:42:04 -05:00
Jon Evans c4bfca251b PcbNew: show file format conversion warning in infobar 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6200
 2020-12-27 19:17:58 -05:00
Jon Evans 3c87e67753 PNS: Allow committing routes even when cursor moves beyond valid solution 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6651
 2020-12-27 17:14:38 -05:00
Jeff Young 1fc4523711 Remove pad-size-setting hack from PCB_PAINTER. 
Also improves the pad warning and error messages, and moves a few
remaining nags from the setting infrastructure to the warning
infrastructure.

Fixes https://gitlab.com/kicad/code/kicad/issues/6141
 2020-12-27 21:11:27 +00:00
Jon Evans 2cdf9875b9 PNS: fix off-by-one in dragCorner45 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6644
 2020-12-27 15:58:36 -05:00
Jon Evans c615b7a49b PNS: make initial direction behavior consistent with fix-all enabled 2020-12-27 15:21:55 -05:00
Jon Evans 132e78d2b8 Fix pcbnew collector prioritization 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6307
 2020-12-27 13:50:11 -05:00
Thomas Pointhuber 3b25e7344a Fix deprecation warning. PyEval_InitThreads() is not needed for Python >= 3.7 
See: https://docs.python.org/3/c-api/init.html#c.PyEval_InitThreads

With Python 3.7 this function is called by Py_Initialize()
With Python 3.9 this function is deprecated and does nothing
 2020-12-27 19:18:49 +01:00
Peter Montgomery 1c79e3174c Pcbnew: Prevent footprint jumping when starting to drag it 
CHANGED: When dragging a footprint, if the mouse isn't directly over the
footprint anchor when 'D' is pressed, the footprint center will jump to
the mouse position when dragging begins.  This MR uses the current
mouse position instead of the footprint anchor as the inital reference
point when starting to drag.

Fixes https://gitlab.com/kicad/code/kicad/issues/6813
 2020-12-27 17:43:52 +00:00
Jeff Young 1579ce9f9e Separate net updating from Edit Tracks & Vias into a second pass. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6858
 2020-12-27 16:35:38 +00:00
Jeff Young 10e51bfea7 Don't apply "normal" locking strategy to alignment options. 
It's much more useful to use the locked items as targets.

Also fixes some issues with commits getting the wrong items when
pads are promoted to footprints.

Fixes https://gitlab.com/kicad/code/kicad/issues/6859
 2020-12-27 15:02:25 +00:00
Jeff Young e3d95cc2c8 Formatting. 2020-12-27 15:02:25 +00:00
jean-pierre charras a675f1f9c5 pcb_painter, draw pad clearance outlines: use the pad shape for non copper layers. 
For copper layers, if the pad shape is not on the active layer, only the hole
shape clearance is shown (this is correct).
But for non copper layers using the hole shape clearance make no sense
(as long as showing the clearance makes sense for some layers).
 2020-12-27 11:20:48 +01:00
jean-pierre charras 97f3c323c3 Pcbnew: fix missing escaping of texts in DIMENSION when saving the .kicad_pcb file. 
Fixes #6855
https://gitlab.com/kicad/code/kicad/issues/6855
 2020-12-27 10:18:23 +01:00
Jeff Young e1f76ea2ab Gracefully handle dots in the outline path. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6854
 2020-12-27 01:01:25 +00:00
Jeff Young 3aca0e1853 Make sure we nofity of self-intersecting outlines. 2020-12-27 01:01:25 +00:00
Jeff Young 8300e17b69 Fix botched attempt to report hole violations between no-net items. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6851
 2020-12-26 16:24:51 +00:00
Jeff Young ab97035ecb Handle closed shapes being processed after other shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6845
 2020-12-26 12:57:49 +00:00
Jeff Young af2219ba7f Finish implementation of hole clearance checking. 
It appears we never did via hole testing, and pad hole testing didn't
appear to get much testing.
 2020-12-25 22:32:19 +00:00
Jeff Young 0d57f90982 Make sure SCH-related frames use the schematic worksheet color. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6843
 2020-12-25 16:59:41 +00:00
Jeff Young 7a081b7c04 Naming consistency. 2020-12-25 16:59:41 +00:00
Jeff Young 04c8d0e9d8 Comments. 2020-12-25 16:59:41 +00:00
Jon Evans 60503652a1 Kick-start appearance panel to redraw on Mac 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6827
 2020-12-25 10:44:18 -05:00
Jeff Young 84ce814037 Repair segment ownership logic for rects and curves. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6847
 2020-12-25 13:21:20 +00:00
Jeff Young 9c4d3add15 Fix typo. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6845
 2020-12-25 12:07:26 +00:00
Jon Evans 8ad89ae457 PNS: fix manual posture mode 2020-12-24 17:31:54 -05:00
Jeff Young ef25c78a04 Separate polygonization error from chaining error. 
This way we can report anything that doesn't exactly chain while still
applying  a fudge factor for our own stuff.

Fixes https://gitlab.com/kicad/code/kicad/issues/1795
 2020-12-24 21:02:14 +00:00
Jon Evans a9ff98bccc Allow selecting locked pads at all times 
Locked pads are a bit different from other locked items
and there are sufficient reasons to need to select them
that it makes sense to introduce this inconsistency.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6837
 2020-12-24 14:35:44 -05:00
Jeff Young 38b8bc89ac Fix a pair of typos. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6839
 2020-12-24 19:32:24 +00:00
Jon Evans d13de9c6c1 Zones: layer set must be initialized after m_isRuleArea 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6814
 2020-12-24 11:29:23 -05:00
Jon Evans 98c437e70f Show the read-only notification for objects, too 2020-12-24 08:42:38 -05:00
Jon Evans db0df1fdc9 Don't try to update non-existent zone layers 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6803
 2020-12-24 08:42:38 -05:00
Jeff Young 5fffde09d4 Improve SNR and formatting. 2020-12-24 10:36:29 +00:00
Jon Evans d0429ced8d Fix layer ordering logic for non-copper layers 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6817
 2020-12-23 22:09:09 -05:00
Jon Evans 8a2667c4c3 PNS: Fix all segments by default (and make optional) 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5920
 2020-12-23 21:55:43 -05:00
Jon Evans 8c247fc97c PNS: Add a setting to disable posture solver 
PNS: Prevent autoposture flutter when trail has little area

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6797
 2020-12-23 21:02:17 -05:00
Michael Kavanagh eb1f07bade Icons: standardise `export_png` to match set 2020-12-24 01:02:03 +00:00
Michael Kavanagh d2018b122b Icons: unify export_svg with the rest of the set 2020-12-24 01:02:02 +00:00
Michael Kavanagh 6489781408 Icons: use correct icons for show/hide ratsnest 
- Remove old icon remnants
 - Recolour show/hide_ratsnest to match KiCad style
 2020-12-24 01:02:02 +00:00
Jeff Young 6b420b191a Use color theme backgrounds in page previews. 
Also includes a *lot* of const fixing to make it happen.

Fixes https://gitlab.com/kicad/code/kicad/issues/6811
 2020-12-23 23:18:38 +00:00
Jeff Young ffe7d2ea49 Only draw group boxes when selected. 
Also ignore footprint groups when in board editor.

Fixes https://gitlab.com/kicad/code/kicad/issues/6826
 2020-12-23 21:43:32 +00:00
Jeff Young 17800b926f Honour couryard_clearance rules when checking for courtyard overlaps. 2020-12-23 17:34:21 +00:00
Jeff Young f30fa60ed7 Need to start with full layer set if we want to end up with any. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6822
 2020-12-23 15:15:09 +00:00
Jeff Young 2f087dfa1b Fix crash bug trying to delete zone from list twice. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6815
 2020-12-23 14:24:35 +00:00
Jon Evans 912657dd23 Component dragger: make relaxed segment pickup work for PTH pads 2020-12-22 22:43:44 -05:00
Jon Evans 70c6314c67 Component dragger: be more generous about picking up tracks 
We now pick up tracks that end anywhere in the pad, not just
at the pad anchor.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/5945
 2020-12-22 22:28:24 -05:00
Seth Hillbrand 61ac9c8d90 Add multiple size icons for programs 
In theory, the WM should now choose the closest size icon for its
purpose, making it easier to distinguish in space-constrained settings

Fixes https://gitlab.com/kicad/code/kicad/issues/6798
 2020-12-22 15:37:26 -08:00
Seth Hillbrand 54ca087999 Update icon resource sets 
Updates the .icns, .ico and .png files used by various distros to show
KiCad and KiCad files.
 2020-12-22 15:16:33 -08:00
Jeff Young 47ea51ec34 Allow both aui-manager-based infobars and window overlay infobars. 2020-12-22 21:36:39 +00:00
Jeff Young e7f9f19469 Tie dimension properties together for better comprehension. 2020-12-22 16:03:20 +00:00
Adam Wolf 8aedc33a6b Fix typo calling directory_open_xpm on macOS. 
Fixes #6809
 2020-12-22 09:52:27 -06:00
Jeff Young 93dc7feea3 Remove multi-threading for footprint loading. 
Also don't load the footprints up front.  The whole purpose of the
footprint-info stuff is to have enough info about the footprints to
filter them *without* loading.  After that just load individual
footprints as we need them.

Fixes https://gitlab.com/kicad/code/kicad/issues/6177
 2020-12-21 22:03:24 +00:00
Jeff Young 5d4042d6b0 Don't check edge cuts visibility when getting board bbox from edges. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6805
 2020-12-21 19:47:36 +00:00
Jeff Young 6848b1055e Make sure sorting is honoured on first display. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6295
 2020-12-21 19:47:36 +00:00
jean-pierre charras eb7dc6ddd9 Minor fixes. In stand alone show the frame as soon as possible. 
Especially when running Pcbnew to open a complex board the frame is shown faster.
Add also a busy cursor when loading files and building the data.
 2020-12-21 17:44:10 +01:00
Wayne Stambaugh 090d7881e0 Revert Coverity fix that caused build issue with older versions of Boost. 
The Boost entropy exception does not exist prior to version 1.67. Once
the minimum Boost version is raise to 1.67 or greater, enable catching
the exception.  We will just have to live with the possibility of an
uncaught exception until then.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6804
 2020-12-21 08:41:05 -05:00
PJM 32f1e79c28 Pcbnew: Fix ctrl-MMB double click to perform 'Zoom to Objects' 
CHANGED: Ctrl-middle mouse button double click should perform
'Zoom to Objects' in Pcbnew, but a change in modifier key handling
broke it.  This MR restores the functionality.

Fixes https://gitlab.com/kicad/code/kicad/issues/6740
 2020-12-20 23:20:09 +00:00
Jon Evans 70c397a9b4 Implement free vias fully 
CHANGED: manually-placed (stitching) vias won't have their nets automatically updated
(unless the via is placed directly on a track segment)

CHANGED: stitching vias can be placed on footprint pads and pick up their nets

Fixes https://gitlab.com/kicad/code/kicad/-/issues/5484
 2020-12-20 16:29:50 -05:00
Jeff Young cd162a8f58 Honour m_placingVia when avoiding collisions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/3773
 2020-12-20 20:36:19 +00:00
Jon Evans e8f38e3c18 Snap to footprint origin when dragging 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6633
 2020-12-20 15:15:48 -05:00
Jon Evans 81ce1a07ee Fix a few issues with builtin color themes 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6754
 2020-12-20 14:43:41 -05:00
Jon Evans 71b446f43c Fix overlay ordering for non-copper layers 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6211
 2020-12-20 14:43:41 -05:00
Wayne Stambaugh f311831c27 Coverity fixes. 
280252, 314742, 314745, 314747, 314755, 314756, 314757, 314758,
314935, 314936
 2020-12-20 13:24:47 -05:00
Jon Evans dc1c80beb8 Allow highlighting from locked items 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6758
 2020-12-20 11:24:19 -05:00
Jon Evans ac793618f9 Set start item for inline dragging so that snapping works properly 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6796
 2020-12-20 11:13:09 -05:00
Jon Evans a6e595dbda Don't start dragging unselected zones from their filled areas 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6795
 2020-12-20 10:41:02 -05:00
Jeff Young 46314f6483 Only compare collision-corrected routes when looking for shortest. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6511
 2020-12-19 23:20:27 +00:00
Jon Evans c8be87a654 Add i18n flag to appearance controls and selection filter 2020-12-19 17:39:43 -05:00
Konstantin Baranovskiy 7c2b66fc2a pcbnew: make pane labels translatable 2020-12-19 22:25:50 +00:00
Jeff Young d9bbdffd99 Don't offer point-based pad editing in PCBNew. 2020-12-19 19:51:51 +00:00
Jeff Young e840e9d997 Use themeable colours for snap helpers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6664
 2020-12-19 19:51:51 +00:00
Marek Roszko 247064a1ed Remove rogue file from pcbnew's cmake 
This is already provided in common and isn't pcbnew conditional (anymore)
 2020-12-19 10:51:00 -05:00
Marek Roszko 9b0a137d6c Stop bludgeoncompiling dialog_page_settings 
Through the power of OOP!
Needs some more cleanup though
 2020-12-19 10:40:37 -05:00
Marek Roszko fc272f407a Write the fp-info-cache if we close the footprint editor 2020-12-18 22:56:01 -05:00
qu1ck 4788f3ae6b Read fp-info-cache on first start of fp editor 
if fp info list is not initialized
 2020-12-18 18:56:36 -08:00
Seth Hillbrand e37a89cdbf Disable the zone display types if zones are hidden 
This prevents user confusion (a little) when the zones are hidden

Fixes https://gitlab.com/kicad/code/kicad/issues/6783
 2020-12-18 17:22:51 -08:00
Jeff Young 06d4476d7a Fix graphics snapping in Footprint Editor. 
Also improves the help text for the various selection modifier
options.

Fixes https://gitlab.com/kicad/code/kicad/issues/6538

Fixes https://gitlab.com/kicad/code/kicad/issues/4745
 2020-12-19 00:21:28 +00:00
Wayne Stambaugh 06aa1506ee Add optional project parameter to PCB plugin load method. 
The optional PROJECT parameter is primarily used for third party plugins
that need to store project information loaded by the plugin.
 2020-12-18 10:40:51 -05:00
Jeff Young 01f6c90fac BOARD_CHANGED is only called after the previous board has been freed. 
There is therefore no reason to remove the listener (and every reason
not to try).

Fixes https://gitlab.com/kicad/code/kicad/issues/6666
 2020-12-18 12:49:20 +00:00
Jeff Young b68b1692ec Clean up some more user messages. 
Mostly component -> symbol but also some I18N cleanup.
 2020-12-18 12:49:20 +00:00
Alexis Lockwood 4bc12e7dcd Don't include plotters_specific.h where not needed 
This avoids some very large rebuilds when a plotter class is changed.
 2020-12-18 07:21:59 +00:00
Jeff Young 1c0d4ac02d Simplify some error messages. 2020-12-18 00:30:26 +00:00
Jeff Young bb232e6ac6 Unify LIB_IDs now that both are stored in sexpr files. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6764
 2020-12-18 00:30:26 +00:00
Wayne Stambaugh aab3c936f0 Move headers from common folders to appropriate include folders round 2. 2020-12-17 11:44:03 -05:00
jean-pierre charras e4b60b03d1 fp editor: fix incorrect initialization of arc center when edited by the 
graphic item properties dialog.
The arc center (in local coordinates) was initialized before the actual
value was calculated.
Fixes #6772
https://gitlab.com/kicad/code/kicad/issues/6772
 2020-12-17 16:32:10 +01:00
Jeff Young a6085fa88d Consistency for gerbview toolbar icons and some other icon tweaks. 2020-12-17 14:02:23 +00:00
Wayne Stambaugh 08cf9a1e20 Move headers from common folders to appropriate include folders round 1. 2020-12-17 08:12:18 -05:00
jean-pierre charras dcbe2413cc Pcbnew: fix incorrect displayed value in polar coordinates. 
Fixes #6771
https://gitlab.com/kicad/code/kicad/issues/6771
 2020-12-17 11:21:24 +01:00
jean-pierre charras b425889a1a fp editor: fix incorrect parent for a error message box 
Fixes #6773
https://gitlab.com/kicad/code/kicad/issues/6773
 2020-12-17 10:47:39 +01:00
Jon Evans 3d68aa4b86 Make sure footprint editor uses the right config object 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6115
 2020-12-16 22:07:35 -05:00
Jon Evans 87b25936a0 Don't hide zone virtual layers in footprint editor 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6642
 2020-12-16 21:47:31 -05:00
Ian McInerney fc20eaa083 Fix some compiler and Coverity warnings 2020-12-17 00:30:22 +00:00
Jeff Young 1ca75c8fda Fix from code review for https://gitlab.com/kicad/code/kicad/-/merge_requests/562. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6747
 2020-12-16 22:02:19 +00:00
Konstantin Baranovskiy 08730cf952 pcbnew: search hits counting fix 
Fixes #6747
 2020-12-16 18:02:24 +00:00
Jeff Young acfbcb4beb Make distinction between PCBNew-wide tools and Board-specific tools. 
The old names were really hard to keep straight (even for me, who named
many of them).
 2020-12-16 13:32:46 +00:00
Seth Hillbrand b7875e4d41 Setup file_* icons 
Don't use the same "post_*" icon in the treeview.  The badge gives an
action that doesn't apply in the treeview.

Also renames different file blobs to the "file_*" prefix.
 2020-12-15 14:48:09 -08:00
Jeff Young 5f9ed2583c Don't put up double lock confirmation dialogs. 
Also removes EditToolSelectionFilter which was misused in more places
than it was used correctly.  The original point of the client filter
was to move the logic to the point of use, which the
EditToolSelectionFilter sort of obviated anyway.

Fixes https://gitlab.com/kicad/code/kicad/issues/6751
 2020-12-15 22:34:24 +00:00
Michael Kavanagh 2f49623579 Tweaks to Pcbnew RHS draw toolbar icons 
- Improve contrast of ratsnest icons by removing blue
- Track icon: make blue as it is a board feature
- Muwave icon: remove handles, make serpentine blue, thicken and pixel align
- New, simplified zone and rule area icons
- Simplify draw tools by removing edit handles/guidelines - improves contrast
- Reorder draw tools in toolbar/menubar to make a little more sense
- Rotate measurement icon (ruler) to match bottom left -> top right
 2020-12-15 02:25:22 +00:00
Seth Hillbrand dad2e317e9 Modify edit text & graphics to use pencil 2020-12-14 17:03:35 -08:00
Jeff Young 2142ad20b1 Draw FPText umbilical lines in themeable colour. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6664
 2020-12-15 00:15:03 +00:00
Jeff Young 4faa4931ae Fix missing gerber icon. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6727
 2020-12-15 00:15:03 +00:00
Jeff Young 22a6b36257 Don't allow dbl-click to leak through to other tools. 
This only applies if the tool doesn't handle properties (which also
handles double-click events).

Fixes https://gitlab.com/kicad/code/kicad/issues/6735
 2020-12-14 22:15:43 +00:00
Jeff Young c1a74b427a Translucent magnifying glass on footprint & library browser icons. 
Also renamed.
 2020-12-14 22:15:43 +00:00
jean-pierre charras dd3b5512ee PANEL_SETUP_LAYERS:do not disable the button "Add User Defined Layer". 
For boards having 2 or 4 layers this button was disabled, that make no sense.
 2020-12-14 17:47:55 +01:00
Jeff Young 3b35bfc0a5 Don't write out synthetic severities (they're headings). 
Fixes https://gitlab.com/kicad/code/kicad/issues/6726
 2020-12-14 13:34:53 +00:00
Michael Kavanagh 4f5c764dde Appearance manager icons: fix which is which 2020-12-13 16:48:22 +00:00
Jon Evans 7695866a72 Fix typo 2020-12-13 11:14:09 -05:00
Michael Kavanagh cc43b66daf Icons: use correct size for open action in toolbar 
Previously 16x16 was used
 2020-12-13 16:10:26 +00:00
Cameron McQuinn f225e95ffc FIx BOARD class SWIG interface 
Commit b1f0bf7 changed netinfo.h to use more consistent naming, but the SWIG board.i file still references the old name.
 2020-12-13 11:55:10 +00:00
Jeff Young 1db7ffad5e Formatting. 2020-12-13 11:42:03 +00:00
Marek Roszko 7565f60a03 Swap wxFileInputStream/wxFileOutputStream for the buffered kind 2020-12-12 18:52:02 -05:00
Seth Hillbrand 2bf0eb1e3a Add convert icon 2020-12-12 11:14:58 -08:00
Michael Kavanagh dce4d04113 Add 24x24 size refresh icon 
Previously 16x16 was being used alongside 24x24
 2020-12-12 18:51:55 +00:00
Jeff Young bc484784fc Make sure zones are triangulated for DRC. 
Normally this happens as a side-effect of rendering them but if done
from a script (or test case) this won't happen.

Fixes https://gitlab.com/kicad/code/kicad/issues/6635
 2020-12-12 15:27:46 +00:00
Jeff Young c0a9742b3a Apply 0ef63aca47 to diff pairs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6314
 2020-12-12 03:43:41 +00:00
Michael Kavanagh cf6f0b9b92 Use trash icon where appropriate 2020-12-11 17:05:11 -08:00
Wayne Stambaugh dd4298bb94 Coverity fixes: 280374, 313611, 313648, 313649, and 314720. 2020-12-11 13:29:52 -05:00
Jeff Young 0ef63aca47 Don't reset tail when changing track width/via sizes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6314
 2020-12-11 17:58:36 +00:00
Jeff Young af841d1318 Pay attention to flashed layers when doing DRC layer switch. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6710
 2020-12-11 17:58:36 +00:00
jean-pierre charras 224e33f8e1 DIALOG_TEXT_PROPERTIES: allows text rotation in 0.001 degree. 
Fix also incorrect rotation (truncation) when displaying info in message panel
fot texts and pads.
 2020-12-11 16:26:58 +01:00
Jeff Young 7cb2d19814 Honour alt-means-disable-grid-snapping in router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6679
 2020-12-11 13:11:47 +00:00
Jeff Young d304f12284 Formatting. 2020-12-11 12:48:04 +00:00
Jeff Young 73b7b104cd Fix some issues with Infobar sizing. 
This also commits to the new strategy as it wasn't really compatible
with if-def-ing anymore.
 2020-12-11 12:39:40 +00:00
Marek Roszko 525934881f Use a temp file for saving the fp-info-cache for now 2020-12-10 23:07:49 -05:00
Marek Roszko dd0ad8f3a1 Read the fp-info-cache on pcb file load rather than on frame open 
Otherwise in standalone mode pcbnew will never load the cache files and also later erase them :/
 2020-12-10 21:34:40 -05:00
Marek Roszko 0967995a80 Replace wxTextFile for writing fp info cache 
wxTextFile uses wxFile which uses write syscalls which means its unbuffered.
This makes file IO more expensive against network shares where it will flush far too aggressively.
wxTextFile is fine for reads however.
 2020-12-10 21:34:40 -05:00
Jeff Young 6898dadd1c Don't activate measure tool when it's already running. 
In this case it's reactivated when the move command ends; only the
move command was ended because of activating the measure tool so it
gets activated twice.

Fixes https://gitlab.com/kicad/code/kicad/issues/6321
 2020-12-10 22:14:52 +00:00
Jeff Young 98330098ac Yet another overhaul to locking. 
This unifies everything under a single architecture with a "don't
show again" dialog.  Since everything now goes through the same
path it should be reasonably easy to make it do whatever we want
in the future.

Right now it presents 3 options: modify only unlocked items, override
locks and modify all items, or cancel command.
 2020-12-10 17:36:19 +00:00
Roberto Fernandez Bautista 260219b0e6 CADSTAR PCB Archive Importer: Fix arc and filled shapes in footprints 
- Need to call the PCB_SHAPE version of SetAngle in order to set the global coordinates for m_ThirdPoint
- Fill shapes also if in a footprint
 2020-12-10 14:35:37 +00:00
Marek Roszko a4879e740a Don't request a full frame refresh when editing text properties (stop apperance flickering) 
Seems like dead code, the commit should trigger just a canvas refresh.
 2020-12-09 21:14:48 -05:00
Jeff Young 9113f93ebe Uniformly apply current locking strategy. 
I make no claims that this is the right strategy, but at least it's
consistent now.

Fixes https://gitlab.com/kicad/code/kicad/issues/6369
 2020-12-10 01:34:37 +00:00
Jeff Young 90d58c8509 Fix typo. (Thanks Graham!) 2020-12-10 00:08:05 +00:00
Marek Roszko bb4aa15736 Remove extraneous msgpanel update 
OnModify right above also calls UpdateMsgPanel
 2020-12-09 18:41:43 -05:00
Ian McInerney be4b6ec06a Cleanup compiler warnings 2020-12-09 23:13:33 +00:00
Jeff Young c6b17a0175 Enable lock menu for all selections. 
It doesn't pay to try and be too smart as it just confuses people.
When the bugs come in that it doesn't dim I'll just be marking them
as "as designed". :)

Fixes https://gitlab.com/kicad/code/kicad/issues/6367
 2020-12-09 22:19:06 +00:00
Jeff Young df4f4560be Change lock toggle to put selection in uniform state. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6367
 2020-12-09 22:19:06 +00:00
Jeff Young 65782d5c5a Move delete-again-to-delete-locked-objects to hypertext in infobar. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6367
 2020-12-09 22:19:06 +00:00
Wayne Stambaugh e0fb12488b Pcbnew: fix more minor text properties dialog layout issues. 2020-12-09 09:18:55 -05:00
Marek Roszko eb2472650c Filter appearance control updates on bulk changes 2020-12-09 08:01:37 -05:00
Wayne Stambaugh ad02156aea Pcbnew: fix minor text properties dialog layout issues. 2020-12-09 07:58:32 -05:00
Marek Roszko ad1aae40ec Unify the saved file strings 2020-12-08 19:49:47 -05:00
Seth Hillbrand fbc70511c7 GTK-require two-step in dataview 
The before reset needs to be called in GTK prior to reseting the tree
otherwise, we will dereference items that may be cleared.

Fixes https://gitlab.com/kicad/code/kicad/issues/6672
 2020-12-08 16:42:28 -08:00
Jeff Young 431c8dba3c Adjust undo when deleting members of a group. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6678
 2020-12-09 00:18:36 +00:00
Jeff Young 5e9d9f5753 Special handling for presence of Ref or Value in groups. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6677
 2020-12-09 00:18:36 +00:00
Seth Hillbrand 799e1efba2 Update group icons 2020-12-08 12:22:18 -08:00
Jeff Young b26a5972c5 LIB_TREE's SetFocus() override no longer getting called. 
The KIPLATFORM stuff forces focus, but not through the SetFocus()
call.

Fixes https://gitlab.com/kicad/code/kicad/issues/6657
 2020-12-08 17:46:10 +00:00
jean-pierre charras ac684ac7a3 Fix minor compil warnings. 2020-12-08 18:28:03 +01:00
jean-pierre charras 9c4eef2cef Fix a missing view update when loading a footprint from the fp viewer. 
For some reason, a footprint loaded from the fp viewer did not have its
view parameters fully updated (view bounding box not moved to the right place).
The fix ensure these parameters are updated.
 2020-12-08 17:52:30 +01:00
Jeff Young b1f0bf7334 More consistent naming. 2020-12-08 13:05:39 +00:00
Jeff Young 60ecd4698c Nets don't have properites; netclasses do. 2020-12-08 13:05:39 +00:00
Jeff Young 20ad2bee2f Naming conventions. 2020-12-08 13:05:39 +00:00
Marek Roszko 9407e6dc83 Another set of color msgpanel items stripped 2020-12-08 00:52:21 -05:00
Marek Roszko cbda1d7bf1 Remove more vestiges of old colored msg panel messages 2020-12-08 00:50:25 -05:00
Marek Roszko 97b5cff5fe Remove redundant message panel SetMsgPanel 
SetMsgPanel( m_pcb ) proceeded to erase and recreate the msg panel anyway...
 2020-12-08 00:35:37 -05:00
Marek Roszko b45eb56ddf Cleanup some msg panel usage using the no longer support colors 
The color was being passed to the aPadding param now.....
 2020-12-08 00:34:36 -05:00
Marek Roszko abb5cb8310 Fix up msg panel status on save slightly 
- pcbnew should use status bar on success like eeschema
- Add a helper to clear msgpanel and set it in one go to avoid redraw delays due to doing processing in between
 2020-12-08 00:28:07 -05:00
Marek Roszko d7154c4334 Skip no_connect_ nets in the appearance widget 2020-12-07 22:11:53 -05:00
Marek Roszko e88d41f764 Add bulk add/remove mode flag to the BOARD_LISTENER 
This attempts to fix performance when importing large changesets from schematics.
The appearance control is a BOARD_LISTENER that would otherwise redraw per item imported which may cause lockups
 2020-12-07 22:04:13 -05:00
Jeff Young 1f3cdffe6b Fix clipping of optimizer slider on OSX. 2020-12-08 00:13:29 +00:00
Jeff Young aa3e29ee7c Don't re-enter router on subsequent X key. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6656

Fixes https://gitlab.com/kicad/code/kicad/issues/4504
 2020-12-08 00:13:29 +00:00
jean-pierre charras 588fd5e267 Better fix than 86b631b3 2020-12-07 18:28:32 +01:00
Jeff Young c7bd8fc987 A couple of missed "footprint" terminology updates. 2020-12-07 15:50:04 +00:00
Jeff Young 78129aabeb Fix another case of 413ff4525b. 2020-12-07 14:25:55 +00:00
jean-pierre charras 86b631b31e Fix incorrect use of ShowQuasiModal instead of ShowModal. 
Fixes #6653
https://gitlab.com/kicad/code/kicad/issues/6653
 2020-12-07 14:20:38 +01:00
Jeff Young d0f9503ee0 Add grouping for violation severities. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6616
 2020-12-06 19:14:48 +00:00
Jeff Young 58afaeb9eb Use QuasiModal in all parents of ConfigPaths so help window works. 2020-12-06 18:44:24 +00:00
Jeff Young b10aa230f7 Remove no-longer-used DRC violation code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6616
 2020-12-06 15:19:33 +00:00
Jeff Young 2260597236 Fix more accidental event capturing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5844
 2020-12-06 13:33:23 +00:00
jean-pierre charras 16c92f4134 Fp editor: Add a tool tip in the vertical toolbar 2020-12-06 13:35:21 +01:00
Jeff Young f09ca9ceee Pass unhandled events when dragging in the router tool. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6630
 2020-12-06 12:30:29 +00:00
Jeff Young 602476cdf2 Update SELECTION_TOOL when loading footprint editor settings. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6641
 2020-12-06 12:13:16 +00:00
Jeff Young 68947864a1 Update zone layers along with corresponding copper layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6613
 2020-12-05 23:31:12 +00:00
Jeff Young de082e9be7 Make footprints mostly covered in pads easier to select. 
If all the uncovered space is at the very edge it doesn't feel like
there's anywhere to click but the disambiguation menu doesn't come
up.

Fixes https://gitlab.com/kicad/code/kicad/issues/6584
 2020-12-05 23:02:45 +00:00
Jeff Young dbf273d5ec Don't leave HOLE_PROXY set; it messes subsequent tests. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6584
 2020-12-05 19:44:02 +00:00
Jeff Young 4c5567a627 Allow colliding pads in netties as well as graphic shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6584
 2020-12-05 19:44:02 +00:00
Jeff Young d6c3c6f7fa Use footprintRect not ViewBBox for determining footprint bounds. 2020-12-05 19:44:02 +00:00
Jeff Young d43eefbad5 Formatting. 2020-12-05 19:44:01 +00:00
Seth Hillbrand 3704c1cdb7 New icons for v6 
Fixes https://gitlab.com/kicad/code/kicad/issues/2542
 2020-12-05 11:17:15 -08:00
jean-pierre charras f53958dd54 Pcbnew, PANEL_EDIT_OPTIONS: add helper messages to display info about LMB 
click and the modifier keys actions.
 2020-12-05 16:04:42 +01:00
jean-pierre charras 63088e8bdb Pcbnew: fix incorrect size of solder paste rectangular area of rect pads. 
When the solder paste margin was the same for X and Y directions, the margin
was not taken in account (missing code)

Fixes #6621
https://gitlab.com/kicad/code/kicad/issues/6621
 2020-12-05 11:51:08 +01:00
Jeff Young 4e100b8d03 Handle groups in clearance report, and make sure zone bboxes are cached. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6571
 2020-12-04 20:49:14 +00:00
Jeff Young 4634802a58 Formatting. 2020-12-04 19:29:04 +00:00
Jeff Young 7b347d793b Change gears on no-connect net generation. See bug rpt. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6534

Fixes https://gitlab.com/kicad/code/kicad/issues/6615
 2020-12-04 18:25:48 +00:00
Jeff Young f3e1ac8dbe Defensive code to prevent lookup of stale parent board. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6618
 2020-12-04 14:01:54 +00:00
Jeff Young fd5e1fbdd4 Formatting and cleanup. 2020-12-04 14:01:54 +00:00
jean-pierre charras 2f3ca60c5e Pcbnew, modifiers for left click behavior: re-add highlight net option. 
Due to last changes fixing the ALT key problems, the highlight net is
CTRL+SHIFT + left click on Windows and Linux
CTRL+ALT + left click on OSX

Fixes #6595
https://gitlab.com/kicad/code/kicad/issues/6595
 2020-12-04 10:25:05 +01:00
Jeff Young 09bfb76545 Make sure dissallow constraints get added to rule. 
Also improves some error reporting.

Fixes https://gitlab.com/kicad/code/kicad/issues/6566
 2020-12-03 23:08:51 +00:00
Jeff Young e882753ebf Grid snapping fixes. 
1) Uniformly honour the GAL grid snap settings
2) Make more uniform use of GRID_HELPERs
3) Smarten EDIT_LINE for mid-point snapping

Fixes https://gitlab.com/kicad/code/kicad/issues/6558
 2020-12-03 19:55:58 +00:00
Jeff Young 43fe228367 Hook up a bit more of the EE_GRID_HELPER. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5985
 2020-12-02 23:18:33 +00:00
Jeff Young 00edc85f4f Allow layer switching when routing from pad. 
Additionally, don't process layer events from both main loop and
transitions -- it makes for a mess.

Fixes https://gitlab.com/kicad/code/kicad/issues/4832
 2020-12-02 21:17:56 +00:00
Jeff Young f2ac6fcd44 Treat net 0 items as each being in their own net. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6534
 2020-12-02 20:05:47 +00:00
Jeff Young d06d35a74d Formatting. 2020-12-02 20:05:47 +00:00
jean-pierre charras 64f555079a Code cleanup related to zoom: 
- remove outdated code or comment coming from old drawing code using wxDC
- move zoom values lists to zoom_defines.h
- fix incorrect zoom max and min values (gal scaling factor limits).
 2020-12-02 18:35:28 +01:00
jean-pierre charras fcce62f0a4 cleanup related to zoom definitions 2020-12-02 18:35:27 +01:00
Jeff Young 96c9680922 Separate width adjustments between single track and diff pair. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6572
 2020-12-02 16:24:33 +00:00
jean-pierre charras 71ab42e60a Minor fixes and cleanup related to zoom definitions. 
Mainly move 2 define relative to Zoom from convert_to_biu.h to zoom_defines.h.
Will make some changes/fixes in zoom code more easy.
 2020-12-02 10:14:35 +01:00
Jeff Young 1cd8426bcb Fix latent dyn_cast bug. And a bunch of formatting issues. 2020-12-02 00:29:00 +00:00
Jeff Young f70153b849 Implement Group Properties in Footprint Editor. 
Also fixes a pair of typos that were keeping delete of a group in the
Footprint Editor from working.

Fixes https://gitlab.com/kicad/code/kicad/issues/6579

Fixes https://gitlab.com/kicad/code/kicad/issues/6578
 2020-12-01 23:43:53 +00:00
Jeff Young df262eaa06 Make prev/next marker work reliably on all platforms. 
Requires us to move from arrow-keys to our own commands (the only
way that the OSX wxWidgets impl doesn't eat the keys when the dataVIew
has focus).

While there we might as well add a command to exlucde markers.

ADDED Prev Marker, Next Marker, Exclude Marker

Fixes https://gitlab.com/kicad/code/kicad/issues/6575

Fixes https://gitlab.com/kicad/code/kicad/issues/5501
 2020-12-01 22:37:07 +00:00
Jeff Young 3c521942ed Smarten isEmpty checks to include nothing-but-whitespace. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6567
 2020-12-01 16:39:06 +00:00
Jeff Young d50d1d84da Fix some issue with group in selection logic. 2020-12-01 14:04:01 +00:00
Jeff Young 288ab7ed6f Minor formatting cleanup. 2020-12-01 14:04:01 +00:00
Ian McInerney aa09418a14 Fixup memory lifespan of GAL options for the settings preview canvas 
The canvas keeps a reference to the settings object, so we
can't pass one from the stack because it runs into lifetime
issues.

Also cleanup some loop-iterator problems.

Fixes https://gitlab.com/kicad/code/kicad/issues/6338
 2020-12-01 01:12:07 +00:00
Jeff Young dadfe03804 Reinstate 5.1 net-tie hack since "real" net-ties got pushed to 7.0. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6556
 2020-11-30 16:11:15 +00:00
jean-pierre charras 7261086779 gendrill_file_writer_base: better algo to sort holes: 
Holes were correctly sorted by size, but inside the same hole size
the holes were strangely sorted.
Now holes are sorted by hole size, and (inside the same size) by position.

Fixes #6553
https://gitlab.com/kicad/code/kicad/issues/6553
 2020-11-30 16:59:13 +01:00
Jeff Young c66e373119 Cleanup of PCBNew message panel routines. 
Also fixes bugs where invalid netclasses were reported as "Default",
and SMD pads were reported as having "0.0000" drills.
 2020-11-30 14:38:06 +00:00
Jeff Young 3a9a6e22bc Fix issues in reporting netclasses. 
1) make sure we get the default netclass when we want it
2) escape for HTML (particularly important for "<invalid>", but also
for reporting user rule names, netclass names, etc.)
 2020-11-30 14:38:06 +00:00
Jeff Young 3989c19c41 Don't test pad:track clearances in pad tester. 
They've already been tested in the track tester.

Fixes https://gitlab.com/kicad/code/kicad/issues/6554
 2020-11-30 14:38:06 +00:00
Wayne Stambaugh 1f8b7b6149 Pcbnew: change block selection and heuristic context menu modifier keys. 
Do not use the alt modifier key to force the display of the heuristic
context menu.  This causes a conflict with menu selection on windows
and immediately dismisses the disambiguation context menu.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/1873
 2020-11-30 08:51:09 -05:00
Jeff Young e09271ca0e Fixes for hole clearance and hole-to-hole tests. 
1) Separate out CONSTRAINT types
2) Filter both source and dest pads/vias for drilled holes when doing
   hole-to-hole checks.  We were checking the items being put into the
   DRC RTree, but not the items we were scanning.
3) Add hole clearance to Board Setup Constraints panel.

Fixes https://gitlab.com/kicad/code/kicad/issues/6546

Fixes https://gitlab.com/kicad/code/kicad/issues/4683
 2020-11-29 23:35:23 +00:00
Jeff Young 0c2cd1abb2 File left out of last commit. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6478
 2020-11-29 21:21:20 +00:00
Jeff Young b171d381f0 Collapse Redraw3DView and Update3DView into a single routine. 
Also fixes some errors about what the flag meant (model changed,
NOT redraw immediately).

Fixes https://gitlab.com/kicad/code/kicad/issues/6478
 2020-11-29 21:08:30 +00:00
Jeff Young 3ca06700fc Formatting. 2020-11-29 20:00:16 +00:00
Marek Roszko 9322b3a4e1 Use the C++ isnan function 2020-11-29 11:30:45 -05:00
Jeff Young 889408c96a More improvements to new selection disambiguation. 
Also a rationalization of text polygon generators, with the "standard"
version inherited from BOARD_ITEM now giving the bounding box.  This
requires callers who want the (much) more expensive stroke-based one
to call it explicitly (and brings PCB_TEXT in line with the was FP_TEXT
already was.

Fixes https://gitlab.com/kicad/code/kicad/issues/6525
 2020-11-29 14:02:46 +00:00
Jeff Young 3c25abbf2f Ignore netcode when expanding track selections. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6529
 2020-11-29 10:57:45 +00:00
Michael Kavanagh becc811775 Make path substitutions grid read only in lib table dialog 
Fixes https://gitlab.com/kicad/code/kicad/issues/5624
 2020-11-29 09:51:53 +00:00
Jon Evans f78d909ffb Correctly set up projects for converted boards 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6209
 2020-11-28 22:46:05 -05:00
Marek Roszko 5e117bfaa5 Don't allow nan values for dxf text alignment points to creep in 
Literally the only place dxflib decides to default to NaN....
 2020-11-28 20:13:42 -05:00
Marek Roszko cc7264c0b9 Subtract off the block's base point coordinate from the insert translation 2020-11-28 20:13:42 -05:00
Marek Roszko cac0d93dfd Implement DXF INSERT scale 
This has a chance of being wrong due to how the dimensions are stored in these intermediate objects
 2020-11-28 20:13:42 -05:00
Jeff Young e4d0ffd607 Retire old SKIP_STRUCT filtering. 
We already added the checkedPairs stuff which deals with a:b vs b:a
better, and the SKIP_STRUCT version had side-effects between the two
tests.

Fixes https://gitlab.com/kicad/code/kicad/issues/6539
 2020-11-29 00:08:23 +00:00
Roberto Fernandez Bautista 0691e942f4 CADSTAR Archive Importer: Fix duplicate KIID for loaded elements 
Don't use clone to copy an EDA_ITEM. Use Duplicate().
Even if you give the clone a new KIID, all its children will still be clones.
Create Duplicate() in LIB_PART
 2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista 71f9847601 CADSTAR Archive Importer: Only load the Master variant 2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista e3334cd25c Non-KiCad Project importers: Do not rebuild the netlist or reannotate after import 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6383
 2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista 78e3f917d9 CADSTAR PCB Archive Importer: Fix loading of old CADSTAR designs and Do Not Keep Upright 
Older CADSTAR versions used 1/10 degree whereas newer versions use 1/1000 degree.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6437
 2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista f2ba9f7ac3 CADSTAR PCB Archive Importer: Correctly load the pad numbers as per the original design 
To load the pad numbers correctly we need to also check the PART DEFINITION for each component
 2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista 5db78a3d53 Fix typo in zone filling progress reporter. "insulated" -> "isolated" 2020-11-28 17:18:17 +00:00
Jeff Young d3c952b122 Commit pending changes from grids. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6527
 2020-11-28 11:44:05 +00:00
Jeff Young b1adb93c16 PCB_GROUP_Ts need to be added and removed from view. 
The SELECTION_TOOL's m_enteredGroup also needs to be updated when
said group is deleted via undo or redo.

Fixes https://gitlab.com/kicad/code/kicad/issues/6493
 2020-11-27 23:34:58 +00:00
Jeff Young 190197794d Apply a similar fix as pads for B&W via printing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6496
 2020-11-27 22:31:07 +00:00
Jeff Young 896ad4a749 Rewrite PCBNew selection disambiguation based on shapes. 
The new shape architecture gives us the opportunity to make text
selection much more intuitive by actually looking at the glyph
shapes.  Before text would be selected when you clicked in the
descenders area (which was usually blank given uppercase letters
and digits).

Fixes https://gitlab.com/kicad/code/kicad/issues/6525
 2020-11-27 22:03:14 +00:00
Jeff Young 0293f880ec Fix a bunch of group issues with importing graphics. 
Groups do not own their children; they only reference them.  That
being said, they do own *selection* and *moving* of their children.
This might address some of 6493, but in any case will be a
pre-requisite for fixing it.

Fixes https://gitlab.com/kicad/code/kicad/issues/6493
 2020-11-27 22:03:14 +00:00
Jon Evans 0bbb7bdb0c Allow selecting graphic footprints in high-contrast mode 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6490
 2020-11-26 20:11:16 -05:00
Jeff Young 6f3b0c452f Make sure unfilled zones get an MD5 hash. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6515
 2020-11-26 20:21:46 +00:00
Jeff Young 06b9439dbf Edge Cuts shapes have zero width. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6517
 2020-11-26 17:42:46 +00:00
Jeff Young b3204a06fd Minor layout improvements to Router Settings dialog. 2020-11-26 17:41:09 +00:00
Jeff Young fc2bdc49de Once more into the depths of hell... er, I mean fix a focus issue. 
So the new steals-focus protection stuff works well when there's a
focused control, but not as well when there's a modal dialog up which
happens not to have a focused control (or worse, a focusable control).

This adds a second mechanism for also checking to see if a modal dialog
is up (something that wxWidgets, true to form, makes very difficult).

Fixes https://gitlab.com/kicad/code/kicad/issues/6520
 2020-11-26 16:47:40 +00:00
Jeff Young 2a87980d45 Remove overly verbose messaging. 2020-11-26 16:47:40 +00:00
Jeff Young 94de8ada97 Formatting and naming conventions. 2020-11-26 16:47:40 +00:00
Jeff Young 09587ef4fb Another attempt at GTK fix. 2020-11-26 00:05:57 +00:00
Jeff Young 96acb12295 Attempt to fix GTK compile issue. 2020-11-25 23:07:49 +00:00
Jeff Young b8414174af Duplicate Eeschema's select-ref-number strategy in PCBNew. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6504
 2020-11-25 17:13:00 +00:00
Jeff Young 7a2a302117 Fix several issues with pad/hole colors when B&W printing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6496
 2020-11-25 17:13:00 +00:00
jean-pierre charras 5c08ad1ab9 Fix a few issues when copying a footprint from fp editor to clipboard, and paste it: 
- ref and value texts were converted to user texts.
- fpid was left empty, thus creating a potential issue if pasted in the board editor.
Now:
- ref and value texts are no changed, and not copied is pasted in the footprint editor
(these texts already exist)
- a dummy fpid (clipboard:<md5 string>) is added if pasted in board editor
(Pasting a (partial) footprint from fp editor to a board editor is certainly not
a good idea but is possible)
 2020-11-25 17:13:35 +01:00
jean-pierre charras 68625494f3 specctra_export: fix an issue with custom and chamfered/round rect pads. 
Is some cases a created pad stack name had the same name as an other pad stack
having a slightly different shape, thus creating pads with a incorrect shape on board.

Fixes #6495
https://gitlab.com/kicad/code/kicad/issues/6495
 2020-11-25 13:57:46 +01:00
Marek Roszko 5607420339 Fix polylines being skipped in DXF blocks 2020-11-25 00:06:02 -05:00
Ian McInerney d50d728d19 Cleanup compiler warnings 2020-11-25 00:08:09 +00:00
Jeff Young 1cae0b6c08 Make sure board edges have 0 width. 
When we divide up a rectangle or polygon (for better RTree usage)
we need to make sure the individual segments also have their widths
zeroed out.

Fixes https://gitlab.com/kicad/code/kicad/issues/6482
 2020-11-24 23:49:28 +00:00
Jeff Young 9c7c05c161 Mostly formatting cleanup but a few type-casting cleanups too. 2020-11-24 22:16:41 +00:00
Jeff Young 31a26e7d25 Add missing GetEffectiveShape(). 2020-11-24 22:16:27 +00:00
Jeff Young d1bddcf879 Implement GetEffectiveShape() for PCB_TARGET_Ts. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6488
 2020-11-24 20:21:40 +00:00
Jeff Young 2f3f4c209e Make sure DRC reports a missing board outline. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6481
 2020-11-24 14:22:27 +00:00
Jeff Young da0d89645f Default to updating 3D models. 
Also cleans up some user strings to try and make this clearer, and to help
translators make it clearer (neither of which is easy to do).

Fixes https://gitlab.com/kicad/code/kicad/issues/6475
 2020-11-24 13:48:33 +00:00
Marek Roszko 272ec53e03 Make DXF import slightly prettier by copying text style width factor 
It's impossible to replicate the original cad font style but replicating width factors at least
gives you something closer.
 2020-11-24 07:15:49 -05:00
jean-pierre charras f64360e915 pcbnew, diff pair config save: fix truncation due to use of int instead double 
Fixes #6477
https://gitlab.com/kicad/code/kicad/issues/6477
 2020-11-24 09:30:31 +01:00
Marek Roszko c07a38b91b Fix MSVC compilation error with wxString fed to strtol 2020-11-23 21:26:20 -05:00
Marek Roszko 45598f2933 Add handling of DXF arbitrary axis/extrusions 
This fixes some DXFs imports where unforunately CAD tools like SolidWorks
randomly decide to mirror circle definitions across the "z" axis (resulting in x or y axis flips in 2d)
Most likely live projection from 3D to 2D drawings introduces this.
However this is DXF specification to describe it so obtusely with vectors for a 2d drawing.
 2020-11-23 21:24:38 -05:00
Marek Roszko 44f4d41bba Fix member variable name 2020-11-23 21:24:38 -05:00
Jeff Young 41aa97d0d2 Make translations a bit easier. 2020-11-23 22:09:15 +00:00
Jeff Young 5f8a8c6850 Read/write "no net" (0) for pins with a no-connection marker. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2273

Fixes https://gitlab.com/kicad/code/kicad/issues/5587
 2020-11-23 19:47:55 +00:00
Jeff Young 62e5500420 Cleanup dialog layout & punctuation. 2020-11-23 19:47:55 +00:00
Marek Roszko 32ec8fa928 Implement correct placement of DXF block contained entities 
DXF blocks are virtual groups of items.
The insert entity is what actually places all the block contents at a given coordinate.
This should fix importing drawings from professional CAD tools like SolidWorks that will have a good bit of blocks.
 2020-11-23 10:10:35 -05:00
Marek Roszko bf59b422bc Record blocks being received during the import 2020-11-23 10:07:30 -05:00
jean-pierre charras 976c6262f4 French translation update (fix also trailing spaces in a few sentences) 2020-11-23 11:42:25 +01:00
qu1ck b32c2a6c90 Refactor EDA_TEXT::TransformToSegmentList() to return a vector of points 
This allows reading text object as it is rendered through python API.
 2020-11-23 07:50:54 +00:00
Marek Roszko 51fcbe47a6 Remove colons from the import gfx dialog fields 2020-11-22 22:15:58 -05:00
Marek Roszko 90db12df2e Rename the dxf units option to Default Units 
The reality is the DXF file can still override the selected unit option which is totally fine.
In fact, per specification, there is a way to change units mid-file with block records :/
 2020-11-22 22:15:58 -05:00
Marek Roszko f5e9a2a6da Use "microns" as the name to be consistent with DXF specification 2020-11-22 15:44:57 -05:00
Marek Roszko 88bee5e32f Use the last used dxf units selection on dialog open 2020-11-22 15:44:36 -05:00
Marek Roszko 39fe89096e Allow specifying the DXF file units on import 
There is no guarantee DXF contains $INSUNIT to specify the units of the file as its optional.
This allows the user to specify the expected units via dropdown.
SolidWorks can definitely generate such unit lacking files as an example
 2020-11-22 15:39:37 -05:00
Jeff Young c9524e707e Don't load preferences from disk when init'ing PANEL_COLOR_SETTINGS. 
It wipes out any changes that have been made in the SETTIGNS_MANAGER.

Fixes https://gitlab.com/kicad/code/kicad/issues/6339
 2020-11-22 14:24:55 +00:00
Jeff Young 2932fe1e64 Fix rotation of dimension objects. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6424
 2020-11-21 23:53:06 +00:00
Jeff Young 1391774f64 Re-factor boundary/courtyard checker error handling. 
ADDED Footprint Checker dialog to display the results in.

Fixes https://gitlab.com/kicad/code/kicad/issues/6446
 2020-11-21 20:57:35 +00:00
jean-pierre charras 22bbe9618e French translation update 2020-11-21 19:58:13 +01:00
Marek Roszko f130970469 Handle lineweight in dxf import more properly 
lineweights can be set to inherit from the layer or block.
 2020-11-21 09:22:11 -05:00
Jeff Young ff3bd7e72a Fix a crash bug in DRC, and equate Margin to Edge.Cuts. 2020-11-20 21:22:27 +00:00
Jeff Young b123318cf6 Encourage use of full DRC for board & footprint malformed outlines. 
It shows much more detail.  Removes some nag dialogs and places
hypertext links in others.

Also fixes the auto-layer-showing to correctly show Edge.Cuts or
F.CrtYd or B.CrtYd for errors relating to them.

Fixes https://gitlab.com/kicad/code/kicad/issues/6446
 2020-11-20 17:24:52 +00:00
Graham Keeth 4bf79f2b90 Remove ddr3_length_match.py 
The script is designed to be used with a particular board that does not
exist in the repository.
 2020-11-20 08:10:53 +00:00
Marek Roszko d59053b775 Fix dxf import making all circles filled 
Filled objects in dxf is actually not handled at all, they are implemented as "hatched" objects
 2020-11-19 21:00:53 -05:00
Marek Roszko d7e10c22c6 dxflib_qcad: match rename of DimAngularData to DimAngularData2L 
upstream 1655be6c7d58609397e9f04cfaff08336d69b20e
 2020-11-19 19:19:59 -05:00
Jeff Young 533d344e3f Honour pad falshing when colliding with DRC RTree. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6443
 2020-11-19 23:55:14 +00:00
Jeff Young 0d850f98cd Cleanup. 2020-11-19 22:48:18 +00:00
Jeff Young 6e0c58adec Include local clearances even if no implicit rule was found. 
The real test should be to apply it any time an explicit rule is
*not* found.

Fixes https://gitlab.com/kicad/code/kicad/issues/6426
 2020-11-19 22:48:18 +00:00
Jeff Young 0517f783e1 Ease i18n of zone descriptions. 2020-11-19 22:48:18 +00:00
Seth Hillbrand 4e36036435 Avoid calculating on-endpoint hits 
When hitting on a start/end point the arc may incorrectly be assigned as
not-connected when the angle does not wrap around from 0-360

Fixes https://gitlab.com/kicad/code/kicad/issues/6380

Fixes https://gitlab.com/kicad/code/kicad/issues/6380
 2020-11-19 14:46:21 -08:00
Jeff Young 9e9946628a Go back to arrow cursor on a cancel (or finish). 
Fixes https://gitlab.com/kicad/code/kicad/issues/6421
 2020-11-19 20:09:28 +00:00
Jeff Young 203c860f01 Ensure better smoothing for zones clipped by board edges. 2020-11-19 18:34:30 +00:00
Jeff Young 876b87b64e Minor performance fixes for PCBNew selections. 2020-11-19 17:23:02 +00:00
Jeff Young 04c84fa842 Remove some expensive trace calls. 2020-11-19 15:47:32 +00:00
Jeff Young 18ad58cf4c Replace legacy copper edge heuristics. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6435
 2020-11-19 13:35:26 +00:00
Dominik Wernberger 99da663e82 Remove unused variables plus some more fixes from CppCheck 
Remove unused variables plus a few more fixes from CppCheck

Remove unused variables plus a few more fixes from CppCheck
 2020-11-19 02:28:47 +00:00
Werni 0e44f5128c Add const specifiers 2020-11-18 19:50:36 +00:00
Jeff Young c1d1c12b41 Simplify message panel code. 
We've had the colours turned off for two releases now without any
screaming or gnashing of teeth, so it's time to clean up the code.
 2020-11-18 17:32:40 +00:00
jean-pierre charras d3a72f73e3 Kicad: fix environment variable changes after running Pcbnew in some cases. 
When pcbnew is built with python support, the env vars defined inside Kicad
(and used mainly in paths) are rewritten for the python environment.
Unfortunately, the values are rewritten as UTF8 string, but in Kicad they are
just expected in utf32 unicode values.

This is now fixed by rewriting the initial values in Kicad env, after the
python environment is initialized.
 2020-11-18 17:33:58 +01:00
Marek Roszko 16e3e59495 Split out arrayDim and MIRROR templates from macros.h 
These were not macros
 2020-11-17 20:21:04 -05:00
Jeff Young 024812e5dd Resolve legacy netclass definitions read from PCB file. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6415
 2020-11-18 00:17:07 +00:00
Jeff Young bb3cbe3fa4 Pretty-up report a bit. 2020-11-18 00:17:07 +00:00
Jeff Young 54427fd594 Make sure deleted text items are removed from view and selection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6407
 2020-11-17 20:48:15 +00:00
Jeff Young bfc4afc506 Restore the 5.1 NetTie hack. 
We really need to do first-class net ties....

Fixes https://gitlab.com/kicad/code/kicad/issues/6416
 2020-11-17 20:07:21 +00:00
Jeff Young 795e45836d Fix assert in DRC. 2020-11-17 17:41:57 +00:00
Jeff Young b2d86ec7c9 Don't double-check DRC clearances (a:b and b:a). 
Fixes https://gitlab.com/kicad/code/kicad/issues/6417
 2020-11-17 16:58:39 +00:00
Jeff Young a207bd97bb Naming conventions. 2020-11-17 16:05:49 +00:00
Jeff Young dff5173baf Exorcise some instances of "modedit". 2020-11-17 16:05:48 +00:00
jean-pierre charras a431fd99ca Fix crash when converting a Eagle board to a Kicad board. 
During conversion a illegal layer number was used without filtering
 2020-11-17 10:23:44 +01:00
Ian McInerney 7d1a4a4224 Add version information to footprint sexpr files and clipboard 
This allows the parser to properly interpret the sexpr version
of the footprint so that it can throw future format errors or
do version specific parsing properly.
 2020-11-16 23:19:09 +00:00
Jeff Young 7933935b4a Naming conventions. 2020-11-16 00:04:55 +00:00
Jeff Young f21e308830 Tweak fill logic to also catch filled primitives in custom pad shapes. 2020-11-15 23:14:46 +00:00
Ian McInerney ceb51bb103 pcbnew: Only write fill flag for circles, rectangles and polygons 
The other shapes don't have the same concept of being filled
(their fill is only a viewing mode, not an actual saved property).
 2020-11-15 22:03:59 +00:00
Ian McInerney 8c08b861ab Cleanup some compiler and Coverity warnings 2020-11-15 21:41:38 +00:00
Ian McInerney b31e97cfed Fix FP/PCB_SHAPE fill sexpr syntax to be backwards compatible 
Previously the fill for shapes inside a footprint was not being
properly imported from older versions becase the default of no
flag changed from representing filled to representing no fill.

Introduce explicit filling information, and continue to treat no
flag on a polygon as meaning it is filled (which is the legacy
behavior).

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6393
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6390
 2020-11-15 21:28:27 +00:00
Jeff Young 114621eb2c Move footprint shape offset/rotation stuff to the right place. 
Most shapes are already offset/rotated (with thier non-offset/rotated
points in start0, etc.).
 2020-11-15 21:04:12 +00:00
Jeff Young 1ce1e493d6 A rule zone is not really a BOARD_CONNECTED_ITEM. 
Or at least it shouldn't always be treated as one.

Fixes https://gitlab.com/kicad/code/kicad/issues/6382
 2020-11-15 20:23:15 +00:00
Jeff Young b227d2b910 More component -> symbol. 2020-11-15 20:23:15 +00:00
Jeff Young 42687a33ff Terminology and layout cleanup in PCBNew Edit Options 2020-11-15 20:23:15 +00:00
Jeff Young 61821f3ee4 GUI guidelines in PCBNew origin setup. 2020-11-15 20:23:15 +00:00
Jeff Young 3f1a58bd06 Replace "module" with "footprint" in PCB sexpr. 2020-11-15 20:23:15 +00:00
jean-pierre charras 9aa6e40b79 Eeschema, fields_grid_table.cpp: fix a crash when the eeschema settings are not available. 
It happens if the svhematic is not open when opening the symbol editor.
Fix also a compil warning.

Fixes #6384
https://gitlab.com/kicad/code/kicad/issues/6384
 2020-11-15 13:50:10 +01:00
Jeff Young e97faa6afd No need for LAST if the compiler still barks anyway. 2020-11-14 22:02:22 +00:00
Jeff Young d094f86b1a Finish module cleanup (except for xpms). 2020-11-14 22:00:12 +00:00
Jeff Young 6e6f6a2d72 Use legacy boardThickness for via length when we don't have a stackup 2020-11-14 21:22:35 +00:00
Jeff Young 61bca4aaa4 A bit of "module" erradication, nameing conventions, and formatting. 2020-11-14 21:21:54 +00:00
Jeff Young d2a88234b6 Fix issue deleting footprint libraries from table. 
wxWidgets pageChanged handler is evidently buggy.  Who would have
guessed?
 2020-11-14 20:12:49 +00:00
Jeff Young 666c11965a Clean up some more MODULE terms. 2020-11-14 19:56:06 +00:00
Jeff Young 7bd31d5237 Naming conventions. 2020-11-14 18:26:03 +00:00
Jeff Young 2d001796a3 Take into account footprint rotation too. 2020-11-14 17:24:27 +00:00
Jeff Young 2eb71447e4 DRC RTree fixes. 
1) Don't collide against hidden text
2) Don't collide in both directions (a:b & b:a)
 2020-11-14 16:59:34 +00:00
Jeff Young 8bae52d1c3 Correct naming conventions. 2020-11-14 14:29:11 +00:00
Jeff Young 74ad1562d9 Make FP_SHAPE GetEffectiveShape() relative to board, not footprint. 2020-11-14 14:15:02 +00:00
Jeff Young aa06de2db4 Legacy polygons on non-Edge_Cuts layers were always filled. 2020-11-14 14:15:02 +00:00