haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,984 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

1446 Commits

Author SHA1 Message Date
Marek Roszko 24cb0e77eb Fix MSVC builds after recent changes 2021-06-02 23:57:45 -04:00
Ian McInerney d56251fdac Remove universal include of wx.h in 3d viewer OpenGL file 2021-06-03 02:29:09 +01:00
jean-pierre charras a06f965ffa 3Dviewer: fix incorrect drawing of a 3d model hovered by the mouse pointer. 
Was due to a recent change in 3D code.
 2021-05-22 20:23:43 +02:00
jean-pierre charras d1061b9683 3D viewer: Fix broken handling of text thickness, thus creating erroneous item positions 
Especially, texts having a not centered justification were shown with artifacts.
 2021-05-15 13:18:06 +02:00
Jeff Young 7bcd524fbd Fix typo. 2021-05-11 23:14:43 +01:00
Jeff Young ac58a3f9f0 Add preference for 3d-model-highlight-on-rollover. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8349
 2021-05-11 20:53:53 +01:00
Wayne Stambaugh d2a7f81b10 Debugging improvements and clean up. 
* Remove unused wxLogDebug calls.
* Add add application level character tracing to detect unhandled key
  events.
* Catch unhandled exceptions in KiCad main event loop like single top
  applications.
 2021-05-03 18:08:15 -04:00
jean-pierre charras 0427bda768 Remove useless wx/wx.h include, that create sometimes compil warnings on msys. 
wx/wx.h includes all wxWidgets .h files, and sometimes creates collision
names in #define between kicad and windows headers
Moreover, blindly including a lot of useless files is compil time consuming
 2021-05-01 19:32:15 +02:00
Marek Roszko 03cf2b517f Enum class PAD_ATTR_T 
Renamed such that python stays the same
 2021-05-01 10:51:54 -04:00
Marek Roszko b243c2280d enum class PAD_SHAPE_T 2021-05-01 08:22:35 -04:00
Marek Roszko 21fde9b629 enum class PCB_SHAPE_TYPE_T 2021-04-30 22:36:12 -04:00
Marek Roszko a69256e15b Remove extraneous #include 2021-04-30 21:55:48 -04:00
Ian McInerney ecd9bf696e Be consistent about using nullptr instead of 0 
0 can be too easily overloaded into an int, so ensure we use nullptr
when we mean pointers.
 2021-04-22 22:20:34 +01:00
Mario Luzeiro e92dc96767 3D-Viewer: fix issue with solder mask 
Fixes https://gitlab.com/kicad/code/kicad/issues/8272
 2021-04-22 06:26:04 +00:00
Mario Luzeiro cdc8fd3804 3D-Viewer: improve edge texture clamping of end segments 
Fixes https://gitlab.com/kicad/code/kicad/issues/8245
 2021-04-21 06:34:19 +00:00
david-beinder e0f69ad28b 3D viewer: Fix gap between plating and annulus copper 
Hide transition by ending layer copper withing the annulus of the cylinder. Also always use hole wall thickness and set more realistic solder mask thickness
 2021-04-19 13:19:32 +00:00
Wayne Stambaugh 2ae264751f Rename class_board_stackup.{h|cpp} to board_stackup.{h|cpp}. 2021-04-16 17:07:06 -04:00
Mikolaj Wielgus 744e70df36 3D Viewer: Fix mouse panning in orthographic projection mode 
Fixes https://gitlab.com/kicad/code/kicad/issues/5561
 2021-04-10 17:58:50 +00:00
Jon Evans c1573744be Lock project files when opening; open locked projects read-only 
Also clean up an include-what-you-use problem

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8037
 2021-04-02 19:29:56 -04:00
Ian McInerney 0a0935e0f3 Remove ACTIONS::TranslateLegacyId and TOOL_DISPATCHER::DispatchWxCommand 
After commit 9535153f9e there were no more IDs inside the legacy ID
system. Therefore the entire system for dispatching and looking up
the legacy ideas and handling those events can now be removed and
the tool dispatcher simplified (it no longer needs to know about
the ACTIONS class).
 2021-03-30 23:20:22 +00:00
jean-pierre charras 23667fc4c4 3D viewer: make solder paste layer thickness bigger than the mask layer. 
Some specific footprints need shapes on paste layer covering the mask layer,
so ensure these shapes are visible.
Fixes #8041
https://gitlab.com/kicad/code/kicad/issues/8041
 2021-03-26 18:02:30 +01:00
Jon Evans c04e19f9ac Include optimization: move some things from common.h to point-of-use 2021-03-20 12:09:18 -04:00
jean-pierre charras c08f74168c 3D viewer: BOARD_ADAPTER::createPadWithClearance() add missing handling of SH_ARC shape. 2021-03-20 14:15:47 +01:00
Jon Evans 18037e2f65 Rework bitmap system to load from archived PNGs 
Bitmaps are now identified by an enum class instead of by pointers.
Bitmap loading and caching is now handled by a class in common, and
we no longer compile most bitmaps into the binary, so there is no
longer a bitmaps static library.

Instead, bitmaps are archived to a .tar.gz file which is installed
in ${KICAD_DATA}/resources/images.tar.gz

The source PNGs are checked in to Git as the original CPP files were,
so that people can build without the required dependencies to convert
SVGs to PNGs.

Initial support is also added for dark theme icons, although this
is not yet exposed in the GUI.

Stubs are present for multi-resolution image resources, but this is
not fully-baked yet and could use some refinement.
 2021-03-11 08:37:35 -05:00
jean-pierre charras fe02155b5a 3D viewer, DIALOG_3D_VIEW_OPTIONS_BASE: fix minor wxWidgets alerts and Add 
minor cosmetic changes.
Fixes #7846
https://gitlab.com/kicad/code/kicad/issues/7846
 2021-03-09 11:23:33 +01:00
Dominik Wernberger e2aa7be4b3 Added a lot of consts and refactored a few lines 2021-03-08 12:49:48 -08:00
Jon Evans 720147d272 Remove transitive inclusion of bitmaps.h 2021-03-07 16:08:57 -05:00
Seth Hillbrand 283d176cdc Use std::locale::classic() globally 
This is a better alternative when imbuing streams
 2021-02-26 17:21:55 -08:00
kamp 0a9a9d625e Fix BBOX_3D documentation 2021-02-24 17:45:53 +00:00
Marek Roszko 907e282347 Silence some msvc warnings 
- exception variables that were unused
- RAYSEG2D improperly foward declared with class instead of struct
- unused vars
 2021-02-20 11:58:55 -05:00
Jeff Young 66b33834b5 Always enable save; move dirty bit to asterisk in title bar. 
Also unifies PCB Editor and Schematic Editor names with other
locations in the GUI (which were still Pcbnew and Eeschema).

Fixes https://gitlab.com/kicad/code/kicad/issues/7587

Fixes https://gitlab.com/kicad/code/kicad/issues/7594
 2021-02-18 16:05:42 +00:00
Jeff Young b6a7981e62 Write changes back to grid after using file explorer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7361
 2021-02-17 14:08:53 +00:00
Marek Roszko b609c7dcd6 Kick the osx specific path helpers into PATHS 2021-02-16 23:29:26 -05:00
Marek Roszko 2370ca1b0e Minor code clean, standard "new" does not need to be null checked 
Because it will bad_alloc exception you instead :D
Silence PVS Studio V668 Warnings
 2021-02-16 18:24:59 -05:00
Marek Roszko f2552d7bc1 Tweak the reported last render message slightly 2021-02-15 17:47:43 -05:00
Marek Roszko f88be65825 Remove mention of FPS 
We are not a real time rendering engine
 2021-02-15 17:00:00 -05:00
Marek Roszko 36d8ca7954 Fix statusbar conflict in 3d viewer 
Fix #7544
 2021-02-15 17:00:00 -05:00
Marek Roszko 872184fe8b Revert "Bump minimum required CMake version to 3.10" 
This reverts commit a475f45753.
 2021-02-09 18:46:13 -05:00
Simon Richter a475f45753 Bump minimum required CMake version to 3.10 
This allows us to remove even more workarounds
 2021-02-08 12:23:08 +00:00
Seth Hillbrand 624a231cc0 Remove unused line width option 
You had to set the line width in the SVG export dialog in order to
change the displayed line width in the 3d viewer.  The line width did
not affect the SVG export.  Removing in favor of the Board design
settings for line widths
 2021-02-06 06:44:53 -08:00
Roberto Fernandez Bautista 9aedeae5c3 Don't log error messages when using the clipboard 
wxClipboard::GetData()and wxClipboard::SetData() both log a "wxLogSysError" error-level message (see for example:  https://github.com/wxWidgets/wxWidgets/blob/v3.1.4/src/msw/clipbrd.cpp#L703 ). This logged message gets displayed as a messagebox to the user.

The logging can be disabled temporarily by creating a wxLogNull object. See https://docs.wxwidgets.org/3.0/classwx_log_null.html

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6956
 2021-02-03 01:55:05 +00:00
Marek Roszko bf2e7215a5 const SGPOINT::GetPoint args 2021-02-01 08:13:00 -05:00
Jeff Young e72262a007 Don't render un-enabled layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7313
 2021-01-30 16:31:27 +00:00
Marek Roszko 914568f1a0 Fix macos using the wrong 3d plugins path 2021-01-27 19:12:19 -05:00
Marek Roszko daf9c4f319 Centralize the 3d cache path 2021-01-27 19:12:19 -05:00
Marek Roszko 7b5397f81f Move PLUGINDIR to the make config.h 2021-01-27 19:12:19 -05:00
Marek Roszko 14327f3708 Cleanup the 3d plugins paths a little bit 2021-01-27 19:12:18 -05:00
Wayne Stambaugh 6ab1144ea3 Fix broken Doxygen comment specifiers. 
Please note, ///> is not a valid Doxygen comment specifier.  ///< is the
correct specifier to use for single line or short Doxygen comments.
 2021-01-25 07:42:36 -05:00
Michael Kavanagh b90eabd68b Icons: out with the old, in with the new 
+ remove icons where they dont make sense or are duplicated within the
same context
 2021-01-19 22:57:24 +00:00
Michael Kavanagh 50e22de3ba Remove empty option from 3D Viewer dropdown 2021-01-17 23:11:29 +00:00
Roberto Fernandez Bautista 49f454e32b Line width already factored into polygon shapes 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7130
 2021-01-16 08:39:20 +00:00
Jeff Young ee6ec2c35c Line width already factored in to rectangle polygon. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7113
 2021-01-14 16:54:20 +00:00
Wayne Stambaugh 2d64613bbb Coverity fixes. 
Reports 314745, 316271, and 316269.
 2021-01-13 11:23:09 -05:00
Wayne Stambaugh 6f0319e29f Fix potential bug in 3D model selection dialog. 
Calling EndModal or EndQuasiModal will cause KiCad to hang if the dialog
was not opened in the same manor.  The modality of the dialog must be
checked and the appropriate end method must be called or emulate a button
click which allows the default dialog close method to be called to handle
shutting down the dialog correctly.
 2021-01-13 09:20:23 -05:00
Seth Hillbrand 26524ef41e Select model on double-click 
Fixes https://gitlab.com/kicad/code/kicad/issues/7070
 2021-01-12 15:21:29 -08:00
Jeff Young 751fdbf278 Simplify layout & terminology in 3D settings dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6659
 2021-01-09 20:53:24 +00:00
Wayne Stambaugh 926cc3a00d 3D Viewer: more code cleaning and naming improvements. 2021-01-07 14:33:43 -05:00
jean-pierre charras 86be755c83 Fix compil warning: do not use class instead of struct in forward declarations 2021-01-06 09:29:03 +01:00
Wayne Stambaugh 1c7a5c46e5 3D Viewer: member variable and method naming improvements. 
A few build improvements thrown in for a good measure.
 2021-01-05 17:24:29 -05:00
Michael Kavanagh a7286ccc34 Icons: remove functional duplicate 2021-01-04 01:44:01 +00:00
Wayne Stambaugh 710e621c6a 3D Viewer: remove all instances of "c" prefix from file names. 2021-01-03 17:44:49 -05:00
Michael Kavanagh 791d1f513c Icons: fix some 3D viewer icons 
- remove old palette icon in favour of new one
 - use dark grey in new icon (instead of light grey)
 - use generic gear for 3D display options
 2021-01-02 23:16:33 +00:00
Wayne Stambaugh 8416c1fc37 3D Viewer: remove all instances of "C" prefix from object names. 2021-01-02 17:45:36 -05:00
Seth Hillbrand 8de9cff4e0 Change environmental variables to human-readable 
Versions specific variables that may point to objects that change
through versions, allowing multiple KiCad versions to operate correctly
(even on MSW) on the same machine.
 2021-01-01 16:20:35 +00:00
Jeff Young 5ea88c897a Go back to AuiMgr strategy for 3D-viewer infobar. 
There some issue with using the 3D canvas as a parent in the new
strategy.
 2020-12-27 01:01:25 +00:00
Jeff Young 0b6c524dda Missing file from last commit. 2020-12-24 21:35:31 +00:00
Jeff Young ef25c78a04 Separate polygonization error from chaining error. 
This way we can report anything that doesn't exactly chain while still
applying  a fudge factor for our own stuff.

Fixes https://gitlab.com/kicad/code/kicad/issues/1795
 2020-12-24 21:02:14 +00:00
Dominik Wernberger caf300aa33 Fix memory leak 2020-12-24 17:33:33 +00:00
Michael Kavanagh eb1f07bade Icons: standardise `export_png` to match set 2020-12-24 01:02:03 +00:00
Jeff Young 47ea51ec34 Allow both aui-manager-based infobars and window overlay infobars. 2020-12-22 21:36:39 +00:00
Wayne Stambaugh f311831c27 Coverity fixes. 
280252, 314742, 314745, 314747, 314755, 314756, 314757, 314758,
314935, 314936
 2020-12-20 13:24:47 -05:00
Jeff Young 0ba175f28c Formatting. 2020-12-19 00:21:28 +00:00
Wayne Stambaugh aab3c936f0 Move headers from common folders to appropriate include folders round 2. 2020-12-17 11:44:03 -05:00
Ian McInerney 048900dda7 Fixup the 3d Viewer code after the last fixup 2020-12-17 00:30:22 +00:00
Marek Roszko a3c4730a3f Add missing return removed in 978935d 2020-12-16 19:03:27 -05:00
Wayne Stambaugh f8efe4a65a 3D viewer code cleaning round 5. 2020-12-16 17:11:05 -05:00
Wayne Stambaugh 978935d749 3D viewer code cleaning round 4. 2020-12-16 13:19:28 -05:00
jean-pierre charras 5e394836d2 Fix a wxWidgets alert. 
Fixes #6743
https://gitlab.com/kicad/code/kicad/issues/6743
 2020-12-15 15:46:52 +01:00
Seth Hillbrand 9a7b161f8e Update rotate icons to clarify action 
Rename icons to make it easier for folks looking at code names

Fixes https://gitlab.com/kicad/code/kicad/issues/6737
 2020-12-14 12:23:08 -08:00
Wayne Stambaugh 4d128b819a 3D viewer code cleaning round 3. 2020-12-13 18:02:57 -05:00
Wayne Stambaugh 9e22499350 3D viewer code cleaning round 2.1. 2020-12-12 12:35:31 -05:00
Wayne Stambaugh 1eba0c435b 3D viewer code cleaning round 2. 2020-12-12 12:35:31 -05:00
Wayne Stambaugh d1fe4a0c98 3D viewer code cleaning round 1. 2020-12-11 08:51:42 -05:00
Jeff Young 73b7b104cd Fix some issues with Infobar sizing. 
This also commits to the new strategy as it wasn't really compatible
with if-def-ing anymore.
 2020-12-11 12:39:40 +00:00
Jeff Young b1f0bf7334 More consistent naming. 2020-12-08 13:05:39 +00:00
Jeff Young 58afaeb9eb Use QuasiModal in all parents of ConfigPaths so help window works. 2020-12-06 18:44:24 +00:00
jean-pierre charras e6550fb92e 3D viewer: fix a draw issue: missing holes. 
Fixes #6608
https://gitlab.com/kicad/code/kicad/issues/6608
 2020-12-04 16:35:57 +01:00
Jeff Young 7f360a7188 Some renaming in 3D code for better SNR. Also formatting fixes. 2020-11-30 14:38:06 +00:00
Jeff Young 3ca06700fc Formatting. 2020-11-29 20:00:16 +00:00
Jeff Young 889408c96a More improvements to new selection disambiguation. 
Also a rationalization of text polygon generators, with the "standard"
version inherited from BOARD_ITEM now giving the bounding box.  This
requires callers who want the (much) more expensive stroke-based one
to call it explicitly (and brings PCB_TEXT in line with the was FP_TEXT
already was.

Fixes https://gitlab.com/kicad/code/kicad/issues/6525
 2020-11-29 14:02:46 +00:00
Jeff Young 9c7c05c161 Mostly formatting cleanup but a few type-casting cleanups too. 2020-11-24 22:16:41 +00:00
Jeff Young 2f3f4c209e Make sure DRC reports a missing board outline. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6481
 2020-11-24 14:22:27 +00:00
Jeff Young 1391774f64 Re-factor boundary/courtyard checker error handling. 
ADDED Footprint Checker dialog to display the results in.

Fixes https://gitlab.com/kicad/code/kicad/issues/6446
 2020-11-21 20:57:35 +00:00
Jeff Young b123318cf6 Encourage use of full DRC for board & footprint malformed outlines. 
It shows much more detail.  Removes some nag dialogs and places
hypertext links in others.

Also fixes the auto-layer-showing to correctly show Edge.Cuts or
F.CrtYd or B.CrtYd for errors relating to them.

Fixes https://gitlab.com/kicad/code/kicad/issues/6446
 2020-11-20 17:24:52 +00:00
Marek Roszko 16e3e59495 Split out arrayDim and MIRROR templates from macros.h 
These were not macros
 2020-11-17 20:21:04 -05:00
Jeff Young a207bd97bb Naming conventions. 2020-11-17 16:05:49 +00:00
Wayne Stambaugh c7926db553 More minor dialog layout improvements. 2020-11-16 07:29:07 -05:00
Mario Luzeiro 8b9be2e129 3D-Viewer: fixes generations of layer lists 
Fixes https://gitlab.com/kicad/code/kicad/issues/6385
 2020-11-15 16:55:16 +00:00
Jeff Young 7bd31d5237 Naming conventions. 2020-11-14 18:26:03 +00:00
Jeff Young ec020dd19f First-class support for filled shapes. 2020-11-14 01:40:32 +00:00
Jeff Young bdbb68f813 MODULE -> FOOTPRINT. 2020-11-13 16:04:03 +00:00
Jeff Young 3451ac3088 PCB_MODULE_T -> PCB_FOOTPRINT_T 2020-11-13 15:16:24 +00:00
Jeff Young 63a54d003e More module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young 522d64968e Yet more module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young 9106cc19bf Yet another tranche of module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young 8c947b69b0 More module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young fc9cf1d827 More module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young 52a46341db More module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young f5443de7f9 D_PAD -> PAD. 2020-11-13 15:16:24 +00:00
Jeff Young 84dd5108ba Remove some "class_" prefixes from files. 2020-11-13 15:16:23 +00:00
Jeff Young f7333ad64a Update some classnames including archaic zone names. 2020-11-12 10:31:25 +00:00
Mario Luzeiro 8ec0cef572 3D-Viewer: Fixes correct copper plated color in Raytracing mode 2020-11-11 20:09:12 +00:00
Mario Luzeiro 5841ea3cd2 3D-Viewer: Raytracing, add silkscreen texture 
improves other textures
 2020-11-11 16:22:34 +00:00
jean-pierre charras 6570cd5850 minor compil warning fix 2020-11-11 12:28:37 +01:00
Mario Luzeiro c08f9ac9f6 3D-Viewer: properly clears the container 
Fixes https://gitlab.com/kicad/code/kicad/issues/6346
 2020-11-11 09:42:14 +00:00
Ian McInerney 11e6cac42b Introduce EGL backend support for the OpenGL canvas 
wxWidgets 3.1.5+ on Linux will compile with the Wayland EGL
canvas as the backend instead of the X11 backend. This requires a
version of GLEW compiled with the proper EGL defines and a different
header/code for certain parts that are X11 GLEW specific.

This introduces an in-tree version of GLEW that will be built with the
GLEW_EGL flag then statically linked into the KiCad executables when
EGL support is needed.
 2020-11-11 00:41:02 +00:00
Mario Luzeiro e105451f44 3D-Viewer: when possible, uses only the board edges to calculate boundings 
Add Report messages to Raytracing

Fixes https://gitlab.com/kicad/code/kicad/issues/6316
 2020-11-10 17:32:24 +00:00
Mario Luzeiro 753383d6ec 3D-Viewer: disable layer subtraction operations on non realistic mode 2020-11-10 14:40:42 +00:00
Mario Luzeiro a9be08e1ce 3D-Viewer: skip layers not created 
Fixes https://gitlab.com/kicad/code/kicad/issues/6324
 2020-11-10 13:57:52 +00:00
Wayne Stambaugh 4ea3914d4e Coverity fixes. 
CIDs: 312996, 305508, 305509, 305510, 312992, 312997, 312994, 312995,
312968, and 306650.
 2020-11-10 08:50:16 -05:00
Mario Luzeiro 82bd232737 3D-Viewer: mark flag as initialized 
Fixes https://gitlab.com/kicad/code/kicad/issues/6331
 2020-11-09 13:19:28 +00:00
Roberto Fernandez Bautista ae26c92a16 Remove modal message box when catching exceptions in EDA_3D_CANVAS::DoRePaint 
Rely on the wxInfobar instead
 2020-11-07 15:39:57 +00:00
Roberto Fernandez Bautista 1bbc569151 Fix DoRePaint routine in EDA_3D_CANVAS 
- Check that we aren't already painting (return if we are)
 - Check that GLEW functions exist before calling them in 3D canvas and throw exception if they are no longer available
 - Catch above exceptions in paint routine and show an infobar message to the user
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6246
 2020-11-07 15:39:57 +00:00
Mario Luzeiro 9454f9df92 3D-Viewer: OpenGL, enable by default the AA 
fixes an issue that disables AA when it back from Raytracing mode
 2020-11-06 20:21:40 +00:00
Mario Luzeiro 89fea36ddd 3D-Viewer: OpenGL, remove outline polygons where it intersects a hole at edge of board 2020-11-06 20:21:40 +00:00
Mario Luzeiro 4b6c602537 3D-Viewer: OpenGL, cut outline on plated pads 2020-11-06 20:21:40 +00:00
Mario Luzeiro 5e371b5f29 3D-Viewer: OpenGL, fix z-fight issue 2020-11-06 20:21:40 +00:00
Mario Luzeiro 78b461a41d 3D-Viewer: OpenGL outline, implement an outline board cut 2020-11-06 20:21:40 +00:00
Mario Luzeiro 3fce3b6591 3D-Viewer: fix code style 2020-11-06 20:21:40 +00:00
Mario Luzeiro 386a0bbe4a 3D-Viewer: add antiboard as a single object 
improves ray transversal,
fixes previous csg operation issues.

Fixes https://gitlab.com/kicad/code/kicad/issues/6097
 2020-11-06 20:21:40 +00:00
Mario Luzeiro b06db80151 3D-Viewer: raytracing, implement an outline board cut 
it cut board items that are outside and on the edge of the board.
Allows castellations render.
 2020-11-06 20:21:40 +00:00
Marek Roszko 08ca80a2d8 Smooth out redrawing of toolbars by not letting wx pointlessly calculate both orientations 
Monkey patch

Fix #5705
 2020-11-05 20:56:14 -05:00
Oleg Endo a238209f3f Add group-by-suffix display option in net inspector 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2469
 2020-11-04 02:49:19 +00:00
Ian McInerney 3d47eb0d49 Fix localization of the menu strings with accelerator strings 
The accelerator strings really shouldn't be part of the translation,
and some translations have cause the accelerator keys to be incorrectly
handled. It is simpler to make it separate and just join them to the
translated string.

Make all accelerator modifiers use lowercased Ctrl instead of CTRL
to be the same as the other modifiers.

Fixes https://gitlab.com/kicad/code/kicad/issues/5992
 2020-11-04 01:31:52 +00:00
Jeff Young 5a644aa3fb QuasiModal needs to be used for any dialog hosting a help window. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5897
 2020-10-28 23:07:15 +00:00
Marek Roszko 04697c5fe8 Avoid 3d viewer stealing back focus/activation 
Fix #6184
 2020-10-27 19:35:55 -04:00
jean-pierre charras 73c7154891 Fix another Coverity warning. 2020-10-27 14:16:38 +01:00
Ian McInerney 6bd3b0afa4 Various Coverity fixes 2020-10-27 00:25:08 +00:00
jean-pierre charras c092e3f8b7 Fix a few minor Coverity warnings 2020-10-26 10:46:08 +01:00
Marek Roszko 91e5611341 Move dialog_configure_paths.h and dialog_edit_library_tables.h to dialogs folder 2020-10-25 20:01:12 -04:00
Marek Roszko eeac3cb4d5 Nix some more common.h includes 2020-10-24 00:38:25 -04:00
Marek Roszko 304e5faf36 Move wxStringSplit to kicad_string 2020-10-24 00:17:07 -04:00
Jeff Young cce557b9ad Redo the board-edge-building logic to return better error reports. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6119
 2020-10-22 21:29:04 +01:00
Seth Hillbrand f8a4edb1c9 First pass renaming module to footprint 
This is mostly in comments and the few remainin text strings that
reference module
 2020-10-20 20:49:11 -07:00
Seth Hillbrand 4085757aeb Remove beginning/ending spaces in translations 
Adding space padding makes translations more difficult by increasing
string counts
 2020-10-20 12:08:04 -07:00
jean-pierre charras 539ac4c214 Remove a few include<wx/wx.h> in many files that do not actually use this include. 2020-10-19 09:00:50 +02:00
jean-pierre charras f6b4b66a86 Avoid include wx/wx.h in many files that do not actually use this include. 
Including wx.h includes the full set of wxWidgets include files, that is not good,
and can create some conflicts with some Windows headers on msys2.
 2020-10-18 18:21:34 +02:00
Ian McInerney 06f01d0d8a Add platform-specific code to allow wxChoice to ellipsize 
Fixes https://gitlab.com/kicad/code/kicad/issues/5377
 2020-10-17 23:20:13 +01:00
Jeff Young 92d84b0d67 Naming updates. 2020-10-15 01:35:16 +01:00
Jeff Young 1703729269 Require explicit decl of maxError and errorLocations. 
This should reduce both performance issues and clearance issues.
 2020-10-13 13:49:07 +01:00
Jeff Young 07f139381b Nullptr safety. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5893
 2020-10-06 12:49:29 +01:00
Jeff Young 52794b3456 Nullptr safety. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5893
 2020-10-06 12:08:31 +01:00
Mario Luzeiro d31c5c41e6 3D-Viewer: add an infobar to the panel preview 2020-10-06 10:42:46 +00:00
Mario Luzeiro 1cbe8fcc1f 3D-Viewer: check for minimum required version of OpenGL 
Fixes https://gitlab.com/kicad/code/kicad/issues/5286
 2020-10-06 10:42:46 +00:00
Jeff Young 37906511f5 Class renaming. 
DRAWSEGMENT  -> PCB_SHAPE
EDGE_MODULE  -> FP_SHAPE
TEXTE_PCB    -> PCB_TEXT
TEXTE_MODULE -> FP_TEXT
 2020-10-05 11:55:33 +01:00
Mark Roszko a28a0e14ba Fix conversion warnings 2020-10-05 10:41:14 +00:00
Jeff Young 7a4900b8dc PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T 
Also updated footprint text and zone types for consistencey.
 2020-10-04 16:49:04 +01:00
jean-pierre charras bda275de46 more cleanup about removing useless include 2020-10-03 11:48:16 +02:00
Mario Luzeiro cea1a56f5f 3D-Viewer: set default alpha when import from legacy 
keep the current alpha when import colors from stackup.
request a refresh instead of a reload when using OpenGL render.

Fixes https://gitlab.com/kicad/code/kicad/issues/5717
 2020-10-02 23:14:42 +00:00
Jeff Young 5b7c6e100d Clip tech layers to board in 3D renderer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4873
 2020-10-01 16:50:22 +01:00
Jeff Young 3c01147f10 Fix 3D hole knock-out of silkscreen. 
It still doesn't knock-out the board edges, but this is a good first
step.

Fixes https://gitlab.com/kicad/code/kicad/issues/4837
 2020-10-01 11:49:28 +01:00
jean-pierre charras 42350a4928 Minor code cleanup: remove useless include or useless code. 
fix also a minor compil warning
 2020-10-01 11:36:15 +02:00
Ian McInerney 38584e55dd Don't process an invalid window position 
This is used for computing a vector index, so it can't be
negative.
 2020-09-30 23:34:04 +01:00
Ian McInerney a5ed5e5675 Handle single line segments on footprint edgecuts 
Also, only display an infobar message for footprints when
there is no footprint loaded (instead of if the outline
isn't closed).

Fixes https://gitlab.com/kicad/code/kicad/issues/4866
 2020-09-30 23:34:04 +01:00
Ian McInerney 78c43158f4 Annotate the board class with if it is for a footprint edit/view 2020-09-30 23:34:04 +01:00
jean-pierre charras 3f8c9d49f8 Revert "Code cleanup: remove useless wx/wx.h include inside a few files." 
due to compil issue on Linux

This reverts commit cffccc3970.
 2020-09-30 20:47:20 +02:00
jean-pierre charras cffccc3970 Code cleanup: remove useless wx/wx.h include inside a few files. 
in most of files, including wx.h is not necessary, when only 2 or 3 wx files must be included.
Moreover, on windows, including wx.h sometimes create compil warnings about
shadowed vars defined in some specific windows headers.
 2020-09-30 20:03:27 +02:00
Seth Hillbrand bf3cb0b1d0 Standardize pad type enums 2020-09-30 08:38:35 -07:00
Jeff Young d3f8f2b81e Remove confusion between pad->IsOnLayer and pad->IsPadOnLayer 2020-09-30 11:50:51 +01:00
Mario Luzeiro ab57c93c98 3D-Viewer: add selection color as an option 2020-09-28 02:26:25 +00:00
Mario Luzeiro ec3c20bf84 3D-Viewer: do not use selection while on preview 2020-09-28 02:26:25 +00:00
Mario Luzeiro 6db0c58e8f 3D-Viewer: fix some code style 2020-09-28 02:26:25 +00:00
Mario Luzeiro 5205709399 3D-Viewer: use LAYER_SELECT_OVERLAY color for selection 
preserve material transparency while rendering as selected
 2020-09-28 02:26:25 +00:00
Mario Luzeiro 10676eb926 3D-Viewer: only show intersection information while using opengl 2020-09-28 02:26:25 +00:00
Mario Luzeiro 3f2cada6c6 3D-Viewer: fix a bug introduced in the previous commits 2020-09-28 02:26:25 +00:00
Mario Luzeiro 6bc19dbfe9 3D-Viewer: intercect modules and cooper items 
show module and net information.
highlight shapes when selected.
 2020-09-28 02:26:25 +00:00
Mario Luzeiro a1e94c2583 3D-Viewer: request a redraw when a footprint is selected in pcbnew 2020-09-28 02:26:25 +00:00
Mario Luzeiro fe51cc947c 3D-Viewer: render 3D shapes in green if footprint is selected 2020-09-28 02:26:25 +00:00
Mario Luzeiro c7a546042e 3D-Viewer: add skip material to model loading 2020-09-28 02:26:25 +00:00
Mario Luzeiro 0ab82ef66a 3D-Viewer: add an option to enable render of plated pads 
by default this option is disabled and will render as in previous
version.
 2020-09-27 13:35:55 +00:00
Ian McInerney fc565edb33 Add a palette to the toolbars to display groups of actions 
This adds a palette to toolbar items that displays groups
of actions when long-pressed on a button.
 2020-09-27 01:00:44 +01:00
jean-pierre charras 0b03d8a5ff Fix a few Coverity warnings. 2020-09-20 16:30:23 +02:00
jean-pierre charras 6ec6baf401 3d viewer: save color settings. 
The call to SaveColorSettings() was not at the right place, and the new
color settings never saved.

Fixes #5529
https://gitlab.com/kicad/code/kicad/issues/5529
 2020-09-17 17:15:25 +02:00
Jon Evans e9b627bfd8 ADDED: Center marker dimension type 2020-09-16 20:55:11 -04:00
Jon Evans 75ffce1a0b ADDED: Leader dimension object 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
 2020-09-15 23:37:38 -04:00
jean-pierre charras 98339cd5eb 3d viewer: fix incorrect calculation of pad hole size of vertical shape. 
Fixes #5627
https://gitlab.com/kicad/code/kicad/issues/5627
 2020-09-15 10:17:31 +02:00
Jon Evans b11e315d10 Refactor DIMENSION to hide internal details; add some new properties 
This is a board file format change to account for the new properties.
Also, we now only store the critical information about the dimension's
geometry in the board, rather than storing every drawn line.

The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION
is the implementation that exists today (we will add more dimension
types in the future)
 2020-09-11 21:12:36 -04:00
Jeff Young e2bc7557cc Clean up arc/circle polygonization. 
1) For a while now we've been using a calculated seg count from a given
maxError, and a correction factor to push the radius out so that all
the error is outside the arc/circle.  However, the second calculation
(which pre-dates the first) is pretty much just the inverse of the first
(and yields nothing more than maxError back). This is particularly
sub-optimal given the cost of trig functions.

2) There are a lot of old optimizations to reduce segcounts in certain
situations, someting that our error-based calculation compensates for
 anyway.  (Smaller radii need fewer segments to meet the maxError
condition.) But perhaps more importantly we now surface maxError in the
UI and we don't really want to call it "Max deviation except when it's
not".

3) We were also clamping the segCount twice: once in the calculation
routine and once in most of it's callers.  Furthermore, the caller
clamping was inconsistent (both in being done and in the clamping
value). We now clamp only in the calculation routine.

4) There's no reason to use the correction factors in the 3Dviewer;
it's just a visualization and whether the polygonization error is
inside or outside the shape isn't really material.

5) The arc-correction-disabling stuff (used for solder mask layer) was
somewhat fragile in that it depended on the caller to turn it back on
afterwards.  It's now only exposed as a RAII object which  automatically
cleans up when it goes out of scope.

6) There were also bugs in a couple of the polygonization routines where
we'd accumulate round-off error in adding up the segments and end up with
an overly long last segment (which of course would voilate the error
max). This was the cause of the linked bug and also some issues with vias
that we had fudged in the past with extra clearance.

Fixes https://gitlab.com/kicad/code/kicad/issues/5567
 2020-09-11 11:23:49 +01:00
Seth Hillbrand 08d4e91f3b Change partitions to fixed size 
Partititioning small polygons causes excessive partitions when we use a
fixed number of cells per side.  Partitioning by size keeps the
partition count limited and speeds the calculations.

Also adds an option to not partition the grid for elements (like 3d
raytracing) that do not need it.

Fixes https://gitlab.com/kicad/code/kicad/issues/5579
 2020-09-10 09:31:20 -07:00
Mario Luzeiro d52c475b27 3D-Viewer: implements plated copper texture 
improves copper and board textures.
Related to https://gitlab.com/kicad/code/kicad/-/issues/2058
Use only one PerlinNoise class.
 2020-09-08 21:02:20 +00:00
Mario Luzeiro f0edbd088c 3D-Viewer: fixing z-fight issues 2020-09-08 21:02:20 +00:00
Mario Luzeiro e288218c4f 3D-Viewer: subtract pads poly to F_Cu and B_Cu poly layers 2020-09-08 21:02:20 +00:00
Mario Luzeiro d7a95951e1 3D-Viewer: implement nonplated copper on raytracing 2020-09-08 21:02:19 +00:00
Mario Luzeiro 1ab968e72f 3D-Viewer: render different materials plated and non plated copper 
implement on OpenGL
 2020-09-08 21:02:19 +00:00
Mario Luzeiro 3544bc09fd 3D-Viewer: remove not used inner holes containers 2020-09-08 21:02:19 +00:00
Jeff Young 2251716784 Don't show 3D models with their show flag set to false. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5548
 2020-09-08 20:42:09 +01:00
qu1ck 636285311e Make DRAWSEGMENT::GetRectCorners return vector 
... instead of modifying the argument.
This will make the method usable in python API and will not incur
permormance penalty because named return value optimization (NRVO)
is a thing since C++11.
But even if copy is not elided vector is moved instead of copied.
https://en.cppreference.com/w/cpp/language/copy_elision
 2020-09-07 05:33:10 +00:00
Mario Luzeiro 306a8f57f7 3D-Viewer: Parameterize sampling options 2020-09-04 15:12:01 +00:00
Mario Luzeiro 2feef44fca 3D-Viewer: Limit the recursive reflection level 
Fixes https://gitlab.com/kicad/code/kicad/issues/5426
 2020-09-01 01:08:38 +00:00
Mario Luzeiro 820e3089a2 3D-Viewer: use the correct opacity meaning in the color settings 2020-09-01 01:08:38 +00:00
Mario Luzeiro 7c9bb9ab07 3D-Viewer: add color to "Clear Color" action in the color picker 2020-09-01 01:08:38 +00:00
Mario Luzeiro 40d5746df6 3D-Viewer: Parameterize body board transparency 
Fix/workarround raytracing render issues related with refraction
 2020-09-01 01:08:38 +00:00
Mario Luzeiro 0302fe5570 3D-Viewer: Parameterize soldermask transparency 2020-09-01 01:08:37 +00:00
Jeff Young 56a531109a Don't try and shrink shapes generated from pads. 
It ends up being different from shrinking the final outline.
 2020-08-28 20:48:47 +01:00
Jeff Young b65bb8e7a8 Fix some out-of-order parameters that compiler didn't catch. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5363
 2020-08-28 15:17:45 +01:00
Jeff Young ebb9a636fa Handle differential x:y clearance for solder mask. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5363
 2020-08-28 14:00:37 +01:00
Jeff Young 2c4269d03e When inflating dummy pad make sure to reset clearance to zero. 
And, the inflate-dummy-pad hack doesn't work for custom pad shapes,
so turn it off there.

Fixes https://gitlab.com/kicad/code/kicad/issues/5363
 2020-08-28 11:05:58 +01:00
Jeff Young 9e12ea9bb6 Cleanup some dead code and make better use of iterators. 
Also applies coding style around auto and lambdas.
 2020-08-28 11:05:58 +01:00
Jeff Young e7db43285f ADDED new footprint fabrication attributes. 
This commit also adds mapping of the new symbol properties
"exclude from BOM" and "exclude from board" to be correctly
handled in Update Board from Schematic.

Fixes https://gitlab.com/kicad/code/kicad/issues/2399

Fixes https://gitlab.com/kicad/code/kicad/issues/4643

Fixes https://gitlab.com/kicad/code/kicad/issues/2233
 2020-08-28 11:05:58 +01:00
Mario Luzeiro 744a8f011e 3D-Viewer: add button to reset light defaults 
Fixes https://gitlab.com/kicad/code/kicad/issues/

Fixes https://gitlab.com/kicad/code/kicad/issues/
 2020-08-19 01:57:22 +00:00
Wayne Stambaugh ede39780e2 Remove all debugging output that cannot be disabled. 
The use of printf, wxLogDebug, and std::err/std::out causes excessive
debugging output which makes finding specific debugging messages more
difficult than it needs to be.

There is still some debugging output in test code that really needs to
be moved into a unit test.

Add debugging output section to the coding policy regarding debugging
output.
 2020-08-18 10:17:36 -04:00
Mario Luzeiro 2764a41d96 3D-Viewer: fixes a shadow hit bug 2020-08-18 00:31:35 +00:00
Jeff Young 66ff16dd3d Better board-edge error reporting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4950
 2020-08-17 23:55:31 +01:00
jean-pierre charras 5b365053db Fix a few I18n issues. 
Especially, only ASCII7 chars can be used in messages.
Do not mark debug messages as I18n strings
 2020-08-17 09:18:49 +02:00
Ian McInerney 45fb030b9b Rename and shorten the names in ACTION_CONDITIONS 2020-08-16 19:10:25 +00:00
Ian McInerney f34ffd3906 Migrate more 3d viewer actions to the tool framework 2020-08-16 19:10:25 +00:00
Ian McInerney 72a1c71e07 Implement a framework to handle wxUpdateUIEvents for tool actions 
This allows for the tool framework to keep track of a universal
set of conditions for the UI state (enabled/checked/shown) for
controls of actions. It removes the need for the main menubar
menus to be CONDITIONAL_MENUs and be rebuilt on each open,
and instead makes the updates of the check and enabling of
items handled in the native wxWidgets way.

This commit switchs the 3d viewer and kicad project manager window
over to this system.
 2020-08-16 19:10:25 +00:00
Mario Luzeiro 78ac675316 3D-Viewer: parameterize raytracing lights, add it to options dialog 
Remove some hacks related to postprocessing (not need now because the
previous postprocessing improvements, light parametrization could be
used for tune or future parameters could be implemented)
 2020-08-15 09:41:34 +01:00
jean-pierre charras ffabc17372 style cleanup and a few comments added. 2020-08-13 14:17:53 +02:00
Jeff Young 393bb0fd83 Fix assert where geometry routine wasn't ready to handle layers. 
This introduces layer handling to a lot of the geometry routines.
Many of them don't do much with it now, but it does help multi-layer
zones and will help when padstacks are implemented.
 2020-08-12 22:20:08 +01:00
Jeff Young 463100d67f Remove a long-standing hack to keep divots out of adjacent zones. 
The new algorithm unions any adjacent zones before doing the
chamfer/fillet and then subtracts the other zones back out afterwards.

Fixes https://gitlab.com/kicad/code/kicad/issues/3812
 2020-08-12 22:20:08 +01:00
jean-pierre charras 29d6fe88f0 3D viewer: do not show via/pad shapes of pads not connected on copper layers. 
Show the same vias/pad shapes as plot functions.
 2020-08-11 11:26:00 +02:00
Peter Montgomery 4d460ec073 Delete 3D cache files with GUI settable number of days 
KiCad stores 3D cache files but never gets rid of any of them.
This patch adds a new function called 'CleanCacheDir()'.  Any cache
files older than the passed 'number of days' parameter are deleted.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/1928
 2020-08-09 10:41:45 +00:00
Tomasz Wlostowski 89a953e039 Migrated GetEffectiveShape(s) to SHAPE_COMPOUND 2020-07-29 23:14:03 +02:00
Jeff Young bf445c1a95 Performance enhancements. 
1) cache pad polygon outlines
   huge improvement in connectivity performance and a decent
   improvement in DRC performance
2) don't pre-allocate CONTEXT stack
   significant improvement in DRC rule performance
2) don't keep re-encoding strings
   decent improvement in DRC rule performance
 2020-07-25 13:03:33 +01:00
Jeff Young 73c6fc8b8b Make opacity box line up with scale, rotation and offset boxes. 2020-07-25 13:03:33 +01:00
Ian McInerney 50b2271f84 Fix missing variable initialization 2020-07-18 23:56:39 +01:00
Jeff Young 3fd0a3f842 Update text variables even when they're changed from other binary. 
For instance, you might have PCBNew open but change the variable
value through EEschema > Schematic Setup.

Fixes https://gitlab.com/kicad/code/kicad/issues/4918
 2020-07-17 21:05:11 +01:00
Joshua Redstone ad99d85390 3d-viewer: add option to clip silkscreen around via annular ring 
Add more conservative clipping of silkscreen layers around vias.
Clips at outside of annular ring rather than outside of copper plating.
 2020-07-16 22:36:06 +00:00
Mario Luzeiro 779ed40588 3D-Viewer: improve SSAO 
Implement blur based on depth weights.
Improve occlusion based on direct light/shadow it receives.
Improve occlusion mixing with the final color by using multiply instead
of subtract.
Remove debug and test code.
 2020-07-16 11:23:02 +00:00
jean-pierre charras 55f4c2b167 Removing creation of a wxPaintEvent instance (step 2), not allowed in 3.1.4 wxWidgets: 
Remove wxPaintEvent creation in 3D viewer
 2020-07-14 15:52:01 +02:00
Seth Hillbrand e19a7910f8 Revert "Revert "Set DoubleBuffering to reduce flicker"" 
This reverts commit c18cab6154.
 2020-07-13 20:19:10 -07:00
Mario Luzeiro 74c6f6ab82 3D-Viewer: set missing scale and position to the list 
Fixes https://gitlab.com/kicad/code/kicad/issues/4826
 2020-07-11 16:55:49 +00:00
Mario Luzeiro ef7d7477d0 3D-Viewer: Remove not used list 2020-07-11 16:55:49 +00:00
Seth Hillbrand c18cab6154 Revert "Set DoubleBuffering to reduce flicker" 
This reverts commit 106259f6e6.

In its place, we set double buffering to only menubars in an attempt to
find a soluton to #4785

Fixes https://gitlab.com/kicad/code/kicad/issues/4863
 2020-07-11 09:43:30 -07:00
jean-pierre charras eab98eee1d 3D viewer: use the full board bounding box to define the visible area. 
Remove also a printf now useless, used for debug.

Fixes #4815
https://gitlab.com/kicad/code/kicad/issues/4815
 2020-07-07 11:40:35 +02:00
Jeff Young d85a707385 Move rest of DRC to SHAPE collision architecture. 2020-07-06 20:00:50 +01:00
Seth Hillbrand 3bf7cf2b54 Add VSYNC to 3d viewer 2020-07-03 21:43:49 -07:00
Seth Hillbrand a210fd570f Set VSYNC to adaptive (if available) 
Swap syncs can limit the redraw rate as the screen waits for previously
issued syncs.  Setting this to -1 allows for adaptive swapping
(resorting to unsynced if it falls behind) if it is supported by the
card but will fall back to unsynced (0) if the adaptive is not
supported.

Fixes https://gitlab.com/kicad/code/kicad/issues/4226
 2020-07-03 13:27:48 +00:00
Jon Evans c0aa6965de Migrate PcbNew project settings to new framework 
Various architecture upgrades to support this.
Creating a BOARD now requires a valid PROJECT, which caused
some (mostly transparent) changes to the Python API internals.

ADDED: Project local settings file
CHANGED: Board design settings are no longer stored in PCB file
CHANGED: Net classes are no longer stored in PCB file
CHANGED: Importing board settings now reads boards, not just projects

Fixes https://gitlab.com/kicad/code/kicad/-/issues/2578
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4070
 2020-07-02 22:08:54 -04:00
Seth Hillbrand d663be853f Explicitly add signed/unsigned comparison to warnings 2020-07-02 10:54:34 -07:00
Jeff Young 40a72d9530 Add SH_RECT handling to 3D shape conversion. 
Also add some debugging for not-implemented shape cases in other
places to catch simmilar issues in future.

Fixes https://gitlab.com/kicad/code/kicad/issues/4757
 2020-06-30 18:32:31 +01:00
Ian McInerney 3bb44f3804 Don't install the import library for the 3dsg library 
No one on Windows should be linking to it outside of
the build process, so there is no need for it in the
installer

Fixes https://gitlab.com/kicad/code/kicad/issues/1842
 2020-06-30 15:38:41 +01:00
Jon Evans 0d4ee39f75 CHANGED: Copper zones can be on more than one layer 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1963
 2020-06-28 08:52:37 -04:00
Ian McInerney fb10406e67 Add right-click context menus for toolbar items 2020-06-26 21:29:03 +00:00
Ian McInerney 52856a8ce4 Move scaled toolbar separator into ACTION_TOOLBAR 
* Ensure all separators are scaled separators
* Clean up toolbar creation functions
 2020-06-26 21:29:03 +00:00
Jeff Young d01b29ab37 Cleanup pad geometry handling. 
There were a lot of plotters, exporters, etc. that were rolling their
own implementations.

This also introduces a lazily-built set of SHAPE objects for doing
collision detection and some forms of rendering (and later DRC).
 2020-06-22 22:28:37 +01:00
Jeff Young 970921f88b Support for filled DRAWSEGMENT::S_RECT and S_CIRCLE. 
One more step in unifying pad primitives and draw segments.
 2020-06-20 14:34:53 +01:00
Ian McInerney 5649558cff Move DPI_SCALING into the GAL from common 
It should be owned by the GAL, since it is used
with the OpenGL canvas infrastructure.
 2020-06-19 17:02:46 +01:00
Seth Hillbrand 08c61e6788 Ensure triangulation follows moving zone 
Dragging filled zones in OpenGL was extremely slow due to the
invalidated triangulation cache.  Moving the zone should also move the
triangles and keep the cache valid.
 2020-06-17 19:43:11 -07:00
Jeff Young aeed8e6e2c Finish implementation of DRAWSEGMENT::C_RECT. 
It's currently only supported in the Footprint Editor.  It could be
easily added to the board editor (all the code is there), but the board
editor is a little short on room in the drawing tools toolbar.
 2020-06-15 20:51:31 +01:00
Jeff Young f84406009b Push a couple of layers of indirection out of grid settings. 2020-06-13 11:35:56 +01:00
Electro707 4a3743e7dd 3D viewer flip action 2020-06-08 21:35:40 +00:00
Ian McInerney a9fa592f5f Fix button size on 3d preview panel 
Fixes https://gitlab.com/kicad/code/kicad/issues/4626
 2020-06-07 15:47:34 +01:00
Ian McInerney 6083c0849f Make the 3d viewer rotation increment configurable 
ADDED: Setting for the 3d viewer rotation increment

Fixes https://gitlab.com/kicad/code/kicad/issues/4618
 2020-06-07 11:44:07 +01:00
Ian McInerney 9d0ea66a96 Don't use the accelerator table in the menubars 
It seems that the accelerator table causes issues with
keyboard events on MSW.

Fixes https://gitlab.com/kicad/code/kicad/issues/1941
 2020-06-06 22:50:35 +00:00
Ian McInerney 4357c1d3b3 Coverity and compiler warning fixes 
* Initialize variables
* Test dynamic casts

Fixes https://gitlab.com/kicad/code/kicad/issues/4620
 2020-06-05 12:50:56 +01:00
Ian McInerney d46f9a5273 Give the 3D viewer an infobar & Infobar upgrades 
ADDED: Infobar warning in 3d viewer for board outline issues
 2020-06-04 00:13:27 +01:00
Wayne Stambaugh 0032845f9e Fix clipped bitmap buttons with GTK on Linux. 
A note to developers, please do not set the minimum and/or size of bitmap
buttons.  It causes bitmaps to get clipped using GTK on Linux.  If the
bitmap button size is not acceptable, then supply an appropriately sized
bitmap rather than attempt to force the wxWidgets sizing mechanism to do
what you want.  This almost always causes platform differences that do
not work well.
 2020-06-03 14:01:44 -04:00
Érico Rolim e9e72bd8e4 Fix sg_version detection for cross compilation 
Fixes https://gitlab.com/kicad/code/kicad/issues/4525
 2020-05-28 13:05:49 +00:00
Jon Evans a52435bbb0 ADDED: New mouse settings panel, expanded mouse settings 
You can now choose the behavior of dragging with the
middle and right mouse buttons.

You can also choose which modifier keys to use for
panning and zooming with the scroll wheel or trackpad.

You can also customize the zoom speed, which makes
it possible to have a good zoom experience on a wider
range of input devices.

You can also now zoom by dragging with the right or
middle button if desired.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/3885
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4348
 2020-05-24 14:38:28 -04:00
Mario Luzeiro 94ed433f64 3D-Viewer: Fixes #4432 
Set default transparency of model from the assigned material.
 2020-05-22 13:28:04 +00:00
jean-pierre charras 2215d8a96b 3d viewer: ensure the opengl engine is selected on start. 
(the ray tracing engine is too time consuming to be select on start)
 2020-05-16 13:18:56 +02:00
jean-pierre charras 3b84653591 3D viewer: avoid crash in raytracing (null pointer use) if layer mask is 
not shown and must be removed from silk screen layer.

Fixes #4430
https://gitlab.com/kicad/code/kicad/issues/4430
 2020-05-14 11:50:12 +02:00
Simon Richter 632494cba7 Add missing includes 
A few more instances of missing <algorithm> for std::max
 2020-05-10 00:24:11 +02:00
jean-pierre charras c78e7c5485 Fix compil issues (warnings and missing include) 2020-05-09 08:59:00 +02:00
Jon Evans 7ca069e63e A few formatting fixes 2020-05-08 17:32:06 -04:00
Mario Luzeiro 9446a9166d 3D-Viewer: implement opacity in raytracing 
fix opacity implementation on OpenGL
 2020-05-08 21:28:16 +00:00
Mario Luzeiro 5a7f875602 3D-Viewer: implements opacity property for 3D models 
fixes #2087
 2020-05-08 21:28:16 +00:00
Jon Evans 4923d993a7 Factor out raytracing background color calculation 2020-05-07 18:40:06 -04:00
Emery Burhan 6c3cc0cfd4 3d_viewer: Ceiling plane: fixed formatting. 2020-05-07 18:00:55 -04:00
Emery Burhan c665bf69b6 3d_viewer: Added a ceiling plane, similar to the floor plane. 2020-05-07 18:00:55 -04:00
jean-pierre charras a43e4fa163 3D Viewer: Animation Speed setting looks wonky (GTK only) 
Fixes #4317
https://gitlab.com/kicad/code/kicad/issues/4317
 2020-05-05 10:41:35 +02:00
Wayne Stambaugh 63291141df Pcbnew: minor footprint properties dialog layout improvements. 2020-05-03 11:45:18 -04:00
Jeff Young 874f13e29e Fix some issues with rotated oval pads. 2020-05-01 18:49:42 +01:00
jean-pierre charras 262283995c string fix 2020-04-30 21:03:03 +02:00
jean-pierre charras 93b9be7ebe DLG_SELECT_3DMODEL rework: better dialog (use split window) and fix a few issues. 2020-04-30 19:49:41 +02:00
Jeff Young d2046b17d7 More shrinking of Footprint Properties. 2020-04-27 00:24:57 +01:00
Ian McInerney d006acecf4 More window sizing fixes 
* Push all sizing operations into EDA_BASE_FRAME
* Save the unmaximized window size when maximizing
  so that we can then save it in the config if the
  window is maximized. Otherwise the config ends up
  with the maximized size saved, and weird behavior
  occurs when unmaximizing on the next opening.
 2020-04-27 00:14:12 +01:00
Emery Burhan e20e45fa54 3d_viewer: Added Animation Speed option 
ADDED: Option to set the speed of and enable/disable 3d viewer animations
 2020-04-24 23:58:50 +00:00
Ian McInerney 99dcadf7e6 Introduce new KI_FALLTHROUGH macro 
Annotate purposeful fallthroughs in switch statements with the
KI_FALLTHROUGH macro.
 2020-04-25 00:44:09 +01:00
Ian McInerney ff67d6300d Hide more OpenGL deprecation warnings on OSX 2020-04-24 23:28:31 +01:00
jean-pierre charras cf66aac15d 3d viewer: fix compil issue (missing include in c3d_render_ogl_legacy.cpp) 2020-04-24 08:24:59 +02:00
Mario Luzeiro b0bf9f7b57 3D-Viewer: use wxStaticBoxSizer for options, fix coding style 2020-04-23 17:28:56 +01:00
Mario Luzeiro 67fe304f1f change the default display tab 2020-04-23 09:29:39 +00:00
Mario Luzeiro 00da17bc7d 3D-Viewer: Add new options: Anti-aliasing quality, "While moving" 
Create new window options with tabs for 3D-Viewer. Remove
"showCopperThickness" option from menus and place it on OpenGL options.
 2020-04-23 09:29:39 +00:00
Mario Luzeiro 656efc8d62 3D-Viewer: disable AA while moving 
disable AA for Raytracing
Fixes #4007
 2020-04-23 09:29:38 +00:00
Emery Burhan b1ac504fcd 3d_viewer: Fix bottom view image being too dark when floor+shadows are enabled 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2083
 2020-04-22 23:00:15 +00:00
Jeff Young c08a6adb2a Implement GUI and file R/W for 3D model opacity. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2087
 2020-04-19 18:24:39 +01:00
Ian McInerney e528769637 Move TOOLS_HOLDER into tools/ folder 
Also clean up some compiler warnings
 2020-04-19 01:51:49 +01:00
Ian McInerney 7bda8178d1 Move library includes to main CMake file 
Placing them behind the SYSTEM directive tells CMake to tell
the compiler they are system libraries, so it shouldn't show
warnings created from them.
 2020-04-19 01:11:56 +01:00
Jeff Young 2b6089240a Change super/subscript syntax to ^{foo} and _{foo}. 2020-04-18 21:04:41 +01:00
Oleg Endo ae6fbc9c60 Improve 3D viewer rendering performance 
* Use GL vertex buffers and index buffers for 3D model rendering
* Use material or average vertex color for bounding boxes instead of red
* Reinstate bounding box rendering with GL vertex/index buffers
* Use compact vertex/index data representation
  - 8-bit normals
  - 8-bit colors
  - 16-bit or 32-bit indices, depending on model size

This should improve performance a bit on lower end GPUs with less memory
and bandwidth.

Fixes #4112
 2020-04-17 16:10:04 +00:00
Jeff Young 9c8941e040 Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
Simon Richter 99c1d7cf96 Add noexcept to some functions in the 3d viewer. 2020-04-16 16:11:21 +00:00
Jeff Young 6e800bddae Rationalize penWidth processing as first step in removing some globals. 2020-04-13 20:58:13 +01:00
Jeff Young 174856bac5 Promote 3D model "preview" flag to a persisted "show" flag. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2061
 2020-04-10 22:49:56 +01:00
Jeff Young 191d4daf53 Fix crash on OSX. (It appears the DC isn't used anyway.) 2020-04-10 22:49:56 +01:00
jean-pierre charras 2c8ada42a0 Arc shaped track segments: fix 3D viewer and track to polygon converter. 2020-04-09 10:37:17 +02:00
jean-pierre charras 2401917776 Fix a bug I added in commit b1b8a320. 
Fixes #4170
https://gitlab.com/kicad/code/kicad/issues/4170
 2020-04-07 16:36:38 +02:00
Ian McInerney cb380cda0c Fix some build warnings 2020-04-06 00:31:45 +01:00
Jeff Young cc9ac37a0e Add text variable support to envVar processing. 2020-04-05 20:52:26 +01:00
jean-pierre charras b1b8a32078 fix a few Coverity warnings and compil minor warnings. 2020-04-03 09:54:47 +02:00
jean-pierre charras 00d9e77e7f 3D viewer: fix a minor problem: to many rotations when typing Shift+z or Shift+y 
more than once.

Fixes #4135
https://gitlab.com/kicad/code/kicad/issues/4135
 2020-03-31 17:35:45 +02:00
Jeff Young 42a876d963 Fix a duplicate definition of the TOOL_DISPATCHER. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4110
 2020-03-28 18:44:34 +00:00
Jeff Young 5134856f18 Rationalise 3D settings data-structure. 
Move the camera out to its own so that everything else is board-
related, and then rename BOARD_ADAPTER.

At some point the flags should probably be moved out too, and they
can have the EDA_3D_SETTINGS name.
 2020-03-28 16:09:40 +00:00
jean-pierre charras 04d6ea982d 3D viewer: fix an issue with solder paste layer having negative clearance. 
The code tried to draw outlines with segments having a negative thickness.
It happens mainly on solder paste layers.

Fixes #4090
https://gitlab.com/kicad/code/kicad/issues/4090
 2020-03-26 13:46:14 +01:00
Jeff Young ba36fc0009 Fix some Coverity issues. 2020-03-25 14:38:43 +00:00
jean-pierre charras 5f7bcb9c34 3D viewer: fix a minor issue in solder paste rect pads: 
the solder paste mask clearance was no taken in account for rect and trap shapes.
 2020-03-25 13:04:30 +01:00
Jeff Young d69ebfae49 Push tool framework base down into TOOL_HOLDER. 
This allows us to use it outside of EDA_BASE_FRAMEs (in this case, in
PANEL_PREVIEW_3D.)
 2020-03-24 19:00:25 +00:00
jean-pierre charras cc47062b17 Fix a few Coverity issues 2020-03-23 16:17:22 +01:00
Wayne Stambaugh d8e99dc5be 3D Viewer: fix broken check for write image permission check. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4081
 2020-03-21 16:19:55 -04:00
Jeff Young 103b0c18de Hook up a few more 3D commands missed in last commit. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4074
 2020-03-21 01:29:30 +00:00
Jeff Young 55e56c6cc1 Don't let 3DViewer steal other tools' hotkeys. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4074
 2020-03-20 20:35:52 +00:00
Jeff Young e9cd9ee8ff Actionize the rest of the 3D viewer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2228
 2020-03-19 15:10:32 +00:00
Wayne Stambaugh fc20f9f0b2 3D viewer: fix double warning attempting to save screen shot file. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4028.
 2020-03-16 12:45:09 -04:00
Jon Evans 0df2191663 Fix missing changes from last commit 2020-03-07 16:17:25 -05:00
jean-pierre charras b7cd0c54c2 Fix compil issues, especially on Windows: 
Replace SEVERITY_ERROR by RPT_SEVERITY_ERROR to avoid collision with a system definition.
Replace other SEVERITY_XXX by RPT_SEVERITY_XX for consistency.
Fix compil warnings and some other compil issues.
 2020-03-04 10:48:18 +01:00
Jeff Young 85c2e0d23a Add user-defined severities, exclusions and colors to DRC markers. 
Exclusions are currently persisted in the project file.

Fixes https://gitlab.com/kicad/code/kicad/issues/1989
 2020-03-04 00:39:28 +00:00
Jon Evans e59a3d981e Implement a new settings framework across all of KiCad 
CHANGED: Settings are now stored in versioned sub-directories
ADDED: First-run dialog for migrating settings from a previous version
CHANGED: Settings are now stored as JSON files instead of wxConfig-style INI files
CHANGED: Color settings are now all stored in a separate settings file
CHANGED: The symbol editor and footprint editor now have their own settings files
CHANGED: Color settings are no longer exposed through BOARD object
CHANGED: Page layout editor now uses Eeschema's color scheme

Settings are now managed through a central SETTINGS_MANAGER held by PGM_BASE.
Existing settings will be migrated from the wxConfig format on first run of each application.
Per-application settings are now stored in one class for each application.
 2020-02-19 23:44:56 -05:00
Ian McInerney 34e5b76c5f Add virtual constructors to some classes that should have them 
This is more for safety from undefined deletion behavior than
anything else (it also silences the Clang -Wnon-virtual-dtor warning).
 2020-02-05 22:19:14 +00:00
jean-pierre charras 0049185d06 Eeschema: Speed up global changes in DIALOG_GLOBAL_EDIT_TEXT_AND_GRAPHICS. 
Previously, OnModify() was called for a lot of items, even when not modified.
For large schematics, the calculation time was unreasonable ( several minutes)
It is now called only a few times.
 2020-02-04 14:04:11 +01:00
Ian McInerney 5053f58bfc Move 3d viewer board outline warning to the status bar 
This is less intrusive than a dialog that is constantly opening
whenever the 3d view is refreshed.
 2020-02-03 22:09:14 +00:00
Mario Luzeiro 970a0a593a 3d-viewer, add an option to subtract Mask from Silk 
Remove holes on Silk layer by default so the behaviour is the same
on OpenGL and Raytracing.
Fixes #1836
Fix raytracing shadow offset issue.
Some codestyle fix.
 2020-01-29 16:00:05 +00:00
Ian McInerney c5a9479953 Only get 3D viewer colors when launched from the PCb editor 
When launched from CVPCB or the footprint editor/viewer the stackup
isn't user-editable, so it just gives its default colors.
 2020-01-22 22:48:20 +00:00
Fabien Corona 183bbf6914 3d-viewer : synchronise colours with board stackup. 
ADDED: 3d-viewer can now look up colours defined in board properties

Fixes https://gitlab.com/kicad/code/kicad/issues/2261
 2020-01-22 22:38:30 +00:00
Ian McInerney 39b1f0e1ff Replace wxCriticalSection with std::mutex 2020-01-15 23:42:16 +00:00
Ian McInerney 56f6b529c8 Simplify 3D object cache class structure 
Remove the CACHE_WRAPPER whose sole purpose was to allow the
cache to be stored in the project, and instead just have the cache
inherit the proper class.
 2020-01-15 23:32:05 +00:00
Ian McInerney bc6139359b Smoothen rotation in 3D viewer when crossing the 0-2pi line 
Rotating to 0 when above pi would result in the board spinning back
through pi to get there. This led to jarring motion.

Also fix an issue added in b6f64815 where the board would rotate
2pi when crossing over the 0-2pi boundary.
 2020-01-15 18:10:05 +00:00
jean-pierre charras b6f64815f4 3D viewer: normalize rotation angles between -2_PI and 2_PI. 
Fixes #3761
https://gitlab.com/kicad/code/kicad/issues/3761
 2020-01-13 14:30:49 +01:00
Ian McInerney f896043067 Fix comments for switch statement fall throughs 
This cleans up all GCC warnings (-Wimplicit-fallthrough=2) about
implicitly falling through switch cases.
 2020-01-11 19:16:32 +00:00
Seth Hillbrand 7c28c3838a Comment-only changes 
Makes class comments conform to coding standards
 2020-01-10 16:43:01 -08:00
Ian McInerney 13b6028e1b Refactor all math into a new kimath library 
* Split up the thirdparty code into the thirdparty folder (#3637)
* Create a new kimath static library containing all the math functions

This is part of cleaning the build system for #1906.
 2020-01-07 17:12:59 +00:00
Mario Luzeiro 2c00540ad6 3d-viewer, make ortho projection zoom similar as prespective projection 
Fixes #1843
Fixes reload of Raytracing when the projection button is pressed.
 2020-01-07 03:29:36 +00:00
Mario Luzeiro 518c1df81b 3d-viewer, ray-tracing, do not add coincident segments 
Fixes #1946 (lp 1852970)
 2020-01-06 14:11:02 +00:00
Seth Hillbrand 84048262bd Descope KB defines 
The 3d viewer is the last component to not use the action framework, so
we descope the common defines to its canvas.  Once the 3d viewer is
converted, we can remove these entirely.
 2020-01-06 05:43:18 -08:00
Mario Luzeiro 37c3e34486 3D-viewer: raytracing, implement multiple shape board. 
Fixes #1879 (lp:1820099)
Fixes #2126 (lp:1764039)
 2020-01-04 20:50:37 +00:00
Mark Roszko b11d52eda1 Scope 3d viewer enums 
Also fix one rogue character in a gerbview file that wasn't proper UTF8.
 2019-12-30 13:01:06 +00:00
Ian McInerney c21e96bcf9 Add virtual destructor to CMATERIAL 
CMATERIAL is a base class, so it should have a virtual constructor
to prevent undefined behavior (and silence warnings).
 2019-12-28 16:44:28 +00:00
Ian McInerney 6faa2188ed Silence warnings on MacOS about OpenGL deprecation 
Apple has apparently deprecated OpenGL and replaced it with
their Metal API. It still works for now though.
 2019-12-28 16:05:03 +00:00
Jeff Young 9d0198bade Easier control of zoom in 3D viewer. 
Go to 3 steps per doubling (instead of 2), and start at 2/3 instead
of 1/2.
 2019-12-28 11:58:33 +00:00
Mark Roszko 19ceb11ae7 Change more enums over to scoped enums 2019-12-28 00:55:11 +00:00
Mark Roszko 11ff16be4e Switch to scoped enums 2019-12-20 14:11:39 +00:00
Mark Roszko ae785194ce Silence/fix double to float conversion warnings 2019-12-12 21:51:21 +00:00
Seth Hillbrand eb3d32f967 SHAPE_LINE_CHAIN: Unify constructors 
Keeps the multi element SHAPE_LINE_CHAIN constructors in a single
routine using std::vector and implicit construction.
 2019-12-12 13:54:48 +00:00
Seth Hillbrand 6983c56cf8 Use const references where possible 
This avoids copy cost on local vars where we only read.
 2019-12-05 14:40:22 -08:00
Seth Hillbrand c6f5df134c Minor speed cleanup 
This adjusts iterators to use const reference when only used for
copy.  It also ensures pre-allocation of vectors when size is known
ahead of time.
 2019-12-05 14:20:59 -08:00
Seth Hillbrand b5f021ff9f Cleanup: Replace push_back with emplace_back 
In cases where we create a new item and immediately push into a
container, the emplace idiom is faster and more efficient.
 2019-12-05 13:41:21 -08:00
Seth Hillbrand 4d2e953f42 Cleanup: Replace C-only deprecated headers 
This replaces headers deprecated by C++14 with their equivalent
replacement
 2019-12-05 11:03:15 -08:00
Seth Hillbrand 79972a3867 3d: Fix initialization call 
The vector duplication call was invalid as growing the vector
invalidates the iterators.
 2019-11-07 04:45:46 -08:00